shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-12 09:18:00 +03:00
Code Issues Projects Releases Wiki Activity

details: Avoid some misleading logging on rename

Browse Source
This commit is contained in:
Cole Robinson 2014-09-20 16:18:10 -04:00
parent 1bfdf0575f
commit f2ff378a9d
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
virtManager/details.py
View File

@ -1910,10 +1910,6 @@ class vmmDetails(vmmGObjectUI):
kwargs = {} kwargs = {}
hotplug_args = {} hotplug_args = {}
if self.edited(EDIT_NAME):
# Renaming is pretty convoluted, so do it here synchronously
self.vm.define_name(self.widget("overview-name").get_text())
if self.edited(EDIT_TITLE): if self.edited(EDIT_TITLE):
kwargs["title"] = self.widget("overview-title").get_text() kwargs["title"] = self.widget("overview-title").get_text()
hotplug_args["title"] = kwargs["title"] hotplug_args["title"] = kwargs["title"]
@ -1949,6 +1945,15 @@ class vmmDetails(vmmGObjectUI):
idmap_list = None idmap_list = None
kwargs["idmap_list"] = idmap_list kwargs["idmap_list"] = idmap_list
# This needs to be last
if self.edited(EDIT_NAME):
# Renaming is pretty convoluted, so do it here synchronously
self.vm.define_name(self.widget("overview-name").get_text())
if not kwargs and not hotplug_args:
# Saves some useless redefine attempts
return
return vmmAddHardware.change_config_helper(self.vm.define_overview, return vmmAddHardware.change_config_helper(self.vm.define_overview,
kwargs, self.vm, self.err, kwargs, self.vm, self.err,
hotplug_args=hotplug_args) hotplug_args=hotplug_args)