401 Commits

Author SHA1 Message Date
Giuseppe Scrivano
0abbb6d122 details: show warning when guest inspection fails
If libguestfs fails to inspect the guest then show a warning.

Now the "Operating System" and "Applications" frames are visible
only when the guest inspection is available.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=755869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-03 11:39:27 +01:00
Giuseppe Scrivano
b3131e828e inspection: report guest inspection errors
Add an `error' flag to the inspection data for a guest and set it when
the inspection failed.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-03 11:39:23 +01:00
Chen Hanxiao
8f661290e3 add RAM filesystems browse support for lxc container
LXC container could use in-memory filesystem,
which do not have source section.
Currently, virt-manager will complain if
dev.source is null.
This patch will fix this issue.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2013-12-02 13:44:17 -05:00
Giuseppe Scrivano
7f3c4cf2f9 virt-manager: correctly initialize the create pool wizard page number
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1034933

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-02 10:45:12 +01:00
Chen Hanxiao
7b9a040249 show read-only check button when add fs for lxc container
Show read-only check button when add fs for lxc container.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2013-11-26 10:08:56 -05:00
Giuseppe Scrivano
d6fbdf717d virtManager: when present, prefer the user specified in capabilities
Prefer the user specified in the host capabilities to the default one
when checking for the access to disk images.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-11-18 09:05:22 +01:00
Cole Robinson
bd782d5757 snapshots: Another s/State/VM State/ change 2013-11-10 11:17:12 -05:00
Cole Robinson
8dcb65bd50 create: Fix default qemu-ga setup (bz 1016613)
We were adding default devices before setting the OS value, which qemu_ga
setup depends on.
2013-11-09 18:52:05 -05:00
Cole Robinson
eb33bd34e7 Misc improvements to some debug messages 2013-11-09 18:17:29 -05:00
Cole Robinson
bcfa8d287f serialcon: Release the text console when the VM window is closed (bz 1016445) 2013-11-09 17:54:47 -05:00
Giuseppe Scrivano
5798c5b9b4 virt-manager: prefer os.makedirs to os.mkdir when creating cache dir
Ensure the parent directories exist when attempting to create the
cache directory.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1016435

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-11-05 18:15:11 +01:00
Martin Kletzander
1ac755e7b2 details: Fix processor tab display for some LXC guests
With LXC domain, the 'current' attribute of 'vcpu' element is not
always present, but the code is still depending on it.
2013-10-29 11:24:52 +01:00
Martin Kletzander
2b7aa33887 engine: Fix started libvirt daemon requirement
This patch makes virt-manager usable again without systemd (or dbus).
When started without systemd, but with libvirtd properly working,
there was error reported, and virt-manager didn't even try to connect
to the destination.

This patch modifies the behavior in two ways.  When connection is
added with "do_start=False" it will still try to connect, but won't
error out when unsuccessful.  The second modification is that upon
startup, the idle_connect() function will error out only if we failed
starting libvirtd _and_ we couldn't connect to the uri.  So if we
failed starting libvirtd, but could connect, there is no disruption
for the user.
2013-10-29 11:24:52 +01:00
Giuseppe Scrivano
408771004f virt-manager: show correctly EGD RNG devices information
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:19 +01:00
Giuseppe Scrivano
a7519dc1e9 virt-manager: fix adding EGD RNG devices in UDP mode
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1001773

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:14 +01:00
Giuseppe Scrivano
0df75c7603 headers: update "Red Hat, Inc." copyright for the year 2013
Ensure that any file touched by a @redhat.com author in 2013 has an
updated copyright header.

The files were updated using the build-aux/update-copyright gnulib
script and manually added where the copyright line wasn't present.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:22:26 +01:00
Cole Robinson
2301f19e4b asyncjob: Fix simple error callback 2013-10-09 17:41:08 -04:00
Cole Robinson
cea22b17d7 storagebrowse: Fix signal cleanup after multiple runs 2013-10-08 10:23:15 -04:00
Cole Robinson
a991c21d08 details: Fix reporting current VM cpus 2013-10-07 18:12:12 -04:00
Cole Robinson
79196cdfcf console: Fix console_active() logic 2013-10-06 15:30:01 -04:00
Cole Robinson
3f532fe263 VirtualDisk: Handle the blktap default
And cache the blktap lookup once for the localhost
2013-10-06 13:17:35 -04:00
Cole Robinson
ef878a5d49 addhw: Fix a few issues with char dev combinations 2013-10-06 13:04:21 -04:00
Cole Robinson
102417ca0c addhw: Make sure to set device defaults 2013-10-06 13:00:30 -04:00
Cole Robinson
56b9f6187b Streamline support checks
Just use one function check_support
2013-10-06 10:08:04 -04:00
Cole Robinson
18fa751059 Add qemu-guest-agent channel automatically for supported OS 2013-10-06 09:19:59 -04:00
Cole Robinson
dae3678d26 guest: Absorb more default device checks 2013-10-06 08:30:33 -04:00
Cole Robinson
fdb79b9832 snapshots: Add a right click menu for start/stop 2013-10-05 14:57:58 -04:00
Cole Robinson
111f4353a3 snapshots: new: Grab name focus, make activate create the snapshot 2013-10-05 14:47:10 -04:00
Cole Robinson
89646fe841 addhw: Filter root hubs out of USB device list 2013-10-05 14:40:38 -04:00
Cole Robinson
c5b5df8db2 storagebrowse: Select default pool on first run 2013-10-05 14:15:11 -04:00
Cole Robinson
ff73f1119e details: If we know the channel target name, pretty list it 2013-10-05 14:04:49 -04:00
Cole Robinson
34f23165b6 addhw: Add channel option for auto socket allocation 2013-10-05 13:54:28 -04:00
Cole Robinson
5f1187e4c3 addhw: Don't show target_type for every char device 2013-10-05 13:33:55 -04:00
Cole Robinson
9d21d2bb02 addhw: List known channel names in a comboboxentry 2013-10-05 13:27:11 -04:00
Cole Robinson
24137cdfe9 addhw: Add 'console' option for adding virtio consoles 2013-10-05 13:22:53 -04:00
Cole Robinson
8e460dce1d create: Hide arch expander if there aren't any connections 2013-10-05 10:31:02 -04:00
Cole Robinson
ca5e849ec6 create: Reset distro detection labels after each run 2013-10-05 10:29:16 -04:00
Cole Robinson
97f5717ef7 snapshots: Fix showing async dialogs for revert/delete 2013-10-05 10:03:56 -04:00
Cole Robinson
e7e97a8088 domain: If title present, print only it
Forcing the name to be in the picture reduces the usefulness IMO
2013-10-04 11:50:19 -04:00
Fred A. Kemp
c005cc84d6 virt-manager: Future-proof disk 'removable' check box
Currently only QEMU is supported so we only show the check box when
it's used. The future-proofing is that we'll show it for an explicitly
set non-default value, even for hypervisors we don't think support it.
2013-10-04 08:17:25 -04:00
Fred A. Kemp
c45e1ef6b8 virt-manager: Add checkbox controlling disk 'removable' flag
(crobinso: Fix to use grid rework)
2013-10-04 08:08:44 -04:00
Cole Robinson
d83b2c02fa virt-manager: Add USB3 convenience option to the controller UI
and a --controller usb3 option to virt-install
2013-10-03 16:34:28 -04:00
Cole Robinson
db6ef91b0b console: spice: don't set port=None
Can happen if defaultMode=secure, only a tlsport is allocated
2013-10-03 15:54:15 -04:00
Cole Robinson
27298c8a80 addhw: Fix disk naming from 'customize' dialog (bz 744137) 2013-10-02 19:58:21 -04:00
Cole Robinson
2954995a28 domain: Fix deleting VM in test driver 2013-10-02 19:57:50 -04:00
Cole Robinson
18d8512699 Move the 'default graphics type' logic into Guest
So we can share it, and make virt-install more robust
2013-10-02 18:06:52 -04:00
Cole Robinson
2218a03154 details: Rip out 'would you like to add/remove spicevmc' bit
This was originally there for when we weren't defaulting to spice.
We basically do that now, so people shouldn't have much need to
switch spice on/off for an existing guest. Plus if we wanted to
be far about it we would want to add/remove qxl as well but there
it's just getting rediculous.
2013-10-02 18:04:56 -04:00
Cole Robinson
a2cbb9f500 support: s/CONN_HV/CONN/g
We don't need to distinguish these days.
2013-10-02 16:41:23 -04:00
Cole Robinson
9c57c72eac Default to adding USB2 for new enough KVM
We enable this for virt-install as well. To avoid it, you can do either

--controller usb,model=none or --controller usb
2013-10-02 15:54:35 -04:00
Cole Robinson
9194feb1f5 virt-manager: Default to qcow2 on kvm
qcow2 enables fancy features like snapshots and is generally more
desktopy, which we purport to be.

We only do this on not horribly old libvirt/qemu, and only on qemu
connections. This may work for xen but I'm not going to turn it on
until someone tests it.
2013-10-02 15:34:34 -04:00