77 Commits

Author SHA1 Message Date
Giuseppe Scrivano
0abbb6d122 details: show warning when guest inspection fails
If libguestfs fails to inspect the guest then show a warning.

Now the "Operating System" and "Applications" frames are visible
only when the guest inspection is available.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=755869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-03 11:39:27 +01:00
Chen Hanxiao
8f661290e3 add RAM filesystems browse support for lxc container
LXC container could use in-memory filesystem,
which do not have source section.
Currently, virt-manager will complain if
dev.source is null.
This patch will fix this issue.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2013-12-02 13:44:17 -05:00
Giuseppe Scrivano
408771004f virt-manager: show correctly EGD RNG devices information
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:19 +01:00
Cole Robinson
ff73f1119e details: If we know the channel target name, pretty list it 2013-10-05 14:04:49 -04:00
Cole Robinson
5f1187e4c3 addhw: Don't show target_type for every char device 2013-10-05 13:33:55 -04:00
Fred A. Kemp
c005cc84d6 virt-manager: Future-proof disk 'removable' check box
Currently only QEMU is supported so we only show the check box when
it's used. The future-proofing is that we'll show it for an explicitly
set non-default value, even for hypervisors we don't think support it.
2013-10-04 08:17:25 -04:00
Fred A. Kemp
c45e1ef6b8 virt-manager: Add checkbox controlling disk 'removable' flag
(crobinso: Fix to use grid rework)
2013-10-04 08:08:44 -04:00
Cole Robinson
d83b2c02fa virt-manager: Add USB3 convenience option to the controller UI
and a --controller usb3 option to virt-install
2013-10-03 16:34:28 -04:00
Cole Robinson
2218a03154 details: Rip out 'would you like to add/remove spicevmc' bit
This was originally there for when we weren't defaulting to spice.
We basically do that now, so people shouldn't have much need to
switch spice on/off for an existing guest. Plus if we wanted to
be far about it we would want to add/remove qxl as well but there
it's just getting rediculous.
2013-10-02 18:04:56 -04:00
Cole Robinson
d44f863c2d details: Disable snapshot buttons if conn or guest doesn't have support 2013-09-30 20:33:42 -04:00
Cole Robinson
9de21be907 virt-manager: Drop --experimental-snapshot-ui
We are just sticking with internal snapshots only
2013-09-30 14:30:50 -04:00
Cole Robinson
375790075d details: Drop combo_or_label paradigm, use combobox entries
So we can handle unknown XML values and give users more flexibility
for things we can't predict.
2013-09-28 14:25:37 -04:00
Cole Robinson
40a9e61ba2 details: Fix looking up nodedev mapping for usb devices 2013-09-27 18:40:00 -04:00
Cole Robinson
fd00ad74e2 devicehostdev: Drop device creation helper
Goes against other device paradigms, and is cleaner when we unwind it.
2013-09-27 18:28:28 -04:00
Cole Robinson
927c596daa Fix host/details graphs to not over expand 2013-09-27 14:17:57 -04:00
Giuseppe Scrivano
ade0c16015 virt-manager: add UI elements for domain title in the details window
Commit b79ba8382e2205c416d7c4836ac9ee08c72e2c56 in libvirt adds a
<title> attribute to the domain XML, that is used by the user to
identify more easily the VM. This feature is not supported by all
HVs. This patch allows to see and modify the title from the details
window.

Something similar was requested here:
https://bugzilla.redhat.com/show_bug.cgi?id=798949

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-25 19:16:23 +02:00
Cole Robinson
a2e5206730 deviceinterface: Fix creating direct interfaces (bz 1006324)
And take the opportunity to standarize on setting net.source,
rather than have API users have to do net.bridge/network/source_dev
2013-09-24 10:00:01 -04:00
Cole Robinson
927334915b details: Make TPM UI use a grid 2013-09-23 18:43:50 -04:00
Giuseppe Scrivano
92db24aa12 virtManager: add GUI elements for showing RNG devices
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-23 14:07:00 -04:00
Cole Robinson
6da801f944 Set list selection signals in glade, not code 2013-09-22 16:29:58 -04:00
Cole Robinson
d338bce329 Rename ui files to match source file names 2013-09-22 16:10:16 -04:00
Cole Robinson
ba3ce7afb3 details: Use VMActionMenu in top window menu 2013-09-22 15:45:53 -04:00
Cole Robinson
268b462126 uihelpers: Add VMShutdownMenu class
And use it in all the places where we are duplicating a similar menu
2013-09-22 15:45:49 -04:00
Cole Robinson
1683d56b8d ui: Set non-stock button images in glade, not explicitly in code 2013-09-22 12:33:02 -04:00
Cole Robinson
36c669d45a Replace get_property("sensitive") with get_sensitive 2013-09-09 11:02:34 -04:00
Cole Robinson
9d87b0d342 Replace set_property("visible") with modern set_visible 2013-09-01 20:18:14 -04:00
Cole Robinson
ae7ebc220b details: Properly limit machine type list by guests arch/type 2013-09-01 19:21:21 -04:00
Cole Robinson
10161a8fdb details: Track serial pages as console tabs
A bit cleaner conceptually, and shrinks the ever growing details.py
2013-09-01 17:40:38 -04:00
Cole Robinson
948b5359d2 virt-manager: Hide snapshot work behind --experimental-snapshot-ui
I don't want to publicize the UI and the current feature set until
we are sure it's what we want to support, so hide it for now.
2013-08-21 18:47:05 -04:00
Cole Robinson
e8531b1f40 Initial snapshot support
This adds initial UI for managing snapshots: list, run/revert, delete,
add, and redefining (for changing <description>) supported, but currently
only for internal snapshots. The UI is mostly in its final form except for
some bells and whistles.

The real remaining question is what do we want to advertise and support.
Internal (qcow2) snapshots are by far the simplest to manage, very
mature, and already have the semantics we want.

However most recent libvirt and qemu work has been to facilitate
external snapshots, which are more extensible and can be performed
live, and with qemu-ga coordination for extra safety. However
they make things much harder for virt-manager at the moment.

Until we have a plan, this work should be considered experimental
and not be relied upon.
2013-08-21 18:41:42 -04:00
Martin Kletzander
3b9c397d11 Handle storage formats properly
This simple patch fixes three issues:

 1) We used only one list of storage formats.  However, we are able to
    use some formats which we cannot create.  This patch adds a list
    called 'no_create_formats' and moves such formats (currently only
    one) into it and uses new parameter 'create' which describes
    whether such formats should be removed or not.

 2) When creating new storage with the above fixed, we need to set the
    combobox's text to "" in order not to change it to "raw".  This
    was already done in reset_state(), but we need it also when
    toggle_storage_select() happens and it doesn't hurt in
    set_initial_state(), so I abstracted the implementation into
    populate_disk_format_combo().

 3) It's a bit unrelated, but when bus of a domain disk gets changed
    (in details.py), the address was not cleaned up properly ('target'
    attribute was still kept), so I fixed up the VirtualDeviceAddress
    as well.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=907289
2013-08-21 11:12:42 +02:00
Cole Robinson
1ce5fb1bb9 details: Wire up DTB support
Only show it for supported archs (arm, microblaze, ppc). Take this
opportunity to tweak the kernel/initrd UI a bit
2013-08-18 12:42:07 -04:00
Cole Robinson
7edd2c5208 Fix spelling error in function names 2013-08-18 12:30:58 -04:00
Cole Robinson
e52f6050fa qemu ARM support: wire up virtio, fix a bunch of defaults
This has some fallout on non-x86 tests which were wrong to begin with.
There's still some missing bits but this is the jist of it.
2013-08-18 12:30:58 -04:00
Giuseppe Scrivano
c1fa43ebb9 virt-manager: ignore VIR_ERR_NO_DOMAIN when a domain was just deleted
Some callbacks could try to access a domain that was just deleted and
not accessible anymore.  Detect these cases and don't propagate the
exception.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-08-16 11:51:15 -04:00
Cole Robinson
5ec2d0cb8e details: Also clear serial list in cleanup() 2013-08-14 20:10:42 -04:00
Giuseppe Scrivano
2751a134f2 virt-manager: do not delete tabs while destroying the details window
_close_serial_tab triggers the switch-page event and that can provoke a
refresh of the window.  This causes an error everytime the details window
is pointing to a domain that was just deleted.

Solves: https://bugzilla.redhat.com/show_bug.cgi?id=985291

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-08-14 20:04:49 -04:00
Cole Robinson
3e158b80bf guest: Move cpuset static functions to DomainNumatune 2013-08-11 12:39:28 -04:00
Cole Robinson
7c55cfeb39 virtManager: Drop util, combine it with virtinst.util and uihelpers 2013-08-11 12:39:28 -04:00
Giuseppe Scrivano
2a67ec9ed6 ui: allow to set an empty password for graphics
Now when a password is used a check box must be explicitely selected.
This enable the possibility to set an empty password "".

Solves: https://bugzilla.redhat.com/show_bug.cgi?id=749718

Signed-off-by: Giuseppe Scrivano <gscrivano@gnu.org>

(crobinso: fix minor pylint violation)
2013-08-01 11:42:08 -04:00
Cole Robinson
bf7773ce58 Guest: Drop add_device set_defaults option
Was only used to fix one bug, but has too many side effects. Just
fix it at the caller.
2013-07-25 15:04:47 -04:00
Cole Robinson
bdfb86fd06 xmlbuilder: Break out much of the xml handling to a separate class
Clears things up a bit.
2013-07-25 15:04:47 -04:00
Cole Robinson
e802eae07b VirtualCharDevice: Convert to new style XML props, rework API 2013-07-23 17:34:31 -04:00
Cole Robinson
a9296ec3ae VirtualController: Convert to new style XML props 2013-07-15 21:52:18 -04:00
Cole Robinson
a75cb4074c VirtualPort: Convert to new style xml properties 2013-07-15 13:08:58 -04:00
Cole Robinson
f3a37ba195 VirtualTPM: Convert to new style properties 2013-07-15 12:18:23 -04:00
Cole Robinson
e5a7fe6405 VirtualVideo: Convert to new style xml props 2013-07-15 11:19:18 -04:00
Cole Robinson
c12327cbd1 Guest: Switch memory units to KB to match default XML 2013-07-13 23:07:01 -04:00
Cole Robinson
194cb715a3 console: A few tweaks to usbredir code
- Make sure to set menu item to unsensitive when console closes
- Avoid dep on latest spice-gtk git for channel_type_from_string
- Create usbwidget every time it's requested, like virt-viewer does
- Minor style fixes
2013-07-08 19:13:52 -04:00
Cole Robinson
39a819c34b details: Fix error with usbredir if no viewer was created 2013-07-07 12:17:54 -04:00