shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-23 17:34:21 +03:00
Code Issues Projects Releases Wiki Activity
7,859 Commits 2 Branches 64 Tags 98 MiB
0c146b2503
Commit Graph

21 Commits

Author SHA1 Message Date
Cole Robinson
4a47d32b09 xmlutil: add a diff() helper 
And centralize all the scattered difflib calls we have

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-09-05 15:49:55 -04:00
Cole Robinson
9a0d49a718 virtinst: uri: Rework MagicURI to work with passed in fakeuri 
Rather than individual options for each possible hypervisor,
and annotations like 'remote' or 'session', just have it take a
fake URI to mock

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-02-03 07:05:11 -05:00
Cole Robinson
f107e39989 Switch to more traditional logging structure 
Init a shared log instance in virtinst/logger.py, and use that
throughout the code base, so we aren't calling directly into
'logging'. This helps protect our logging output from being
cluttered with other library output, as happens with some
'requests' usage
 2019-06-17 00:12:31 -04:00
Cole Robinson
361657ad15 virtinst: Add a lot of test code coverage 
* Delete dead code
* Add tests for various device default code paths
* Rework certain conditions a bit so code coverage always hits them
 2019-06-09 18:59:50 -04:00
Cole Robinson
c2de4d7c36 util: Move get_cache_dir to VirtinstConnection 
Renaming it get_app_cache_dir so it doesn't conflict with get_cache_dir
usage in virtManager
 2019-06-07 17:53:15 -04:00
Eduardo Kienetz
ef8398268b Fix URI parsing when username contains @ sign 
On a domain-joined host the URI wasn't getting properly parsed due to the username containing an @ sign.

Before:
DEBUG (sshtunnels:263) ['ssh', 'ssh', '-l', 'eduardok', 'ad.mydomain.com@kvmhost1', 'sh -c', '\'nc -q 2>&1 | grep "requires an argument" >/dev/null;if [ $? -eq 0 ] ; then   CMD="nc -q 0 127.0.0.1 5900";else   CMD="nc 127.0.0.1 5900";fi;eval "$CMD";\'']

After:
DEBUG (sshtunnels:263) ['ssh', 'ssh', '-l', 'eduardok@ad.mydomain.com', 'kvmhost1', 'sh -c', '\'nc -q 2>&1 | grep "requires an argument" >/dev/null;if [ $? -eq 0 ] ; then   CMD="nc -q 0 127.0.0.1 5900";else   CMD="nc 127.0.0.1 5900";fi;eval "$CMD";\'']
 2018-04-17 15:14:44 -04:00
Daniel P. Berrangé
48e32b429d Fix copyright header to specify GPLv2 or later, not GPLv2 only. 
The copyright headers in every file were chjanged in this previous commit

  commit b6dcee8eb7
  Author: Cole Robinson <crobinso@redhat.com>
  Date:   Tue Mar 20 15:00:02 2018 -0400

    Use consistent and minimal license header for every file

Where before this they said "

  "either version 2 of the License, or (at your option) any later version."

Now they just say

  "GNU GPLv2"

This fixes it to say "GNU GPLv2 or later" again.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
 2018-04-04 16:51:37 -04:00
Cole Robinson
b6dcee8eb7 Use consistent and minimal license header for every file 2018-03-21 07:29:40 -04:00
Cole Robinson
3086c7fda9 Drop python3 compat imports 
We are going completely python3
 2018-02-06 18:56:15 -05:00
Radostin Stoyanov
6de65ab328 urlfetcher: Python 2/3 compatability for 'urllib' 
The `urllib2` module has been split across several modules in Python 3
named `urllib.request` and `urllib.error`. [1]

[1] https://docs.python.org/2.7/library/urllib2.html
 2018-02-06 18:49:17 -05:00
Cole Robinson
1d0b4a0a9e connect: Handle \ in username 
We need to quote URL values in the username, that's what libvirt expects.
Unquote the values before caching them in the URI object, so console
connections continue to work

https://bugzilla.redhat.com/show_bug.cgi?id=1452389
 2017-06-01 14:26:46 -04:00
Cole Robinson
f551d7e55d Replace file() usage with open() 
Same semantics, but the latter is needed for python3
 2017-05-05 14:53:12 -04:00
Mikhail Feoktistov
3870001fd2 virtinst: Add tests for Virtuozzo hypervisor 2017-03-01 15:45:24 -05:00
Cole Robinson
837a9710a3 guest: Use newer named CreateXML API 
CreateLinux is the very old style name. CreateXML has been around
since at least 2009, which covers our minimum libvirt-python version
 2016-06-17 08:58:28 -04:00
Cole Robinson
7bee927276 conn: Stop using VirtOptionParser 
It only needs a minimal portion of the functionality, so separate
that out and use it explicitly. Clean up some of the surrounding
cli.py bits as well
 2016-06-13 18:37:30 -04:00
Cole Robinson
31b8051525 cli: Rename opts.opts -> opts.optdict 
To make it more clear to callers what type of structure they are
dealing with
 2016-06-12 10:32:23 -04:00
Cole Robinson
7f1af40262 tests: Share sanitize_xml helpers 2015-09-22 12:41:57 -04:00
Cole Robinson
29745a9f75 clitest: Do a basic xen-pv install test 2015-09-22 12:41:57 -04:00
Cole Robinson
1d7b74ba52 uri: Add a MagicURI class for handling magic virtinst URIs 
And document it
 2015-09-06 12:00:25 -04:00
Cole Robinson
3ac272e635 uri: Add unit tests, fix some bugs 2014-12-09 10:15:53 -05:00
Cole Robinson
cff08223ba util: Move uri_split to its own URISplit class 
Does what uri_split did, but wraps it all up in an object that makes
handling the data easier, and makes it easy to extend.
 2014-12-09 08:43:19 -05:00