Commit Graph

2948 Commits

Author SHA1 Message Date
Cole Robinson
80e6389b75 Fix a spelling error 2013-06-30 14:33:01 -04:00
Cole Robinson
eec74f1346 Don't show libvirt created nics/taps in net device list 2013-06-30 14:29:49 -04:00
Cole Robinson
0b2aa07480 host: Don't keep items in list when conn closes. 2013-06-30 12:49:48 -04:00
Cole Robinson
cafaea8999 error: Don't append empty tb to details 2013-06-30 12:42:32 -04:00
Cole Robinson
bc13c302de console: Warn if qemu+tcp URI and listen == 127.0.0.1 2013-06-30 11:44:58 -04:00
Cole Robinson
a6d3b0ca14 createinterface: bridge delay is a float 2013-06-30 11:12:45 -04:00
Richard W.M. Jones
9d5c1cdb1c inspection: Check can_set_row_none before setting icon to None.
Previously one could set the icon field of a tree model to None, but
with Gtk3 and older versions of pygobject3 this would fail.

Use can_set_row_none to test for this condition and work around it.

The previous traceback was:

Traceback (most recent call last):
  File "/home/rjones/d/virt-manager/virtManager/manager.py", line 981, in vm_inspection_changed
    self.get_inspection_icon_pixbuf(vm, 16, 16)
  File "/usr/lib64/python2.7/site-packages/gi/overrides/Gtk.py", line 1152, in __setitem__
    self.model.set_value(self.iter, key, value)
  File "/usr/lib64/python2.7/site-packages/gi/overrides/Gtk.py", line 1298, in set_value
    Gtk.TreeStore.set_value(self, treeiter, column, value)
  File "/usr/lib64/python2.7/site-packages/gi/types.py", line 47, in function
    return info.invoke(*args, **kwargs)
TypeError: Argument 3 does not allow None as a value
2013-06-28 13:46:49 -04:00
Richard W.M. Jones
ab312910f2 inspection: Don't recursively try to inspect guestfs-* temporary VMs.
This is a hack.  Should libvirt have a way to mark these VMs?

Note you'll only come across this problem if you run virt-manager as
root with libguestfs >= 1.20 on Fedora >= 18 (libguestfs using libvirt).
2013-06-28 13:05:16 -04:00
Cole Robinson
367041a8d7 Revert "details: Add USB redirection support in console viewer"
This reverts commit 7e1e21a26a.

Was accidentally applied while patch was still in review.
2013-06-28 11:12:23 -04:00
Cole Robinson
555b2d960d Revert "error: new helper function to embed customized widget into dialog"
This reverts commit ee7794a616.

Was accidentally applied while patches are still in review.
2013-06-28 11:11:28 -04:00
Cole Robinson
6b8d4753f6 details: Fix TPM details after my recent change 2013-06-28 10:32:31 -04:00
Cole Robinson
771707fb9c Minor TPM UI fixups 2013-06-26 20:20:12 -04:00
Stefan Berger
4453305d64 Add GUI elements for adding a TPM device to a guest
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2013-06-26 19:45:20 -04:00
Stefan Berger
2766dd5c6a Add GUI elements for TPM passthrough details
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2013-06-26 19:45:16 -04:00
Stefan Berger
93718868c7 Add CLI support and CLI test cases
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2013-06-26 19:43:58 -04:00
Stefan Berger
c829b55581 Add VirtualTPMDevice class to virtinst
Add VirtualTPMDevice class and TPM test cases to xmlparse.py

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2013-06-26 19:43:53 -04:00
Cole Robinson
c1a5bc91d7 details: Remove redundant separator 2013-06-24 12:47:31 -04:00
Guannan Ren
7e1e21a26a details: Add USB redirection support in console viewer
Add "Select USB devices to redirect" option in console viewer
Initialize and embed UsbDeviceWidget object from SpiceClientGtk into
a dialog to let use choose available USB devices for redirection.
Throw an error message if USB connection failed.
2013-06-24 12:39:11 -04:00
Guannan Ren
ee7794a616 error: new helper function to embed customized widget into dialog
helper function: show_info_with_widget()
Widget argument has to be type of Gtk.VBox
2013-06-24 12:39:11 -04:00
Cole Robinson
57345cd61a Tweak 'libvirt needs to be started' first run message 2013-06-24 12:15:28 -04:00
Cole Robinson
10cf80c25b Prep for release 0.10.0 2013-06-19 18:37:21 -04:00
Martin Kletzander
c457363f5a Don't duplicate SCSI controller IDs and assign proper addresses
When Virtio SCSI disk was added to machine with default-model SCSI
controller, the new Virtio SCSI controller had the same index as the
default one (so the domain wouldn't start or with newer libvirt even
define).

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=950330

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-06-19 18:18:33 -04:00
Martin Kletzander
af9762313e Fix VirtualDisk formatting
Add EOLs after iotune elements and add address generation when the
address is set.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-06-19 18:18:32 -04:00
Martin Kletzander
137134650f Allow partial address formatting
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-06-19 18:18:32 -04:00
Martin Kletzander
5fe2d5e977 One more vnc->spice cleanup
Last commit changing the default was de1695b2, but there was still one
place in man page left and the spec file was left dirty.  This is
hopefully the last vnc->spice patch

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-06-19 17:31:51 -04:00
Cole Robinson
ae3ed8db03 async: Revive timer unregistering, unintentionally dropped. 2013-06-18 10:59:19 -04:00
Cole Robinson
f3e061da36 asyncjob: Fix tracebacks if main loop exits early
Our use of nested mainloops is still kinda wonky and a proper solution
will take some decent effort. Deal with the fact that a main loop
might exit before the thread completes, and the thread will try to
talk to resources that no longer exist.
2013-06-18 09:01:45 -04:00
Cole Robinson
1c8bf88db7 baseclass: Add unregister wrappers for idle and timeout
If an idle handler raises an exception, it isn't unregistered and loops
forever. This is a regression from previous pygobject and pygtk:

https://bugzilla.gnome.org/show_bug.cgi?id=702552

Work around this for now with our own wrappers.
2013-06-18 08:49:34 -04:00
Leonardo Garcia
660178abe1 Permit to delete a running VM.
The VM will be forced off before being deleted.

(crobinso: fix a minor pylint violation)
2013-06-18 08:49:18 -04:00
Cole Robinson
44328b1507 Fix some pylint 2013-06-17 20:17:20 -04:00
Leonardo Garcia
18bf5f508d Add delete VM option in console viewer.
(crobinso: Fix a minor pep8 warning)
2013-06-17 20:07:37 -04:00
Cole Robinson
30d509feec delete: Tweak 'are you sure' message for storage deletion 2013-06-17 13:41:32 -04:00
Cole Robinson
b339295fb5 Sigh, fix previous commit. 2013-06-14 16:32:48 -04:00
Cole Robinson
ea9fadac78 config: Fix changing tick timeout on the fly 2013-06-14 16:22:33 -04:00
Cole Robinson
0283750b9d Fix USB test failures with latest libvirt 2013-06-14 14:58:52 -04:00
Cole Robinson
3889bc480b asyncjob: Fix dialog closing and progress bar pulsing
After the recent cleanups
2013-06-14 14:28:04 -04:00
Cole Robinson
8914a61689 Fix exiting app if asyncjobs are running 2013-06-14 11:24:52 -04:00
Cole Robinson
b5baebf24c asyncjob: Only close window if operation completes. 2013-06-14 11:19:22 -04:00
Cole Robinson
cdde7e1d9f asyncjob: Some code reorg
Privatize a bunch of things, move code around to be grouped consistently.
2013-06-14 11:18:12 -04:00
Cole Robinson
2b3604ceeb systray: Fix pylint from appindicators 2013-06-14 11:03:48 -04:00
Cole Robinson
8e0a181cc6 asyncjob: Explicitly pass callbacks to vmmCreateMeter 2013-06-14 10:45:20 -04:00
Eric Shattow
f2c0a77e3e AppIndicator3 required with Gtk3 usage
$ ./virt-manager --debug
/usr/lib/python2.7/dist-packages/gi/overrides/GLib.py:53:
PyGIDeprecationWarning: threads_init longer needs to be called. See:
https://bugzilla.gnome.org/show_bug.cgi?id=686914
  PyGIDeprecationWarning)
2013-06-12 13:10:56,977 (cliutils:75): virt-manager startup
2013-06-12 13:10:56,978 (virt-manager:199): Launched as:
['./virt-manager', '--debug']
2013-06-12 13:10:56,978 (virt-manager:200): virt-manager version: 0.9.100
2013-06-12 13:10:56,978 (virt-manager:201): virtManager import:
<module 'virtManager' from
'/home/es/software/pubscm/virt-manager/virtManager/__init__.pyc'>
2013-06-12 13:10:57,167 (virt-manager:247): GTK version: 3.8.2
/usr/lib/python2.7/dist-packages/gobject/constants.py:24: Warning:
g_boxed_type_register_static: assertion 'g_type_from_name (name) == 0'
failed
  import gobject._gobject
/usr/lib/python2.7/dist-packages/gtk-2.0/gtk/__init__.py:40: Warning:
specified class size for type 'PyGtkGenericCellRenderer' is smaller
than the parent type's 'GtkCellRenderer' class size
  from gtk import _gtk
/usr/lib/python2.7/dist-packages/gtk-2.0/gtk/__init__.py:40: Warning:
g_type_get_qdata: assertion 'node != NULL' failed
  from gtk import _gtk
Segmentation fault (core dumped)
2013-06-14 09:09:08 -04:00
Cole Robinson
8a0bee44dc packagekit: Allow cancelling package search 2013-06-13 17:37:12 -04:00
Cole Robinson
1c22ea92df engine: Close packagekit dialog before connecting to libvirt
We are bunching up a slew of hefty operations, split things up a bit
so the UI has a change to catchup.
2013-06-13 17:35:48 -04:00
Cole Robinson
e2435b6d02 asyncjob: Simplify registering a cancel callback 2013-06-13 17:05:33 -04:00
Cole Robinson
04f0113c2d libguestfs: Work around a pylint error
Not sure why it's triggering a warning here, thinks the return result
is a dict()
2013-06-13 16:12:55 -04:00
Cole Robinson
cbe8665948 libguestfs: Don't try to create icon if none found 2013-06-13 16:10:44 -04:00
Cole Robinson
f3751e6fe9 libguestfs: Start the inspection thread earlier 2013-06-13 16:04:16 -04:00
Cole Robinson
5a46e7420a libguestfs: Drop all version checks
Now that virt-manager requires very modern versions of gtk, it's
quite unlikely that we will even run on a system with an old
libguestfs version, so don't bother checking versions.
2013-06-13 16:04:16 -04:00
Cole Robinson
0c9552bccb spec: Drop libguestfs conditional
We will likely never explicitly depend on it.
2013-06-13 15:56:41 -04:00