Commit Graph

2548 Commits

Author SHA1 Message Date
Li Zhang
e06b277362 details: Add machine type options for non-x86 architecture.
This patch adds the machine type combo callback
funcitons on non-x86 architectures.
For non-x86 architectures, user can select machine
type and the details of overview page are refreeshed,
and the machine type value is set.

Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>

(crobinso: squashed the two patches)
2012-01-12 20:46:41 -05:00
Deepak C Shetty
708dc74468 virt-manager: Add support for filesystem Driver Type
This patch adds support for the user to select Driver Type
on the addhardware->filesystems page. Currently only 'path'
and 'handle' driver types are supported. When anything but
'path' is selected, the security modes do not apply, hence
they are removed from the page based on user's selected
driver type.

Note: Some changes were needed in libvirt also to ensure
smooth experience while dealing with driver and mode
fields. Related libvirt patches are posted at ...

https://www.redhat.com/archives/libvir-list/2011-December/msg00919.html

Signed-off-by: Deepak C Shetty <deepakcs@linux.vnet.ibm.com>

(crobinso: small fix to handle if dev.driver is None)
2012-01-12 20:44:25 -05:00
Deepak C Shetty
18e12e7ad9 virt-manager: Add support for fs readonly attribute
Enables exporting filesytem as a readonly mount for guest, by
default read-write access is given (currently only works for
QEMU/KVM driver)

The support for the same in libvirt was added recently at ...
https://www.redhat.com/archives/libvir-list/2011-December/msg00937.html

Signed-off-by: Deepak C Shetty <deepakcs@linux.vnet.ibm.com>
2012-01-12 20:21:35 -05:00
Guido Günther
5e77012c76 storagebrowser: ignore unparseable volumes
This e.g. happens when the volume was moved away but the pool didn't get
refereshed:

Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/create.py", line 1229, in browse_import
    self._browse_file(set_path, is_media=False)
  File "/usr/share/virt-manager/virtManager/create.py", line 2118, in _browse_file
    self.storage_browser.show(self.topwin, self.conn)
  File "/usr/share/virt-manager/virtManager/storagebrowse.py", line 74, in show
    self.reset_state(conn)
  File "/usr/share/virt-manager/virtManager/storagebrowse.py", line 183, in reset_state
    self.pool_selected()
  File "/usr/share/virt-manager/virtManager/storagebrowse.py", line 257, in pool_selected
    self.populate_storage_volumes()
  File "/usr/share/virt-manager/virtManager/storagebrowse.py", line 322, in populate_storage_volumes
    path = vol.get_target_path()
  File "/usr/share/virt-manager/virtManager/storagevol.py", line 49, in get_target_path
    return util.xpath(self.get_xml(), "/volume/target/path")
  File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 93, in get_xml
    self.refresh_xml()
  File "/usr/share/virt-manager/virtManager/libvirtobject.py", line 105, in refresh_xml
    self._xml = self._XMLDesc(self._active_xml_flags)
  File "/usr/share/virt-manager/virtManager/storagevol.py", line 35, in _XMLDesc
    return self.vol.XMLDesc(flags)
  File "/usr/lib/python2.7/dist-packages/libvirt.py", line 2002, in XMLDesc
    if ret is None: raise libvirtError ('virStorageVolGetXMLDesc() failed', vol=self)
libvirt.libvirtError: cannot stat file '/var/scratch/vms/squeeze-template.img': No such file or directory

Instead of failing the whole pool simply ignore the one failing volume.
Without this patch selecting "Browse..." when creating a new vm from an
existing disk image won't show the volume dialog if the default pool has
a missing volume.
2012-01-12 20:05:38 -05:00
Deepak C Shetty
a7a0e316cf virt-manager: Fix Mode hotkey problem in FS page
Mode label in FS page should be associated with the
fs-mode-combo, but its erronesouly is associated with
fs-type-combo, fixing that here.

Signed-off-by: Deepak C Shetty <deepakcs@linux.vnet.ibm.com>
2012-01-12 20:03:21 -05:00
Deepak C Shetty
ea4f6f4ed3 virt-manager: Throw appropriate error when fs target string already exists.
In case of qemu for default fs type (mount) target is not
actually a directory, it is merely a arbitrary string tag
that is exported to the guest as a hint for where to mount.

This tag is unique and is exported as a virito-9p-pci
device and hence this patch adds check to ensure the target
string/tag is never entered duplicate by the user when
adding 2 or more filesystem devices.

Signed-off-by: Deepak C Shetty <deepakcs@linux.vnet.ibm.com>
2012-01-12 19:36:38 -05:00
Cole Robinson
f96796dda3 AUTHORS: Clarify that I am really the only active dev/maintainer
Yeah, look at me, I'm sooooo cool.
2011-12-22 13:26:10 -05:00
Cole Robinson
bb59b1b075 AUTHORS: Use sensible indentation 2011-12-22 13:24:05 -05:00
Cole Robinson
28a399cbd7 Add Jim to AUTHORS 2011-12-22 13:21:45 -05:00
Jim Fehlig
42a871984f addhw: Add SATA disk bus option 2011-12-22 13:18:40 -05:00
Cole Robinson
becf776d6a console: Fix hang when reconnecting to remote VNC console
VNC disconnect signals aren't being delivered, meaning we never cleanup
up SSH tunnels for remote VNC connections. This causes a reconnect
attempt to hang, trying to reuse the existing tunnels (which doesn't
work).

The problem is that we are cleaning up the VNC widget too early,
unregistering callbacks before they get a chance to be invoked.

Not cleaning up only causes a small memory leak for every console we
open, so only a minor problem compared to the original issue. A more
involved fix is required to clean up safely.
2011-12-22 12:55:40 -05:00
Lars Sjostrom
9d2119ab3e inspection: exclude cdrom from vm inspection
Can cause inspection to fail if cdrom is the first device
See: https://bugzilla.redhat.com/show_bug.cgi?id=752552

(crobinso: added Lars to AUTHORS, expanded commit msg)
2011-11-10 13:23:06 -05:00
Cole Robinson
a712a7b32e details: Always show toolbar in customize dialog
Make sure it isn't accidentally hidden
2011-10-30 13:28:18 -04:00
Cole Robinson
930a321f8e console: Fix crashes when deleting vm on F16
The toolbar cleanup order was causing crashed on f16 at app shutdown or
VM delete (when a console window is fully uninstantiated)
2011-10-28 12:20:31 -04:00
Cole Robinson
392cb8075f connection: Don't have tick edit object lists in place
Since 'tick' isn't really thread safe, and we sometimes call a manual tick
to refresh resources (say immediately after creating a guest), we
can't depend on lists staying consistent.
2011-10-13 16:59:15 -04:00
Cole Robinson
bca1552306 migrate: Better attempt at generating a remote URI for localhost
If doing p2p migration from a remote host to localhost, we need to
generate a remote libvirt URI for qemu:///system. Try and use the remote
auth credentials of source connection.
2011-10-13 16:13:36 -04:00
Cole Robinson
03435db779 Fix some pylint 2011-10-06 14:06:40 -04:00
Marc-André Lureau
e69977f82f virt-manager: allow switching between USB1/piix3 and USB2/ich9 controller
crobinso: Fix some small pylint
2011-10-06 14:05:46 -04:00
Cole Robinson
5a84a3a627 create: Make 'browse local image' chooser allow entering a new path 2011-09-26 20:44:40 -04:00
Cole Robinson
b2c9a0eb8e create: Warn about unapplied changes for customize dialog
Also make virtinst domains report signals synchronously to avoid customize
dialog tracebacks in the logs.
2011-09-26 20:14:12 -04:00
Cole Robinson
731fd74bf0 cli: Log uncaught exceptions at debug level
Logging at exception level expects a stack trace, which we don't see
since we are in the exception handler.
2011-09-26 19:22:52 -04:00
Cole Robinson
f0e963e356 createvol: Hook up configure switch to hide unsupported RHEL6 formats 2011-09-26 18:53:00 -04:00
Cole Robinson
e37b67b59a create: RHEL6 supports SPICE, hardcode it 2011-09-26 17:10:05 -04:00
Cole Robinson
1e386dbf8f console: Properly handle mnemonics on spice focus change 2011-09-26 16:32:37 -04:00
Cole Robinson
ee434cb66a addhw: Hide unsupported RHEL6 serial device types 2011-09-26 11:34:21 -04:00
Cole Robinson
8b0be3ee2a configure: Make summary output match command line names for rhel6 opts 2011-09-26 11:33:03 -04:00
Cole Robinson
0a7640c593 manager: Properly show vm desc in tooltip w/ special xml characters 2011-09-26 11:07:52 -04:00
Cole Robinson
3d3ac635e1 host: Don't use text entries for fields that aren't editable
Also make some interface labels selectable.
2011-09-22 10:45:09 -04:00
Cole Robinson
1f87e18dbf Add back .pot file 2011-09-20 10:08:35 -04:00
Cole Robinson
1bcc39005d Update translations 2011-09-19 10:53:56 -04:00
Marc-André Lureau
faf93c0f8f virt-manager: Learn to add USB redirection devices 2011-09-14 16:41:52 -04:00
Marc-André Lureau
b2cadf3c3d virt-manager: Add redirected devices details 2011-09-14 16:41:52 -04:00
Marc-André Lureau
5b8e215e06 virt-manager: Add controller model in details 2011-09-14 16:41:51 -04:00
Marc-André Lureau
df4dfd7362 virt-manager: fix char device source mode 2011-09-01 13:23:54 -04:00
Cole Robinson
ce8111e190 Import logged info from validation errors 2011-08-30 14:50:50 -04:00
Cole Robinson
66f879e19d connection: Fix some code that trips up pylint 2011-08-30 14:50:29 -04:00
Cole Robinson
cbbc8044bf details: Better logging and error reporting for child dialogs 2011-08-30 14:29:51 -04:00
Cole Robinson
9a46aa41e0 util: get_default_path: Handle 'None' in collidelist 2011-08-30 14:29:08 -04:00
Cole Robinson
b36ec4b8c2 domain: Remove managed save state before delete
Newer libvirt forbids 'undefine' in this case
2011-08-29 14:03:50 -04:00
Cole Robinson
db21a2a833 delete: Properly raise 'undefine' errors 2011-08-29 14:01:40 -04:00
Cole Robinson
bbc6f41baf TUI: Remove some pylint 2011-08-29 12:53:05 -04:00
Cole Robinson
41e6d7b0f4 details: Fix confusion when removing device with unapplied changes 2011-08-29 12:53:02 -04:00
Cole Robinson
8a51336152 manager: Properly show domain names with reserved XML characters 2011-08-29 12:11:43 -04:00
Cole Robinson
a1057be68f spec: Fix disabling RHEL6 unsupported options 2011-08-29 11:13:34 -04:00
Cole Robinson
0c2eee328d details: Don't show SCSI/USB bus for RHEL6 2011-08-29 11:06:19 -04:00
Cole Robinson
1458604034 storagepool: Fix RHEL6 gtk compat issue 2011-08-24 12:52:46 -04:00
Cole Robinson
5104669795 Specify /usr/bin/python explicitly 2011-08-24 12:41:30 -04:00
Cole Robinson
3438e7ecf5 Remove unneeded python header 2011-08-24 12:41:29 -04:00
Cole Robinson
5476a7dbb7 Add Miklos to AUTHORS 2011-08-24 12:41:28 -04:00
Cole Robinson
9dc799af9c domain: Don't fetch XML on tick to get vcpu count
It's available in the domain info structure. Saves us from hammering
xenstored and just plain doing to much work on every tick.
2011-08-23 15:48:30 -04:00