Commit Graph

294 Commits

Author SHA1 Message Date
Cole Robinson
467fea9df7 asyncjob: Convert to GtkBox 2016-01-11 14:46:53 -05:00
Cole Robinson
2178cc8c93 create: Drop explicit kickstart UI
Few users actually use this, and they can easily do it with the kernel
options field.
2015-11-21 20:21:09 -05:00
Cole Robinson
d32953d8c6 details: Remove UI for vcpu pinning
This UI exposed the old NUMA allocation policy detailed in the last commit.
It's very much sub-optimal, and should be removed.

Manual cpuset configuration is also quite uncommon and not really something
worth exposing in the UI. It can easily be done from the command line
with virt-xml.

If people complain, I'd consider adding a checkbox for vcpu placement=auto,
or an option to do that by default for new VMs.
2015-11-18 15:05:21 -05:00
Cole Robinson
ba8080db3f storagelist: Reset list position after deleting volume (bz 1279861) 2015-11-10 17:27:49 -05:00
Cole Robinson
117cad551d ui: Don't mark UI accessibility names as translatable
Because I haven't been using translatable strings...
2015-09-23 17:01:41 -04:00
Cole Robinson
8e58734699 create: Hide aarch64 warning if we switch architectures
Simplest is to have a separate UI area for the arch warning, since
the standard startup warning may still apply too.

Reported-by: João Pirralha <joaopirralha@gmail.com>
2015-09-23 16:51:49 -04:00
Cole Robinson
b6111b5e85 details: Fix misaligned labels (bz 1264628)
Shows up with different sized translation strings

https://bugzilla.redhat.com/show_bug.cgi?id=1264628

Reported-by: João Pirralha <joaopirralha@gmail.com>
2015-09-20 12:58:23 -04:00
Cole Robinson
0b881591ec console: Add a separate notebook for serial pages
Rather than the 'offset' page hack we previously did that is hard to
keep track of. This allows for a handful of code simplifications
2015-09-18 12:36:06 -04:00
Cole Robinson
d896dd7347 create: Allow switching between KVM and TCG for armv7l (bz 1214592)
Otherwise we tried to always force KVM which reduces the usefulness
here. We still get the defaults right though

https://bugzilla.redhat.com/show_bug.cgi?id=1214592
2015-09-14 19:27:48 -04:00
Cole Robinson
7953f23975 create: Update storage path in summary when VM name changes
If the name is going to influence the default storage path, update it
as people type
2015-09-14 16:22:17 -04:00
Cole Robinson
a4ddac4bb1 create: Always display the storage path in the summary 2015-09-14 15:22:17 -04:00
Cole Robinson
01da21b93a uitests: Add a basic details.py test
Checks all hw of test-many-devices and make sure an error isn't raised
2015-09-14 14:44:39 -04:00
Cole Robinson
9f56641b49 addstorage: Tweak labels to be a bit more descriptive
WRT the fact that we aren't just 'browsing' for storage anymore
2015-09-13 19:27:44 -04:00
Cole Robinson
16a744749f addhardware: Drop 'storage format' field
Originally this made sense, as it was the only way to specify a non-default
storage format when creating new storage.

Nowadays the storage browser is a full featured storage manager... and
this field is a bit confusing WRT whether it's used for creating new
storage, or informing libvirt about an existing image's format.

Drop it from the addhardware wizard, and simplify what we show in the
details wizard as well.
2015-09-13 19:13:53 -04:00
Cole Robinson
a2bd31c2a6 virt-manager: Drop old style config- prefix for widget names
It's redundant and we haven't followed that pattern for a long while
2015-09-13 18:01:39 -04:00
Cole Robinson
4b5e65fe8d details: Remove iotune UI
This is a little low level and rarely used IMO to have it in the UI.
If people want to edit this we should point them at virt-xml which
seems like the appropriate user friendlyness for this feature.
2015-09-13 15:54:47 -04:00
Cole Robinson
15a6a7e210 addstorage: Drop explicit sparse option
This made more sense when raw was the disk image default, but nowadays
we use qcow2 which doesn't even support non-sparse, so the UI is always
disabled.

If the user changed their preference to raw, it still doesn't make much
sense to show the option, since they are likely using raw for performance
in which case they are going to want to preallocate anyways.

So just default to sparse=False. If users want to override it, they can
do it via custom created storage.
2015-09-13 15:43:24 -04:00
Cole Robinson
241c3125e5 create: Drop redundant _have_startup_error
Isn't needed in the modern code
2015-09-13 12:28:16 -04:00
Cole Robinson
ddea18baf9 create: Cleanup of distro detection code
- Use better variable names
- Lots of comments
- Streamline various parts
2015-09-13 12:28:16 -04:00
Cole Robinson
5c66328e10 uitests: Several more 'New VM' tests, and cli --show tests 2015-09-09 19:07:31 -04:00
Cole Robinson
730b739795 create: A bunch of mnemonic fixes 2015-09-09 14:26:36 -04:00
Cole Robinson
531260be36 details: Raise upper limits for lxc ID namespaces (bz 1244490) 2015-08-10 13:14:37 -04:00
Cole Robinson
5f497b4d79 Mark a couple strings as translatable 2015-08-09 14:01:01 -04:00
Cole Robinson
fc93e154dc addhardware: Fix udp/tcp host vs mode UI
We had the UI label names swapped, so were showing the incorrect fields
2015-06-21 15:14:30 -04:00
Cole Robinson
b02cb7ffa0 delete: Improve dialog sizing and scrolling
Drop horizontal scrolling, since with gtk3 hidden scrollbars it might
mean users don't realize there's info that is scrolled off.

Adjust the default sizing to match that pattern
2015-05-20 17:50:11 -04:00
Cole Robinson
2168f33799 details: Unify controller model handling with addhardware 2015-05-19 18:29:45 -04:00
Giuseppe Scrivano
fbdf574c53 add-hardware: fix shortcut key for USB redir dev type
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1172108

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-11 10:17:11 +02:00
Cole Robinson
68ce97d533 create: customize: cancel now cancels the entire installation
Trying to fall back to the create wizard can give weird results, since
it's really hard to ensure the customized changes are preserved if
the user changes things in the 'new' wizard.
2015-05-03 16:53:43 -04:00
Cole Robinson
46ecafd820 migrate: Fix typos pointed out by translator 2015-05-01 09:38:25 -04:00
Cole Robinson
18a6d8b444 migrate: Add 'temporary' option
This doesn't undefine the VM source, and leaves it temporary on the
destination. Basically the default migration action
2015-04-21 17:39:44 -04:00
Cole Robinson
62ad0e91ee migrate: Big reworking of the dialog
It's largely the same, but now

- The code is better organized
- The UI is much more streamlined, only showing relevant fields when
  required.
- We warn about the hostname/URI cases that we know libvirt will error on
- Drop some of the attempts at being smart, and just mimic what libvirt
  will do.
2015-04-21 17:15:58 -04:00
Cole Robinson
bfcfdbf785 host: Remove some redundant connection fields 2015-04-21 16:33:41 -04:00
Cole Robinson
996c8b76b8 clone: Use conn desc if showing destination conn 2015-04-21 16:33:41 -04:00
Cole Robinson
2b877cf337 migrate: Remove 'max downtime' support
This is only needed when people have very specific downtime constraints
on public facing services. I don't think that covers many virt-manager
users. So suggest they just use the command line for this.
2015-04-21 16:33:41 -04:00
Cole Robinson
39dc0c7b94 migrate: Drop 'bandwidth' UI
A bit too enterprisy for my tastes. If people need this they should use
the command line.
2015-04-21 16:33:41 -04:00
Cole Robinson
3d2afbaf6f connection: Allow setting a custom 'pretty name' (bz 784701)
We've had multiple requests over the years for something similar. People
might have to connect to multiple IP addresses, or really large hostnames,
that become difficult to distinguish in the UI.

Add a field in the host details page that allows setting a custom name,
and store it in gsettings.
2015-04-11 13:39:25 -04:00
Cole Robinson
8c107f87f9 host: Remove some redudant conn details
And some minor UI spacing fixes
2015-04-11 11:29:03 -04:00
Cole Robinson
413c290bfe create: Renamed 'advanced options' to 'network selection'
Since that's all it contains now
2015-04-10 18:44:16 -04:00
Cole Robinson
8f563cbae8 storagelist: Simplify Ui a bit
Drop the bold and overly sized text. Drop the name duplication.
Drop the type field since it's shown in the pool list.
2015-04-10 18:40:54 -04:00
Cole Robinson
92c42bc5a0 details: Improve UI labeling of keyboard devices 2015-04-09 13:36:40 -04:00
Cole Robinson
771154d104 addhardware: Make network model a combo entry
So users can add non-advertised models
2015-04-09 12:58:21 -04:00
Cole Robinson
058c06972e Break out shared storage UI to storagelist.py (bz 1060433)
We were already sharing a chunk of this in a haphazard way. Now officially
break it all out, similar to netlist.py. This mostly unifies the views
of host->storage and storagebrowser.py
2015-04-09 12:31:24 -04:00
Cole Robinson
ec162888f5 addhardware: Make bus list dependent on device type
And not the other way around. It's less confusing this way IMO, particularly
if virtio is selected by default and the user is confused, wondering
where the cdrom option is.

Take the opportunity to actually share the bus combo logic between details
and addhardware
2015-04-07 19:31:30 -04:00
Cole Robinson
1d98af2c47 create: Move mac address editing to customize dialog
People should rarely need to edit the mac address, so remove it from
the create wizard. However we only allow editing the mac address in
the 'customize' dialog: regular network details disables editing, since
that should be a rare and potentially dangerous operation.
2015-04-07 18:52:35 -04:00
Cole Robinson
39b5d11628 details: Make CPU config a frame, not an expander
It's very commonly tweaked, so move it front and center.
2015-04-07 11:53:16 -04:00
Chen Hanxiao
101ca3cef8 details: change duplicated short-key 'd' to 'e' on Overview tab
add hardware also use 'd' as its short-key.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-03-16 21:26:47 -04:00
Giuseppe Scrivano
61e06856a3 virt-manager: Allow to change SGIO with LUN disk devices
It is added only in the details window, and intentionally not added to
the addhardware UI to keep it simpler.  Users can edit this after a
new device is added.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-16 20:32:40 +01:00
Cole Robinson
0ddec9199b details: Don't allow changing machine type for existing VM
But still allow it from the customize dialog. It's one of those things
that rarely can be changed for a working VM and things continue to work.
2015-02-22 10:25:51 -05:00
Chen Hanxiao
694f2b1370 connection details: add short-keys for Virtual Networks
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-01-28 09:52:23 +08:00
Chen Hanxiao
751d189110 ui: remove underline property of tpm device type in details
We could not modify tpm device type yet.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-31 14:28:22 +08:00
Giuseppe Scrivano
2dff68c1df virtManager: Add missing shortcut keys
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1172108

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-13 15:42:46 +01:00
Chen Hanxiao
e0b5283ac3 Redirect device: remove underline property of 'Type' in details UI
redir-type is a label.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:10:14 +08:00
Chen Hanxiao
71613d95e8 Smartcard device: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:08:02 +08:00
Chen Hanxiao
34f9be43c2 sound: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:07:33 +08:00
Chen Hanxiao
8f2c9b354a cpu: add mnemonics in details UI
Add mnemonics for 'Configuration' page,
'Topology' page, 'Pinning' page
and their sub-pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:06:47 +08:00
Chen Hanxiao
0368394c7e boot options: add mnemonics in details UI
Add mnemonics for 'Direct kernel' page
and sub-pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:06:13 +08:00
Chen Hanxiao
e758aec861 video: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:05:38 +08:00
Chen Hanxiao
351d0a2834 details: add shortkey for controller model
shortkey 'o' for 'Model'.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:04:28 +08:00
Chen Hanxiao
ce7fd785e4 watchdog: add missing mnemonics in details UI
add missing mnemonics and fix an duplicated shortkey

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:02:02 +08:00
Wei Huang
dea3520ea8 ui: add a warning message for hyper-threading support
Not all CPUs support Hyper-Threading. This patch adds a warning
message next to the threads selection field of processor topology
box. It warns that "Selected CPU model does not support
Hyper-Threading" when # of Threads > 1 and the selected CPU model
does not support Hyper-Threading.

This UI modification was added using glade 3.18.3.

Signed-off-by: Wei Huang <wei@redhat.com>
2014-10-27 18:05:21 -04:00
Chen Hanxiao
8f077a270f panic notifier: remove shortcuts in details.ui
We could not modify them in panic notifier page,
so remove them.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:07:35 +08:00
Chen Hanxiao
6f196ed21d panic-notifier: add missing mnemonics in addhardware UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:06:14 +08:00
Chen Hanxiao
b5fd41135d details: add missing mnemonics in cpu UI tab
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:05:52 +08:00
Chen Hanxiao
7752d60cfe ui: change fs-type label ID from "label18" to "fs-type-title"
It looks not very social as its naming.
And it will be used in the later patch.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 10:23:59 +08:00
Chen Hanxiao
64e7e783e7 ui: change duplicated fsdetail shortkey
shortkey M for fs-mode in fsdetail duplicate shortkey of
"Virtual Machine" in details.
change it to 'o'.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-17 17:18:53 +08:00
Cole Robinson
f4563906ca snapshots: Use consistent button layout with host dialog
Except 'refresh' is in place of 'stop'
2014-09-21 11:44:01 -04:00
Cole Robinson
439e5ad0fe details: Reorg a bunch of the global helpers
Some were redundant, some should be in virtinst
2014-09-20 10:23:19 -04:00
Cole Robinson
4ad50d968a details: Put tabs on left, easier to navigate with glade 2014-09-20 10:21:27 -04:00
Cole Robinson
fa76e92f2c virt-manager: Fix issues with ellipsizing on recent gtk 2014-09-19 22:08:22 -04:00
Cole Robinson
55739055fd ui: Set all files to minimum requirement of gtk 3.8
That way gives us better feedback from glade
2014-09-19 21:19:26 -04:00
Cole Robinson
ae26313ed4 details: Add UI for enabling UEFI via 'customize before install'
We expose a simple combobox with two entries: BIOS, and UEFI. The
UEFI option is only selectable if 1) libvirt supports the necessary
domcapabilities bits, 2) it detects that qemu supports the necessary
command line options, and 3) libvirt detects a UEFI binary on the
host that maps to a known template via qemu.conf

If those conditions aren't met, we disable the UEFI option, and show
a small warning icon with an explanatory tooltip.

The option can only be changed via New VM->Customize Before Install.
For existing x86 VMs, it's a readonly label.
2014-09-17 18:43:41 -04:00
Cole Robinson
cc70aa82ab ui: Fix minor issues, and resave all files with f21 glade 2014-09-06 15:01:12 -04:00
Giuseppe Scrivano
724c6499f0 snapshots: add button to force snapshots list refresh
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-01 09:30:21 +02:00
Giuseppe Scrivano
e44ee980ae virtManager: add QoS information for a network
Add UI elements to display and modify QoS settings in the network
details.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1089117

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-08 00:05:09 +02:00
Cole Robinson
1e77c05c4e Clarify some translation strings, reported on transifex 2014-07-04 16:42:24 -04:00
Chen Hanxiao
27d03b8b92 preferences ui: fix a duplicate shortkey
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-17 13:21:46 +08:00
Chen Hanxiao
75d43f6a37 fix some missed binary prefixes for units
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-17 09:33:14 +08:00
Chen Hanxiao
100023baa6 preferences ui: add shortkey for Add Spice USB Redirection
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-17 09:32:42 +08:00
Chen Hanxiao
2f4a424521 use binary prefixes for units where appropriate
https://bugzilla.redhat.com/show_bug.cgi?id=1103893

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:56:53 +08:00
Chen Hanxiao
ba96af8df8 addhardware: add a tool tip when USB controller already existed
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:50:04 +08:00
Chen Hanxiao
b4a43fb6b7 preferences ui: add shortkey for tab page
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:43:33 +08:00
Chen Hanxiao
ea4847961a host ui: add shortkey for tab page
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:43:09 +08:00
Chen Hanxiao
d007352aa4 connection: Fix Alt - t shortcut key
Or we will get:
"Couldn't find a target for a mnemonic activation"

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-12 16:36:16 +08:00
Giuseppe Scrivano
64c6a9be34 preferences, feedback: fix Alt-i key shortcut
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
fb56ac8f36 createinterface: add key shortcuts for Bridge configuration
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
75e83a099e createinterface: make "Configure" shortcuts unique
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
e9687ab071 createpool: fix shortcuts refs and make them unique
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
a8db7ec266 createvol: change "Format" key shortcut to Alt-o
Alt+f is already used for Finish.  Choose Alt-o as it is already used
for "Format" in other places.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
0b7c7c0c07 createnet: fix references for Alt-d and Alt-m
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
86d5ff04e3 connection: Fix Alt-o shortcut key
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Cole Robinson
f686e36e42 details: Expose chipset=i440fx/q35 in customize dialog
So enterprising users can choose q35 for x86 qemu/kvm VMs. Some
discussion over here:

http://www.redhat.com/archives/virt-tools-list/2014-May/msg00001.html
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00019.html

We show a warning if q35 is selected, saying it's not well tested.
Hopefully that dissuades people who are just clicking about.
2014-06-03 15:58:04 -04:00
Cole Robinson
091eb9fe26 details: Expose LXC <initarg> 2014-05-31 17:34:23 -04:00
Cole Robinson
9369ad3ac0 virt-manager: Allow setting interface portgroup element
We only show the option if the selected virtual network actually has
portgroups listed in its XML
2014-05-31 15:51:24 -04:00
Cole Robinson
9fd0ef5c88 details: Better handling for <input type=keyboard> 2014-05-04 13:23:54 -04:00
Chen Hanxiao
865dd99af2 addhardware: add controller UI
This patch will enable adding controller
without model.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-26 22:40:17 +08:00
Giuseppe Scrivano
33a2d1a1c8 virt-manager: use autocomplete for OS variant selection
After the migration to libosinfo, choosing an OS variant from "New VM"
wizard became a mess for the very long list of options.
Using an autocomplete entry text will facilitate this task, as an user
can start typing the variant as soon as the OS type is selected.
The combo-box is left untouched, so undecided users can still use it.

UI-suggested-by: Máirín Duffy <duffy@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-04-26 10:32:30 +02:00
Cole Robinson
70da20682c details: Explicit warn that 'format' doesn't change image format (bz 1089457) 2014-04-21 17:04:33 -04:00
Cole Robinson
8fa2aad1d3 createpool: Clarify iscsi IQN fields (bz 1084011) 2014-04-03 11:19:03 -04:00
Giuseppe Scrivano
6c68467be7 virt-manager: update copyright years in the About box
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-26 16:12:13 +01:00
Marc-André Lureau
2606c1d1b8 ui: add 'channel' to addhardware char panel
Add a 'Channel' entry, to specify the name of a channel (Spice port,
currently).
2014-03-25 17:42:57 -04:00