Commit Graph

249 Commits

Author SHA1 Message Date
Cole Robinson
0b8ba7760e details: Fix status icon shrinking on state change.
No idea why this is happening or what is causing it, but
forcing the icon width fixes things...
2014-01-12 14:35:35 -05:00
Cole Robinson
f055b07a61 details: Couple mini 'panic' UI cleanups 2014-01-11 15:08:00 -05:00
Chen Hanxiao
c7a374b51d virt-manager: add support for adding panic notifier device
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-11 14:53:20 -05:00
Chen Hanxiao
a90a375bda virt-manager: add support for showing panic notifier device
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-11 14:53:19 -05:00
Thorsten Behrens
77b1143965 Add memory stats widget also to manager tree view.
(crobinso: Fix an initialization issue)
2014-01-06 12:08:55 -05:00
Charles Arnold
1124043151 Allow unsafe migrations in virt-manager
Normally, setting cache=none is required in order to ensure a consistent view
of storage between the source and destination migration hosts. However, some
configurations have that quality without resorting to the use of an O_DIRECT
open (which is what cache=none does), and hence cache=none wouldn't be
necessary.

Unfortunately, libvirt is not able to determine on it's own all the
configurations which require cache=none for migration but in the interest of
safety enforces it when it isn't otherwise able to determine migration safety.

For this reason the libvirt api has an 'unsafe' option which allows the user
to override the safety migration checks.

This patch adds a checkbox to allow unsafe migration to the 'Advanced options'
portion of the migration dialog.

Signed-off-by: Charles Arnold <carnold@suse.com>
2013-12-14 12:23:37 -05:00
Chen Hanxiao
10d5eb8375 add button to remove cpu feature
We could copy host CPU config by
button 'Copy host CPU configuration'.
If we regret to do this or the host CPU config
caused VM starting failure, we need a button to
help us clear CPU feature.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2013-12-04 18:34:53 -05:00
Giuseppe Scrivano
0abbb6d122 details: show warning when guest inspection fails
If libguestfs fails to inspect the guest then show a warning.

Now the "Operating System" and "Applications" frames are visible
only when the guest inspection is available.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=755869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-12-03 11:39:27 +01:00
Cole Robinson
fb3b5a277b snapshots: s/State/VM State/ (bz 1016604) 2013-11-09 18:00:00 -05:00
Martin Kletzander
30c33ea5cd Fix label at the end of installation
The commit 67c62e68 moved naming of the domain to the last
installation page and this made a placeholder "foobar" appear.
2013-10-29 11:24:52 +01:00
Giuseppe Scrivano
408771004f virt-manager: show correctly EGD RNG devices information
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:19 +01:00
Giuseppe Scrivano
a7519dc1e9 virt-manager: fix adding EGD RNG devices in UDP mode
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1001773

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:41:14 +01:00
Cole Robinson
fdb79b9832 snapshots: Add a right click menu for start/stop 2013-10-05 14:57:58 -04:00
Cole Robinson
111f4353a3 snapshots: new: Grab name focus, make activate create the snapshot 2013-10-05 14:47:10 -04:00
Cole Robinson
34f23165b6 addhw: Add channel option for auto socket allocation 2013-10-05 13:54:28 -04:00
Cole Robinson
9d21d2bb02 addhw: List known channel names in a comboboxentry 2013-10-05 13:27:11 -04:00
Cole Robinson
24137cdfe9 addhw: Add 'console' option for adding virtio consoles 2013-10-05 13:22:53 -04:00
Cole Robinson
97f5717ef7 snapshots: Fix showing async dialogs for revert/delete 2013-10-05 10:03:56 -04:00
Fred A. Kemp
c45e1ef6b8 virt-manager: Add checkbox controlling disk 'removable' flag
(crobinso: Fix to use grid rework)
2013-10-04 08:08:44 -04:00
Cole Robinson
6de06778d3 details: Convert disk UI from table to grid 2013-10-04 08:01:18 -04:00
Cole Robinson
d83b2c02fa virt-manager: Add USB3 convenience option to the controller UI
and a --controller usb3 option to virt-install
2013-10-03 16:34:28 -04:00
Cole Robinson
7cb84f5ba5 preferences: Explicitly list system default 2013-10-02 14:47:21 -04:00
Cole Robinson
7c7f3ad0b2 create: Fix some spacing issues 2013-10-02 12:35:59 -04:00
Cole Robinson
d6f96f72d5 create: Add kernel/initrd install option for arm
Basically just show kernel/initrd options for the 'import' install
method on non-x86.
2013-10-02 12:35:59 -04:00
Cole Robinson
c18c94d157 create: A couple mini layout tweaks 2013-10-01 17:55:27 -04:00
Cole Robinson
42389214af create: Add 'machine' option for non-x86 arch 2013-10-01 17:40:44 -04:00
Cole Robinson
0697e5f349 create: More arch/type handling
Hide the 'type' field on non-xen: we shouldn't need to expose
kvm vs. qemu in the UI, just assume if kvm is available we use it.

Hide arch if there's only one available. And hide the whole expander
if we hid both sub fields.
2013-10-01 17:27:58 -04:00
Cole Robinson
67c62e68de create: Move name to last page, arch/type to first page
Moving name to the end allows us to do things like generate a default
name based on the chosen OS type, which we do here. This is bz 736951

Moving arch/type to the front page of the wizard simplifies validation
and will be needed to intuitively install arm guests without a bunch
of hacky workarounds.
2013-10-01 16:53:59 -04:00
Cole Robinson
7009bd2560 createvol: Bunch of misc improvements
- Hide backing store for formats that don't support it
- Hide allocation for qcow2 since it doesn't do anything
- Automatically select the storage format as specified in prefs
2013-10-01 14:50:47 -04:00
Cole Robinson
868fbd9fc9 snapshots: Add screenshot support
Show a screenshot in the 'new snapshot' wizard. If we successfully create
that snapshot, save the screenshot in

~/.cache/virt-manager/$connuri/$vmuuid/snap-screenshot-$snapname.$ext

And show it in the snapshot details overview. We don't do any reaping
on snapshot delete, vm delete, etc, but that could be added later.
2013-10-01 10:14:51 -04:00
Cole Robinson
7a23ece986 details: Move snapshot switcher at end of toolbar
This was the original suggested layout from way way back when the designers
did mock ups.
2013-09-30 20:59:15 -04:00
Cole Robinson
d44f863c2d details: Disable snapshot buttons if conn or guest doesn't have support 2013-09-30 20:33:42 -04:00
Cole Robinson
6043a88a0c snapshots: Add some specific UI for external snapshots
We sort them separately in the snapshot list, explicitly mention that
they are 'external', and add a UI field listing the memory/disk
details.

In general mixing internal and external snapshots is a recipe for
confusion and disaster, so I think the best thing to do is at least
acknowledge their presence in the UI but not make any attempt to
predict what will or will not work.
2013-09-30 19:55:21 -04:00
Cole Robinson
6f469d7947 snapshots: List VM status in 'new snapshot' window 2013-09-30 17:40:01 -04:00
Cole Robinson
01577d3d88 snapshots: Desensitize 'finish' if no name entered 2013-09-30 16:22:12 -04:00
Cole Robinson
5f34e7d885 details: Use 'clone' icon for snapshot button
Better than the 'new' icon since people see that one much more and
likely already have an association with it. Better would be a
distinct icon though.
2013-09-30 15:38:34 -04:00
Cole Robinson
2b74c46909 snapshots: Pretty up the 'new snapshot' dialog 2013-09-30 15:38:12 -04:00
Cole Robinson
8f0bfb1ad6 host: Allow renaming a storage pool 2013-09-29 12:28:01 -04:00
Cole Robinson
369a17160a host: Allow renaming virtual networks 2013-09-29 12:14:00 -04:00
Cole Robinson
b6adf48e56 createvol: Add UI for specifying backing store 2013-09-29 10:53:37 -04:00
Cole Robinson
375790075d details: Drop combo_or_label paradigm, use combobox entries
So we can handle unknown XML values and give users more flexibility
for things we can't predict.
2013-09-28 14:25:37 -04:00
Cole Robinson
927c596daa Fix host/details graphs to not over expand 2013-09-27 14:17:57 -04:00
Cole Robinson
b7f0ac1ed7 choosecd: Minor UI tweak 2013-09-27 13:41:38 -04:00
Cole Robinson
fa47586b37 createnet: Use blue header like other wizards 2013-09-27 13:36:22 -04:00
Cole Robinson
2da4ed7cf1 createvol: Use blue header like other wizards 2013-09-27 13:17:40 -04:00
Cole Robinson
33f15f58f0 createpool: Use blue header like other wizards, cleanup UI
Drop the docs reporting since it's inconsistent and not all that
useful. Few other misc cleanups
2013-09-27 12:13:01 -04:00
Cole Robinson
9e73d6e4f0 delete: Make it look like other UI wizards
And fix a couple UI issues:
- Hide storage list when not deleting
- Have confirmation dialog explicitly list paths we will delete (bz 967927)
2013-09-27 11:10:54 -04:00
Cole Robinson
60b7365ae9 Use consistent widget names for create wizard headers
Makes copying code around simpler
2013-09-27 10:56:52 -04:00
Giuseppe Scrivano
ade0c16015 virt-manager: add UI elements for domain title in the details window
Commit b79ba8382e2205c416d7c4836ac9ee08c72e2c56 in libvirt adds a
<title> attribute to the domain XML, that is used by the user to
identify more easily the VM. This feature is not supported by all
HVs. This patch allows to see and modify the title from the details
window.

Something similar was requested here:
https://bugzilla.redhat.com/show_bug.cgi?id=798949

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-25 19:16:23 +02:00
Cole Robinson
927334915b details: Make TPM UI use a grid 2013-09-23 18:43:50 -04:00
Giuseppe Scrivano
6f8ad1bf21 virtManager: add GUI elements for adding a RNG device
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1001773

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-23 14:09:34 -04:00
Giuseppe Scrivano
92db24aa12 virtManager: add GUI elements for showing RNG devices
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-09-23 14:07:00 -04:00
Cole Robinson
7e42faab0f createnet: Massive code and UI cleanup
Modernize the UI, simplify the code, etc.
2013-09-23 12:28:05 -04:00
Cole Robinson
6da801f944 Set list selection signals in glade, not code 2013-09-22 16:29:58 -04:00
Cole Robinson
d338bce329 Rename ui files to match source file names 2013-09-22 16:10:16 -04:00
Cole Robinson
ba3ce7afb3 details: Use VMActionMenu in top window menu 2013-09-22 15:45:53 -04:00
Cole Robinson
268b462126 uihelpers: Add VMShutdownMenu class
And use it in all the places where we are duplicating a similar menu
2013-09-22 15:45:49 -04:00
Cole Robinson
1683d56b8d ui: Set non-stock button images in glade, not explicitly in code 2013-09-22 12:33:02 -04:00
Cole Robinson
a7834f5d6c Add Network class for parsing <network> XML
Convert virtManager/host.py, do some cleanups and modernization to the
UI there, add tests.

createnet.py hasn't really been touched yet, but still works because
it was building the XML by hand anyways.
2013-09-22 11:16:07 -04:00
Cole Robinson
9ca0545533 addhw: Drop intro text, simplify UI alignment 2013-09-09 13:06:37 -04:00
Cole Robinson
32c990dc29 addhw: Simplify chardev UI
The previous UI was a ugly and the doc text wasn't particularly helpful,
just make it work like the other UI.
2013-09-09 12:48:17 -04:00
Cole Robinson
3c9f3a16e1 addhw: Use gtkgrid for network UI 2013-09-09 11:37:32 -04:00
Cole Robinson
ba6e40e879 addhw: Convert usbredir UI to grid 2013-09-09 11:17:01 -04:00
Cole Robinson
efbc815a60 addhardware: Modernize 'graphics' UI
- Drop SDL, it doesn't mesh with modern libvirt
- Drop keymap, modern qemu/virt-manager handle this automagically
- Drop big text fields
- Misc other cleanups and simplifications
2013-09-02 11:59:02 -04:00
Cole Robinson
1ce02cc7d9 addhw: Fix FS UI for non-qemu 2013-09-01 20:07:46 -04:00
Cole Robinson
c79ba14a6a details: Fix description field spacing 2013-09-01 20:03:53 -04:00
Cole Robinson
ae7ebc220b details: Properly limit machine type list by guests arch/type 2013-09-01 19:21:21 -04:00
Cole Robinson
4c2f7377af preferences: Stats interval can't be less than 1 2013-09-01 18:55:31 -04:00
Cole Robinson
10161a8fdb details: Track serial pages as console tabs
A bit cleaner conceptually, and shrinks the ever growing details.py
2013-09-01 17:40:38 -04:00
Cole Robinson
e8531b1f40 Initial snapshot support
This adds initial UI for managing snapshots: list, run/revert, delete,
add, and redefining (for changing <description>) supported, but currently
only for internal snapshots. The UI is mostly in its final form except for
some bells and whistles.

The real remaining question is what do we want to advertise and support.
Internal (qcow2) snapshots are by far the simplest to manage, very
mature, and already have the semantics we want.

However most recent libvirt and qemu work has been to facilitate
external snapshots, which are more extensible and can be performed
live, and with qemu-ga coordination for extra safety. However
they make things much harder for virt-manager at the moment.

Until we have a plan, this work should be considered experimental
and not be relied upon.
2013-08-21 18:41:42 -04:00
Cole Robinson
1ce5fb1bb9 details: Wire up DTB support
Only show it for supported archs (arm, microblaze, ppc). Take this
opportunity to tweak the kernel/initrd UI a bit
2013-08-18 12:42:07 -04:00
Giuseppe Scrivano
2a67ec9ed6 ui: allow to set an empty password for graphics
Now when a password is used a check box must be explicitely selected.
This enable the possibility to set an empty password "".

Solves: https://bugzilla.redhat.com/show_bug.cgi?id=749718

Signed-off-by: Giuseppe Scrivano <gscrivano@gnu.org>

(crobinso: fix minor pylint violation)
2013-08-01 11:42:08 -04:00
Cole Robinson
5e9e444dec connection: Do non-VM polling on demand
The goal here is to reduce the amount of tick() polling that we do by default.
For things like pools, networks, and interfaces, the constant polling is
not very helpful and causes CPU churn and slowness for remote connections.

Switch to a more on demand style. Pages that want new information for
these objects now request a priority tick that only refreshes the info
we want.

This isn't perfect, but neither was the previous solution in the face of
things like XML updates behind our back. The real solution here is libvirt
event support across the board.
2013-07-07 12:17:54 -04:00
Guannan Ren
88f2d1abe0 details: Add auto USB redirection support in console viewer
Add "Redirect USB device" option in console viewer. Initialize and
embed UsbDeviceWidget object from SpiceClientGtk into a dialog to
let user choose available USB devices for redirection.
Throw an error message if USB connection failed.
Auto-redirection is enable by default.

There is race between creating usbredir channel and calling
has_usb_redirection() when initializing spice session like
happening on virt-viwer. So adding a new signal handler
on_details_menu_virtual_manager_activate() to recheck the
status of usbredir channel, set "Redirect USB device" option
sensitive if it is availiable.
2013-07-01 14:33:59 -04:00
Cole Robinson
a6d3b0ca14 createinterface: bridge delay is a float 2013-06-30 11:12:45 -04:00
Cole Robinson
367041a8d7 Revert "details: Add USB redirection support in console viewer"
This reverts commit 7e1e21a26a.

Was accidentally applied while patch was still in review.
2013-06-28 11:12:23 -04:00
Cole Robinson
6b8d4753f6 details: Fix TPM details after my recent change 2013-06-28 10:32:31 -04:00
Cole Robinson
771707fb9c Minor TPM UI fixups 2013-06-26 20:20:12 -04:00
Stefan Berger
4453305d64 Add GUI elements for adding a TPM device to a guest
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2013-06-26 19:45:20 -04:00
Stefan Berger
2766dd5c6a Add GUI elements for TPM passthrough details
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
2013-06-26 19:45:16 -04:00
Cole Robinson
c1a5bc91d7 details: Remove redundant separator 2013-06-24 12:47:31 -04:00
Guannan Ren
7e1e21a26a details: Add USB redirection support in console viewer
Add "Select USB devices to redirect" option in console viewer
Initialize and embed UsbDeviceWidget object from SpiceClientGtk into
a dialog to let use choose available USB devices for redirection.
Throw an error message if USB connection failed.
2013-06-24 12:39:11 -04:00
Leonardo Garcia
660178abe1 Permit to delete a running VM.
The VM will be forced off before being deleted.

(crobinso: fix a minor pylint violation)
2013-06-18 08:49:18 -04:00
Leonardo Garcia
18bf5f508d Add delete VM option in console viewer.
(crobinso: Fix a minor pep8 warning)
2013-06-17 20:07:37 -04:00
Cole Robinson
3da7f55462 create-interface: Fix VLAN tag upper limit
https://bugzilla.redhat.com/show_bug.cgi?id=863322
2013-06-12 21:27:47 -04:00
Cole Robinson
a5a9f8e3bd Fix a couple more typos pointed out by translator 2013-05-27 20:04:55 -04:00
Cole Robinson
7f621db08f Fix a few wordings recommended by a translator 2013-05-27 13:41:45 -04:00
Gene Czarcinski
41c782a37e static route support
The syntax for static route support is defined by the
new <route> subelement which has the form:
  <route family='xx' address='xx' prefix='n' gateway='gg' metric='m'/>
This patch builds on the previous patches for adding IPv6 support and
extending the virtual network support.

The static route support code has been recently added to libvirt and will
be included in libvirt 1.0.6.
.
Signed-off-by: Gene Czarcinski <gene@czarc.net>
2013-05-21 15:45:34 -04:00
Cole Robinson
d3f9bc8e7a details: Remove unused bit in the UI 2013-04-29 12:24:46 -04:00
Cole Robinson
40cbc39a98 Revert "add a checkbox for cpu host-model mode, remove 'copy' button"
host-model is a bit more scary then previous behavior, since the
model of an existing VM can transparently change across libvirt
upgrade or HW upgrade. This will probably be improved at the libvirt
level, but for now revert.

This reverts commit 17f43e47fb.
2013-04-27 09:28:15 -04:00
Cole Robinson
2f09a3665c prefs: Remove distinction between local and remote sound
Remote sound works fine these days. If people want to turn the
preference off, they probably want to do it in all cases, and can
'customize before install' to alter the rest.
2013-04-23 14:21:46 -04:00
Cole Robinson
f84ccc0cf9 prefs: Remove preference for 'history length'
Also kinda pointless, and I've never heard of anyone actually
tweaking it.
2013-04-23 14:21:45 -04:00
Cole Robinson
42bfb8fe19 console: s/console-vnc/console-gfx/g
Just for clarity
2013-04-21 12:10:14 -04:00
Guannan Ren
17f43e47fb add a checkbox for cpu host-model mode, remove 'copy' button
If the host-model is selected, disable the cpu model drop down
and features list. They still show what exact configuration the
host-model is using.
For the old libvirt which doesn't support <cpu mode='host-model'/>
virt-manager still copy cpu configs from caps XML to domain XML.

(crobinso: Fix some minor pylint)
2013-04-20 16:07:39 -04:00
Cole Robinson
111a1dea0f details: Fix some spacing on the disk page 2013-04-16 18:41:20 -04:00
Cole Robinson
9f3b21c9a1 Shorten iotune names for simplicity
And refactor some of the virt-manager code for the same goal.
2013-04-16 18:37:42 -04:00
Gene Czarcinski
61f8e39700 IPv6 support v2: update the create network wizard
With this patch, basic IPv6 support has been added to
the network creation wizard.  It includes changes to
both the glade-3 ui and the related python code.  There
have been some significant changes made to both files for
IPv6 support and some additional capabilities.

This update includes the fix so color will work in the
network creation wizard.

Besides basic IPv6 support, this includes optionally
specifying a DNS domain name and enabling IPv6 internal
routing if no IPv6 address is specified.
.
Signed-off-by: Gene Czarcinski <gene@czarc.net>
2013-04-03 21:32:57 -04:00
Gene Czarcinski
73629b76b2 IPv6 support v2: update gui python and ui
The purpose of this update is:

1. replace use of IPy with ipaddr since ipaddr has needed
functionality and IPy does not.
2. Update the glade-3 ui (vmm-host.ui) to provide
for IPv6 as well as IPv4.  If either IPv4 or IPv6
is not defined, its respective frame is hidden.
3. The DNS Domain Name is added to the basic frame.
4. IPv4 forwarding is moved to the basic frame and ipv6
forwarding is added.
5. If an IPv4 address is not defined then the IPv4
is set to Isolated network, internal rout only.
6. IPv6 network has three values for Forwarding:
Isolated network, Isolated network with internal forwarding,
and Routed network.
7. Add network definitions to tests/testdriver.xml which
include IPv6 and other new parameters now being handled.

This patch includes the fix for getting a KeyError exception
when deleting a network definition.

In this update, createnet.py has been changed to use
ipaddr but it still only handles IPv4 network creation.
.
Signed-off-by: Gene Czarcinski <gene@czarc.net>

(crobinso: Add Gene to AUTHORS)
2013-04-03 21:32:42 -04:00
Cole Robinson
9d05583c26 Remove autotools, replace with distutils-extra
Despite being a known quantity, autotools is so overkill for our needs,
so let's drop it and replace it with a much simpler and easy to customize
system.
2013-04-03 18:20:51 -04:00