shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-22 13:34:07 +03:00
Code Issues Projects Releases Wiki Activity
8,707 Commits 2 Branches 64 Tags 98 MiB
2835c250c7
Commit Graph

28 Commits

Author SHA1 Message Date
Cole Robinson
bb1afaba29 Fix pylint/pycodestyle warnings with latest versions 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2022-12-13 11:23:45 -05:00
Cole Robinson
e45a2228dc objects: Erase the notion of connkey 
Make it explicit that all uses of this is actually the object
name. We already leaked this abstraction in several places so better
to make it explicit. This also communicates to users that this is a
field that is not immutable so it shouldn't be used as a unique key

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-09-01 14:27:11 -04:00
Cole Robinson
eb5e087366 tests: Add full coverage for pollhelpers and VirtinstConnection 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-01-27 06:57:37 -05:00
Cole Robinson
d410773af8 virtManager: Remove virInterface polling 
There are no more users of interface objects in the code. Remove
all the polling support, and all the remaining references to
interface objects throughout the code base

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-01-26 11:39:34 -05:00
Cole Robinson
419f8cd31b pollhelpers: Streamline usage a bit 
* Explicitly define the build 'cb', don't use lambda
* Rename pollhelpers arguments, clarifying use of cb
* Check support status in pollhelpers
* Move 'dopoll' checking up a level in vmmConnection

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-01-24 17:04:29 -05:00
Cole Robinson
3ad646fef1 pollhelpers: Kill old style polling 
All the major hypervisor drivers have supported listAllDomains
since rhel6 vintage libvirt. Most other driver types have had the APIs
since their introduction, or for just as long.

I will be surprised if this affects anyone in any material way

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-01-24 17:04:18 -05:00
Cole Robinson
f107e39989 Switch to more traditional logging structure 
Init a shared log instance in virtinst/logger.py, and use that
throughout the code base, so we aren't calling directly into
'logging'. This helps protect our logging output from being
cluttered with other library output, as happens with some
'requests' usage
 2019-06-17 00:12:31 -04:00
Cole Robinson
f85e6def55 support: Convert callers to the new format 2019-06-07 16:26:03 -04:00
Daniel P. Berrangé
48e32b429d Fix copyright header to specify GPLv2 or later, not GPLv2 only. 
The copyright headers in every file were chjanged in this previous commit

  commit b6dcee8eb7
  Author: Cole Robinson <crobinso@redhat.com>
  Date:   Tue Mar 20 15:00:02 2018 -0400

    Use consistent and minimal license header for every file

Where before this they said "

  "either version 2 of the License, or (at your option) any later version."

Now they just say

  "GNU GPLv2"

This fixes it to say "GNU GPLv2 or later" again.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
 2018-04-04 16:51:37 -04:00
Cole Robinson
b6dcee8eb7 Use consistent and minimal license header for every file 2018-03-21 07:29:40 -04:00
Radostin Stoyanov
978fb25ac7 Wrap keys(), values() in a list 
In Python 3 dict.values() [1] , dict.keys() [2] and dict.items() [3]
return a view [4] of the dictionary’s values, keys and items.

In Python 2 these functions return a list. [5] [6] [7]

To resolve this we can convert the result of these function to a list.

[1] https://docs.python.org/3/library/stdtypes.html#dict.values
[2] https://docs.python.org/3/library/stdtypes.html#dict.keys
[3] https://docs.python.org/3/library/stdtypes.html#dict.items
[4] https://docs.python.org/3/library/stdtypes.html#dict-views
[5] https://docs.python.org/2/library/stdtypes.html#dict.items
[6] https://docs.python.org/2/library/stdtypes.html#dict.keys
[7] https://docs.python.org/2/library/stdtypes.html#dict.values
 2018-02-06 18:49:17 -05:00
Chen Hanxiao
7f1b4cee82 pycodestyle: fix all E125 warnings 
Fix all E125:
     Continuation line with same indent as next logical line

   Also remove ignore options of E125

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-10-21 23:26:16 +08:00
Radostin Stoyanov
b93cc3bbc9 pycodestyle: Do not use bare 'except:' 
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].

[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
 2017-08-02 13:57:43 -04:00
Cole Robinson
62feeb02a8 Switch to python3 style 'except X as Y' notation 
Which also works with python2.7
 2017-05-05 14:52:11 -04:00
Cole Robinson
053cda8de7 virt-manager: Add hidden options --test-old-poll and --test-no-events 
For easy testing of fallback codepaths
 2015-09-17 15:18:22 -04:00
Pavel Hrdina
a2505def2c pep8 E731: do not assign a lambda expression, use a def 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2015-07-14 13:01:20 -04:00
Michał Kępień
c4d26d16a6 pollhelpers: Fix VM polling on old libvirt 
https://bugzilla.redhat.com/show_bug.cgi?id=1219443
 2015-05-07 11:10:20 -04:00
Cole Robinson
838baf6946 connection: tick: Operate on combined object lists 
Makes the flow a bit simpler, and allows us to break out polling without
having to pass around a ton of lists.
 2015-04-10 15:00:34 -04:00
Cole Robinson
cb5d075f50 libvirtobject: Unify a few APIs and conn tick handling 2015-04-10 15:00:34 -04:00
Cole Robinson
aefd4c4824 connection: Use name instead of uuid for object keys 
And clean up the API mess while we are at it. Treat the key as an opaque
value that users shouldn't depend on.

Besides the improved code clarity and API layout, this will help diagnose
'key error' issues, since we'll see an object name instead of UUID which
is hard to trace back.
 2014-06-02 17:48:32 -04:00
Cole Robinson
d3e9af8328 pollhelpers: Use correct dictionary keys for old pool/net polling (bz 1099827) 
We were inadvertently using the object name rather than UUID when libvirt
didn't support new style polling APIs.
 2014-06-02 12:18:59 -04:00
Cole Robinson
d3e55a1fbf pollhelpers: Add debugging helper to force old polling 2014-06-02 12:02:09 -04:00
Cole Robinson
56b9f6187b Streamline support checks 
Just use one function check_support
 2013-10-06 10:08:04 -04:00
Cole Robinson
ddba6098f6 pollhelpers: Support nodedev listAllDevices 2013-09-29 09:39:55 -04:00
Cole Robinson
52e4976462 pollhelpers: Add fetch_volumes helper 
That does the listAllVolumes support check to speed us up a bit.
 2013-09-29 09:33:17 -04:00
Cole Robinson
ce9f8ee24e pollhelpers: Clarify some variable names and docs 2013-09-29 09:28:42 -04:00
Cole Robinson
0ffdbb13fe pollhelpers: Re-enable list-all-interfaces 
Was just transient F19 breakage
 2013-09-29 08:33:45 -04:00
Cole Robinson
ee7d0b620d connection: Support listAll* object lookups 
These calls save us a few API lookups, but are not supported by all
libvirt versions.

Since these bits were getting quite large, move them all to a separate
pollhelpers file.

However listAllInterfaces is returning an empty list for now, so we
disable the check: https://bugzilla.redhat.com/show_bug.cgi?id=982014
 2013-07-07 15:06:09 -04:00