Commit Graph

781 Commits

Author SHA1 Message Date
Giuseppe Scrivano
a063a74831 storage: change default storage size to 20G
If libosinfo fails to detect the operating system or the user doesn't
select any, use 20G by default.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-01-27 20:08:04 +01:00
Cole Robinson
f815c988aa details: When VM is run, always update console page
If we were focused on the VM details page for a container, then clicked
'Run', the console page wouldn't be switched to view the serial console.
Make that work, but continue to not switch focus away from the current
non-console page.

Based on Cédric's patch here: http://www.redhat.com/archives/virt-tools-list/2015-January/msg00078.html
2015-01-27 13:41:45 -05:00
Charles Arnold
65f7017eaf createnet: Fix creating network with forward device 2015-01-16 13:30:36 -05:00
Richard W.M. Jones
22b338a65a virt-manager, inspection: use add_libvirt_dom
Enable inspection only if the add_libvirt_dom function is present at
runtime.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1075143

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-01-09 12:32:45 +01:00
Cédric Bosdonnat
7e01c4f1cd Default connection URI if libvirt-daemon-driver-lxc is installed
The default URI is set to lxc:/// if libvirt's lxc driver is installed
locally, but only if there is no kvm/xen URI to default to.
2014-12-10 13:28:36 -05:00
Cole Robinson
9552afcc92 storagebrowse: Standardize on set_finish_cb
Instead of gobject signals
2014-12-09 18:37:00 -05:00
Cole Robinson
e61311fc8a storage: More support for network pools
Including parsing multiple hosts, filling reasonably defaults, making
sure the createpool wizard does the correct thing, etc.
2014-12-09 16:12:47 -05:00
Cole Robinson
cff08223ba util: Move uri_split to its own URISplit class
Does what uri_split did, but wraps it all up in an object that makes
handling the data easier, and makes it easy to extend.
2014-12-09 08:43:19 -05:00
Cole Robinson
7e2ea81a2c addstorage: Switch away from set_create_storage 2014-12-05 21:49:10 -05:00
Cole Robinson
66a8c5d374 vmm: conn: Don't abuse path_definitely_exists for pool refreshing
Just catch any errors and continue on
2014-12-04 20:39:27 -05:00
Cole Robinson
6489df83ca devicedisk: Rename path_exists -> path_definitely_exists
Since it's a best effort attempt, try to make it more clear that
we aren't certain if paths exist in some cases.
2014-12-04 20:10:37 -05:00
Cole Robinson
a75aa47daf devicedisk: Use consistent capitalization for property names 2014-12-04 16:30:18 -05:00
Cole Robinson
01d6541f69 create: Don't show default disk path on summary page
Since it's dependent on the VM name, which the user might change
2014-12-03 13:14:36 -05:00
Cole Robinson
4a678f0543 create: Fix default storage path when VM name is changed (bz 1169141)
Regressed with 2e7ebd4 . Use skip_disk_page() to determine when we
shouldn't assume default storage
2014-12-03 13:08:18 -05:00
Cole Robinson
c090d18beb console: Show multiple graphics devices in menu list
But actually switching to one isn't supported, so show a tooltip to
that effect.
2014-12-03 12:21:57 -05:00
Cole Robinson
ef99daa3d1 console: Rework serial menu building
Mostly code reorg with some minor bug fixes thrown in.
2014-12-03 12:14:32 -05:00
Cole Robinson
d178923609 create: Clarify function name
It's no longer the 'name' page
2014-12-03 10:13:39 -05:00
Cole Robinson
0b391fe9ed virt-manager: Enforce gobject introspection versions
This is needed with freebsd and opensuse at least. See:

https://bugzilla.suse.com/__show_bug.cgi?id=901869
http://www.redhat.com/archives/libvir-list/2014-December/msg00184.html
2014-12-02 14:01:28 -05:00
Giuseppe Scrivano
51e5a47120 virt-manager: reset vgamem for video when changing device type
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1169295

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-01 17:02:22 +01:00
Giuseppe Scrivano
ad1f0fa081 details: fix --show-domain-performance
the introspection page could be missing, in this case the tabs values
are shifted by one.  The new code looks for the correct row number
before selecting it.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1167600

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-26 08:41:40 +01:00
Giuseppe Scrivano
c9a04c23dc virtManager: show correctly IPv6 addresses
VirtualConnection.get_uri_host_port already splits this information
taking care of IPv6 addresses, do not split it again.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1094631

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-20 15:51:16 +01:00
Giuseppe Scrivano
5c68542151 console: switch to CONSOLE_PAGE_UNAVAILABLE while waiting for login
It fixes a race condition if the ERROR_AUTH error if received while
still on the CONSOLE_PAGE_AUTHENTICATE and skipping the page_changed
event.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1165990

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-20 15:51:16 +01:00
Giuseppe Scrivano
1cdd10ce34 virt-manager: show the manager when using a wrong domain id
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1164691

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-17 16:50:04 +01:00
Marc-André Lureau
5daee287d9 tunnels: do not close unowned fd
The fd is handed to spice-gtk and gtk-vnc. They will close it when no
longer needed. Double closing leads to various race issues, since the
same fd may be opened for a different usage.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1081227
2014-11-16 12:09:02 -05:00
Giuseppe Scrivano
741f2923d7 details: do not show MAC address if not set
Fixes this exception:
Traceback (most recent call last):
  File "virt-manager/virtManager/create.py", line 1780, in finish
    self.customize(guest)
  File "virt-manager/virtManager/create.py", line 1812, in customize
    self.config_window = vmmDetails(virtinst_guest, self.topwin)
  File "virt-manager/virtManager/details.py", line 560, in __init__
    self.populate_hw_list()
  File "virt-manager/virtManager/details.py", line 3165, in populate_hw_list
    self.repopulate_hw_list()
  File "virt-manager/virtManager/details.py", line 3220, in repopulate_hw_list
    update_hwlist(HW_LIST_TYPE_NIC, dev)
  File "virt-manager/virtManager/details.py", line 3195, in update_hwlist
    label = _label_for_device(dev)
  File "virt-manager/virtManager/details.py", line 188, in _label_for_device
    return "NIC %s" % dev.macaddr[-9:]
TypeError: 'NoneType' object has no attribute '__getitem__'

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1164123

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-14 10:45:18 +01:00
Giuseppe Scrivano
f19a07d5a5 virt-manager: close the SPICE main channel on an AUTH error
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1152981

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-28 14:59:21 +01:00
Cole Robinson
cbf38cbe9f pylint: Ignore new warnings 2014-10-27 19:53:25 -04:00
Wei Huang
2d6422e10b virt-manager/details: add checking code for CPU threads
This patches adds the support to check the thread # against the
selected CPU model. If the selected # of CPU threads > 1 and CPU
model does not support hyper-threading, a warning message will be shown.

Signed-off-by: Wei Huang <wei@redhat.com>
2014-10-27 18:05:21 -04:00
Giuseppe Scrivano
750eeaad98 virt-manager, details: properly check for pool presence
commit 5e8f35f5e6 introduced this
problem.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-14 12:23:08 +02:00
Giuseppe Scrivano
8f1aa5a4f0 virt-manager, delete: fix path for disk type='volume'
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-14 12:23:08 +02:00
Lubomir Rintel
835d40b151 addhardware, details: STOCK_DIRECTORY is gone
It's no longer present in Gtk+ 3.14 and deprecated since at least 3.10 in favor
of named "folder" icon. That seems a good fit, a quick check on my system finds
it present in all themes that are available.
2014-10-06 12:14:14 -04:00
Guido Günther
1726505fd6 s/gconf/gsettings/
GConf got replaced by GSettings but some methods kept the old name
2014-09-29 08:56:37 -04:00
Cole Robinson
bf6af370c6 sshtunnels: Clarify a logging message 2014-09-29 08:55:47 -04:00
Cole Robinson
d1f36ac875 domain: Fix defining domain after migration 2014-09-29 08:55:47 -04:00
Giuseppe Scrivano
5e8f35f5e6 virt-manager, details: fix path and size for disk type='volume'
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-26 16:24:59 +02:00
Cole Robinson
69b131f81f engine: Clarify a debug message 2014-09-25 10:13:20 -04:00
Cole Robinson
3e5a20aaf1 addhardware: Fix attaching USB/PCI hostdev (bz 1146297) 2014-09-24 20:12:38 -04:00
Cole Robinson
310f65273f osdict: Restrict n-cpus to 1 for machvirt
It fails to boot otherwise
2014-09-23 17:09:36 -04:00
Cole Robinson
c4162f6708 Use -M virt as default machine for arm/aarch64
Centralize the default machine logic in caps and use it consistently
2014-09-23 16:05:48 -04:00
Laszlo Ersek
3e5b61da86 domain: relax the UNDEFINE_NVRAM condition precisely to libvirtd's one
(1) A separate nvram (ie. variable store) file for the domain exists if
and only if the following condition holds:

    (self.get_xmlobj().os.loader_ro is True and
     self.get_xmlobj().os.loader_type == "pflash")

(Refer to libvirtd's qemuPrepareNVRAM() function, as of commit 742b08e30.)

(2) The

    self.get_xmlobj().os.nvram

condition is sufficient, but not necessary, for the separate varstore file
to exist. That is, if the condition holds, then the separate varstore file
exists for sure, but if the condition doesn't hold, the file may exist
nonetheless. (Because libvirtd can auto-generate the varstore file's
pathname.)

This means that requiring condition (2) for setting UNDEFINE_NVRAM on
domain deletion will miss a subset of the cases, ie. when the necessary
and sufficient condition (1) holds, but the sufficient-only condition (2)
doesn't.

Make sure that the code uses the necessary and sufficient condition (1).

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
2014-09-22 12:32:31 -04:00
Cole Robinson
662922dc95 createinterface: Use inactive XML for embeding child XML
The inactive XML will drop things like complex protocol output and
link state info, which netcf can choke on for sub interfaces.
2014-09-21 15:04:16 -04:00
Cole Robinson
bd0bcba0b5 createinterface: Fix 'copy child protocol' behavior (bug 1122743)
We should only copy the inactive protocol XML, which lists things
like dhcp, vs the running XML, which is the same format as static
addressing.
2014-09-21 15:02:27 -04:00
Cole Robinson
6a9aa6827b console: Break out tunnel handling to its own file 2014-09-21 13:38:53 -04:00
Cole Robinson
e1b646594c console: Hide display widget from consumers
There were several layering violations, make it explicit by making
display private, and providing APIs for everything the consumers
need.
2014-09-21 13:25:43 -04:00
Cole Robinson
a3bd1b26a9 console: Clarify keyboard grab default handling 2014-09-21 13:06:25 -04:00
Cole Robinson
4568cdb636 module_trace: Only show main thread APIs by default 2014-09-21 12:05:02 -04:00
Cole Robinson
b0d5198b7a virt-manager: Switch 'Copy host' to use host-model (bz 1133155)
Similar to the previous change for virt-install
2014-09-20 20:44:14 -04:00
Cole Robinson
85161e4c57 host: Clean up invocation of *apply from confirm dialog
Basically, only apply the page we are actually on
2014-09-20 17:32:10 -04:00
Cole Robinson
0717a21f65 host: Fix renaming network/storage pool 2014-09-20 17:32:09 -04:00
Cole Robinson
38738d9fa6 connection: Don't close VM dialog on rename
Rework things a bit to simplify everything we pass around.

The specific bug fix is making sure we update the object list in place,
otherwise the event loop detects it as the VM being deleted and closes
the details window.
2014-09-20 17:32:09 -04:00