Commit Graph

4249 Commits

Author SHA1 Message Date
Cole Robinson
67b36a086c osdict: Remove unused diskbus field 2014-11-20 10:58:15 -05:00
Giuseppe Scrivano
c9a04c23dc virtManager: show correctly IPv6 addresses
VirtualConnection.get_uri_host_port already splits this information
taking care of IPv6 addresses, do not split it again.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1094631

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-20 15:51:16 +01:00
Giuseppe Scrivano
5c68542151 console: switch to CONSOLE_PAGE_UNAVAILABLE while waiting for login
It fixes a race condition if the ERROR_AUTH error if received while
still on the CONSOLE_PAGE_AUTHENTICATE and skipping the page_changed
event.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1165990

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-20 15:51:16 +01:00
Cole Robinson
08bea2195e HACKING: Make the test suite instructions the first listed bit 2014-11-17 15:42:15 -05:00
Giuseppe Scrivano
1cdd10ce34 virt-manager: show the manager when using a wrong domain id
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1164691

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-17 16:50:04 +01:00
Cole Robinson
60e62e2676 osdict: Add back compat 'virtio26' entry
We used to have that in the old osdict. Map it to fedora10 which gives
virtio net/block but nothing else, which matches the old behavior.
2014-11-17 10:22:37 -05:00
Anatoly Belikov
78c52a13f1 add gluster and sheepdog pool/volume to testdriver.xml 2014-11-16 15:46:27 -05:00
Marc-André Lureau
5daee287d9 tunnels: do not close unowned fd
The fd is handed to spice-gtk and gtk-vnc. They will close it when no
longer needed. Double closing leads to various race issues, since the
same fd may be opened for a different usage.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1081227
2014-11-16 12:09:02 -05:00
Giuseppe Scrivano
741f2923d7 details: do not show MAC address if not set
Fixes this exception:
Traceback (most recent call last):
  File "virt-manager/virtManager/create.py", line 1780, in finish
    self.customize(guest)
  File "virt-manager/virtManager/create.py", line 1812, in customize
    self.config_window = vmmDetails(virtinst_guest, self.topwin)
  File "virt-manager/virtManager/details.py", line 560, in __init__
    self.populate_hw_list()
  File "virt-manager/virtManager/details.py", line 3165, in populate_hw_list
    self.repopulate_hw_list()
  File "virt-manager/virtManager/details.py", line 3220, in repopulate_hw_list
    update_hwlist(HW_LIST_TYPE_NIC, dev)
  File "virt-manager/virtManager/details.py", line 3195, in update_hwlist
    label = _label_for_device(dev)
  File "virt-manager/virtManager/details.py", line 188, in _label_for_device
    return "NIC %s" % dev.macaddr[-9:]
TypeError: 'NoneType' object has no attribute '__getitem__'

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1164123

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-11-14 10:45:18 +01:00
Chen Hanxiao
e0b5283ac3 Redirect device: remove underline property of 'Type' in details UI
redir-type is a label.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:10:14 +08:00
Chen Hanxiao
71613d95e8 Smartcard device: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:08:02 +08:00
Chen Hanxiao
34f9be43c2 sound: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:07:33 +08:00
Chen Hanxiao
8f2c9b354a cpu: add mnemonics in details UI
Add mnemonics for 'Configuration' page,
'Topology' page, 'Pinning' page
and their sub-pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:06:47 +08:00
Chen Hanxiao
0368394c7e boot options: add mnemonics in details UI
Add mnemonics for 'Direct kernel' page
and sub-pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:06:13 +08:00
Chen Hanxiao
e758aec861 video: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:05:38 +08:00
Chen Hanxiao
351d0a2834 details: add shortkey for controller model
shortkey 'o' for 'Model'.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:04:28 +08:00
Chen Hanxiao
ce7fd785e4 watchdog: add missing mnemonics in details UI
add missing mnemonics and fix an duplicated shortkey

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:02:02 +08:00
Martin Kletzander
339ead9f70 tests: fix failure on 32-bit machines
clitest.py used the value 100000000000 (100 PB) for memory size, which
was parsed as 0 by older libvirt.  Latest release (1.2.10) has the
parsing fixed and properly reports an error on overflow.  Changing the
memory size to 4000000 (4 TB) is still an overcommit, at least most
development machines and it works properly.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-11-05 09:00:58 +01:00
Giuseppe Scrivano
23d2047576 spec: move dependency to libosinfo from virt-manager to common
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1159370
2014-11-04 09:04:09 +01:00
Cole Robinson
26d16a5978 diskbackend: Fix typo 2014-10-29 12:35:18 -04:00
Chen Hanxiao
a6e72f30f3 virtinst: fix some comment typos
s/occurence/occurrence

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-29 16:00:28 +08:00
Giuseppe Scrivano
f19a07d5a5 virt-manager: close the SPICE main channel on an AUTH error
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1152981

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-28 14:59:21 +01:00
Cole Robinson
baee53fbaa util: Simplify default_bridge to not confuse pylint 2014-10-27 19:53:25 -04:00
Cole Robinson
cbf38cbe9f pylint: Ignore new warnings 2014-10-27 19:53:25 -04:00
Wei Huang
2d6422e10b virt-manager/details: add checking code for CPU threads
This patches adds the support to check the thread # against the
selected CPU model. If the selected # of CPU threads > 1 and CPU
model does not support hyper-threading, a warning message will be shown.

Signed-off-by: Wei Huang <wei@redhat.com>
2014-10-27 18:05:21 -04:00
Wei Huang
dea3520ea8 ui: add a warning message for hyper-threading support
Not all CPUs support Hyper-Threading. This patch adds a warning
message next to the threads selection field of processor topology
box. It warns that "Selected CPU model does not support
Hyper-Threading" when # of Threads > 1 and the selected CPU model
does not support Hyper-Threading.

This UI modification was added using glade 3.18.3.

Signed-off-by: Wei Huang <wei@redhat.com>
2014-10-27 18:05:21 -04:00
Chen Hanxiao
8f077a270f panic notifier: remove shortcuts in details.ui
We could not modify them in panic notifier page,
so remove them.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:07:35 +08:00
Chen Hanxiao
6f196ed21d panic-notifier: add missing mnemonics in addhardware UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:06:14 +08:00
Chen Hanxiao
b5fd41135d details: add missing mnemonics in cpu UI tab
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:05:52 +08:00
Chen Hanxiao
7752d60cfe ui: change fs-type label ID from "label18" to "fs-type-title"
It looks not very social as its naming.
And it will be used in the later patch.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 10:23:59 +08:00
Chen Hanxiao
64e7e783e7 ui: change duplicated fsdetail shortkey
shortkey M for fs-mode in fsdetail duplicate shortkey of
"Virtual Machine" in details.
change it to 'o'.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-17 17:18:53 +08:00
Giuseppe Scrivano
750eeaad98 virt-manager, details: properly check for pool presence
commit 5e8f35f5e6 introduced this
problem.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-14 12:23:08 +02:00
Giuseppe Scrivano
8f1aa5a4f0 virt-manager, delete: fix path for disk type='volume'
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-14 12:23:08 +02:00
Lubomir Rintel
835d40b151 addhardware, details: STOCK_DIRECTORY is gone
It's no longer present in Gtk+ 3.14 and deprecated since at least 3.10 in favor
of named "folder" icon. That seems a good fit, a quick check on my system finds
it present in all themes that are available.
2014-10-06 12:14:14 -04:00
Giuseppe Scrivano
ea0cded87b spec: add a dependency on "gnome-icon-theme"
virt-manager uses some icons included in the gnome-icon-theme package.
Make it explicit and add a dependency.

Desktop folks agree that this is the place where to add this
dependency as adding it to gtk is too problematic.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146612

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-06 17:47:24 +02:00
Chen Hanxiao
52744fadf8 man: update binary prefixes for units in virt-install man page
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-06 09:50:55 +08:00
Cole Robinson
a4db445a45 spec: Install the gconf .convert file 2014-09-30 08:41:37 -04:00
Giuseppe Scrivano
4c978f70cb doc, virt-clone: make --quiet consistent with --help output
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-30 14:33:05 +02:00
Giuseppe Scrivano
bfeed049b8 doc, virt-install: do not use obsoleted --file/--file-size
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-30 14:33:05 +02:00
Guido Günther
1726505fd6 s/gconf/gsettings/
GConf got replaced by GSettings but some methods kept the old name
2014-09-29 08:56:37 -04:00
Guido Günther
a41e2c6f5a Add conversion file to migrate GConf values to GSettings
This makes sure we don't lose already configured connections.

Reference: http://bugs.debian.org/740047
2014-09-29 08:56:14 -04:00
Cole Robinson
bf6af370c6 sshtunnels: Clarify a logging message 2014-09-29 08:55:47 -04:00
Cole Robinson
d1f36ac875 domain: Fix defining domain after migration 2014-09-29 08:55:47 -04:00
Giuseppe Scrivano
5e8f35f5e6 virt-manager, details: fix path and size for disk type='volume'
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-26 16:24:59 +02:00
Giuseppe Scrivano
cce5827195 virtinst: add support for disk type="volume"
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-26 16:24:59 +02:00
Cole Robinson
69b131f81f engine: Clarify a debug message 2014-09-25 10:13:20 -04:00
Cole Robinson
3e5a20aaf1 addhardware: Fix attaching USB/PCI hostdev (bz 1146297) 2014-09-24 20:12:38 -04:00
Cole Robinson
310f65273f osdict: Restrict n-cpus to 1 for machvirt
It fails to boot otherwise
2014-09-23 17:09:36 -04:00
Cole Robinson
318ac3df55 guest: Add clarifying comment 2014-09-23 16:19:54 -04:00
Cole Robinson
42ac7a3036 guest: Set optimal arm CPU defaults
If doing arm kvm, use cpu=host. Otherwise, specify cortex-a57 for aarch64
so we actually get a 64bit cpu
2014-09-23 16:18:23 -04:00