Commit Graph

4205 Commits

Author SHA1 Message Date
Cole Robinson
dd67c48233 connection: Handle nodedev polling too
And cleanup up a bunch of nodedev functions as a result
2014-09-20 12:04:49 -04:00
Cole Robinson
8cd4958a19 cli: Break out function to disable libvirt error printing
We need it early in the test suite
2014-09-20 12:04:37 -04:00
Cole Robinson
439e5ad0fe details: Reorg a bunch of the global helpers
Some were redundant, some should be in virtinst
2014-09-20 10:23:19 -04:00
Cole Robinson
4ad50d968a details: Put tabs on left, easier to navigate with glade 2014-09-20 10:21:27 -04:00
Cole Robinson
fa76e92f2c virt-manager: Fix issues with ellipsizing on recent gtk 2014-09-19 22:08:22 -04:00
Cole Robinson
775ea8dc72 virt-manager: Silence gtk deprecation warnings
They are on by default on F21, and they are very noisy
2014-09-19 21:47:13 -04:00
Cole Robinson
55739055fd ui: Set all files to minimum requirement of gtk 3.8
That way gives us better feedback from glade
2014-09-19 21:19:26 -04:00
Cole Robinson
f42e9bf8d4 man: virt-install: Drop overly specific bits about full virt 2014-09-19 20:54:08 -04:00
Cole Robinson
edf9bf0aad serialcon: Drop use of yet more removed API 2014-09-19 20:35:06 -04:00
Cole Robinson
ca2ee52eb8 virtinst: cli: Move unshared bits to virt-install
Since virt-image is gone, this stuff should all be private to virt-install
2014-09-19 20:31:22 -04:00
Cole Robinson
d119a1bf6a pylint: Disable cyclic-import check
Yeah it has a point... but the code works fine in practice, and the
remaining issues will need some decent reorg to fix.
2014-09-19 20:13:52 -04:00
Cole Robinson
3feedb76e9 domain: Match UNDEFINE_NVRAM conditions with libvirt
Suggested-By: Laszlo Ersek <lersek@redhat.com>
2014-09-19 20:08:59 -04:00
Cole Robinson
ebeea7af9f delete: Remove nvram support
As of now, the only uses of nvram likely in the domain XML are with
libvirt configurations that also support the UNDEFINE_NVRAM flag, so
listing it here is kind of redundant. And in the common config of
non-root user connected to qemu:///system with template based nvram
in /var/lib, we won't be able to remove it anyways.
2014-09-19 20:04:39 -04:00
Cole Robinson
ae26313ed4 details: Add UI for enabling UEFI via 'customize before install'
We expose a simple combobox with two entries: BIOS, and UEFI. The
UEFI option is only selectable if 1) libvirt supports the necessary
domcapabilities bits, 2) it detects that qemu supports the necessary
command line options, and 3) libvirt detects a UEFI binary on the
host that maps to a known template via qemu.conf

If those conditions aren't met, we disable the UEFI option, and show
a small warning icon with an explanatory tooltip.

The option can only be changed via New VM->Customize Before Install.
For existing x86 VMs, it's a readonly label.
2014-09-17 18:43:41 -04:00
Cole Robinson
ead9d3f56d domain: If VM has nvram, ask libvirt to remove it on undefine 2014-09-17 18:35:20 -04:00
Cole Robinson
052220cfc8 virtinst: Add DomainCapabilities parser 2014-09-17 18:29:24 -04:00
Cole Robinson
0ad7611b59 virt-xml: Tweak update prompting messages 2014-09-17 12:21:49 -04:00
Lin Ma
e088486b23 addhardware: Deal with the conflict host device
If a host device is in use by guests, Warn user and
let user make choice while adding hardware.

Signed-off-by: Lin Ma <lma@suse.com>
2014-09-16 11:41:13 -04:00
Lin Ma
2f62ba964c Add comparison function for NodeDevice
PCIDevice and USBDevice include respective comparison logic.

Signed-off-by: Lin Ma <lma@suse.com>
2014-09-16 11:41:13 -04:00
Giuseppe Scrivano
e5d2059853 virt-manager: delete nvram file on VM deletion
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:49:00 +02:00
Giuseppe Scrivano
17a37ea39b virt-install: add tests for OVMF
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:47:02 +02:00
Laszlo Ersek
d2fffa509e virt-install: add support for OVMF
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
2014-09-16 09:47:02 +02:00
Giuseppe Scrivano
21319c4232 osdict, libosinfo: use "minimum" resources when "recommended" is missing
Some OS entries in libosinfo miss the "recommended" resources block.
In this case use the "minimum" resources when available.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:12:04 +02:00
Giuseppe Scrivano
f2ad085918 virtManager: add "ich9" to the list of stable audio models
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1140937

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:04:14 +02:00
Giuseppe Scrivano
0218d29a35 virtinst: add ich9 to the list of audio models
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-16 09:04:14 +02:00
Chen Hanxiao
30c3434916 test: update compare_check flags for auto-clone cases
auto-clone cases use SUPPORT_CONN_BARE_BACKINGSTORE,
which check libvirt 1.2.4.
Change it to SUPPORT_CONN_LOADER_ROM(1.2.9)
and drop SUPPORT_CONN_BARE_BACKINGSTORE.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-09-16 10:03:27 +08:00
Chen Hanxiao
4a83ea3a83 test: skip unit tests affected by loader extention before libvirt 1.2.9
libvirt commit for 1.2.9
68bf13dbef8342eaee0bf57c73cebb60b7de11e8
conf: Extend <loader/> and introduce <nvram/>

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-09-16 10:02:57 +08:00
Giuseppe Scrivano
1341928e92 test: Fix tests with latest libvirt
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-15 11:27:35 +02:00
Cole Robinson
9b62573c0b module_trace: Improve output for tracking mainloop libvirt usage 2014-09-13 13:52:42 -04:00
Cole Robinson
226c4562d5 virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
Cole Robinson
eb7612356e virtinst: Switch to relative imports, fix cyclic import warnings 2014-09-12 16:28:38 -04:00
Cole Robinson
f512c05381 diskbackend: Get volume path from XML
The XML is likely already cached, and path() can hit the network, so
this can speed things up.
2014-09-12 16:28:38 -04:00
Cole Robinson
3064f4058d diskbackend: Simplify pool source lookup
Have it share logic with a similar routine
2014-09-12 16:28:38 -04:00
Cole Robinson
3753fcbaa3 addstorage: Rate limit the default pool refresh 2014-09-12 16:28:37 -04:00
Cole Robinson
76bc8e5ab9 connection: Do initial object refreshes in a thread
None of these objects are urgent, and this allows us to split up the
initial API calls to be more parallel.
2014-09-12 16:28:37 -04:00
Cole Robinson
37e0f16c8b connection: Simplifying connection error tracking 2014-09-12 16:28:37 -04:00
Cole Robinson
df32f9331d baseclass: Add helper for launching daemon thread
And use it in a few spots
2014-09-12 16:28:37 -04:00
Cole Robinson
5041529822 domain: Cache autostart value 2014-09-12 16:28:37 -04:00
Cole Robinson
d1c22b3b2c storagepool: Don't default to refreshing volume list
This needlessly hits the network too much. The places where it's
important to have up to date info will either manually call pool
refresh, or give the user an refresh button.
2014-09-12 16:28:37 -04:00
Cole Robinson
508debaf2d virtinst: Don't needlessly call conn.getType 2014-09-12 16:28:37 -04:00
Cole Robinson
92835f205f connection: Cache x86 cpu values at connection time 2014-09-12 16:28:37 -04:00
Cole Robinson
1662f75e07 domain: Grab snapshot info at domain init time 2014-09-12 16:28:37 -04:00
Cole Robinson
1cf4671f85 domain: Prime the XML cache when object is created 2014-09-12 16:28:37 -04:00
Cole Robinson
f36d2ed960 domain: Remove the description/title hotplug hacks
We would unconditionally read VM description/hotplug from the inactive
domain XML, this allowed us to emulate metadata hotplug where it wasn't
implemented. However this means we end up doing many needless XMLDesc
calls, which slows down connection startup for low latency connections.

Since SetMetadata has been in libvirt for 2 years now, drop this hack.
2014-09-12 16:28:37 -04:00
Cole Robinson
fb671b4d92 connection: Leave in 'connecting' state until all bits are polled 2014-09-12 16:28:37 -04:00
Cole Robinson
8d862a7b7b storagepool: Don't defer initial refresh to main thread
Otherwise this can block the UI on initial connect
2014-09-12 16:28:37 -04:00
Cole Robinson
adbe68fc7f connection: Cleanup some initial connection code 2014-09-12 16:28:37 -04:00
Cole Robinson
bd5e57dbdc connection: Simplify state management 2014-09-12 16:28:37 -04:00
Cole Robinson
b398a46e9b domain: Cache has_managed_save value
Otherwise we call it every time a domain row is selected, which makes
things choppy on remote connections.
2014-09-12 16:28:37 -04:00
Cole Robinson
f0ab054109 connection: Do mediadev setup in a thread
Otherwise a lot of XMLDesc calls are done from the main thread
at connection startup time.
2014-09-12 16:28:37 -04:00