shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-02-04 17:47:19 +03:00
Code Issues Projects Releases Wiki Activity
4,340 Commits 2 Branches 64 Tags
Commit Graph

4340 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Cole Robinson
52691c511e devicedisk: Move more validation into diskbackend 2014-12-06 16:44:21 -05:00
Cole Robinson
7e7b1bdd4e tests: Order disks in same order libvirt shows them 2014-12-06 16:43:53 -05:00
Cole Robinson
7b8e850bc0 clitest: Sanitize diff output some more 2014-12-06 16:32:10 -05:00
Cole Robinson
cf0206a58c devicedisk: Break apart set_create_storage 
And break about the vol_install vs local clone storage creators. And
just generally delete a lot of code. The commit aint pretty but it works
and deletes a ton of hacks
 2014-12-05 23:28:53 -05:00
Cole Robinson
7e2ea81a2c addstorage: Switch away from set_create_storage 2014-12-05 21:49:10 -05:00
Cole Robinson
92663eb1de devicedisk: Drop transient parameter 
Just patch it in from distroinstaller
 2014-12-05 21:49:10 -05:00
Cole Robinson
40a5ec75b7 tests: Switch away from set_create_storage 2014-12-05 21:49:10 -05:00
Cole Robinson
210ab4d8e0 devicedisk: Add set_vol_install 
And use it in places where we don't need set_create_storage
 2014-12-05 21:49:10 -05:00
Cole Robinson
2acbf52ce3 cli: If creating storage, always build vol_install 
This is the start of moving this logic out of devicedisk
 2014-12-05 20:00:11 -05:00
Cole Robinson
ef0beeb18b cli: Clean up disk source handling 
...sort of. This stuff is a hairy mess, but this makes it more stream line
and easier to extend.
 2014-12-05 19:05:15 -05:00
Cole Robinson
0cdf6032fb devicedisk: Remove some redundant validation 2014-12-05 15:31:13 -05:00
Cole Robinson
3e87aadeb7 devicedisk: Clarify backend vs creator code 2014-12-04 21:25:49 -05:00
Cole Robinson
dfc062c611 diskbackend: Make check_if_path_managed more readable 2014-12-04 21:08:38 -05:00
Cole Robinson
66a8c5d374 vmm: conn: Don't abuse path_definitely_exists for pool refreshing 
Just catch any errors and continue on
 2014-12-04 20:39:27 -05:00
Cole Robinson
6489df83ca devicedisk: Rename path_exists -> path_definitely_exists 
Since it's a best effort attempt, try to make it more clear that
we aren't certain if paths exist in some cases.
 2014-12-04 20:10:37 -05:00
Cole Robinson
ba05e1cd43 diskbackend: Drop all pool source matching 
It's only used to try and determine if a path actually exists, however
in the pool source case there isn't much we can actually do with that
info.
 2014-12-04 20:10:37 -05:00
Cole Robinson
0389ab23a7 diskbackend: Remove backing by pool object 
It just muddles things up for a minor edge case. The autopoolify logic
should catch all practical cases we care about.
 2014-12-04 19:45:00 -05:00
Cole Robinson
c7d00baf66 virtinst: connection: Only poll volumes for running pools 2014-12-04 19:25:15 -05:00
Cole Robinson
a75aa47daf devicedisk: Use consistent capitalization for property names 2014-12-04 16:30:18 -05:00
Cole Robinson
0e67ffba2e xmlbuilder: Remove now unused clear_attrs infrastructure 2014-12-04 15:29:12 -05:00
Cole Robinson
e71e5cd9dd devicedisk: Open code _xmlpath handling 
Rather than depend on xmlbuilder infrastructure. We will need to extend
this logic for network disks, and it's easier this way.
 2014-12-04 15:28:14 -05:00
Cole Robinson
e992cc15b2 virt-xml: Disable clearxml= for devices 
It doesn't work in the general case, and users can just --remove and
--add devices as needed for the same effect
 2014-12-04 15:28:14 -05:00
Cole Robinson
8d6ffafa1b tests: testdriver: More network storage examples 2014-12-04 13:06:20 -05:00
Cole Robinson
899bff4c4d tests: Quiet things with non-latest libvirt 2014-12-04 13:04:02 -05:00
Chen Hanxiao
43550c6daa devicedisk: add qed in driver_types 
We already used 'qed' in our codes,
but seems we forgot to add this in driver_types.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-12-04 08:57:06 +08:00
Cole Robinson
01d6541f69 create: Don't show default disk path on summary page 
Since it's dependent on the VM name, which the user might change
 2014-12-03 13:14:36 -05:00
Cole Robinson
4a678f0543 create: Fix default storage path when VM name is changed (bz 1169141) 
Regressed with 2e7ebd4 . Use skip_disk_page() to determine when we
shouldn't assume default storage
 2014-12-03 13:08:18 -05:00
Cole Robinson
c090d18beb console: Show multiple graphics devices in menu list 
But actually switching to one isn't supported, so show a tooltip to
that effect.
 2014-12-03 12:21:57 -05:00
Cole Robinson
ef99daa3d1 console: Rework serial menu building 
Mostly code reorg with some minor bug fixes thrown in.
 2014-12-03 12:14:32 -05:00
Cole Robinson
d178923609 create: Clarify function name 
It's no longer the 'name' page
 2014-12-03 10:13:39 -05:00
Cole Robinson
0b391fe9ed virt-manager: Enforce gobject introspection versions 
This is needed with freebsd and opensuse at least. See:

https://bugzilla.suse.com/__show_bug.cgi?id=901869
http://www.redhat.com/archives/libvir-list/2014-December/msg00184.html
 2014-12-02 14:01:28 -05:00
Giuseppe Scrivano
d2e6271337 Revert "tests: fix tests suite with last libvirt version" 
This reverts commit 9477f063762d25f858855172caf49e23511a85be.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-12-01 18:00:16 +01:00
Giuseppe Scrivano
9477f06376 tests: fix tests suite with last libvirt version 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-12-01 17:02:22 +01:00
Giuseppe Scrivano
51e5a47120 virt-manager: reset vgamem for video when changing device type 
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1169295

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-12-01 17:02:22 +01:00
Chen Hanxiao
a28b915724 HACKING: add more descriptions for test options 
also added the site of virt-manager translate project.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-12-01 10:20:18 +08:00
Giuseppe Scrivano
ad1f0fa081 details: fix --show-domain-performance 
the introspection page could be missing, in this case the tabs values
are shifted by one.  The new code looks for the correct row number
before selecting it.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1167600

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-11-26 08:41:40 +01:00
Giuseppe Scrivano
9d633879b1 tests: fix failures with libvirt upstream version 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-11-25 10:42:51 +01:00
Cole Robinson
09ef4583a0 virt-install: Also don't show console= warning for machvirt + --location 2014-11-21 13:57:30 -05:00
Cole Robinson
507af25258 virt-install: Don't warn about missing console= for machvirt 
Since latest kernels figure it out automatically
 2014-11-20 19:15:11 -05:00
Cole Robinson
be3787f2d1 urlfetcher: Detect RHEL ARM distro from treeinfo 2014-11-20 19:15:11 -05:00
Cole Robinson
26828b52cc guest: Use virtio-scsi for arm machvirt CDROM 
Since it's the only option we have to actually use the CDROM
 2014-11-20 11:27:09 -05:00
Cole Robinson
67b36a086c osdict: Remove unused diskbus field 2014-11-20 10:58:15 -05:00
Giuseppe Scrivano
c9a04c23dc virtManager: show correctly IPv6 addresses 
VirtualConnection.get_uri_host_port already splits this information
taking care of IPv6 addresses, do not split it again.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1094631

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-11-20 15:51:16 +01:00
Giuseppe Scrivano
5c68542151 console: switch to CONSOLE_PAGE_UNAVAILABLE while waiting for login 
It fixes a race condition if the ERROR_AUTH error if received while
still on the CONSOLE_PAGE_AUTHENTICATE and skipping the page_changed
event.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1165990

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-11-20 15:51:16 +01:00
Cole Robinson
08bea2195e HACKING: Make the test suite instructions the first listed bit 2014-11-17 15:42:15 -05:00
Giuseppe Scrivano
1cdd10ce34 virt-manager: show the manager when using a wrong domain id 
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1164691

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-11-17 16:50:04 +01:00
Cole Robinson
60e62e2676 osdict: Add back compat 'virtio26' entry 
We used to have that in the old osdict. Map it to fedora10 which gives
virtio net/block but nothing else, which matches the old behavior.
 2014-11-17 10:22:37 -05:00
Anatoly Belikov
78c52a13f1 add gluster and sheepdog pool/volume to testdriver.xml 2014-11-16 15:46:27 -05:00
Marc-André Lureau
5daee287d9 tunnels: do not close unowned fd 
The fd is handed to spice-gtk and gtk-vnc. They will close it when no
longer needed. Double closing leads to various race issues, since the
same fd may be opened for a different usage.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1081227
 2014-11-16 12:09:02 -05:00
Giuseppe Scrivano
741f2923d7 details: do not show MAC address if not set 
Fixes this exception:
Traceback (most recent call last):
  File "virt-manager/virtManager/create.py", line 1780, in finish
    self.customize(guest)
  File "virt-manager/virtManager/create.py", line 1812, in customize
    self.config_window = vmmDetails(virtinst_guest, self.topwin)
  File "virt-manager/virtManager/details.py", line 560, in __init__
    self.populate_hw_list()
  File "virt-manager/virtManager/details.py", line 3165, in populate_hw_list
    self.repopulate_hw_list()
  File "virt-manager/virtManager/details.py", line 3220, in repopulate_hw_list
    update_hwlist(HW_LIST_TYPE_NIC, dev)
  File "virt-manager/virtManager/details.py", line 3195, in update_hwlist
    label = _label_for_device(dev)
  File "virt-manager/virtManager/details.py", line 188, in _label_for_device
    return "NIC %s" % dev.macaddr[-9:]
TypeError: 'NoneType' object has no attribute '__getitem__'

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1164123

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-11-14 10:45:18 +01:00