shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-11 05:17:59 +03:00
Code Issues Projects Releases Wiki Activity
4,762 Commits 2 Branches 64 Tags 99 MiB
4f9fd84f8f
Commit Graph

882 Commits

Author SHA1 Message Date
Cole Robinson
015da05973 storage: Use .local/libvirt/images for session URIs 
.config isn't really appropriate
 2015-05-02 19:09:14 -04:00
Cole Robinson
8369c65966 storage: Use ~/.config/libvirt/images for qemu:///session 
It doesn't create the annoying ~/VirtualMachines directory, and already
has proper labelling.
 2015-04-24 21:01:55 -04:00
Cole Robinson
33cfe883c6 guest: arm kvm should use host-passthrough, not model=host 
Seems to work with libvirt, not sure if it was ever broken as the comment
suggested.
 2015-04-23 10:14:58 -04:00
Cole Robinson
6fd3983f6d tests: Clean up capabilities test data 
Make it clear which ones are used for the caps unit tests, and which
are for cli/UI testing and can be updated at will. And drop a bunch
of outdated stuff.
 2015-04-22 19:05:06 -04:00
Cole Robinson
070664b9e7 tests: Enable property checking for all objects 
And loosen restrictions a bit so any read/write will trigger the
tracking.
 2015-04-22 16:26:03 -04:00
Giuseppe Scrivano
1c22118179 aarch64: support virt-rhelsa7.1 machine type 
Just check for the prefix of the machine type, as it is done for ARM
vexpress.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1212021

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-04-22 19:08:02 +02:00
Cole Robinson
dcfce5585a osdict: If detecting fedora-unknown, convert to latest fedora 
That's basically what it is internally for libosinfo, and it helps
us generate better names in virt-manager
 2015-04-13 17:07:16 -04:00
Cole Robinson
4553912c64 diskbackend: Fix busted volume lookup API name 2015-04-13 16:41:59 -04:00
Cole Robinson
93f826a8b2 cli: Replace add --check option (bz 1063471) 
For fine grained enabling/disabling validation checks. Use this to
replace the heavy handed --force option.
 2015-04-11 19:48:35 -04:00
Cole Robinson
0f3d86ac9e guest: Disable PM for virt-install as well 
We are just mirroring the behavior that virt-manager (and boxes) have
used for a while now.

In my experience the average user is confused by their VMs suspending,
so for our sake I'd rather make people opt into this feature.
 2015-04-11 18:02:45 -04:00
Cole Robinson
a2c7d62ec4 guest: Disable spice image compression for local VMs 
The image compression setting has a noticably detrimental effect on
spice graphics quality. It's meant to be used for spice VDI but the
vast majority of people don't use spice in a way that makes bandwidth
usage matter.

Boxes has already done this for a while as well:

https://mail.gnome.org/archives/commits-list/2013-March/msg14904.html

Turn it off by default if creating the VM on a local connection.
 2015-04-11 17:53:17 -04:00
Cole Robinson
20d37422fe virt-install: Fill in a bunch of --graphics spice options (bz 1110017) 2015-04-11 16:56:27 -04:00
Cole Robinson
9a789c19e2 virt-install: Support --hostdev scsi passthrough (bz 1054912) 
Pass it a type=scsi nodedev name, and we will set things up correctly.
 2015-04-11 15:55:09 -04:00
Cole Robinson
9a1fc63c89 manager: Disable 'force reset' if HV doesn't support it (bz 1078731) 2015-04-11 14:01:45 -04:00
Cole Robinson
4781ad6cd6 connection: Simplify manager row 'pretty name' handling 
Unify all the callers, and use some UI ellipsizing to handle
crazy long hostnames.

This drops the conn name collision prevention stuff which can be
useful when you have lots of similar connection names. But upcoming
patches will make it mostly redundant.
 2015-04-11 12:57:32 -04:00
Cole Robinson
fc171fc31d connection: Bunch of minor tweaks handling TCP URIs 2015-04-11 12:08:57 -04:00
Cole Robinson
838baf6946 connection: tick: Operate on combined object lists 
Makes the flow a bit simpler, and allows us to break out polling without
having to pass around a ton of lists.
 2015-04-10 15:00:34 -04:00
Cole Robinson
cb5d075f50 libvirtobject: Unify a few APIs and conn tick handling 2015-04-10 15:00:34 -04:00
Giuseppe Scrivano
616df760be storage: copy allocation and capacity also on cross-pool clones 
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1210265

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-04-10 16:40:49 +02:00
Cole Robinson
527c49dec2 virt-install: Add --input option 
For configuring VM <input> devices
 2015-04-09 13:22:40 -04:00
Cole Robinson
6634053533 domcapabilities: Can and log error fetching XML (bz #1209723) 2015-04-08 09:53:30 -04:00
Cole Robinson
cc3a522455 Use is_pseries() helper more consistently 2015-04-08 09:31:01 -04:00
Cole Robinson
9b21f27e31 cli: Maintain same --print-xml behavior for non virt-install 
Don't want it scooping up any nargs
 2015-04-07 19:58:28 -04:00
Cole Robinson
a5d03fdf6e guest: Don't unconditionally overwrite on_poweroff/on_crash 2015-04-07 19:53:15 -04:00
Cole Robinson
86f1133777 guest: Encode defaults into the XML at install time 
Previously we made all the default encoding non-permanent by XML objects
before generating the XML, making changes to the copies, and restoring
to the old state after the XML is returned to the user.

This allows us to call start_install multiple times with the same Guest
object and not alter it's original config... but that feature isn't really
useful anymore, and this behavior makes the 'customize before install'
dialog difficult to handle.

So drop most of it, and fix some of the minor fallout.
 2015-04-07 18:36:06 -04:00
Cole Robinson
a773a66a3f virtcli: Export config variables in a class object 
Makes things easier to extend later
 2015-04-06 15:54:35 -04:00
Cole Robinson
e29f216503 guest: Use sata by default for q35 cdrom, non-virtio (bz #1207834) 2015-04-06 13:43:18 -04:00
Cole Robinson
feb010621b addhardware: Don't advertise IDE for Q35 (bz #1207834) 
Laine suggests we hide it altogether
 2015-04-06 13:36:54 -04:00
Cole Robinson
3a36d95da0 details: Explicitly label virtio scsi disks + controllers 2015-04-04 20:06:40 -04:00
Cole Robinson
3d6831ec8f virt-install: Deprecate --print-step, just use --print-xml 
argparse lets us handle this in a back compat fashion, so let's simplify
the CLI.
 2015-04-04 17:10:45 -04:00
Cole Robinson
af64b79679 osdict: Use is_related_to for support check 
Simplifies our whitelist maintenance
 2015-04-04 16:08:00 -04:00
Cole Robinson
393aed191e urlfetcher: Detect centos URLs as centos, not rhel variants 2015-04-04 15:41:13 -04:00
Cole Robinson
d0c65b30a4 osdict: Simplify a bunch of the checks, drop some legacy stuff 2015-04-04 15:32:35 -04:00
Cole Robinson
a7dbc5e250 tests: Add more osdict.py coverage 2015-04-04 14:43:12 -04:00
Cole Robinson
ce73272c7e create: Drop hardcoded STABLE_OS_SUPPORT list 
It's out of date, and doesn't even seem to work with current RHEL versions
and no one is complaining.

If we want to add it back, it should be an explicit setup.py configure
option.
 2015-04-04 13:48:15 -04:00
Cole Robinson
595b5b4bdf osdict: Drop explicit 'type' class 
create.py is the only thing that cares about this nowadays, so we can
work with things to make it all simpler.
 2015-04-04 12:48:50 -04:00
Cole Robinson
bd9ab2d5b5 osdict: Add toplevel OSDB as API entry point 
Makes code more readable, and lazy loading simpler.
 2015-04-04 12:06:41 -04:00
Cole Robinson
f644b0997d osdict: Have users call functions, rather than access properties 
Gives us more future flexibility, and simplifies the flow quite a bit.
 2015-04-04 11:24:18 -04:00
Cole Robinson
710c588eaf guest: Use cached osdict object for all lookups 
Rather than have lookup_osdict_key constantly do the dictionary lookup.

This is step one towards simplifying the osdict lazy loading
 2015-04-04 11:23:54 -04:00
Cole Robinson
36e46d0276 capabilities: Use _CapsInfo to simplife recommended_machine 2015-04-03 17:37:08 -04:00
Cole Robinson
97259c4d9b capabilities: Store results of guest_lookup together 
Simplifies API users lives to not have to remember whether caps guest
or caps domain contains a particular value.
 2015-04-03 17:37:08 -04:00
Cole Robinson
81a1910d90 capabilities: Rename no_install_options -> has_install_options 
It's easier to visually parse the wording
 2015-04-03 17:25:29 -04:00
Cole Robinson
fe9ffe86f6 capabilities: Drop xen-only bios virt checks 
These only work for xen x86, and are less relevant nowadays since HW
virt has been around for a very long time. Also it's tough to be sure
that we aren't giving a bogus warning.
 2015-04-03 17:25:29 -04:00
Cole Robinson
4e9f70f9b3 Drop all references to kqemu, it's long dead 2015-04-03 16:45:43 -04:00
Cole Robinson
f5b13a6e19 Drop all references to xenner, it's long dead 2015-04-03 16:45:43 -04:00
Cole Robinson
45ae269950 storage: Use XMLBuilder for pool enumerate parsing 
And kill the parse_node_helper function, since that paradigm is dead.
 2015-04-03 16:45:43 -04:00
Cole Robinson
d4dfbd41b5 capabilities: Use XMLBuilder for cpu_map parsing 
And clean up the internal bits a little
 2015-04-03 16:45:43 -04:00
Cole Robinson
cac4ac1401 capabilities: Switch to use XMLBuilder 
Just a cleanup to finally unify all the XML objects around the same
API, and drop a bunch of old cruft.
 2015-04-03 16:45:42 -04:00
Charles Arnold
20fe287341 virt-manager: Don't allow an empty string for a network name 
When starting the 'Create virtual network' wizard, you are allowed to proceed
without specifying a Network Name.  An error only occurs after all else is
completed with the wizard. This patch stops the user from proceeding if a
network name has not been specified.

The check for an empty string is done in util.py which also effects storage
pool names and guest names neither of which should have empty strings.

Signed-off-by: Charles Arnold <carnold@suse.com>

Message-Id: <551D664702000091000F42E8@prv-mh.provo.novell.com>
 2015-04-03 10:49:42 -04:00
Giuseppe Scrivano
bbb96bcaa8 clone: keep the same image format on a cross-pool clone 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-04-01 11:56:34 +02:00
Cole Robinson
82e9684fa6 urlfetcher: Make debian treearch checking more generic 
Use regex parsing rather than a whitelist
 2015-03-27 13:06:26 -04:00
Mauricio Faria de Oliveira
0dc334fa58 Add ppc64el support for 'virt-install --location' (Debian/Ubuntu) 
The installation of Debian/Ubuntu for ppc64el (a.k.a. ppc64le on Fedora/RHEL)
fails with 'virt-install --location', as the arch dir and kernel filename
are not correct for this arch/distros.

This patch fixes it by adding checks for 'treeArch' and 'hvm_kernel_paths'.

Signed-off-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
 2015-03-27 12:30:04 -04:00
Cole Robinson
e125aa69d8 nodedev: Handle busted 'system' XML 
Libvirt can generated invalid XML for the system nodedev device:

https://bugzilla.redhat.com/show_bug.cgi?id=1184131

This hits at least two people, so catch this specific case, but the
real fix is libvirt not outputing busted XML.
 2015-03-26 18:04:23 -04:00
Cole Robinson
dc1737e623 cpu: Drop vendor and features if setting host-model (bz 1190851) 
Otherwise via virt-manager we can try to set a <cpu> with a <vendor>
but no <model>, and libvirt complains.
 2015-03-26 17:08:15 -04:00
Cole Robinson
7866e291f6 guest: Never use vmvga if host is RHEL (bz 1147662) 
We basically need to do this independent of whether the build is configured
for RHEL defaults or not
 2015-03-25 09:04:51 -04:00
Cole Robinson
cfe9e7dc7e virt-install: Make '--cpu none' work with aarch64 2015-03-23 17:46:09 -04:00
Cole Robinson
08a72a4aec connection: Clean up stable_defaults, improve test coverage 2015-03-23 16:49:32 -04:00
Cole Robinson
2a31ff0248 guest: Perform stable_defaults check using our emulator 
Not passing an emulator is only for showing ideal defaults in the UI.
When doing internal checks, we only want to disable features if we know
the emulator doesn't support them.
 2015-03-23 16:49:32 -04:00
Cole Robinson
590e4772eb connection: Fix error checking stable_defaults 
This should fail when run against actual RHEL capabilities output
 2015-03-23 16:39:49 -04:00
Cole Robinson
0273ee2fac tests: Move some test suite hacks into the code, increase coverage 2015-03-23 16:25:31 -04:00
Cole Robinson
7a1b7b69e3 Drop non-ascii text from files 
Seems to be tripping up coverage output on f22
 2015-03-23 15:56:55 -04:00
Cole Robinson
c6481f6c5d cli: Drop needless assignment that confuses pylint 2015-03-23 14:03:52 -04:00
Pavel Hrdina
1689677482 virtinst/cli: don't use hard-coded path for binaries 
The binaries could be installed somewhere else and we should not
hard-code the binary paths.  This patch allows non-root user to build
their own virt-viewer/virsh, set the PATH env and run virt-manager
tests.

(crobinso: Fix check_output args, alphabetize imports)

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Message-Id: <ddf77f9519da580c8d5f3df0f56bdb36d5c000fa.1427117670.git.phrdina@redhat.com>
 2015-03-23 13:31:49 -04:00
Giuseppe Scrivano
31836e2b5d virtinst: add support for <disk> sgio attribute 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-03-16 20:32:40 +01:00
Giuseppe Scrivano
64264e8fa2 Disable domain events with XEN 
When XEN is used, disable domain events and use polling.

On RHEL-5.9 virDomainInfo() seems to not report correctly the domain
status when called immediately after the event is received.

Solves: https://bugzilla.redhat.com/show_bug.cgi?id=1177207

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-02-26 11:08:57 +01:00
Giuseppe Scrivano
478ba6d885 Use virtio-net only when it is supported 
Do not use the model specified by the OS if it is "virtio-net" and
virtionet is not supported.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1177113

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-02-25 15:32:54 +01:00
Giuseppe Scrivano
00aea929ef tests: check that vmvga is not used on RHEL 
And fix typo in last commit

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-02-24 19:03:59 +01:00
Giuseppe Scrivano
6c61e66ff7 Do not use vmvga on RHEL 
Fallback to VGA

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1179652

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-02-24 17:44:23 +01:00
Giuseppe Scrivano
7b630c00a0 Move stable_defaults from vmmConnection to VirtualConnection 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-02-24 17:44:23 +01:00
Cole Robinson
0befc54abe details: Handle libvirt reporting multiple firmware paths 2015-02-22 11:19:50 -05:00
Cole Robinson
4ee9fdf944 domcapabilities: Get arch from caps XML 2015-02-22 11:13:59 -05:00
Cole Robinson
a5b3e2adab create: Try to default to UEFI for aarch64 
If we detect AAVMF, set it up, and allow all install options.
If we don't find AAVMF, disable all options except import install (the
current behavior) and show a warning.
 2015-02-22 10:25:51 -05:00
Cole Robinson
a04307cd70 virt-install: Add --boot uefi 
Will enable UEFI if we know libvirt + hypervisor support it, and libvirt
is advertising a suitable UEFI binary.
 2015-02-22 10:25:47 -05:00
Cole Robinson
760465fd2b support: Rename variable for easier debugging 2015-02-22 10:25:47 -05:00
Cole Robinson
4efc814d7f connection: Add domain caps handling for fake URIs 
Allows us to pass in custom domcaps content for testing purposes
 2015-02-22 10:25:47 -05:00
Cole Robinson
6e2e43b178 storage: Fix some pylint on libvirt without REFLINK flag 2015-02-22 10:25:47 -05:00
Cole Robinson
271e248a41 storage: Fix test failures with reflink check 2015-02-22 10:13:27 -05:00
Chen Hanxiao
4622a0a8f8 virt-clone: introduce --reflink for btrfs COW copy 
libvirt commit 466b29c8c3593b2dac92acad5dd8ec923c428259
introduce btrfsCloneFile() for COW copy.
This patch add support for --reflink option for virt-clone.
When specified --reflink, if src and dst images all on a btrfs
fs, we could take advantage of COW copy.
If not, error out.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2015-02-07 10:18:05 +08:00
Anatoly Belikov
e44b95149b devicedisk: fix source name attribute for gluster volumes 
(crobinso: Small code tweak, and add test cases)
 2015-01-29 11:31:43 -05:00
Cole Robinson
a1d82a162c devicedisk: Add logging of pool/vol XML 2015-01-29 10:20:18 -05:00
Cole Robinson
9464ca3dcf cli: Fix debug message formatting 2015-01-29 10:03:35 -05:00
Giuseppe Scrivano
cbba1c4dd3 virt-manager: disable HYPER-V on Windows 2008 R2 and Win7 SP1 with UEFI 
Windows 2008 R2 or Win7 SP1 guests do not work when UEFI and HYPER-V,
so just disable HYPER-V.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1185253

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-01-27 13:38:24 +01:00
Prerna Saxena
232507b4e9 Add support for PowerPC Little Endian (ppc64le) architecture. 
This enables virt-install to create VMs based on ppc64le architecture.

(crobinso: fix minor pylint)

Signed-off-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
 2015-01-09 10:47:52 -05:00
Cole Robinson
aa772f01e1 guest: Prefer virtio-scsi for arm mach-virt 
Since it gives us disk hotplug, and CDROM devices, etc.

This requires fairly recent patches to UEFI/OVMF/AAVMF
 2014-12-17 15:23:05 -05:00
Chen Hanxiao
cbe5ca4c7d cloner: fix a doc typo 
s/It/If

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-12-15 09:42:08 +08:00
Cole Robinson
6871ee0c91 urlfetcher: Hint at the user if URL appears unaccessible 2014-12-10 13:57:10 -05:00
Gabriel de Perthuis
24faf86750 URL installs: remove hasFile("") check 
Specialised proxies like apt-cacher-ng disallow directory listing.
OSDistro subclasses do have checks for known files and they are
sufficient.
 2014-12-10 13:46:11 -05:00
Cole Robinson
8a96406902 man: Document --disk $URL format 2014-12-10 13:22:42 -05:00
Cole Robinson
0370d3b796 devicedisk: Never raise error for missing TYPE_VOLUME 
We can't predict when it's expected or not, so just never raise the
error and let libvirt error if the user is trying do things at
create time.
 2014-12-10 13:22:42 -05:00
Cole Robinson
9ae3dbe05b virt-install: Fix --disk pool=NETPOOL,size=... creation 2014-12-10 13:22:42 -05:00
Cole Robinson
e1ab165b1a cli: Don't try to create storage with source_pool + size 2014-12-10 13:22:42 -05:00
Cole Robinson
117cbfe12f devicedisk: Don't set driver name=unknown for rbd vols 2014-12-10 13:22:42 -05:00
Cole Robinson
12340a3858 diskbackend: Try looking up network volumes by path 
For gluster volumes, which have unique URLs for volume paths, this
makes selecting network volumes via the storagebrowser UI work.

Sheepdog and RBD volumes don't work yet
 2014-12-10 09:04:29 -05:00
Cole Robinson
464ebabc5a virt-install: Wire up --disk vol= for network volumes 
This involves convering pool/vol XML to disk source bits
 2014-12-09 18:23:22 -05:00
Cole Robinson
214872498d test: Set volume type in testdriver XML 2014-12-09 17:50:16 -05:00
Cole Robinson
626295a036 storage: Remove unused function 2014-12-09 17:42:01 -05:00
Cole Robinson
f7c17d4c46 diskbackend: Mandate parent_pool when vol_object is passed 
We will need parent pool for looking up info about network volumes
 2014-12-09 17:03:48 -05:00
Cole Robinson
208672eea9 diskbackend: Minor simplifications 2014-12-09 16:57:32 -05:00
Cole Robinson
e61311fc8a storage: More support for network pools 
Including parsing multiple hosts, filling reasonably defaults, making
sure the createpool wizard does the correct thing, etc.
 2014-12-09 16:12:47 -05:00
Cole Robinson
838d7f015c tests: Drop a bunch of redundant xmlconfig tests 
These are mostly covered by clitests. Keep the important ones around
for code coverage.
 2014-12-09 13:19:56 -05:00
Cole Robinson
9f4d03d31a storage: Really don't use PREALLOC flag with test driver 
Even if we are trying really hard to fake looking like qemu/kvm
 2014-12-09 13:14:12 -05:00
Cole Robinson
9952764dda virt-install: Make --disk $URL 'just work' 
If VirtualDisk.path is set to a URL, parse it and fill in all the
source_* values automagically.
 2014-12-09 10:45:26 -05:00
Cole Robinson
3ac272e635 uri: Add unit tests, fix some bugs 2014-12-09 10:15:53 -05:00
Cole Robinson
1c79b936f5 diskbackend: Check if the passed path is a url 2014-12-09 08:44:45 -05:00
Cole Robinson
c5ccd68e4d devicedisk: Handle an empty storage backend 
Rather than have every little bit depend on a present storage backend,
only create one when it really matters.
 2014-12-09 08:44:45 -05:00
Cole Robinson
f0b8062226 devicedisk: Unify StorageCreator vs StorageBackend handling 2014-12-09 08:44:45 -05:00
Cole Robinson
db0942bd09 diskbackend: Document the various classes 2014-12-09 08:44:44 -05:00
Cole Robinson
cff08223ba util: Move uri_split to its own URISplit class 
Does what uri_split did, but wraps it all up in an object that makes
handling the data easier, and makes it easy to extend.
 2014-12-09 08:43:19 -05:00
Chen Hanxiao
802e57ea5e diskbackend: fix some comment typos 
s/if/If
s/a/an

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-12-09 15:53:21 +08:00
Cole Robinson
00957db6e0 devicedisk: Clarify _xmlpath 2014-12-07 10:08:33 -05:00
Cole Robinson
cd305da3f8 virt-install: support network --disk's 
Handle type=network in devicedisk.py, and wire up all the network fields
for virt-install --disk. Right now it requires manually spelling out
all the protocol, name, host/port etc fields.

The one 'magic' bit is that VirtualDisk.path will be a pretty URL when
all those network fields are specified. This is keeps things mostly
working in various parts of the code where we expect 'path' to be an
identifier for a VirtualDisk.
 2014-12-06 21:00:51 -05:00
Cole Robinson
0f6fddf610 devicedisk: Simplife get_xmlpath 
Rather than deal with hacks, just read the backing paths and return
the first hit
 2014-12-06 17:29:05 -05:00
Cole Robinson
86682c8c54 virt-install: Support --disk source_pool,source_volume 
For setting type=volume disks. This requires some reworking of
devicedisk bits
 2014-12-06 17:14:16 -05:00
Cole Robinson
9b62c2260d devicedisk: Catch --disk /dev/idontexist,size=2 2014-12-06 16:44:21 -05:00
Cole Robinson
52691c511e devicedisk: Move more validation into diskbackend 2014-12-06 16:44:21 -05:00
Cole Robinson
cf0206a58c devicedisk: Break apart set_create_storage 
And break about the vol_install vs local clone storage creators. And
just generally delete a lot of code. The commit aint pretty but it works
and deletes a ton of hacks
 2014-12-05 23:28:53 -05:00
Cole Robinson
7e2ea81a2c addstorage: Switch away from set_create_storage 2014-12-05 21:49:10 -05:00
Cole Robinson
92663eb1de devicedisk: Drop transient parameter 
Just patch it in from distroinstaller
 2014-12-05 21:49:10 -05:00
Cole Robinson
40a5ec75b7 tests: Switch away from set_create_storage 2014-12-05 21:49:10 -05:00
Cole Robinson
210ab4d8e0 devicedisk: Add set_vol_install 
And use it in places where we don't need set_create_storage
 2014-12-05 21:49:10 -05:00
Cole Robinson
2acbf52ce3 cli: If creating storage, always build vol_install 
This is the start of moving this logic out of devicedisk
 2014-12-05 20:00:11 -05:00
Cole Robinson
ef0beeb18b cli: Clean up disk source handling 
...sort of. This stuff is a hairy mess, but this makes it more stream line
and easier to extend.
 2014-12-05 19:05:15 -05:00
Cole Robinson
0cdf6032fb devicedisk: Remove some redundant validation 2014-12-05 15:31:13 -05:00
Cole Robinson
3e87aadeb7 devicedisk: Clarify backend vs creator code 2014-12-04 21:25:49 -05:00
Cole Robinson
dfc062c611 diskbackend: Make check_if_path_managed more readable 2014-12-04 21:08:38 -05:00
Cole Robinson
6489df83ca devicedisk: Rename path_exists -> path_definitely_exists 
Since it's a best effort attempt, try to make it more clear that
we aren't certain if paths exist in some cases.
 2014-12-04 20:10:37 -05:00
Cole Robinson
ba05e1cd43 diskbackend: Drop all pool source matching 
It's only used to try and determine if a path actually exists, however
in the pool source case there isn't much we can actually do with that
info.
 2014-12-04 20:10:37 -05:00
Cole Robinson
0389ab23a7 diskbackend: Remove backing by pool object 
It just muddles things up for a minor edge case. The autopoolify logic
should catch all practical cases we care about.
 2014-12-04 19:45:00 -05:00
Cole Robinson
c7d00baf66 virtinst: connection: Only poll volumes for running pools 2014-12-04 19:25:15 -05:00
Cole Robinson
a75aa47daf devicedisk: Use consistent capitalization for property names 2014-12-04 16:30:18 -05:00
Cole Robinson
0e67ffba2e xmlbuilder: Remove now unused clear_attrs infrastructure 2014-12-04 15:29:12 -05:00
Cole Robinson
e71e5cd9dd devicedisk: Open code _xmlpath handling 
Rather than depend on xmlbuilder infrastructure. We will need to extend
this logic for network disks, and it's easier this way.
 2014-12-04 15:28:14 -05:00
Cole Robinson
e992cc15b2 virt-xml: Disable clearxml= for devices 
It doesn't work in the general case, and users can just --remove and
--add devices as needed for the same effect
 2014-12-04 15:28:14 -05:00
Cole Robinson
899bff4c4d tests: Quiet things with non-latest libvirt 2014-12-04 13:04:02 -05:00
Chen Hanxiao
43550c6daa devicedisk: add qed in driver_types 
We already used 'qed' in our codes,
but seems we forgot to add this in driver_types.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-12-04 08:57:06 +08:00
Giuseppe Scrivano
51e5a47120 virt-manager: reset vgamem for video when changing device type 
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1169295

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-12-01 17:02:22 +01:00
Cole Robinson
be3787f2d1 urlfetcher: Detect RHEL ARM distro from treeinfo 2014-11-20 19:15:11 -05:00
Cole Robinson
26828b52cc guest: Use virtio-scsi for arm machvirt CDROM 
Since it's the only option we have to actually use the CDROM
 2014-11-20 11:27:09 -05:00
Cole Robinson
67b36a086c osdict: Remove unused diskbus field 2014-11-20 10:58:15 -05:00
Cole Robinson
60e62e2676 osdict: Add back compat 'virtio26' entry 
We used to have that in the old osdict. Map it to fedora10 which gives
virtio net/block but nothing else, which matches the old behavior.
 2014-11-17 10:22:37 -05:00
Cole Robinson
26d16a5978 diskbackend: Fix typo 2014-10-29 12:35:18 -04:00
Chen Hanxiao
a6e72f30f3 virtinst: fix some comment typos 
s/occurence/occurrence

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-10-29 16:00:28 +08:00
Cole Robinson
baee53fbaa util: Simplify default_bridge to not confuse pylint 2014-10-27 19:53:25 -04:00
Cole Robinson
cbf38cbe9f pylint: Ignore new warnings 2014-10-27 19:53:25 -04:00
Giuseppe Scrivano
cce5827195 virtinst: add support for disk type="volume" 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-09-26 16:24:59 +02:00
Cole Robinson
310f65273f osdict: Restrict n-cpus to 1 for machvirt 
It fails to boot otherwise
 2014-09-23 17:09:36 -04:00
Cole Robinson
318ac3df55 guest: Add clarifying comment 2014-09-23 16:19:54 -04:00
Cole Robinson
42ac7a3036 guest: Set optimal arm CPU defaults 
If doing arm kvm, use cpu=host. Otherwise, specify cortex-a57 for aarch64
so we actually get a 64bit cpu
 2014-09-23 16:18:23 -04:00
Cole Robinson
c4162f6708 Use -M virt as default machine for arm/aarch64 
Centralize the default machine logic in caps and use it consistently
 2014-09-23 16:05:48 -04:00
Cole Robinson
0182ba3ead guest: Use virtio for arm -M virt 
In fact it's the only thing it supports
 2014-09-23 15:12:02 -04:00