Commit Graph

174 Commits

Author SHA1 Message Date
Radostin Stoyanov
5553cbeb38 Replace ipaddr module with ipaddress
The `ipaddress` is available in Python 3.3+ [1] and backport for
Python 2 is available on PyPI [2].

The main differences between ipaddr and ipaddress are:

- ipaddress *Network classes are equivalent to the ipaddr *Network
  class counterparts with the strict flag set to True.
- ipaddress *Interface classes are equivalent to the ipaddr *Network
  class counterparts with the strict flag set to False.
- The factory functions in ipaddress were renamed to disambiguate them
  from classes.
- A few attributes were renamed to disambiguate their purpose as well.
  (eg. network -> network_address, numhosts -> num_addresses)
- A number of methods and functions which returned containers in ipaddr
  now return iterators. This includes subnets, address_exclude,
  summarize_address_range and collapse_address_list.

Another major difference is that in Python 2 the `ipaddress` module
must use unicode. [3]

[1] https://www.python.org/dev/peps/pep-3144/
[2] https://pypi.python.org/pypi/ipaddress
[3] https://github.com/phihag/ipaddress
2018-02-06 18:49:17 -05:00
Cole Robinson
fe04438832 spec: Add dep on genisoimage, for isoinfo 2018-01-06 14:18:19 -05:00
Cole Robinson
405b5ea804 spec: Remove duplicate libxml2 dep 2017-03-06 22:15:46 -05:00
Mario Trangoni
83a40a932f NEWS: convert to Markdown format. 2017-02-16 19:02:22 -05:00
Cole Robinson
9bfd9f66c8 spec: README->README.md
And fix the MANIFEST as well
2017-02-05 15:47:36 -05:00
Cole Robinson
4a365046d6 spec: Add virt-install libvirt-client dep (bz 1416752)
Since we unconditionally attempt to call 'virsh console' for certain
configs.

https://bugzilla.redhat.com/show_bug.cgi?id=1416752
2017-02-05 15:44:33 -05:00
Cole Robinson
b7d4267cd2 spec: Add dep on python2-devel
This is needed to pull in the __python2 RPM macro
2016-06-18 16:58:21 -04:00
Cole Robinson
47dd38eb3e Use #!/usr/bin/env for python scripts
This is recommended for upstream, but not for downstream, like Fedora.
So change /usr/bin/env to /usr/bin/python2 at RPM install time to
match the ideal Fedora config.

https://fedoraproject.org/wiki/Features/SystemPythonExecutablesUseSystemPython
https://bugzilla.redhat.com/show_bug.cgi?id=1303282
2016-06-17 12:56:14 -04:00
Cole Robinson
2204de62d9 spec: Move BuildArch before Source
My patch scripts like it better that way
2016-05-20 17:15:36 -04:00
Cole Robinson
35e3bf1715 spec: Replace %define with %global 2015-12-29 12:00:40 -05:00
Cole Robinson
437d25f356 spec: Depend on latest vte package vte291
The vte291 package is actually the latest vte with API version 2.91, while
the vte3 package is effectively a compat package with API version 2.90.
virt-manager works fine with either, so pull the latest bits so there's
no ambiguity.
2015-12-24 12:29:46 -05:00
Cole Robinson
fe722b99cb setup: Make gsettings always work regardless of install dir (bz #1267377)
Most of this is lifted from 'meld'. The bits are

- compile gsettings schemas at setup.py install time
- add options to disable that, and use them in the RPM
- always pass GSETTINGS_SCHEMA_DIR so gsettings loading always works
  regardless of the install dir

https://bugzilla.redhat.com/show_bug.cgi?id=1267377
2015-11-02 21:02:42 -05:00
Cole Robinson
d5d6cfff2c Copy urlgrabber progress bar code into virt-manager.git
This is so we can drop the dep on system python-urlgrabber, which will
block us from going to python3.

All we need is like 300 lines from python-urlgrabber for the progress
bar. In reality our needs are much lower, we don't need the fancy
progress bar that urlgrabber provides, but it's nice to have. So if
keeping a copy of this code causes issues in the future, we can probably
come up with something simpler (or hopefully there's a more common
python progressbar impl that we can use at that point).
2015-09-18 20:55:44 -04:00
Cole Robinson
5584863d18 urlfetcher: Switch to requests and urllib2 instead of urlgrabber
urlgrabber is largely dead upstream and isn't going to be ported to
python3 AFAIK. So we will need to move off of it eventually.

Use requests for http handling which is the most common library nowadays,
and just plain old urllib2 for ftp fetching.
2015-09-18 19:50:35 -04:00
Cole Robinson
a722e3d5e3 Update documentation to point to github, other minor tweaks 2015-09-03 12:44:02 -04:00
Cole Robinson
59b30c81a0 spec: Add LXC to default connection list (bz 1235972) 2015-08-09 18:15:37 -04:00
Pavel Hrdina
cbd7e33a09 spec: we don't need to depend on qemu-kvm
Similarly as in commit 95cda553, just remove the dependency on qemu-kvm
package for RHEL builds.  We don't need it, becase libvirt-daemon-kvm
will handle this dependency correctly for us even in case that only
qemu-kvm-rhev is present.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1046651

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-06-21 15:06:10 -04:00
Cole Robinson
95cda55376 spec: Don't use hardcode lookup of qemu-system-x86
libvirt-daemon-kvm pulls in the correct emulator dep per architecture
2015-05-02 18:25:41 -04:00
Cole Robinson
7c3f9dfcc2 spec: Don't install GConf conversion script
We have shipped several releases of RPMs that use gsettings. People
have already rebuilt their settings by hand. Installing the conversion
script could overwrite their latest bits with old gconf bits (this
happened to me).
2015-04-11 11:14:04 -04:00
Cole Robinson
ef5552d0aa configure: Add --default-hvs, kill --with-bhyve
Takes a comma separated list of HVs, and only shows those as options in
the 'Open Connection' wizard. This option can be used to hide the bhyve
option as well, so drop --with-bhyve
2015-04-06 16:29:28 -04:00
Cole Robinson
1e2f605e81 virtcli: Drop custom version handling
No one uses it, and it can be handled easy enough with a wrapper script or
similar.
Message-Id: <1b33f161591b86407f78fb307aa4f89f6eee9e4e.1428346382.git.crobinso@redhat.com>
2015-04-06 15:54:35 -04:00
Cole Robinson
ba527471fc spec: Only pull in gnome-icon-theme on RHEL7 (bz 1207061)
It's the wrong dep on F21+, and it's redundant there anyways. So just
restrict this to RHEL7 where the bug was reported, come RHEL8 time
it likely won't be relevant.
2015-03-30 12:47:39 -04:00
Cole Robinson
72324a8575 spec: Add pygobject3-base dep for virt-install (bz 1195794) 2015-02-24 11:23:46 -05:00
Cole Robinson
9a5da6972a Remove test-autobuild support
I don't think anything is actually using it these days, and upstream
autobuild development seems dead. If someone is still using it, we
can revert this commit.
2015-02-22 11:32:02 -05:00
Cole Robinson
84decb61f8 spec: Add BuildRequires: python for f22/rawhide 2015-02-22 10:01:43 -05:00
Giuseppe Scrivano
23d2047576 spec: move dependency to libosinfo from virt-manager to common
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1159370
2014-11-04 09:04:09 +01:00
Giuseppe Scrivano
ea0cded87b spec: add a dependency on "gnome-icon-theme"
virt-manager uses some icons included in the gnome-icon-theme package.
Make it explicit and add a dependency.

Desktop folks agree that this is the place where to add this
dependency as adding it to gtk is too problematic.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146612

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-06 17:47:24 +02:00
Cole Robinson
a4db445a45 spec: Install the gconf .convert file 2014-09-30 08:41:37 -04:00
Cole Robinson
2224364b1d spec: Remove changelog
It just duplicates the NEWS file, not really that interesting
2014-09-10 13:29:25 -04:00
Cole Robinson
f4fcf4c3e7 Prep for release 1.1.0 2014-09-07 16:22:04 -04:00
Cole Robinson
5aafe008bc Remove virt-image, as scheduled
As promised with the last release, remove virt-image. In 6 months I didn't
hear a peep from any actual users that cared.
2014-09-06 18:05:43 -04:00
Giuseppe Scrivano
f73c5683c5 virt-manager: add dependency to libosinfo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-24 12:40:42 +01:00
Cole Robinson
8b7ebd4538 Prep for release 1.0.1 2014-03-22 18:38:44 -04:00
Cole Robinson
907c9c4dec spec: Drop needless version/release macros 2014-03-07 09:57:04 -05:00
Cole Robinson
b83ee891ab Prep for release 1.0.0 2014-02-14 18:45:01 -05:00
Cole Robinson
748ff1c4cc virt-xml: Initial commit, basic set of tests 2014-01-25 17:20:29 -05:00
Martin Kletzander
dc0b9bbaaf Rename hide_unsupported_rhel_options to stable_defaults and clean-up its usage
There were multiple problems with the setting and usage of
hide_unsupported_rhel_options.  Due to the fact that the option has
several diferent namings throughout the code, this patch is renaming
it to stable_defaults, which basically says what the option does and
makes it possible to use it without need for more than one negation
(where the old code had up to 4 of them in some places), which also
helps understanding it.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-01-21 17:13:18 +01:00
Cole Robinson
e57cd46904 spec: Require dbus-x11 (bz 1039803)
virt-manager is one of those tools that people will often install when
no traditional desktop is present. dbus-x11 is pulled in by desktop
environments, but not by gtk3 for (presumably) legitimate reasons.
But we need it to do anything worthwhile with dbus.
2013-12-14 12:02:47 -05:00
Cole Robinson
7c3c70d3d0 Remove gconf dep, Require dconf 2013-10-04 16:34:32 -04:00
Cole Robinson
cda621548b Fix last remnants of default_graphics=vnc 2013-10-02 18:51:27 -04:00
Cole Robinson
2148eaa2ae Distribute appdata xml (bz 1011120)
More info: http://people.freedesktop.org/~hughsient/appdata/
2013-09-24 08:38:12 -04:00
Cole Robinson
7edd2c5208 Fix spelling error in function names 2013-08-18 12:30:58 -04:00
Cole Robinson
10cf80c25b Prep for release 0.10.0 2013-06-19 18:37:21 -04:00
Martin Kletzander
5fe2d5e977 One more vnc->spice cleanup
Last commit changing the default was de1695b2, but there was still one
place in man page left and the spec file was left dirty.  This is
hopefully the last vnc->spice patch

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-06-19 17:31:51 -04:00
Cole Robinson
0c9552bccb spec: Drop libguestfs conditional
We will likely never explicitly depend on it.
2013-06-13 15:56:41 -04:00
Cole Robinson
799bca76f3 spec: Make sure libvirt-daemon-config-network is installed (bz 950329) 2013-05-27 18:41:40 -04:00
Cole Robinson
a0961e35b7 spec: Unconditionally add default-graphics=spice (bz 965864) 2013-05-27 18:40:11 -04:00
Cole Robinson
d8deda4264 spec: Make sure virt-manager pulls in -common (bz 958730) 2013-05-09 18:32:30 -04:00
Cole Robinson
a3da77dab6 spec: Fix dep on vte (bz 958945) 2013-05-09 18:24:09 -04:00
Cole Robinson
a58442ec3e Remove AUTHORS
Kind of a maintenance pain, and it's just poorly duplicating info
from the git logs. We could autogenerate this but I don't really
have the interest in figuring it out. Patches welcome :)
2013-04-21 14:05:06 -04:00