Commit Graph

54 Commits

Author SHA1 Message Date
Cole Robinson
226c4562d5 virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
Giuseppe Scrivano
f4365b669a console: prevent access to deleted objects
last commits revealed that some objects can still be accessed by
registered callbacks after the console is closed.  Unregister these
callbacks.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-02 15:31:41 +02:00
Cole Robinson
d17cf4a223 console: vnc: Don't force keyboard grab before widget is realized
Causes gtk warnings on the console, and the code was mistaken anyways
2014-05-31 19:40:18 -04:00
Chen Hanxiao
10e199279d console: fix a comment typo
s/arbitray/arbitrary

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-26 23:01:08 +08:00
Chen Hanxiao
b1236c1af0 console: fix a comment typo
s/succesfull/successful

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-22 23:41:04 +08:00
Cole Robinson
a398d245cb Clean up pylint integration
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
2014-04-02 19:00:24 -04:00
Cole Robinson
8562c3258e More pylint fixes 2014-03-22 11:21:19 -04:00
Kjö Hansi Glaz
66d146acee Add a gsetting key to disable keyboard grabbing
Add a gsetting key to disable keyboard grabbing that works the same way
as spicy when unchecking "Options" > "Grab keyboard when active and
focused".
2014-03-10 14:54:58 -04:00
Chen Hanxiao
7dfdbb3f35 Fix some pylint
Two bad-indentation fixed.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-01 11:23:42 +08:00
Maros Zatko
dfa23765b5 vmmConsolePages: toggle visibilities on page change 2014-02-28 14:29:48 -05:00
Cole Robinson
4a2493f1e4 console: Fix unsetting 'resize-guest' property from UI
Reported in the followup of bz 754559
2014-02-28 11:47:05 -05:00
Cole Robinson
99eaf059ae Fix deprecation warnings on F21/rawhide 2014-02-25 15:57:38 -05:00
Kristóf Marussy
256052d389 console: Improve resize-guest when scaling is enabled 2014-02-08 10:14:50 -05:00
Cole Robinson
bff94f2365 console: Support spice 'resize-guest' (bz 754559)
This will auto change the guest resolution to match the window size.
Off by default, can be enabled like scaling preferences.
2014-01-31 10:08:18 -05:00
Cole Robinson
382543e15f console: Clean up scaling function names 2014-01-30 19:15:02 -05:00
Cole Robinson
b9bbf4686d console: Bunch of scaling fixes (bz 969416)
Make scaling=always work correctly with spice
Make 'resize to vm' work with scaling enabled
Simplify it all
2014-01-30 12:49:50 -05:00
Cole Robinson
3cd47c9e9f console: Make sure viewer exists before setting grab_keys 2014-01-29 13:07:43 -05:00
Cole Robinson
0a77093cbc console: Handle ipv6 addresses (bz 974126) 2014-01-29 11:02:54 -05:00
Cole Robinson
20088ab8fb Move many shared UI functions to addhw static functions
Much of uihelpers is just simple stuff that's shared between addhw
and details UI, so just make it staticmethods in addhw, which details
already has a reference to.
2014-01-26 17:09:07 -05:00
Cole Robinson
febd8bf4e5 Disable accelerators when serial console has focus (bz 1018822) 2013-12-18 16:31:48 -05:00
Cole Robinson
bcfa8d287f serialcon: Release the text console when the VM window is closed (bz 1016445) 2013-11-09 17:54:47 -05:00
Giuseppe Scrivano
0df75c7603 headers: update "Red Hat, Inc." copyright for the year 2013
Ensure that any file touched by a @redhat.com author in 2013 has an
updated copyright header.

The files were updated using the build-aux/update-copyright gnulib
script and manually added where the copyright line wasn't present.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:22:26 +01:00
Cole Robinson
79196cdfcf console: Fix console_active() logic 2013-10-06 15:30:01 -04:00
Cole Robinson
db6ef91b0b console: spice: don't set port=None
Can happen if defaultMode=secure, only a tlsport is allocated
2013-10-03 15:54:15 -04:00
Cole Robinson
2759d674b8 console: Make fullscreen toolbar retract a bit slower 2013-09-25 13:03:03 -04:00
Cole Robinson
1683d56b8d ui: Set non-stock button images in glade, not explicitly in code 2013-09-22 12:33:02 -04:00
Cole Robinson
0551d8956b error: Rename confusing sync/async param to modal 2013-09-06 20:16:37 -04:00
Cole Robinson
0eab1706cc console: Fix password screen issue
Connect to remote URI, connect to VNC guest with password auth. Don't
enter password, just close the details window. Reopen the window,
password UI is still there, but it's no longer hooked up behind the
scenes. Fix it.
2013-09-06 19:55:46 -04:00
Cole Robinson
5bf63759b6 console: Fix issues with spice and askpass (bz 811346)
Spice opens many FDs to handle different channels (display, usb, sound,
etc.). For remote SSH URIs, this means we launch multiple SSH proceses.
We do so by forking off the process, and when SSH has successfully
authenticated, the data starts flowing.

If using spice + remote SSH w/o SSH keys, you need to put your data
into ssh askpass. askpass wants to own the display for security reasons.

When all the channel requests start coming in, we were launching multiple
ssh processes one after another. This upset askpass and generally
caused havoc in the app.

Add some infrastructure to serialize launching ssh processes. We only
launch the next ssh process if spice/vnc have conclusively connected
or errored out the connection. This makes connection a bit slower
for the non-askpass ssh case (about 1.5 seconds), but will ignore
avoid this oft reported problem.
2013-09-06 19:36:09 -04:00
Cole Robinson
10161a8fdb details: Track serial pages as console tabs
A bit cleaner conceptually, and shrinks the ever growing details.py
2013-09-01 17:40:38 -04:00
Cole Robinson
cdc82e62a2 console: Fix spice with TLS (bz #904295)
We now use the same CA trust store as virt-viewer's default, which is:

~/.spicec/spice_truststore.pem
2013-09-01 16:09:35 -04:00
Cole Robinson
82ef6ba173 console: Catch spice connection errors (bz #971558) 2013-09-01 13:25:37 -04:00
Cole Robinson
5f497cba41 console: Don't double create spice display
I can't reproduce, but a couple gentoo users have issues that this
fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=981975
2013-07-09 17:50:05 -04:00
Cole Robinson
194cb715a3 console: A few tweaks to usbredir code
- Make sure to set menu item to unsensitive when console closes
- Avoid dep on latest spice-gtk git for channel_type_from_string
- Create usbwidget every time it's requested, like virt-viewer does
- Minor style fixes
2013-07-08 19:13:52 -04:00
Guannan Ren
88f2d1abe0 details: Add auto USB redirection support in console viewer
Add "Redirect USB device" option in console viewer. Initialize and
embed UsbDeviceWidget object from SpiceClientGtk into a dialog to
let user choose available USB devices for redirection.
Throw an error message if USB connection failed.
Auto-redirection is enable by default.

There is race between creating usbredir channel and calling
has_usb_redirection() when initializing spice session like
happening on virt-viwer. So adding a new signal handler
on_details_menu_virtual_manager_activate() to recheck the
status of usbredir channel, set "Redirect USB device" option
sensitive if it is availiable.
2013-07-01 14:33:59 -04:00
Cole Robinson
22f9928a54 Fix some pylint 2013-06-30 14:33:33 -04:00
Cole Robinson
bc13c302de console: Warn if qemu+tcp URI and listen == 127.0.0.1 2013-06-30 11:44:58 -04:00
Cole Robinson
367041a8d7 Revert "details: Add USB redirection support in console viewer"
This reverts commit 7e1e21a26a.

Was accidentally applied while patch was still in review.
2013-06-28 11:12:23 -04:00
Guannan Ren
7e1e21a26a details: Add USB redirection support in console viewer
Add "Select USB devices to redirect" option in console viewer
Initialize and embed UsbDeviceWidget object from SpiceClientGtk into
a dialog to let use choose available USB devices for redirection.
Throw an error message if USB connection failed.
2013-06-24 12:39:11 -04:00
Leonardo Garcia
660178abe1 Permit to delete a running VM.
The VM will be forced off before being deleted.

(crobinso: fix a minor pylint violation)
2013-06-18 08:49:18 -04:00
Cole Robinson
0f8ea6eaa6 baseclass: Clean up non-standard __init__
Only used by console.py, make it more explicit.
2013-06-08 19:25:36 -04:00
Cole Robinson
42bfb8fe19 console: s/console-vnc/console-gfx/g
Just for clarity
2013-04-21 12:10:14 -04:00
Cole Robinson
7e23244096 Port from gconf to gsettings
This unfortunately has a decent amount of fallout: add a wrapper class
in config.py that reduces much of the churn.

Another big piece is that gsettings can't accept arbitrary paths like
gconf would, everything needs to be described in the schema.

Also do a bunch more RPM spec modernizing
2013-04-18 12:43:16 -04:00
Cole Robinson
8ce479f7f8 console: Re-enable accelerator handling
Seems to work fine with F18 gtk versions
2013-04-17 09:32:00 -04:00
Cole Robinson
07e0c92b4b Remove a bunch of outdates FIXME/XXX comments 2013-04-17 09:32:00 -04:00
Cole Robinson
1078facce2 console: Fix keycombo menu location in fullscreen mode 2013-04-15 12:38:53 -04:00
Cole Robinson
a102edaa89 console: Fix broken size-allocate signal 2013-04-15 12:37:37 -04:00
Cole Robinson
d440ec4d0d console: Fix size_allocate arguments 2013-04-15 12:37:37 -04:00
Cole Robinson
079835bfaf Fix other popup menus after gtk3 conversion 2013-04-14 13:16:02 -04:00
Cole Robinson
0d243983d0 Revive pep8 and clean up the code
autopep8 is pretty cool :)
2013-04-13 15:22:43 -04:00