3983 Commits

Author SHA1 Message Date
Maros Zatko
74e6d43903 vmmDetails: toggle visibilities on page change 2014-02-28 14:29:48 -05:00
Maros Zatko
dfa23765b5 vmmConsolePages: toggle visibilities on page change 2014-02-28 14:29:48 -05:00
Cole Robinson
4a2493f1e4 console: Fix unsetting 'resize-guest' property from UI
Reported in the followup of bz 754559
2014-02-28 11:47:05 -05:00
Cole Robinson
b4e4f68376 cli: Add --graphics defaultMode 2014-02-27 17:43:59 -05:00
Cole Robinson
f67df11701 vmm connection: Handle missing storage volumes (bz 1070883)
Similar to what was done in a808bd669293ac66047a716b2e84a5a64c99667b
for the virtinst connection wrapper.
2014-02-27 13:16:21 -05:00
Chen Hanxiao
77553c7e49 ui: disable setting uid/gid_start for user namespace
Libvirt not allowed uid/gid_start
configured as none 0 or not specified.
This patch will disable config uid/gid_start in UI.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-27 10:01:29 +08:00
Chen Hanxiao
c1e7da72b7 cli: add missing remove_first method for --blkiotune
Add missing remove_first method for --blkiotune.
Update related man pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-26 09:38:20 +08:00
Chen Hanxiao
25a50d7b27 delete: fix a typo
s/sharable/shareable

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-26 09:36:16 +08:00
Cole Robinson
99eaf059ae Fix deprecation warnings on F21/rawhide 2014-02-25 15:57:38 -05:00
Cole Robinson
ce64d037bf engine: Fix closing connection when tick() fails (bz 1069351) 2014-02-25 15:17:34 -05:00
Cole Robinson
dd577de636 tests: Remove 'support' module, not very useful these days 2014-02-25 15:06:36 -05:00
Cole Robinson
a2ab8a2643 tests: 'skip' a test if compare check fails
And make latest tests dependent on libvirt.git version
2014-02-25 15:05:58 -05:00
Cole Robinson
0b94c83beb xmlbuilder: Actually import logging 2014-02-25 14:56:54 -05:00
Cole Robinson
3efbefe91a Don't forbid object names that are only all numbers (bz 1067127)
Just let libvirt error, since in the case of things like storage pools
this is totally legitimate.
2014-02-25 14:54:06 -05:00
Cole Robinson
87c2ff1a14 xmlbuilder: Log broken XML if we can't parse it
Related to https://bugzilla.redhat.com/show_bug.cgi?id=1066564
2014-02-25 12:45:15 -05:00
Thorsten Behrens
b5c3fe1da5 Attempt empty path on virDomainBlockStats
libvirt for some backends yields summary domain stats for empty
disk path - which saves us the looping on our side.
2014-02-24 21:38:20 -05:00
Chen Hanxiao
08daebe1aa details: add UI interface for LXC user namespace
We could config user namespace for LXC container
in details->overview page.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 21:37:13 -05:00
Chen Hanxiao
49cbc20b12 domain: add define method for idmap
add define_idmap and get_idmap method.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 21:37:13 -05:00
Chen Hanxiao
a48f75078d virt-install: Add --memtune option
This patch provides the ability to
tune memroy tunable parameters for the domain.
Also add test cases for --memtune option
and update man page.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 21:02:31 -05:00
Chen Hanxiao
6722d2049e tests: update test suites output with the last libvirt
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 11:33:42 +01:00
Chen Hanxiao
0dceb24b3b virtinst: fix an issue of disk bus caculation
commit 466c2bcf9cb07f16690cb41684d67d0265d2d47e
will generate the same index for
'hda' and 'hdaa'.
Also break test cases.

This patch will fix this.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-23 13:31:48 +08:00
Chen Hanxiao
2ace5317e0 addhardware: fix a little typo
s/paams/params

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-23 13:29:08 +08:00
Martin Kletzander
466c2bcf9c disk: calculate the disk bus properly
I forgot to amend this change when changing it the last time.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-19 10:12:53 +01:00
Martin Kletzander
7c437f6a6f addhardware: don't get duplicated disks
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-19 10:11:14 +01:00
Martin Kletzander
4aec369e44 addhardware: Don't clash with different buses using the same prefix
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-18 16:09:12 +01:00
Martin Kletzander
bc5d84b040 addhardware: generate target only if not customizing
Commit 078e1a4d0503d98884b5b61df83021941bf32e8d changed the fact that
disk target was generated only when adding new disk, not when current
disk is being customized, so fix that back.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-18 16:09:12 +01:00
Chen Hanxiao
155bd7da8f cli: unify tag style
Unify tag style, looks a little better.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-18 22:40:39 +08:00
Martin Kletzander
55d5b35e50 Fix generate_target once more
Passing a zero to the generate_target() function's as pref_ctrl
parameter makes the 'if pref_ctrl' conditions obviously false.  Also
the range created was starting from 0 and not from 1.  Apart from
fixing this, also fix tests so they actually test something this time.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-18 08:14:32 +01:00
Cole Robinson
7c516b382c create: Don't alter caps machine list 2014-02-17 11:56:54 -05:00
Cole Robinson
63b27ceae1 caps: Simplify guest lookup routines
Checking for acceleration should always be done, API users can opt out
by requesting a specific domain type.
2014-02-17 11:54:11 -05:00
Cole Robinson
96232ba2f0 details: Don't stretch machine dropdown 2014-02-17 10:28:02 -05:00
Cole Robinson
a37b200f69 create: Fix non-x86 qemu/kvm guest creation 2014-02-17 10:24:59 -05:00
Cole Robinson
0169042c1e connect: Fix connecting to lxc:/// URI 2014-02-17 10:22:24 -05:00
Chen Hanxiao
fa622273a0 delete: fix an improper comment
commit b2a7c396 introduce confirmation before deleting,
we should keep the comment consistent with it.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-17 21:11:49 +08:00
Cole Robinson
b83ee891ab Prep for release 1.0.0 v1.0.0 2014-02-14 18:45:01 -05:00
Cole Robinson
5d5be6df28 Remove some pylint 2014-02-14 11:37:47 -05:00
Cole Robinson
20b103d910 tests: test_inject: Minor fixups 2014-02-14 11:35:29 -05:00
Cole Robinson
63a575f631 network: Fix detecting when network is deleted through the UI 2014-02-14 11:35:00 -05:00
Cole Robinson
f431efc9b7 tests: Don't overwrite mkstemp, just check environment
Since this can interfere with the initrdinject test
2014-02-14 11:02:35 -05:00
Cole Robinson
d9d50db522 ui: Add margins to 'description' text fields 2014-02-14 10:21:21 -05:00
Cole Robinson
e4711061c4 snapshots: Make sure 'current' icon is always visible (bz 1065074) 2014-02-14 10:20:37 -05:00
Cole Robinson
88538f916d connection: Actually fix domain event deregister 2014-02-14 10:00:45 -05:00
Cole Robinson
517fbe0b30 createinterface: Catch error when creating stub (bz 1065042) 2014-02-14 09:27:56 -05:00
Cole Robinson
4b98a471b9 manager: Handle multiple vm-added signals
Our conn.tick idle dispatcher can be racey, handle it in manager.py
2014-02-13 11:17:14 -05:00
Cole Robinson
3f27bc1bd1 connection: Fix race when updating conn.vms
We update the canonical conn.vms list in an idle callback, so any parts
of the main UI thread won't see the conn.vms change while they are
iterating over it.

Problem with this, is that if multiple ticks() are scheduled before
the first idle handler has a chance to run, we can overwrite the VM
list can fail to be correctly updated.

Fix this by only updating 'vms' if it actually changed.
2014-02-13 11:17:14 -05:00
Martin Kletzander
078e1a4d05 Rework disk target assignment
Using previous patches, this one makes the disk target generation a
bit more intelligent, so adding multiple disks with various
controllers is not a problem anymore.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1036716

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
6c4302b0a7 disk: generate target controller-wise
Add an optional parameter to generate_target() that controls what
controller the disk should reside in (using libvirt's rules to create
addresses).

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
a9c791b5b8 Add target_to_num method
Opposite to num_to_target.  It will be used in future patch.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
55e85b1612 Unify prettification of VirtIO serial
Use the same case for occurrences of 'VirtIO' which start with
uppercase V.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Martin Kletzander
4196f4287b Use proper python version
since we work with python2 only, mentioning it in all shebangs make
the commands from git work even when python3 is set as default.

This also fixes one test where command being ran is 'virt-xml' through
subprocess.Popen().

While at that, add '-tt' where possible in order to make everyone use
same indentation characters.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00