Commit Graph

85 Commits

Author SHA1 Message Date
Cole Robinson
6e988e994c details: inspection: Fix UI alignment
Convert the table to a grid to get modern spacing behavior
2017-03-01 16:32:09 -05:00
Pino Toscano
409ae0bcf4 inspection: add a way to refresh the inspection info
Introduce a 'Refresh' button in the 'Information' page of a VM, and
wire it up so a refresh of the inspection data for it is triggered.
2017-03-01 16:25:47 -05:00
Pino Toscano
ebf4ade208 inspection: show OS type in Inspection page
Show also a pretty label for the OS of the guest, in addition to
hostname and product name.
2017-02-09 16:29:27 -05:00
Pavel Hrdina
09cc6f3832 console: add support to forget password
If password for console is saved currently there is no way how to tell
virt-manager to forget that password.  This patch improves the authentication
page in order to provide a way how to forget password simply by unchecking the
"Save this password in your keyring".

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2016-06-07 20:03:27 +02:00
Cole Robinson
0f88ebbc0b console: Enforce text wrapping on 'unavailable' page 2016-05-18 16:32:07 -04:00
Cole Robinson
dfcac3fe9c Bump gtk and pygobject deps to 3.14
We need to bump the gtk dep to at least 3.10 for GtkRevealer usage,
and I want to bump the pygobject higher to drop some bug workarounds.

But since the oldest thing I have that meets those requirements is
RHEL/Centos 7.3 which is at 3.14 for both, set those as the minimum
versions since that's what I'll be testing against. They are still
1.5 years old and only a bit over a year newer than the previous
versions, so it's not a huge change.
2016-05-17 17:49:55 -04:00
Cole Robinson
dc05600324 console: Convert from autodrawer to native Gtk widgets
Gtk 3.10 has a GtkOverlay and GtkRevealer widget which we can
use to more sustainably implement the autodrawer functionality.
2016-05-17 17:49:55 -04:00
Cole Robinson
671d9c0218 ui: details: Make the graphics error label selectable
For copying error messages
2016-05-16 15:19:52 -04:00
Cole Robinson
d32953d8c6 details: Remove UI for vcpu pinning
This UI exposed the old NUMA allocation policy detailed in the last commit.
It's very much sub-optimal, and should be removed.

Manual cpuset configuration is also quite uncommon and not really something
worth exposing in the UI. It can easily be done from the command line
with virt-xml.

If people complain, I'd consider adding a checkbox for vcpu placement=auto,
or an option to do that by default for new VMs.
2015-11-18 15:05:21 -05:00
Cole Robinson
117cad551d ui: Don't mark UI accessibility names as translatable
Because I haven't been using translatable strings...
2015-09-23 17:01:41 -04:00
Cole Robinson
b6111b5e85 details: Fix misaligned labels (bz 1264628)
Shows up with different sized translation strings

https://bugzilla.redhat.com/show_bug.cgi?id=1264628

Reported-by: João Pirralha <joaopirralha@gmail.com>
2015-09-20 12:58:23 -04:00
Cole Robinson
0b881591ec console: Add a separate notebook for serial pages
Rather than the 'offset' page hack we previously did that is hard to
keep track of. This allows for a handful of code simplifications
2015-09-18 12:36:06 -04:00
Cole Robinson
01da21b93a uitests: Add a basic details.py test
Checks all hw of test-many-devices and make sure an error isn't raised
2015-09-14 14:44:39 -04:00
Cole Robinson
16a744749f addhardware: Drop 'storage format' field
Originally this made sense, as it was the only way to specify a non-default
storage format when creating new storage.

Nowadays the storage browser is a full featured storage manager... and
this field is a bit confusing WRT whether it's used for creating new
storage, or informing libvirt about an existing image's format.

Drop it from the addhardware wizard, and simplify what we show in the
details wizard as well.
2015-09-13 19:13:53 -04:00
Cole Robinson
a2bd31c2a6 virt-manager: Drop old style config- prefix for widget names
It's redundant and we haven't followed that pattern for a long while
2015-09-13 18:01:39 -04:00
Cole Robinson
4b5e65fe8d details: Remove iotune UI
This is a little low level and rarely used IMO to have it in the UI.
If people want to edit this we should point them at virt-xml which
seems like the appropriate user friendlyness for this feature.
2015-09-13 15:54:47 -04:00
Cole Robinson
5c66328e10 uitests: Several more 'New VM' tests, and cli --show tests 2015-09-09 19:07:31 -04:00
Cole Robinson
531260be36 details: Raise upper limits for lxc ID namespaces (bz 1244490) 2015-08-10 13:14:37 -04:00
Cole Robinson
68ce97d533 create: customize: cancel now cancels the entire installation
Trying to fall back to the create wizard can give weird results, since
it's really hard to ensure the customized changes are preserved if
the user changes things in the 'new' wizard.
2015-05-03 16:53:43 -04:00
Cole Robinson
92c42bc5a0 details: Improve UI labeling of keyboard devices 2015-04-09 13:36:40 -04:00
Cole Robinson
1d98af2c47 create: Move mac address editing to customize dialog
People should rarely need to edit the mac address, so remove it from
the create wizard. However we only allow editing the mac address in
the 'customize' dialog: regular network details disables editing, since
that should be a rare and potentially dangerous operation.
2015-04-07 18:52:35 -04:00
Cole Robinson
39b5d11628 details: Make CPU config a frame, not an expander
It's very commonly tweaked, so move it front and center.
2015-04-07 11:53:16 -04:00
Chen Hanxiao
101ca3cef8 details: change duplicated short-key 'd' to 'e' on Overview tab
add hardware also use 'd' as its short-key.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-03-16 21:26:47 -04:00
Giuseppe Scrivano
61e06856a3 virt-manager: Allow to change SGIO with LUN disk devices
It is added only in the details window, and intentionally not added to
the addhardware UI to keep it simpler.  Users can edit this after a
new device is added.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-03-16 20:32:40 +01:00
Cole Robinson
0ddec9199b details: Don't allow changing machine type for existing VM
But still allow it from the customize dialog. It's one of those things
that rarely can be changed for a working VM and things continue to work.
2015-02-22 10:25:51 -05:00
Chen Hanxiao
751d189110 ui: remove underline property of tpm device type in details
We could not modify tpm device type yet.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-31 14:28:22 +08:00
Giuseppe Scrivano
2dff68c1df virtManager: Add missing shortcut keys
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1172108

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-12-13 15:42:46 +01:00
Chen Hanxiao
e0b5283ac3 Redirect device: remove underline property of 'Type' in details UI
redir-type is a label.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:10:14 +08:00
Chen Hanxiao
71613d95e8 Smartcard device: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:08:02 +08:00
Chen Hanxiao
34f9be43c2 sound: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:07:33 +08:00
Chen Hanxiao
8f2c9b354a cpu: add mnemonics in details UI
Add mnemonics for 'Configuration' page,
'Topology' page, 'Pinning' page
and their sub-pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:06:47 +08:00
Chen Hanxiao
0368394c7e boot options: add mnemonics in details UI
Add mnemonics for 'Direct kernel' page
and sub-pages.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:06:13 +08:00
Chen Hanxiao
e758aec861 video: add missing mnemonics in details UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:05:38 +08:00
Chen Hanxiao
351d0a2834 details: add shortkey for controller model
shortkey 'o' for 'Model'.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:04:28 +08:00
Chen Hanxiao
ce7fd785e4 watchdog: add missing mnemonics in details UI
add missing mnemonics and fix an duplicated shortkey

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-11-11 16:02:02 +08:00
Wei Huang
dea3520ea8 ui: add a warning message for hyper-threading support
Not all CPUs support Hyper-Threading. This patch adds a warning
message next to the threads selection field of processor topology
box. It warns that "Selected CPU model does not support
Hyper-Threading" when # of Threads > 1 and the selected CPU model
does not support Hyper-Threading.

This UI modification was added using glade 3.18.3.

Signed-off-by: Wei Huang <wei@redhat.com>
2014-10-27 18:05:21 -04:00
Chen Hanxiao
8f077a270f panic notifier: remove shortcuts in details.ui
We could not modify them in panic notifier page,
so remove them.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:07:35 +08:00
Chen Hanxiao
b5fd41135d details: add missing mnemonics in cpu UI tab
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:05:52 +08:00
Cole Robinson
439e5ad0fe details: Reorg a bunch of the global helpers
Some were redundant, some should be in virtinst
2014-09-20 10:23:19 -04:00
Cole Robinson
4ad50d968a details: Put tabs on left, easier to navigate with glade 2014-09-20 10:21:27 -04:00
Cole Robinson
55739055fd ui: Set all files to minimum requirement of gtk 3.8
That way gives us better feedback from glade
2014-09-19 21:19:26 -04:00
Cole Robinson
ae26313ed4 details: Add UI for enabling UEFI via 'customize before install'
We expose a simple combobox with two entries: BIOS, and UEFI. The
UEFI option is only selectable if 1) libvirt supports the necessary
domcapabilities bits, 2) it detects that qemu supports the necessary
command line options, and 3) libvirt detects a UEFI binary on the
host that maps to a known template via qemu.conf

If those conditions aren't met, we disable the UEFI option, and show
a small warning icon with an explanatory tooltip.

The option can only be changed via New VM->Customize Before Install.
For existing x86 VMs, it's a readonly label.
2014-09-17 18:43:41 -04:00
Cole Robinson
cc70aa82ab ui: Fix minor issues, and resave all files with f21 glade 2014-09-06 15:01:12 -04:00
Chen Hanxiao
2f4a424521 use binary prefixes for units where appropriate
https://bugzilla.redhat.com/show_bug.cgi?id=1103893

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:56:53 +08:00
Cole Robinson
f686e36e42 details: Expose chipset=i440fx/q35 in customize dialog
So enterprising users can choose q35 for x86 qemu/kvm VMs. Some
discussion over here:

http://www.redhat.com/archives/virt-tools-list/2014-May/msg00001.html
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00019.html

We show a warning if q35 is selected, saying it's not well tested.
Hopefully that dissuades people who are just clicking about.
2014-06-03 15:58:04 -04:00
Cole Robinson
091eb9fe26 details: Expose LXC <initarg> 2014-05-31 17:34:23 -04:00
Cole Robinson
9fd0ef5c88 details: Better handling for <input type=keyboard> 2014-05-04 13:23:54 -04:00
Cole Robinson
70da20682c details: Explicit warn that 'format' doesn't change image format (bz 1089457) 2014-04-21 17:04:33 -04:00
Maros Zatko
44d4c1d329 details-toolbar: set show_arrow to true 2014-02-28 14:29:48 -05:00
Chen Hanxiao
77553c7e49 ui: disable setting uid/gid_start for user namespace
Libvirt not allowed uid/gid_start
configured as none 0 or not specified.
This patch will disable config uid/gid_start in UI.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-27 10:01:29 +08:00