shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-25 23:21:45 +03:00
Code Issues Projects Releases Wiki Activity
4,434 Commits 2 Branches 64 Tags 98 MiB
792774450f
Commit Graph

76 Commits

Author SHA1 Message Date
Cole Robinson
792774450f console: Properly cleanup viewer when closing 
Otherwise signals aren't properly removed, can cause some backtraces on
shutdown.
 2015-04-12 09:53:23 -04:00
Cole Robinson
aec851f73a viewers: Always clean up tunnel FDs when closing viewer 
We were basically leaking a lot of FDs. They were still being tracked
but they were stranded and never dealt with.
 2015-04-11 22:44:03 -04:00
Cole Robinson
285e345f17 viewer: Simplify tunnel handling 
- Cache ginfo, since it is tied to a single viewer instance
- Always create the sshtunnels object
- Track lock state so we can make it idempotent
 2015-04-11 21:39:24 -04:00
Cole Robinson
fc171fc31d connection: Bunch of minor tweaks handling TCP URIs 2015-04-11 12:08:57 -04:00
Cole Robinson
a3f8d73a9c libvirtobject: Unify internal status APIs and signals 
Drop config-changes vs. status-changed and just use one signal, since they
are largely the same code paths for all users.
 2015-04-10 15:00:34 -04:00
Cole Robinson
03dbbac806 console: Make API used by vmmDetails explicit 
And hide everything else. Similar to what we did with the Viewers, this
should help clarify what the boundaries are here.
 2015-04-03 21:34:03 -04:00
Cole Robinson
f589f01665 console: Move viewer classes to viewers.py 2015-04-03 20:54:38 -04:00
Cole Robinson
3b671a9ac3 console: Large amount of internal API tidying 
It's very difficult to tell what bits of Viewer that vmmConsolePages
accesses, and what bits of vmmConsolePages that vmmDetails will access.

Clean up the Viewer side with consistent function names, lots of comments,
and privatizing everything that shouldn't be shared.

Yeah this is a big ugly commit...
 2015-04-03 20:43:48 -04:00
Cole Robinson
87c5094745 details: Don't access console.viewer directly 
Add accessors for everything details.py needs. Makes separation clearer
 2015-03-26 13:16:50 -04:00
Cole Robinson
26abb5a2b5 console: Drop _has_property 
All these checks are redundant with modern deps
 2015-03-26 13:10:38 -04:00
Marc Deslauriers
8574eedd2e virt-manager: Don't clear all page visibilities during initialization 
Since commit dfa23765, page_changed() sets page visibilities based on the
value of the newpage parameter. Calling the function without it being set
makes all pages invisible at once during initialization, resulting in a
weird scenario which prevents the window from getting proper focus events
when another window partially overlaps it, resulting in stuck grabs.
Message-Id: <55114787.6070401@canonical.com>
 2015-03-24 12:36:16 -04:00
Cole Robinson
7a1b7b69e3 Drop non-ascii text from files 
Seems to be tripping up coverage output on f22
 2015-03-23 15:56:55 -04:00
Cole Robinson
a2109f922c console: Drop custom usb format string 
It's just recreating the default, and causes a headache with translations
 2015-02-11 13:14:19 -05:00
Cole Robinson
c090d18beb console: Show multiple graphics devices in menu list 
But actually switching to one isn't supported, so show a tooltip to
that effect.
 2014-12-03 12:21:57 -05:00
Cole Robinson
ef99daa3d1 console: Rework serial menu building 
Mostly code reorg with some minor bug fixes thrown in.
 2014-12-03 12:14:32 -05:00
Cole Robinson
0b391fe9ed virt-manager: Enforce gobject introspection versions 
This is needed with freebsd and opensuse at least. See:

https://bugzilla.suse.com/__show_bug.cgi?id=901869
http://www.redhat.com/archives/libvir-list/2014-December/msg00184.html
 2014-12-02 14:01:28 -05:00
Giuseppe Scrivano
5c68542151 console: switch to CONSOLE_PAGE_UNAVAILABLE while waiting for login 
It fixes a race condition if the ERROR_AUTH error if received while
still on the CONSOLE_PAGE_AUTHENTICATE and skipping the page_changed
event.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1165990

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-11-20 15:51:16 +01:00
Giuseppe Scrivano
f19a07d5a5 virt-manager: close the SPICE main channel on an AUTH error 
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1152981

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-10-28 14:59:21 +01:00
Guido Günther
1726505fd6 s/gconf/gsettings/ 
GConf got replaced by GSettings but some methods kept the old name
 2014-09-29 08:56:37 -04:00
Cole Robinson
6a9aa6827b console: Break out tunnel handling to its own file 2014-09-21 13:38:53 -04:00
Cole Robinson
e1b646594c console: Hide display widget from consumers 
There were several layering violations, make it explicit by making
display private, and providing APIs for everything the consumers
need.
 2014-09-21 13:25:43 -04:00
Cole Robinson
a3bd1b26a9 console: Clarify keyboard grab default handling 2014-09-21 13:06:25 -04:00
Cole Robinson
226c4562d5 virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
Giuseppe Scrivano
f4365b669a console: prevent access to deleted objects 
last commits revealed that some objects can still be accessed by
registered callbacks after the console is closed.  Unregister these
callbacks.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-07-02 15:31:41 +02:00
Cole Robinson
d17cf4a223 console: vnc: Don't force keyboard grab before widget is realized 
Causes gtk warnings on the console, and the code was mistaken anyways
 2014-05-31 19:40:18 -04:00
Chen Hanxiao
10e199279d console: fix a comment typo 
s/arbitray/arbitrary

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-04-26 23:01:08 +08:00
Chen Hanxiao
b1236c1af0 console: fix a comment typo 
s/succesfull/successful

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-04-22 23:41:04 +08:00
Cole Robinson
a398d245cb Clean up pylint integration 
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
 2014-04-02 19:00:24 -04:00
Cole Robinson
8562c3258e More pylint fixes 2014-03-22 11:21:19 -04:00
Kjö Hansi Glaz
66d146acee Add a gsetting key to disable keyboard grabbing 
Add a gsetting key to disable keyboard grabbing that works the same way
as spicy when unchecking "Options" > "Grab keyboard when active and
focused".
 2014-03-10 14:54:58 -04:00
Chen Hanxiao
7dfdbb3f35 Fix some pylint 
Two bad-indentation fixed.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-03-01 11:23:42 +08:00
Maros Zatko
dfa23765b5 vmmConsolePages: toggle visibilities on page change 2014-02-28 14:29:48 -05:00
Cole Robinson
4a2493f1e4 console: Fix unsetting 'resize-guest' property from UI 
Reported in the followup of bz 754559
 2014-02-28 11:47:05 -05:00
Cole Robinson
99eaf059ae Fix deprecation warnings on F21/rawhide 2014-02-25 15:57:38 -05:00
Kristóf Marussy
256052d389 console: Improve resize-guest when scaling is enabled 2014-02-08 10:14:50 -05:00
Cole Robinson
bff94f2365 console: Support spice 'resize-guest' (bz 754559) 
This will auto change the guest resolution to match the window size.
Off by default, can be enabled like scaling preferences.
 2014-01-31 10:08:18 -05:00
Cole Robinson
382543e15f console: Clean up scaling function names 2014-01-30 19:15:02 -05:00
Cole Robinson
b9bbf4686d console: Bunch of scaling fixes (bz 969416) 
Make scaling=always work correctly with spice
Make 'resize to vm' work with scaling enabled
Simplify it all
 2014-01-30 12:49:50 -05:00
Cole Robinson
3cd47c9e9f console: Make sure viewer exists before setting grab_keys 2014-01-29 13:07:43 -05:00
Cole Robinson
0a77093cbc console: Handle ipv6 addresses (bz 974126) 2014-01-29 11:02:54 -05:00
Cole Robinson
20088ab8fb Move many shared UI functions to addhw static functions 
Much of uihelpers is just simple stuff that's shared between addhw
and details UI, so just make it staticmethods in addhw, which details
already has a reference to.
 2014-01-26 17:09:07 -05:00
Cole Robinson
febd8bf4e5 Disable accelerators when serial console has focus (bz 1018822) 2013-12-18 16:31:48 -05:00
Cole Robinson
bcfa8d287f serialcon: Release the text console when the VM window is closed (bz 1016445) 2013-11-09 17:54:47 -05:00
Giuseppe Scrivano
0df75c7603 headers: update "Red Hat, Inc." copyright for the year 2013 
Ensure that any file touched by a @redhat.com author in 2013 has an
updated copyright header.

The files were updated using the build-aux/update-copyright gnulib
script and manually added where the copyright line wasn't present.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2013-10-28 17:22:26 +01:00
Cole Robinson
79196cdfcf console: Fix console_active() logic 2013-10-06 15:30:01 -04:00
Cole Robinson
db6ef91b0b console: spice: don't set port=None 
Can happen if defaultMode=secure, only a tlsport is allocated
 2013-10-03 15:54:15 -04:00
Cole Robinson
2759d674b8 console: Make fullscreen toolbar retract a bit slower 2013-09-25 13:03:03 -04:00
Cole Robinson
1683d56b8d ui: Set non-stock button images in glade, not explicitly in code 2013-09-22 12:33:02 -04:00
Cole Robinson
0551d8956b error: Rename confusing sync/async param to modal 2013-09-06 20:16:37 -04:00
Cole Robinson
0eab1706cc console: Fix password screen issue 
Connect to remote URI, connect to VNC guest with password auth. Don't
enter password, just close the details window. Reopen the window,
password UI is still there, but it's no longer hooked up behind the
scenes. Fix it.
 2013-09-06 19:55:46 -04:00