3 Commits

Author	SHA1	Message	Date
Cole Robinson	f27e203732	cli: Skip MAC collision error with --check mac_in_use= ... There's valid cases where a VM can be defined with a conflicting MAC address. Prior to ebd6091cc8 and related refactorings we were more lax here if the conflicting VM wasn't running, but now we are blocking some valid usage. Hoist the validation check up to cli.py and add --check mac_in_use=off to skip the validation. Advertise it like we do for other checks, so now a collision error will look something like: The MAC address '22:11:11:11:11:11' is in use by another virtual machine. (Use --check mac_in_use=off or --check all=off to override) Reported-by: Pino Toscano <ptoscano@redhat.com> Signed-off-by: Cole Robinson <crobinso@redhat.com>	2020-07-06 10:17:10 -04:00
Cole Robinson	140a1f3b15	cloner: Drop ability to clone a paused VM ... Generally this doesn't work with qemu metadata locking nowadays, and it was never a safe idea to begin with, because disk contents could be in an inconsistent state. https://bugzilla.redhat.com/show_bug.cgi?id=1725330 Signed-off-by: Cole Robinson <crobinso@redhat.com>	2020-01-29 18:34:38 -05:00
Cole Robinson	8fe0a208db	Move virt-* code into their modules ... This layout is closer to what most python modules have nowadays. It also simplifies testing and static analysis setup. Keep virt-* wrappers locally, for ease of running these commands from a git checkout. Adjust the wrapper binaries we install on via packaging to be pure python, which makes things like running gdb easier. Signed-off-by: Cole Robinson <crobinso@redhat.com>	2020-01-26 18:27:20 -05:00