4223 Commits

Author SHA1 Message Date
Chen Hanxiao
8f077a270f panic notifier: remove shortcuts in details.ui
We could not modify them in panic notifier page,
so remove them.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:07:35 +08:00
Chen Hanxiao
6f196ed21d panic-notifier: add missing mnemonics in addhardware UI
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:06:14 +08:00
Chen Hanxiao
b5fd41135d details: add missing mnemonics in cpu UI tab
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 16:05:52 +08:00
Chen Hanxiao
7752d60cfe ui: change fs-type label ID from "label18" to "fs-type-title"
It looks not very social as its naming.
And it will be used in the later patch.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-21 10:23:59 +08:00
Chen Hanxiao
64e7e783e7 ui: change duplicated fsdetail shortkey
shortkey M for fs-mode in fsdetail duplicate shortkey of
"Virtual Machine" in details.
change it to 'o'.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-17 17:18:53 +08:00
Giuseppe Scrivano
750eeaad98 virt-manager, details: properly check for pool presence
commit 5e8f35f5e6d2f86a6846e3725885980eb51a5eae introduced this
problem.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-14 12:23:08 +02:00
Giuseppe Scrivano
8f1aa5a4f0 virt-manager, delete: fix path for disk type='volume'
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-14 12:23:08 +02:00
Lubomir Rintel
835d40b151 addhardware, details: STOCK_DIRECTORY is gone
It's no longer present in Gtk+ 3.14 and deprecated since at least 3.10 in favor
of named "folder" icon. That seems a good fit, a quick check on my system finds
it present in all themes that are available.
2014-10-06 12:14:14 -04:00
Giuseppe Scrivano
ea0cded87b spec: add a dependency on "gnome-icon-theme"
virt-manager uses some icons included in the gnome-icon-theme package.
Make it explicit and add a dependency.

Desktop folks agree that this is the place where to add this
dependency as adding it to gtk is too problematic.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146612

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-06 17:47:24 +02:00
Chen Hanxiao
52744fadf8 man: update binary prefixes for units in virt-install man page
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-10-06 09:50:55 +08:00
Cole Robinson
a4db445a45 spec: Install the gconf .convert file 2014-09-30 08:41:37 -04:00
Giuseppe Scrivano
4c978f70cb doc, virt-clone: make --quiet consistent with --help output
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-30 14:33:05 +02:00
Giuseppe Scrivano
bfeed049b8 doc, virt-install: do not use obsoleted --file/--file-size
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-30 14:33:05 +02:00
Guido Günther
1726505fd6 s/gconf/gsettings/
GConf got replaced by GSettings but some methods kept the old name
2014-09-29 08:56:37 -04:00
Guido Günther
a41e2c6f5a Add conversion file to migrate GConf values to GSettings
This makes sure we don't lose already configured connections.

Reference: http://bugs.debian.org/740047
2014-09-29 08:56:14 -04:00
Cole Robinson
bf6af370c6 sshtunnels: Clarify a logging message 2014-09-29 08:55:47 -04:00
Cole Robinson
d1f36ac875 domain: Fix defining domain after migration 2014-09-29 08:55:47 -04:00
Giuseppe Scrivano
5e8f35f5e6 virt-manager, details: fix path and size for disk type='volume'
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-26 16:24:59 +02:00
Giuseppe Scrivano
cce5827195 virtinst: add support for disk type="volume"
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-26 16:24:59 +02:00
Cole Robinson
69b131f81f engine: Clarify a debug message 2014-09-25 10:13:20 -04:00
Cole Robinson
3e5a20aaf1 addhardware: Fix attaching USB/PCI hostdev (bz 1146297) 2014-09-24 20:12:38 -04:00
Cole Robinson
310f65273f osdict: Restrict n-cpus to 1 for machvirt
It fails to boot otherwise
2014-09-23 17:09:36 -04:00
Cole Robinson
318ac3df55 guest: Add clarifying comment 2014-09-23 16:19:54 -04:00
Cole Robinson
42ac7a3036 guest: Set optimal arm CPU defaults
If doing arm kvm, use cpu=host. Otherwise, specify cortex-a57 for aarch64
so we actually get a 64bit cpu
2014-09-23 16:18:23 -04:00
Cole Robinson
c4162f6708 Use -M virt as default machine for arm/aarch64
Centralize the default machine logic in caps and use it consistently
2014-09-23 16:05:48 -04:00
Cole Robinson
0182ba3ead guest: Use virtio for arm -M virt
In fact it's the only thing it supports
2014-09-23 15:12:02 -04:00
Cole Robinson
81fdc1e5e5 guest: Clarify a function name 2014-09-23 15:09:35 -04:00
Cole Robinson
92db9bd4dd tests: Add some more arm tests
Many are broken for now, but they will help validate we are setting
the correct defaults with subsequent patches.
2014-09-23 15:08:47 -04:00
Cole Robinson
c216302743 tests: capabilities: Add aarch64 test data 2014-09-23 14:56:44 -04:00
Cole Robinson
86417d42ca osxml: Ensure kernel/initrd/dtb are absolute paths 2014-09-23 14:32:01 -04:00
Cole Robinson
4c4bdbb8b8 cli: Allow embedding comma in kernel_args
And fix can_comma for aliases
2014-09-23 14:14:21 -04:00
Cole Robinson
30db9ece22 osdict: Add qemu-ga for RHEL6 and RHEL7 guests (bz 1139109) 2014-09-22 17:33:55 -04:00
Cole Robinson
e1c803dc7c osdict: Only list latest point release in virt-manager
So only list RHEL6.5, and not 6.4-6.0 as well. That earlier versions
can be seen by selecting 'show all options'
2014-09-22 17:20:07 -04:00
Laszlo Ersek
3e5b61da86 domain: relax the UNDEFINE_NVRAM condition precisely to libvirtd's one
(1) A separate nvram (ie. variable store) file for the domain exists if
and only if the following condition holds:

    (self.get_xmlobj().os.loader_ro is True and
     self.get_xmlobj().os.loader_type == "pflash")

(Refer to libvirtd's qemuPrepareNVRAM() function, as of commit 742b08e30.)

(2) The

    self.get_xmlobj().os.nvram

condition is sufficient, but not necessary, for the separate varstore file
to exist. That is, if the condition holds, then the separate varstore file
exists for sure, but if the condition doesn't hold, the file may exist
nonetheless. (Because libvirtd can auto-generate the varstore file's
pathname.)

This means that requiring condition (2) for setting UNDEFINE_NVRAM on
domain deletion will miss a subset of the cases, ie. when the necessary
and sufficient condition (1) holds, but the sufficient-only condition (2)
doesn't.

Make sure that the code uses the necessary and sufficient condition (1).

Signed-off-by: Laszlo Ersek <lersek@redhat.com>
2014-09-22 12:32:31 -04:00
Cole Robinson
b3fa8bb650 tests: Ensure osdict.py aliases is never extended 2014-09-21 15:26:03 -04:00
Cole Robinson
662922dc95 createinterface: Use inactive XML for embeding child XML
The inactive XML will drop things like complex protocol output and
link state info, which netcf can choke on for sub interfaces.
2014-09-21 15:04:16 -04:00
Cole Robinson
bd0bcba0b5 createinterface: Fix 'copy child protocol' behavior (bug 1122743)
We should only copy the inactive protocol XML, which lists things
like dhcp, vs the running XML, which is the same format as static
addressing.
2014-09-21 15:02:27 -04:00
Cole Robinson
6a9aa6827b console: Break out tunnel handling to its own file 2014-09-21 13:38:53 -04:00
Cole Robinson
e1b646594c console: Hide display widget from consumers
There were several layering violations, make it explicit by making
display private, and providing APIs for everything the consumers
need.
2014-09-21 13:25:43 -04:00
Cole Robinson
a3bd1b26a9 console: Clarify keyboard grab default handling 2014-09-21 13:06:25 -04:00
Cole Robinson
4568cdb636 module_trace: Only show main thread APIs by default 2014-09-21 12:05:02 -04:00
Cole Robinson
f4563906ca snapshots: Use consistent button layout with host dialog
Except 'refresh' is in place of 'stop'
2014-09-21 11:44:01 -04:00
Cole Robinson
df50fdc323 testdriver: Add a host-model and host-passthrough usage 2014-09-21 10:17:51 -04:00
Cole Robinson
b0d5198b7a virt-manager: Switch 'Copy host' to use host-model (bz 1133155)
Similar to the previous change for virt-install
2014-09-20 20:44:14 -04:00
Cole Robinson
eda5eea549 virt-install: Switch --cpu host to use host-model, not copy (bz 1133155)
host-model offers us other protections now, like ensuring we don't try
to use a host cpu feature that qemu doesn't support.

http://bugzilla.redhat.com/show_bug.cgi?id=1133155
2014-09-20 20:44:13 -04:00
Cole Robinson
64106230bd virt-install: Add hidden option --test-media-detection
Can help with debugging and test cases
2014-09-20 20:32:19 -04:00
Cole Robinson
3933ff101b guest: Limit number of default usb redirdevs to 2 (bug 1135488)
If we use 4 devices here, we fill up all the emulated USB2 slots,
and directly assigned devices are forced to fall back to USB1

https://bugzilla.redhat.com/show_bug.cgi?id=1135488
2014-09-20 20:16:31 -04:00
Cole Robinson
99700821c6 virt-install: Reorder --help output a bit 2014-09-20 19:30:16 -04:00
Cole Robinson
d7e1a40352 virt-install: Deprecate --nodisks in favor of --disk none 2014-09-20 19:16:13 -04:00
Cole Robinson
57ae284ad4 virt-install: Deprecate --nonetworks in favor of --network none
Follows the pattern used by the other cli options
2014-09-20 19:02:38 -04:00