shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-12 09:18:00 +03:00
Code Issues Projects Releases Wiki Activity
6,519 Commits 2 Branches 64 Tags 99 MiB
9d78759ac5
Commit Graph

41 Commits

Author SHA1 Message Date
Cole Robinson
11ffe2e569 addstorage: separate device building and explicit validation 
Have two clear paths. This will be useful when we add direct XML
editing UI
 2019-04-14 20:22:02 -04:00
Cole Robinson
eb870e4658 addstorage: Drop prompting to start default pool 
Just let virtinst try and start it for us, and fail if it's the
startup fails. Prompting about this doesn't really buy us anything
 2019-04-14 20:22:02 -04:00
Cole Robinson
425f599c84 device: disk: Move all path search handling to diskbackend 
Simplify it slightly by combining return output and removing
an entry point. Add some additional test cases for it
 2018-10-11 19:11:16 -04:00
Cole Robinson
c5033c02d5 fsdetails: Use combo entry for format list 
And stop listing all the crazy qemu formats
 2018-09-06 13:28:21 -04:00
Daniel P. Berrangé
48e32b429d Fix copyright header to specify GPLv2 or later, not GPLv2 only. 
The copyright headers in every file were chjanged in this previous commit

  commit b6dcee8eb7
  Author: Cole Robinson <crobinso@redhat.com>
  Date:   Tue Mar 20 15:00:02 2018 -0400

    Use consistent and minimal license header for every file

Where before this they said "

  "either version 2 of the License, or (at your option) any later version."

Now they just say

  "GNU GPLv2"

This fixes it to say "GNU GPLv2 or later" again.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
 2018-04-04 16:51:37 -04:00
Cole Robinson
b6dcee8eb7 Use consistent and minimal license header for every file 2018-03-21 07:29:40 -04:00
Cole Robinson
1c911ce567 virtinst: Give device classes consistent DeviceX naming 
Previous state was inconsistenty and needlessly wordy. Fix up
a few other class namings that have redundant Virtual in the name
 2018-03-21 07:29:40 -04:00
Cole Robinson
20d5c1887a baseclass: Export GObject.SignalFlags.RUN_FIRST 
Saves some typing and imports
 2018-03-15 21:24:48 -04:00
Radostin Stoyanov
978fb25ac7 Wrap keys(), values() in a list 
In Python 3 dict.values() [1] , dict.keys() [2] and dict.items() [3]
return a view [4] of the dictionary’s values, keys and items.

In Python 2 these functions return a list. [5] [6] [7]

To resolve this we can convert the result of these function to a list.

[1] https://docs.python.org/3/library/stdtypes.html#dict.values
[2] https://docs.python.org/3/library/stdtypes.html#dict.keys
[3] https://docs.python.org/3/library/stdtypes.html#dict.items
[4] https://docs.python.org/3/library/stdtypes.html#dict-views
[5] https://docs.python.org/2/library/stdtypes.html#dict.items
[6] https://docs.python.org/2/library/stdtypes.html#dict.keys
[7] https://docs.python.org/2/library/stdtypes.html#dict.values
 2018-02-06 18:49:17 -05:00
Radostin Stoyanov
dff00d4fc0 Remove deprecated statvfs module 
The statvfs module has been removed in Python 3. [1]
It is replaced by os.statvfs which is also available in Pyhton 2.

[1] https://docs.python.org/2/library/statvfs.html#module-statvfs
[2] https://docs.python.org/3/library/os.html#os.statvfs
 2017-10-20 11:49:14 -04:00
Radostin Stoyanov
b93cc3bbc9 pycodestyle: Do not use bare 'except:' 
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].

[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
 2017-08-02 13:57:43 -04:00
Cole Robinson
4e7a6ad728 tests: pylint: Silence/fix a bunch of new warnings 2017-06-16 12:54:56 -04:00
Cole Robinson
62feeb02a8 Switch to python3 style 'except X as Y' notation 
Which also works with python2.7
 2017-05-05 14:52:11 -04:00
Colin Walters
3eaa59dc95 addstorage: Fix a typo in an error message 
Just noticed it while using the app.
 2015-10-05 14:47:50 -04:00
Cole Robinson
ba0711b0bf addhardware: Use same default storage size as create.py (20 GB) 
createvol too
 2015-09-13 19:32:11 -04:00
Cole Robinson
16a744749f addhardware: Drop 'storage format' field 
Originally this made sense, as it was the only way to specify a non-default
storage format when creating new storage.

Nowadays the storage browser is a full featured storage manager... and
this field is a bit confusing WRT whether it's used for creating new
storage, or informing libvirt about an existing image's format.

Drop it from the addhardware wizard, and simplify what we show in the
details wizard as well.
 2015-09-13 19:13:53 -04:00
Cole Robinson
6861d467a4 addstorage: Clean up validate_storage a bit more 2015-09-13 19:08:30 -04:00
Cole Robinson
a2bd31c2a6 virt-manager: Drop old style config- prefix for widget names 
It's redundant and we haven't followed that pattern for a long while
 2015-09-13 18:01:39 -04:00
Cole Robinson
c558bb1f56 addstorage: Move validate_storage error catching to the caller 
Saves some code indentation, and is more robust
 2015-09-13 16:02:35 -04:00
Cole Robinson
15a6a7e210 addstorage: Drop explicit sparse option 
This made more sense when raw was the disk image default, but nowadays
we use qcow2 which doesn't even support non-sparse, so the UI is always
disabled.

If the user changed their preference to raw, it still doesn't make much
sense to show the option, since they are likely using raw for performance
in which case they are going to want to preallocate anyways.

So just default to sparse=False. If users want to override it, they can
do it via custom created storage.
 2015-09-13 15:43:24 -04:00
Pavel Hrdina
9f26bbb5e9 addstorage: remove _check_ideal_path 
This feature has been added few years ago.  I don't think, that it's a
good feature, as it can ask a user to use different storage than he
actually wants to use.  One thing is automatically create a new storage
for user, if he let as do that, but we shouldn't annoy a user with this
question as he probably don't want to use the proposed storage.  For
example he would like to use different storage pool or while importing
existing storage.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1232599

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2015-08-10 15:07:38 -04:00
Cole Robinson
5f497b4d79 Mark a couple strings as translatable 2015-08-09 14:01:01 -04:00
Cole Robinson
cc67f8f194 addstorage: Clarify that VM will fail if cant set path search perms 
https://bugzilla.redhat.com/show_bug.cgi?id=1181025
 2015-05-03 17:33:26 -04:00
Cole Robinson
45e6cd4cac Remove redundant 'default dir' functions 2015-05-02 19:48:04 -04:00
Cole Robinson
fb7a921ec4 storagelist: Select newly created pool/volumes 
And clean up some of the internal APIs in this area
 2015-04-10 15:00:33 -04:00
Cole Robinson
9552afcc92 storagebrowse: Standardize on set_finish_cb 
Instead of gobject signals
 2014-12-09 18:37:00 -05:00
Cole Robinson
7e2ea81a2c addstorage: Switch away from set_create_storage 2014-12-05 21:49:10 -05:00
Cole Robinson
6489df83ca devicedisk: Rename path_exists -> path_definitely_exists 
Since it's a best effort attempt, try to make it more clear that
we aren't certain if paths exist in some cases.
 2014-12-04 20:10:37 -05:00
Cole Robinson
4a678f0543 create: Fix default storage path when VM name is changed (bz 1169141) 
Regressed with 2e7ebd4 . Use skip_disk_page() to determine when we
shouldn't assume default storage
 2014-12-03 13:08:18 -05:00
Cole Robinson
226c4562d5 virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
Cole Robinson
3753fcbaa3 addstorage: Rate limit the default pool refresh 2014-09-12 16:28:37 -04:00
Chen Hanxiao
2f4a424521 use binary prefixes for units where appropriate 
https://bugzilla.redhat.com/show_bug.cgi?id=1103893

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-06-16 11:56:53 +08:00
Cédric Bosdonnat
2e7ebd4b76 Don't create a qemu disk image when creating containers 
Make sure we don't create a default disk image if the option is checked
but not visible as this is the case for containers
 2014-05-28 08:26:42 -04:00
Chen Hanxiao
e0215dec61 addstorage: removing whitespace for storage path 
virtinst util validate_name can't accept name
with whitespaces aroud it.
Remove it when getting text from UI.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
 2014-04-09 23:33:00 +08:00
Cole Robinson
a398d245cb Clean up pylint integration 
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
 2014-04-02 19:00:24 -04:00
Cole Robinson
4f7f1adc47 addhw: Desensitive the 'create storage' UI for cdrom/floppy 
Since we already fail in that case anyways, it makes things a bit clearer.
 2014-03-12 17:22:48 -04:00
Cole Robinson
abb3920ac6 addhw: Fix adding empty cdrom/floppy drive 2014-03-12 16:54:14 -04:00
Cole Robinson
d0f44491ff cli: Warn if disk path isn't searchable by qemu 2014-02-10 18:09:15 -05:00
Cole Robinson
69015c048f addstorage: Fix check VM path collision 2014-02-04 17:39:44 -05:00
Cole Robinson
6f93d3decf Use .qcow2 extension when creating qcow2 files 
Seems the be the practice these days
 2014-02-04 17:30:24 -05:00
Cole Robinson
00d5312bd6 Break out shared storage creation UI to addstorage.py 2014-01-29 09:22:28 -05:00