shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-07 17:18:00 +03:00
Code Issues Projects Releases Wiki Activity
7,448 Commits 2 Branches 64 Tags 98 MiB
a10d746c41
Commit Graph

1637 Commits

Author SHA1 Message Date
Cole Robinson
a10d746c41 gfxdetails: Update UI a bit 
Refactor the internals to cleanly separate the pieces that fill in
the UI, and the pieces that react to UI state to dynamically show/hide
fields.

Improve spice GL warnings while he are here, and several other minor
fixes

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-09-01 20:10:34 -04:00
Cole Robinson
9b5d9eb9eb systray: add a standalone window impl for uitests 
This gives us as much coverage as possible without relying on too much
host desktop config

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-09-01 16:59:20 -04:00
Cole Robinson
315f492156 uitests: Remove some debugging 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-09-01 14:27:11 -04:00
Cole Robinson
e45a2228dc objects: Erase the notion of connkey 
Make it explicit that all uses of this is actually the object
name. We already leaked this abstraction in several places so better
to make it explicit. This also communicates to users that this is a
field that is not immutable so it shouldn't be used as a unique key

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-09-01 14:27:11 -04:00
Cole Robinson
b3fb88e345 cli: Add --cpu numa.cell.memAccess and discard 
https://bugzilla.redhat.com/show_bug.cgi?id=1824373

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-31 13:53:26 -04:00
Cole Robinson
7e3fb3f281 graphics: Default to 'vga' instead of 'qxl' for non-spice 
qxl doesn't add anything for the VNC case, and qxl is more likely
to be compiled out of qemu since it is dependent on spice, so vga
is the safer default for getting a working config

https://bugzilla.redhat.com/show_bug.cgi?id=1833704

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-31 13:43:56 -04:00
Pino Toscano
7b8ea00361 tests: add Mageia 5 detection test 
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
 2020-08-31 13:20:41 -04:00
Pino Toscano
f98daef031 tests: tweak mageia detection 
- create a versioned directory for the current VERSION file, fixing the
  typo in the distro name
- move the test to an own function

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
 2020-08-31 13:20:41 -04:00
Cole Robinson
1a3a89d949 uitests: finish delete.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-30 15:59:39 -04:00
Cole Robinson
30e021bd3d uitests: finish createvm.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-30 14:23:24 -04:00
Cole Robinson
5442b6a890 createvm: Fix checking for empty KVM caps 
This code path was never hit because it came after caps.guest_lookup
which errors in this case. We need to check things earlier

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-30 14:23:24 -04:00
Cole Robinson
38405a477c tests: Add *DIR helper variables 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-30 14:23:24 -04:00
Cole Robinson
c36f232370 uitests: Finish console.py and viewers.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-30 10:34:44 -04:00
Cole Robinson
e414fc3bdc viewers: Drop old style VNC socket handling 
In all modern local cases we will be using openFD to get a direct
file descriptor from the VM, so this code should never be triggered
nowadays

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 16:49:52 -04:00
Cole Robinson
d5f7089ef2 uitests: finish engine.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 16:17:45 -04:00
Cole Robinson
b0294a1bc6 testmock: Split apart the first-run option 
Break it into disable-libguestfs, fake-systemd-success, and
firstrun-uri suboptions, and adjust using code to match

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 15:04:49 -04:00
Cole Robinson
64e3ff1d08 uitests: console/keyring/viewer coverage work 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 13:23:34 -04:00
Cole Robinson
87eb36dda1 uitests: Finish virtmanager.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 12:37:52 -04:00
Cole Robinson
687658832e uitests: details/domain/config coverage additions 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 12:37:52 -04:00
Cole Robinson
e9c937691d uitests: Finish serialcon.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 12:37:12 -04:00
Cole Robinson
fa82508e53 virt-manager: drop libvirt 0.6.0 version check 
This is comically old and completely unrealistic anyone would
attempt to use that nowadays.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 12:37:12 -04:00
Cole Robinson
6006b7b628 tests: Remove some unused testdriver.xml domains 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-28 10:42:29 -04:00
Cole Robinson
a2ad7b4f2f domain: Add test mocking for IP address APIs 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-28 08:47:20 -04:00
Cole Robinson
ab903ef69b domain: Fix clearing topology when VM has dies= in XML 
We need to use the topology.clear() helper to properly empty
out everything

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 19:41:28 -04:00
Cole Robinson
34c6d1c7ea virtinst: cpu: Move topology elements to their own class 
This is a no-op but will help with a future bug fix

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 19:41:28 -04:00
Cole Robinson
a289676574 uitests: More use of safer utility helpers 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
eea394b9d3 uitests: Increase details + domain + vmwindow coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
138856c6df uitests: make manager test less flakey 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
632f07b2bb uitests: Give more time for graceful app shutdown 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:24:40 -04:00
Cole Robinson
69ebf852ca uitests: make onscreen property work for menus 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:24:40 -04:00
Cole Robinson
f74c061061 uitests: Finish asyncjob.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:24:39 -04:00
Cole Robinson
cfd6d6ead4 uitests: Finish vmmenu.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:24:39 -04:00
Cole Robinson
4c1b35f7e7 uitests: Finish migrate.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:01:30 -04:00
Cole Robinson
25d23b1d8b uitests: finish manager.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:01:30 -04:00
Cole Robinson
e9ee0f6d4b uitests: add some mock inspection.py testing 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:26:12 -04:00
Cole Robinson
b59a30ad77 uitests: Finish addhardware.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
8f76c97705 uitests: Make createpool test less flaky 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
d140596ce9 uitests: try to make flakey createvm test more robust 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
dc41f61e5e uitests: Add combo selection helpers and use them 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
3f59d9de84 uitests: More usage of storagebrowser helper 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
73b61ffbc9 uitests: Use our loop check() helper for all asserts 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
ab92693a56 uitests: finish preferences.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
b1ddc6344a uitests: make test_createvm.py asserts more robust 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
fd5216c184 uitests: Finish createconn.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
35d4687237 uitests: Rename test_newvm.py to test_createvm.py 
To mirror the code name

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
bb1180fb40 Move virtmanager test cli handling to testmock.py 
We will be adding more stuff here, so let's move it out
of the main virt-manager script

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
5ccbcb898f uitests: Finish netlist.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
ea49c1d932 netlist: Rework the 'no network' case 
Always force a network selection. If we have to fall back to
manual bridge UI because nothing else exists, show a warning.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
0283f26ace uitests: test createvm.py with an inactive default network 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
153dcba126 uitests: test createvm.py with an empty connection 
Fix the 'No networking' createvm case that it shows was broken

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00