171 Commits

Author SHA1 Message Date
Cole Robinson
b9d0f267fd connection: Rename is_test_conn -> is_test
To match virtinst connection helper names
2017-06-27 14:13:36 -04:00
Cole Robinson
3d81ef097a ui: addhardware: Add virtio tablet/keyboard options 2017-06-27 12:39:17 -04:00
Cole Robinson
62feeb02a8 Switch to python3 style 'except X as Y' notation
Which also works with python2.7
2017-05-05 14:52:11 -04:00
Cole Robinson
c0a3234633 baseclass: share wizard cursor setting code 2017-04-27 15:00:17 -04:00
Mikhail Feoktistov
c25ea6537b Tune default device list for Virtuozzo containers
Virtuozzo supports virtio NIC.
Also add default VNC graphics.
Privnet feature and emulator device have no sense for vz containers.
2017-03-17 13:36:15 -04:00
Marc-André Lureau
53d09bc28c virtManager/ui: add rendernode selection
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2017-03-01 17:57:57 -05:00
Marc-André Lureau
326dc03c23 virtManager/ui: add listen type option
Similarly to virt-install --listen=none, add a combobox to select
the listen type: "address" or "none" for now, as suggested by Pavel
Hrdina.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2017-03-01 17:56:52 -05:00
Marc-André Lureau
88942028b3 virtManager/ui: add opengl graphics option
Add an OpenGL checkbox to the Spice graphics options (only available if
SUPPORT_CONN_SPICE_GL).

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
2017-03-01 17:54:19 -05:00
Pavel Hrdina
798a2e5080 virtManager/addhardware: get supported disk bus types from libvirt
Libvirt provides domain capabilities where supported disk bus types are
listed.  Virt-manager should try to get those bus types.  The old code
remains as fallback if domain capabilities doesn't contain the disk
bus types.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1387218

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-01-24 08:37:17 +01:00
Pavel Hrdina
4506d49ff5 addhardware: don't remove QXL if VNC graphics are configured
Commit 1a6e803a introduced a fix for bogus behavior of QXL+VNC where
there was no cursor visible by disabling this configuration in
virt-manager.  We should enable it again because this is a supported
configuration and the bug was actually in QEMU.

This is now fixed in qemu-2.6.0 [1] so revert commits 1a6e803a and
67ca0a9f.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1326544

[1] http://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg00507.html

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2016-05-20 18:10:24 +02:00
Chen Hanxiao
c4f62ff028 chardev: use pretty type of virtio
We shoud use VirtIO instead of virtio.

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
2016-05-02 17:11:41 -04:00
Pavel Hrdina
c39592ae7b localization: mark several strings as translatable
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2016-02-06 16:25:08 +01:00
Pavel Fedin
ecf4b3ad40 Prohibit adding PCI host devices to container
libvirt does not allow this and attempt to do so causes error during domain
startup. Prevent this in the beginning instead with correct explanation.

Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
2015-12-24 11:37:59 -05:00
Cole Robinson
16a744749f addhardware: Drop 'storage format' field
Originally this made sense, as it was the only way to specify a non-default
storage format when creating new storage.

Nowadays the storage browser is a full featured storage manager... and
this field is a bit confusing WRT whether it's used for creating new
storage, or informing libvirt about an existing image's format.

Drop it from the addhardware wizard, and simplify what we show in the
details wizard as well.
2015-09-13 19:13:53 -04:00
Cole Robinson
6861d467a4 addstorage: Clean up validate_storage a bit more 2015-09-13 19:08:30 -04:00
Cole Robinson
a2bd31c2a6 virt-manager: Drop old style config- prefix for widget names
It's redundant and we haven't followed that pattern for a long while
2015-09-13 18:01:39 -04:00
Cole Robinson
c558bb1f56 addstorage: Move validate_storage error catching to the caller
Saves some code indentation, and is more robust
2015-09-13 16:02:35 -04:00
Cole Robinson
9e23843961 devicechar: Simplify host/port/mode handling
It's kinda crazy, and parts of cli API depend on it, but we can strip
a lot of the confusing bits away by pushing a small bit of logic to
the callers.
2015-09-05 17:16:18 -04:00
Cole Robinson
7d08d3d981 addhw: Drop unused columns from host-device list 2015-08-10 14:18:43 -04:00
Cole Robinson
b4a7d89d4b addhardware: Fix USB host device listing 2015-08-10 14:12:27 -04:00
Pavel Hrdina
745fa9fa5e scsi-storage: unify SCSI storage code and logic
There is no virtio-scsi or spapr-vscsi bus, but only 'scsi' bus.  There
are several types of SCSI controllers, but the SCSI storage don't care
about the SCSI controller and there is also no difference in address
specification or address type.  Use only 'scsi' bus for all SCSI storages
to correspond the reality and also the libvirt domain XML.  The only
difference is in the type of SCSI controller

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-08-05 13:41:47 +02:00
Pavel Hrdina
db9d851c96 Revert "create: customize: Hide bus=virtio-scsi"
This reverts commit cca34185c01971e9433c162abf0eee1525322516.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-08-05 13:41:45 +02:00
Pavel Hrdina
b06c91d2fc hostdev: add an address element for USB host devs if necessary
This issue was fixed for few years but only in virt-manager,
virt-install has the same bug.  If you have two USB devices with same
vendor and product ID, you need to use also address element to create
a valid XML to define that device into a guest.

This patch moves the logic from vmmAddHardware into VirtualHostDevice in
order to not duplicate that code for virt-manager and virt-install.

Also update the tests files to properly check this functionality.  I've
changed the USB device according the 'tests/testdriver.xml' and picked
one of the USB HUBs, because they have the same vendor and product ID.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1230611

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-08-05 13:32:04 +02:00
Pavel Hrdina
0fbe8e7a1f translation: fix wrong usage of _() function
All the strings have to be at first translated and then we can fill the
formated and translated string.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-06-05 16:33:51 -04:00
Cole Robinson
23bf115024 uiutil: Rename select_list_row* to match getter functions 2015-05-19 18:29:46 -04:00
Cole Robinson
490aee74de uiutil: select_list_row_by_value: Handle value=None
Which is a legit value we use as a key in several places. Fix up
a potentially problematic caller
2015-05-19 18:29:46 -04:00
Cole Robinson
5219e49eec uiutil: Merge get_combo_entry into get_list_selection
There's no reason we can't handle it together
2015-05-19 18:29:45 -04:00
Cole Robinson
fdad3efe24 uiutil: streamline column vs rowidx parameter name 2015-05-19 18:29:45 -04:00
Cole Robinson
e8e2c831bf addhardware: Don't list device 'default' options
This is really only useful for building default XML internally, and
for virt-install stuff like --watchdog default. Instead just select
the 'default' value in the wizard
2015-05-19 18:29:45 -04:00
Cole Robinson
f33b6d2750 addhardware: Modernize the code
- Privatize the actually private functions
- Drop the largely redundant get_config helpers
2015-05-19 18:29:45 -04:00
Cole Robinson
2168f33799 details: Unify controller model handling with addhardware 2015-05-19 18:29:45 -04:00
Cole Robinson
cca34185c0 create: customize: Hide bus=virtio-scsi
We don't handle it correctly, need to duplicate the addhw logic
2015-05-03 17:24:02 -04:00
Cole Robinson
4547031152 addhardware: Generate disk targets for disks via customize dialog
Since the XML we use now is with the defaults filled in. Fixes some
issues in the log here:

https://bugzilla.redhat.com/show_bug.cgi?id=1213475
2015-05-03 17:17:53 -04:00
Cole Robinson
53703117d9 storagebrowser: Don't log about closing, if already closed. 2015-05-03 16:57:31 -04:00
Cole Robinson
42648f45f0 libvirtobject: Clean up XML invalidation
Make sure we aren't invalidating things when we are using events. Don't
overload APIs so much.
2015-04-10 17:50:06 -04:00
Cole Robinson
1552cb257e domain: Make device XML editing similar to guest XML editing 2015-04-10 17:15:07 -04:00
Cole Robinson
6071ab0ea4 uiutil: Clarify a few ambiguous function names 2015-04-10 15:00:34 -04:00
Cole Robinson
2d25c920ea connection: Use consistent nodedev function names 2015-04-10 15:00:34 -04:00
Cole Robinson
92c42bc5a0 details: Improve UI labeling of keyboard devices 2015-04-09 13:36:40 -04:00
Cole Robinson
22b9932c47 addhardware: Add USB keyboard option (bz 1176724) 2015-04-09 13:25:15 -04:00
Cole Robinson
2bf1a29f40 details: Add tooltips if device isn't removable 2015-04-09 13:11:20 -04:00
Cole Robinson
771154d104 addhardware: Make network model a combo entry
So users can add non-advertised models
2015-04-09 12:58:21 -04:00
Cole Robinson
058c06972e Break out shared storage UI to storagelist.py (bz 1060433)
We were already sharing a chunk of this in a haphazard way. Now officially
break it all out, similar to netlist.py. This mostly unifies the views
of host->storage and storagebrowser.py
2015-04-09 12:31:24 -04:00
Cole Robinson
cc3a522455 Use is_pseries() helper more consistently 2015-04-08 09:31:01 -04:00
Cole Robinson
ec162888f5 addhardware: Make bus list dependent on device type
And not the other way around. It's less confusing this way IMO, particularly
if virtio is selected by default and the user is confused, wondering
where the cdrom option is.

Take the opportunity to actually share the bus combo logic between details
and addhardware
2015-04-07 19:31:30 -04:00
Cole Robinson
55c8453d15 details: Use 'Hypervisor default' description in more places (bz #1073521) 2015-04-07 18:36:07 -04:00
Cole Robinson
c66bc2a87f connection: Have get_nodedevs return vmmNodeDevice
To make it consistent with similar vmmConnection functionas
2015-04-07 14:12:00 -04:00
Cole Robinson
ebfb0cd726 mediadev: Kill the abstraction, just use nodedevs
It's really a useless hold over from the days when we manually talked
to HAL.

One semi useful bit lost in the shuffle is the option to repoll cdroms
for media. But since virt-manager allows attaching a device to the
VM regardless of whether it notices media change, this plumbing is
really overkill. If libvirt ever grows nodedev events we will get this
much easier.
2015-04-07 13:59:43 -04:00
Cole Robinson
feb010621b addhardware: Don't advertise IDE for Q35 (bz #1207834)
Laine suggests we hide it altogether
2015-04-06 13:36:54 -04:00
Cole Robinson
dd8f7c90c0 addhardware: Allow SATA CDROM (bz 1207834) 2015-04-04 19:07:39 -04:00