shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-03-09 08:58:27 +03:00
Code Issues Projects Releases Wiki Activity
5,310 Commits 2 Branches 64 Tags
Commit Graph

769 Commits

Author SHA1 Message Date
Chen Hanxiao
b44aa0e3bb pycodestyle: fix all E131 warnings 
Fix all E131:
     Continuation line unaligned for hanging indent

   Also remove ignore options of E131

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-08-26 20:03:21 +08:00
Chen Hanxiao
c92aade081 pycodestyle: fix all E203 warnings 
Fix all E203 whitespace before ':'
   Also remove E203 ignore option of pycodestyle

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-08-11 00:01:38 +08:00
Radostin Stoyanov
b93cc3bbc9 pycodestyle: Do not use bare 'except:' 
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].

[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
 2017-08-02 13:57:43 -04:00
Radostin Stoyanov
2fd6d9aa32 tests: Upgrade pep8 to pycodestyle 
The PEP8 [1] project has been renamed to pycodestyle [2].

[1] https://github.com/codeclimate/pep8
[2] https://github.com/pycqa/pycodestyle
 2017-08-02 13:23:20 -04:00
Cole Robinson
6f8206dc55 uitests: newvm: Fix after CPU UI tweaks 2017-07-20 17:54:11 -04:00
Cole Robinson
1a09a05dc7 tests: Add a clone test for importing nvram directory 
Need to use some callback magic to fake it like there's a file in
an existing directory
 2017-07-20 17:51:06 -04:00
Cole Robinson
6b586e2bed tests: Rework connection caching 
Drop the callbacks and instead prime the connection's internal cache.
This will simplify upcoming changes
 2017-07-20 17:28:38 -04:00
Cole Robinson
5b51c98ae5 storage: Check for pool name collisions against the pool cache 
Rather than using storagePoolLookupByName. This will save some API
calls, but the main benefit is that it can help shake out cache
issues.
 2017-07-20 17:28:38 -04:00
Cole Robinson
55aa23b400 connection: Return copys of cached object lists 
Incase any users manipulate the lists, we don't want that to affect
our caching. Could prevent future mistakes
 2017-07-20 17:28:38 -04:00
Cole Robinson
4e4a6c817f connection: Rework cache function layout slightly 
Have the internal polling functions not touch the connection cache.
This let's us not worry about the connection cache in the test suite,
where clear_cache wasn't 100% correct.
 2017-07-20 17:28:38 -04:00
Cole Robinson
e241f4c957 tests: Open a new connection for each test 
To ensure we are testing each time from a clean state. Isn't causing
obvious issues in practice at the moment but it may with future
changes
 2017-07-20 17:27:22 -04:00
Cole Robinson
d3074141c8 cloner: Remove redundant setup() method 
The functional callers use the individual setup methods, let's drop the
helper function and adjust the test suite
 2017-07-20 17:27:22 -04:00
Cole Robinson
1e3e9a9fc4 uitests: Add 'host' window smoke tests 2017-07-20 17:27:22 -04:00
Cole Robinson
ca56f74ed7 capabilities: Fix model list caching for different archs (bz 1451113) 
We could return cached x86_64 results for aarch64 VMs

https://bugzilla.redhat.com/show_bug.cgi?id=1451113
 2017-07-17 11:47:01 -04:00
Cole Robinson
2eaf084b04 capabilities: Drop cpu_map.xml handling 
We've had getCPUModelNames in libvirt for years now, and this
functionality isn't critical anyways, so drop the fallback
 2017-07-17 11:47:01 -04:00
Cole Robinson
c6fdfbf3c3 cli: disk: add driver_detect_zeroes= support 2017-07-15 13:39:04 -04:00
Cole Robinson
f41844f3f2 guest: Use usb3 qemu-xhci for machvirt 
This is what libvirt will default to nowadays for those configs,
so let's match it.
 2017-07-10 19:46:13 -04:00
Cole Robinson
a51929fcd3 snapshots: Handle XML chars in snapshot name (bz 1468912) 
https://bugzilla.redhat.com/show_bug.cgi?id=1468912
 2017-07-10 17:51:04 -04:00
Cole Robinson
0633055fb9 guest: Drop old os type=linux back compat 
We don't support libvirt versions that require this anymore
 2017-07-10 09:34:38 -04:00
Cole Robinson
6d625ae45f guest: Enable spice sound on more arches 
If spice is enabled, just assume sound devices will work as well
 2017-06-28 16:28:25 -04:00
Cole Robinson
a07a874497 guest: If graphics enabled, add usb tablet/keyboard for machvirt 2017-06-28 16:22:23 -04:00
Cole Robinson
2cabc2e386 guest: Don't add default ps2 or xen mouse 
libvirt drivers have added these by default for a long time, so
its redudnant here
 2017-06-28 16:17:50 -04:00
Cole Robinson
f2de47cee2 guest: Add USB3 controller for machvirt by default 
...if libvirt is new enough to do machvirt PCI by default. We can
just use usb3 since all guest OS that support aarch64 are new enough
to support it
 2017-06-28 15:35:07 -04:00
Cole Robinson
225d53c511 guest: Default to video type=virtio for machvirt 
That's basically the only working config on KVM
 2017-06-28 15:13:44 -04:00
Cole Robinson
0fe76d321b guest: Enable default virtio-rng for pseries and machvirt 
arm guys confirmed virtio-rng should be fine. pseries guys didn't
but I think it will be okay
 2017-06-28 15:12:00 -04:00
Cole Robinson
47b127b49f guest: Use virtio more for ppc64 pseries, and s390 
qemu s390x is virtio only nowadays, and on ppc64 pseries is preferred,
and all relevant OS are going to support it for that case
 2017-06-28 15:02:23 -04:00
Cole Robinson
4e7cd661ee guest: Only add input devices if graphics are specified 2017-06-28 12:05:14 -04:00
Cole Robinson
5a1f2f7b66 tests: add aarch64 graphics test 2017-06-28 11:54:41 -04:00
Cole Robinson
1600ac39f0 fsdetails: Fix displaying filesystem type=ram devices 
And add a test XML example to demonstrate it
 2017-06-27 14:08:44 -04:00
Radostin Stoyanov
795a9d2d44 Set default Filesystem type for LXC to "Mount" 2017-06-20 16:14:17 -04:00
Radostin Stoyanov
0dfc371f18 Keep the value of filesystem/source when attribute is changed 
When the attribute of filesystem/source is changed the old value was
not assigned to the new attribute.
 2017-06-20 16:14:17 -04:00
Yuri Arabadji
4be3d030b5 cli: Add --disk logical/physical_block_size 2017-06-16 13:28:25 -04:00
Cole Robinson
4e7a6ad728 tests: pylint: Silence/fix a bunch of new warnings 2017-06-16 12:54:56 -04:00
Cole Robinson
c75b3a99b1 tests: pylint: Slim down the configuration file 
Only list things that we change defaults for, or may want to in the future
 2017-06-15 08:12:06 -04:00
Pavel Hrdina
b690908aa4 virtinst: enable secure feature together with smm for UEFI 
The secure feature actually enforce the secure boot if Secure Boot
Mode is configured.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1387479

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-06-07 20:49:45 +02:00
Cole Robinson
1c22105a54 tests: inject: Update URL list 2017-06-07 12:40:46 -04:00
Cole Robinson
1d0b4a0a9e connect: Handle \ in username 
We need to quote URL values in the username, that's what libvirt expects.
Unquote the values before caching them in the URI object, so console
connections continue to work

https://bugzilla.redhat.com/show_bug.cgi?id=1452389
 2017-06-01 14:26:46 -04:00
Pavel Hrdina
4f8e795c6a virtinst: if required by UEFI enable SMM feature and set q35 machine type 
If we detect that the UEFI image is build to require SMM feature we
should configure the guest to enable SMM feature and set q35 machine
type.  Without this user wouldn't be able to boot the guest.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1387479

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-06-01 09:58:46 +02:00
Pavel Hrdina
24f9d05329 virt-install: add support for loader secure attribute 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-06-01 09:58:46 +02:00
Pavel Hrdina
f38c56c971 virt-install: add support for SMM feature 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-06-01 09:58:46 +02:00
Cole Robinson
69f19ca614 tests: test_urls: Update 2017-05-16 17:16:59 -04:00
Cole Robinson
f551d7e55d Replace file() usage with open() 
Same semantics, but the latter is needed for python3
 2017-05-05 14:53:12 -04:00
Cole Robinson
55288c4551 Convert to python3 style print() syntax 
Use __future__ imports to keep this working for python2
 2017-05-05 14:52:37 -04:00
Cole Robinson
62feeb02a8 Switch to python3 style 'except X as Y' notation 
Which also works with python2.7
 2017-05-05 14:52:11 -04:00
Cole Robinson
fcebefd3bb tests: Stop using deprecated assertEquals 
The recommended way is assertEqual
 2017-05-05 12:40:52 -04:00
Pavel Hrdina
a2985f07e6 virtinst: add support for memory device 
This is the actual memory device that is used to hot(un)plug memory
to(from) a guest.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-05-05 12:20:52 +02:00
Pavel Hrdina
3ebbeef80e virtinst: introduce support for <maxMemory> element 
This element controls hot(un)plugable memory for the guest in
addition to the initial memory configured by <memory> element.

One has to configure <maxMemory> and guest numa nodes using <numa>
element to enable hot(un)plug of memory modules.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-05-05 11:49:27 +02:00
Lin Ma
ea85a3c680 tests: add test for network forward mode 'open' 
Signed-off-by: Lin Ma <lma@suse.com>
 2017-05-03 14:08:42 -04:00
Lin Ma
be6566a134 testdriver: Add network example of open network forward mode 
Signed-off-by: Lin Ma <lma@suse.com>
 2017-05-03 14:08:38 -04:00
Cole Robinson
7a4acfcd0c devicedisk: Raise proper error on invalid source_volume (bz 1445198) 
https://bugzilla.redhat.com/show_bug.cgi?id=1445198
 2017-04-27 15:44:46 -04:00