Commit Graph

40 Commits

Author SHA1 Message Date
Radostin Stoyanov
b93cc3bbc9 pycodestyle: Do not use bare 'except:'
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].

[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
2017-08-02 13:57:43 -04:00
Cole Robinson
69f19ca614 tests: test_urls: Update 2017-05-16 17:16:59 -04:00
Cole Robinson
62feeb02a8 Switch to python3 style 'except X as Y' notation
Which also works with python2.7
2017-05-05 14:52:11 -04:00
Cole Robinson
e369580450 tests: test_urls: update data 2016-12-13 14:36:24 -05:00
Cole Robinson
64c286e68b tests: Fix pep8 issue 2016-08-16 20:04:08 -04:00
Cole Robinson
cf1b820e19 tests: urls: Update fedora24 test 2016-08-16 19:05:54 -04:00
Cole Robinson
137a6c4600 tests: urls: Add centos ppc64le URL 2016-08-16 18:52:09 -04:00
Cole Robinson
51e8b9df11 tests: test_urls: Add opensuse tumbleweed test 2016-06-07 13:23:14 -04:00
Cole Robinson
2fbf8e9821 tests: test_urls: Update with latest libosinfo 2016-04-26 08:57:18 -04:00
Cole Robinson
f4dfb6de9d Fix recent pylint/pep8 output 2016-04-18 16:42:12 -04:00
Cole Robinson
f4bf4ef349 urlfetcher: Don't set os_variant=linux
os_variant=linux is basically meaningless; it doesn't set any useful
defaults. better to be explicit that we didn't detect any meaningful
os_variant, to trigger the virt-install warning
2016-04-07 17:43:53 -04:00
Cole Robinson
9d886e1440 test_urls: Better error reporting for URL lookup failure 2016-04-07 17:13:17 -04:00
Cole Robinson
31f5fff9b8 test_urls: Add fedora dev tree tests 2016-04-07 16:46:37 -04:00
Cole Robinson
c92507baea urlfetcher: Fix ftp URLs with ports in them
Reported-by: int-0 <tobias.deb@gmail.com>
2016-03-24 16:15:21 -04:00
Cole Robinson
f9297f3bc3 test_urls: Update with latest URLs 2016-03-24 16:04:06 -04:00
Cole Robinson
fdfddff6a4 test_urls: Improve error reporting 2016-03-24 15:57:34 -04:00
Cole Robinson
d1d202bb1f test_urls: Update and improve an error message 2015-11-24 21:59:26 -05:00
Cole Robinson
3091b2134a test_urls: Use ftp for debian URLs for better FTP testing 2015-09-14 10:35:51 -04:00
Cole Robinson
fd6b09ac63 tests: Update test_urls 2015-09-11 11:49:43 -04:00
Cole Robinson
697164f2e5 virtinst: Centralize urlgrabber meter lookup
We will eventually want to drop this dep since it's basically dead
upstream, this is a small step in that direction
2015-09-06 15:09:44 -04:00
Cole Robinson
832293f3fd test_urls: Update latest distro detection 2015-06-05 16:30:53 -04:00
Lin Ma
9b99eff73d test_urls: Add opensuse 13.x tests
Because the content file is changed little bit in 13.2, Both of
urls of 13.1 and 13.2 need to be tested.

From: Charles Arnold <carnold@suse.com>
Signed-off-by: Lin Ma <lma@suse.com>
2015-06-05 16:00:20 -04:00
Cole Robinson
393aed191e urlfetcher: Detect centos URLs as centos, not rhel variants 2015-04-04 15:41:13 -04:00
Cole Robinson
82e9684fa6 urlfetcher: Make debian treearch checking more generic
Use regex parsing rather than a whitelist
2015-03-27 13:06:26 -04:00
Cole Robinson
ba95aa91e6 test_urls: Update fedora URLs 2015-03-26 19:28:53 -04:00
Chen Hanxiao
08007d56fe test_urls: remove commented fedora21 alpha urls
Discoverd by pep8 '# ' style.
introduced by 92b443df
We forgot to delete it.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-12-12 10:10:17 +08:00
Cole Robinson
92b443df55 test_urls: Update 2014-12-10 13:39:18 -05:00
Cole Robinson
2e7d477156 urlfetcher: Bunch of distro detection fixes
And update test_urls to ensure it's passing
2014-09-06 16:42:09 -04:00
Cole Robinson
a398d245cb Clean up pylint integration
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
2014-04-02 19:00:24 -04:00
Giuseppe Scrivano
2a040ccd17 mass update: remove double spaces from comments
Updated by this script:

find -name '*.py' -exec sed -i "s|^\(#.*[^.?\!]\)  \(.*[^#]\)$|\1 \2|g" \{\} \;

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:22:31 +01:00
Giuseppe Scrivano
0df75c7603 headers: update "Red Hat, Inc." copyright for the year 2013
Ensure that any file touched by a @redhat.com author in 2013 has an
updated copyright header.

The files were updated using the build-aux/update-copyright gnulib
script and manually added where the copyright line wasn't present.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2013-10-28 17:22:26 +01:00
Cole Robinson
74a2ab5612 test_urls: Fix --path option 2013-09-26 18:32:50 -04:00
Cole Robinson
d49e11dabc urlfetcher: Fix distro lookup short circuiting if os_variant specified 2013-09-26 17:45:02 -04:00
Cole Robinson
7aa24be31a urlfetcher: Detect debian, ubuntu, and opensuse variant from URL 2013-09-26 17:44:57 -04:00
Cole Robinson
1220d3082c test_urls: Fix SL6 test 2013-09-26 14:53:59 -04:00
Cole Robinson
7d02d508dd test_urls: Encode expected distro store in URL object 2013-09-26 14:40:52 -04:00
Cole Robinson
c5f5d5ad9d urlfetcher: Clean up APIs for fetching URL media 2013-09-26 14:28:13 -04:00
Cole Robinson
655f458298 test_urls: Turn each URL test into an object, not a dict
Update the URL list and fix a couple bugs
2013-09-26 12:36:21 -04:00
Cole Robinson
ff5b8d29e2 test_urls: Use multiple unittests, not a single big one 2013-09-26 11:49:16 -04:00
Cole Robinson
15eac4de59 tests: Fix and update test_urls 2013-09-25 19:36:15 -04:00