shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-12-24 21:34:47 +03:00
Code Issues Projects Releases Wiki Activity
6,802 Commits 2 Branches 64 Tags 98 MiB
b513388979
Commit Graph

68 Commits

Author SHA1 Message Date
Cole Robinson
387614c641 generatename: Move libvirt collision handling to callers 
Make every caller pass an explicit cb that handles libvirt
collision processing. Makes it easier to see exactly what is going
on at the call impls
 2019-06-11 17:54:45 -04:00
Cole Robinson
58dfe05344 virtManager: Remove some unnecessary generatename collidelist usage 
The libvirt callbacks will handle this for us already
 2019-06-11 17:54:45 -04:00
Cole Robinson
b5a664bd1b virtinst: move UI only functions into virtManager 
These throw off code coverage testing. They are mostly:

* pretty* device helpers
* network + snapshot validation + creation routines
 2019-06-09 18:33:45 -04:00
Cole Robinson
388850f04e virtinst: Rename util to xmlutil 
The only functions left in there are largely for xml handling, so
make it explicit
 2019-06-07 18:21:24 -04:00
Cole Robinson
f2304664d6 snapshots: Split out vmmSnapshotNew class 
Simplifies code org
 2019-06-05 11:15:28 -04:00
Cole Robinson
f7ba2f2f99 error: Add helper confirm_unapplied_changes 
For the common dialog we use to confirm changes
 2019-04-14 18:24:04 -04:00
Cole Robinson
927d668215 virtManager: Use popup_at_pointer 
Added in gtk 3.22 to fix some wayland ambiguity. Needed for sway wm
multimonitor apparently:

https://bugzilla.redhat.com/show_bug.cgi?id=1694379
 2019-04-07 13:54:00 -04:00
Cole Robinson
ea413be214 xmlbuilder: Rename get_xml_config -> get_xml 
The config part is redundant. Should have done this a long time ago
 2018-08-31 16:52:02 -04:00
Daniel P. Berrangé
48e32b429d Fix copyright header to specify GPLv2 or later, not GPLv2 only. 
The copyright headers in every file were chjanged in this previous commit

  commit b6dcee8eb7
  Author: Cole Robinson <crobinso@redhat.com>
  Date:   Tue Mar 20 15:00:02 2018 -0400

    Use consistent and minimal license header for every file

Where before this they said "

  "either version 2 of the License, or (at your option) any later version."

Now they just say

  "GNU GPLv2"

This fixes it to say "GNU GPLv2 or later" again.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
 2018-04-04 16:51:37 -04:00
Cole Robinson
eee1caa946 domain: Drop most device list wrappers 
There's lots of hacks stuffed into the domain device lists. Formalize
some of it, move some of the specific stuff to details.py, and drop
a lot of the needless API wrappers
 2018-03-21 16:10:45 -04:00
Cole Robinson
b6dcee8eb7 Use consistent and minimal license header for every file 2018-03-21 07:29:40 -04:00
Cole Robinson
cad809fe80 Make all dialogs clean up when vm/conn disappears 
Moves all the window cleanup handling to each class and audit for
all --test-leak-debug errors and fix
 2018-03-15 21:24:48 -04:00
Cole Robinson
2ee69edc8e snapshots: Fix generating screenshot after py3 conversion 2018-03-15 21:24:48 -04:00
Radostin Stoyanov
978fb25ac7 Wrap keys(), values() in a list 
In Python 3 dict.values() [1] , dict.keys() [2] and dict.items() [3]
return a view [4] of the dictionary’s values, keys and items.

In Python 2 these functions return a list. [5] [6] [7]

To resolve this we can convert the result of these function to a list.

[1] https://docs.python.org/3/library/stdtypes.html#dict.values
[2] https://docs.python.org/3/library/stdtypes.html#dict.keys
[3] https://docs.python.org/3/library/stdtypes.html#dict.items
[4] https://docs.python.org/3/library/stdtypes.html#dict-views
[5] https://docs.python.org/2/library/stdtypes.html#dict.items
[6] https://docs.python.org/2/library/stdtypes.html#dict.keys
[7] https://docs.python.org/2/library/stdtypes.html#dict.values
 2018-02-06 18:49:17 -05:00
Cole Robinson
2f12823cb5 snapshots: Maintain selection after refresh 2018-01-18 16:55:57 -05:00
Radostin Stoyanov
75210ed37c Replace StringIO with io.(StringIO or BytesIO) 
StringIO and cStringIO modules no longer exists in Python 3. [1]
Use either io.StringIO [2] for text or io.BytesIO [3] for bytes.

[1] http://docs.python.org/3.0/whatsnew/3.0.html
[2] https://docs.python.org/3/library/io.html#text-i-o
[3] https://docs.python.org/3/library/io.html#binary-i-o
 2017-10-20 13:18:31 -04:00
Chen Hanxiao
04e35b2d85 pycodestyle: fix all E124 warnings 
Fix all E124:
     Closing bracket does not match visual indentation

   Also remove ignore options of E124

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-09-09 23:21:42 +08:00
Chen Hanxiao
c92aade081 pycodestyle: fix all E203 warnings 
Fix all E203 whitespace before ':'
   Also remove E203 ignore option of pycodestyle

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-08-11 00:01:38 +08:00
Radostin Stoyanov
b93cc3bbc9 pycodestyle: Do not use bare 'except:' 
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].

[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
 2017-08-02 13:57:43 -04:00
Cole Robinson
a51929fcd3 snapshots: Handle XML chars in snapshot name (bz 1468912) 
https://bugzilla.redhat.com/show_bug.cgi?id=1468912
 2017-07-10 17:51:04 -04:00
Cole Robinson
f551d7e55d Replace file() usage with open() 
Same semantics, but the latter is needed for python3
 2017-05-05 14:53:12 -04:00
Cole Robinson
62feeb02a8 Switch to python3 style 'except X as Y' notation 
Which also works with python2.7
 2017-05-05 14:52:11 -04:00
Cole Robinson
c0a3234633 baseclass: share wizard cursor setting code 2017-04-27 15:00:17 -04:00
Chen Hanxiao
911dac0dfa snapshot: start snapshot when double-click the item of snapshot list 
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2016-08-02 13:20:15 -04:00
Cole Robinson
3aa941571a uiutil: Drop check for old pygobject row handling 
Once upon a time it couldn't handle setting a row value to None,
but we've bumped the dep now
 2016-05-17 17:49:56 -04:00
Cole Robinson
f4dfb6de9d Fix recent pylint/pep8 output 2016-04-18 16:42:12 -04:00
Pavel Hrdina
0fbe8e7a1f translation: fix wrong usage of _() function 
All the strings have to be at first translated and then we can fill the
formated and translated string.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2015-06-05 16:33:51 -04:00
Cole Robinson
42648f45f0 libvirtobject: Clean up XML invalidation 
Make sure we aren't invalidating things when we are using events. Don't
overload APIs so much.
 2015-04-10 17:50:06 -04:00
Cole Robinson
226c4562d5 virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
Giuseppe Scrivano
de8e39ba53 snapshots: alert users for unapplied changes 
The UI works slightly different than with other "unapplied changes"
alerts, as it changes anyway to the selected snapshot, no matter what
the user chooses.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-08-01 09:30:21 +02:00
Giuseppe Scrivano
f5b29c0416 snapshots: allow deleting multiple snapshots 
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1124818

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-08-01 09:30:21 +02:00
Giuseppe Scrivano
724c6499f0 snapshots: add button to force snapshots list refresh 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2014-08-01 09:30:21 +02:00
Cole Robinson
2272166844 snapshots: Fix screenshot with qxl+spice (bz 1089780) 2014-04-29 13:26:26 -04:00
Cole Robinson
a398d245cb Clean up pylint integration 
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
 2014-04-02 19:00:24 -04:00
Cole Robinson
9d743ab4c8 snapshots: Tweak warning before run 
Make it clear that VM configuration changes will also be dropped if
reverting to a snapshot while the VM is offline.

Suggested-by: Jorge Fábregas <jorge.fabregas@gmail.com>
 2014-03-26 08:54:10 -04:00
Cole Robinson
99eaf059ae Fix deprecation warnings on F21/rawhide 2014-02-25 15:57:38 -05:00
Cole Robinson
e4711061c4 snapshots: Make sure 'current' icon is always visible (bz 1065074) 2014-02-14 10:20:37 -05:00
Cole Robinson
09390b8151 snapshots: Show indication of the 'current' snapshot (bz 1017385) 2014-02-01 11:25:35 -05:00
Cole Robinson
889ec18031 uiutil: Use list selection helpers everywhere 2014-01-27 10:46:14 -05:00
Cole Robinson
708a2737cf Split uihelpers into sharedui and uiutil 
Reserve uiutil for the little gtk helper functions, rest goes into shared
UI (which all should probably be factored into their own files but thats
a task for another day)
 2014-01-26 18:15:50 -05:00
Cole Robinson
58d5e0b799 uihelpers: Move a few more functions closer to their callers 2014-01-26 17:51:15 -05:00
Cole Robinson
d12c986b98 Use BUTTON size for all status icons 2014-01-12 14:36:03 -05:00
Cole Robinson
bd782d5757 snapshots: Another s/State/VM State/ change 2013-11-10 11:17:12 -05:00
Cole Robinson
fdb79b9832 snapshots: Add a right click menu for start/stop 2013-10-05 14:57:58 -04:00
Cole Robinson
111f4353a3 snapshots: new: Grab name focus, make activate create the snapshot 2013-10-05 14:47:10 -04:00
Cole Robinson
97f5717ef7 snapshots: Fix showing async dialogs for revert/delete 2013-10-05 10:03:56 -04:00
Cole Robinson
bdaa0e511a Log object name with XML diff on redefine 2013-10-01 10:21:44 -04:00
Cole Robinson
868fbd9fc9 snapshots: Add screenshot support 
Show a screenshot in the 'new snapshot' wizard. If we successfully create
that snapshot, save the screenshot in

~/.cache/virt-manager/$connuri/$vmuuid/snap-screenshot-$snapname.$ext

And show it in the snapshot details overview. We don't do any reaping
on snapshot delete, vm delete, etc, but that could be added later.
 2013-10-01 10:14:51 -04:00
Cole Robinson
d44f863c2d details: Disable snapshot buttons if conn or guest doesn't have support 2013-09-30 20:33:42 -04:00
Cole Robinson
8f1ea67cad Don't lose current selection if redefining net/pool/iface/snapshot 2013-09-30 19:55:21 -04:00