3985 Commits

Author SHA1 Message Date
Chen Hanxiao
658c9500a9 createnet: fix a small pylint
commit f109b1ed6fc93c1c74675d047affc0fe57ae7243
used a undefined variable 'PAGE_MAX'.
It looks like it should be in a developing series,
but should be fixed in upstream.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-27 09:06:14 +02:00
Chen Hanxiao
240111f091 create: fix a comment typo
s/detction/detection

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-27 10:06:24 +08:00
Giuseppe Scrivano
f109b1ed6f createnet: validate last page before creating the network
On the last page in the createnet wizard the Next button is changed to
Finish.  Ensure the user input is validated also on this page.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-26 15:26:37 +02:00
Giuseppe Scrivano
81bd6bbffb createnet: fix "show_err" typo
s|show_erro|show_err|

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-26 15:26:37 +02:00
Giuseppe Scrivano
57d26e6265 virtinst: parse "bandwith" node in network definition
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-26 15:26:37 +02:00
Cole Robinson
72d0d5d8ea manager: Make it clear which functions are called from engine.py 2014-06-26 09:05:34 -04:00
Cole Robinson
f6e214d438 testdriver: Add network <bandwidth> example 2014-06-26 08:50:08 -04:00
Giuseppe Scrivano
eb5b261311 details.py: fix typo
s|removeable|removable|

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1112629

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-24 17:14:19 +02:00
Giuseppe Scrivano
48be09a997 createnet: use vmmInterface.get_name() instead of vmmInterface.name
It fixes this exception:

Traceback (most recent call last):
  File "virt-manager/virtManager/host.py", line 467, in add_network
    self.addnet.show(self.topwin)
  File "virt-manager/virtManager/createnet.py", line 102, in show
    self.reset_state()
  File "virt-manager/virtManager/createnet.py", line 180, in reset_state
    devnames.append(iface.name)
AttributeError: 'vmmInterface' object has no attribute 'name'

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-24 17:14:19 +02:00
Cole Robinson
c78974c0d9 connection: Drop netdev abstraction
Just open code it in the one place it's needed. Try to simplify some of
the netlist logic while we are at it. Should fix:

https://bugzilla.redhat.com/show_bug.cgi?id=1109574
2014-06-18 12:41:36 -04:00
Giuseppe Scrivano
4ac49a1d66 virt-manager: split EDIT_VCPUS and EDIT_MAXVCPUS
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1098040

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-17 17:27:47 +02:00
Chen Hanxiao
27d03b8b92 preferences ui: fix a duplicate shortkey
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-17 13:21:46 +08:00
Chen Hanxiao
75d43f6a37 fix some missed binary prefixes for units
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-17 09:33:14 +08:00
Chen Hanxiao
100023baa6 preferences ui: add shortkey for Add Spice USB Redirection
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-17 09:32:42 +08:00
Giuseppe Scrivano
5c2459e6e4 createpool.py: fix creation of gluster pools
It fixes this exception:

Traceback (most recent call last):
  File "virt-manager/virtManager/createpool.py", line 454, in page_changed
    self.set_page(page_number)
  File "virt-manager/virtManager/createpool.py", line 451, in set_page
    self.show_options_by_pool()
  File "virt-manager/virtManager/createpool.py", line 292, in show_options_by_pool
    self.widget("pool-source-name").get_child().set_text(
AttributeError: 'Entry' object has no attribute 'get_child'

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-16 08:20:58 +02:00
Chen Hanxiao
2f4a424521 use binary prefixes for units where appropriate
https://bugzilla.redhat.com/show_bug.cgi?id=1103893

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:56:53 +08:00
Chen Hanxiao
ba96af8df8 addhardware: add a tool tip when USB controller already existed
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:50:04 +08:00
Chen Hanxiao
e124f3e401 addhardware: enable setting model when adding controller
This patch will enable setting controller model
when adding controller.

If no USB controller or usb model = none,
we could add a new one;
if had, disable 'create-finish' button.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:48:22 +08:00
Chen Hanxiao
7beb7db31d addhardware: move _change_config_helper from details
rename it as change_config_helper.
It will be used in the later patch.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:47:19 +08:00
Chen Hanxiao
b4a43fb6b7 preferences ui: add shortkey for tab page
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:43:33 +08:00
Chen Hanxiao
ea4847961a host ui: add shortkey for tab page
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:43:09 +08:00
Chen Hanxiao
d007352aa4 connection: Fix Alt - t shortcut key
Or we will get:
"Couldn't find a target for a mnemonic activation"

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-12 16:36:16 +08:00
Giuseppe Scrivano
64c6a9be34 preferences, feedback: fix Alt-i key shortcut
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
fb56ac8f36 createinterface: add key shortcuts for Bridge configuration
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
75e83a099e createinterface: make "Configure" shortcuts unique
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
3118ec5f51 createpool.py: fix comment typo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
e9687ab071 createpool: fix shortcuts refs and make them unique
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
a8db7ec266 createvol: change "Format" key shortcut to Alt-o
Alt+f is already used for Finish.  Choose Alt-o as it is already used
for "Format" in other places.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
0b7c7c0c07 createnet: fix references for Alt-d and Alt-m
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Giuseppe Scrivano
86d5ff04e3 connection: Fix Alt-o shortcut key
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Chen Hanxiao
17a11672b1 createnet: enable specify /29 subnet
https://bugzilla.redhat.com/show_bug.cgi?id=1106913

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-11 09:52:07 +08:00
Chen Hanxiao
d3d76beb5b guest: fix order in _XML_PROP_ORDER
re-order xml values according to libvirt code.

a) move "blkiotune" "memtune" ahead of "memoryBacking"
b) move "resource" ahead of "pm"

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-05 08:52:24 +08:00
Giuseppe Scrivano
be63db61ad create: allow users to select a type without variant
The check made in get_config_os_info fails anytime a variant is not
found, making impossible to choose Generic.  Change it to not fail if
the OS was found.

commit 33a2d1a1c8eece3c55dd69aed1e7d4018b3d15aa broke this.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-04 21:20:24 +02:00
Chen Hanxiao
99df0057f5 man: fix an incorrect description in virt-install man page
Actually --pm accepts suspend_to_mem rather than suspend_to_ram.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-04 16:39:23 +08:00
Chen Hanxiao
d1b0fade1d virt-install: add --resource support
This patch will enable setting
resource partition configuration.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-04 10:08:05 +08:00
Cole Robinson
809c5a81e5 diskbackend: Fix pool 'create' call (bz 1103442) 2014-06-03 16:26:28 -04:00
Cole Robinson
f686e36e42 details: Expose chipset=i440fx/q35 in customize dialog
So enterprising users can choose q35 for x86 qemu/kvm VMs. Some
discussion over here:

http://www.redhat.com/archives/virt-tools-list/2014-May/msg00001.html
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00019.html

We show a warning if q35 is selected, saying it's not well tested.
Hopefully that dissuades people who are just clicking about.
2014-06-03 15:58:04 -04:00
Cole Robinson
03670c38dc details: xen keyboard can't be removed either 2014-06-02 18:54:28 -04:00
Cole Robinson
aefd4c4824 connection: Use name instead of uuid for object keys
And clean up the API mess while we are at it. Treat the key as an opaque
value that users shouldn't depend on.

Besides the improved code clarity and API layout, this will help diagnose
'key error' issues, since we'll see an object name instead of UUID which
is hard to trace back.
2014-06-02 17:48:32 -04:00
Cole Robinson
d3e9af8328 pollhelpers: Use correct dictionary keys for old pool/net polling (bz 1099827)
We were inadvertently using the object name rather than UUID when libvirt
didn't support new style polling APIs.
2014-06-02 12:18:59 -04:00
Cole Robinson
d3e55a1fbf pollhelpers: Add debugging helper to force old polling 2014-06-02 12:02:09 -04:00
Cole Robinson
42204c9379 connection: Add debug helper to disable libvirt events 2014-06-02 12:02:09 -04:00
Cole Robinson
d17cf4a223 console: vnc: Don't force keyboard grab before widget is realized
Causes gtk warnings on the console, and the code was mistaken anyways
2014-05-31 19:40:18 -04:00
Cole Robinson
506791157e Fix some pylint 2014-05-31 17:37:19 -04:00
Cole Robinson
091eb9fe26 details: Expose LXC <initarg> 2014-05-31 17:34:23 -04:00
Cole Robinson
da73e4980b virt-install: Add --boot initargs=
Expects a shell escaped string which we split into individual initarg bits
2014-05-31 17:15:03 -04:00
Cole Robinson
eca6cd9471 virt-convert: Don't print 'convert' output with --print-xml 2014-05-31 16:41:30 -04:00
Cole Robinson
ceab99cf7b virtconv: Don't create default pool when in dry mode
We will still need to create pools to probe source storage if doing
--print-xml.
2014-05-31 16:30:00 -04:00
Cole Robinson
d6f063d0b8 diskbackend: If pool not running, start it
Nowadays we depend on the pool existing and running, so better to get
an error up front if pool startup will fail
2014-05-31 16:29:29 -04:00
Cole Robinson
9c4c1e84aa cliconfig: Better error if glib-compile-schemas is not available 2014-05-31 16:28:58 -04:00