Commit Graph

155 Commits

Author SHA1 Message Date
Cole Robinson
c8a0b8310c create: Fix a logging typo 2015-05-03 16:37:42 -04:00
Cole Robinson
0f3d86ac9e guest: Disable PM for virt-install as well
We are just mirroring the behavior that virt-manager (and boxes) have
used for a while now.

In my experience the average user is confused by their VMs suspending,
so for our sake I'd rather make people opt into this feature.
2015-04-11 18:02:45 -04:00
Cole Robinson
4781ad6cd6 connection: Simplify manager row 'pretty name' handling
Unify all the callers, and use some UI ellipsizing to handle
crazy long hostnames.

This drops the conn name collision prevention stuff which can be
useful when you have lots of similar connection names. But upcoming
patches will make it mostly redundant.
2015-04-11 12:57:32 -04:00
Cole Robinson
6071ab0ea4 uiutil: Clarify a few ambiguous function names 2015-04-10 15:00:34 -04:00
Cole Robinson
1e154a373d libvirtobject: Populate status up front
And use this to kill paranoid object tick() that are sprinkled throughout
the code.
2015-04-10 15:00:34 -04:00
Cole Robinson
a3f8d73a9c libvirtobject: Unify internal status APIs and signals
Drop config-changes vs. status-changed and just use one signal, since they
are largely the same code paths for all users.
2015-04-10 15:00:34 -04:00
Cole Robinson
01bf07ba11 libvirtobject: Unify status signals
Dispatch them all from the actual object and not proxied through
the connection. Use the same signal name for all objects with the same
signature.
2015-04-10 15:00:33 -04:00
Cole Robinson
058c06972e Break out shared storage UI to storagelist.py (bz 1060433)
We were already sharing a chunk of this in a haphazard way. Now officially
break it all out, similar to netlist.py. This mostly unifies the views
of host->storage and storagebrowser.py
2015-04-09 12:31:24 -04:00
Cole Robinson
68a11727a4 create: Show proper install options for ppc64le (bz 1209720) 2015-04-08 09:31:07 -04:00
Cole Robinson
1d98af2c47 create: Move mac address editing to customize dialog
People should rarely need to edit the mac address, so remove it from
the create wizard. However we only allow editing the mac address in
the 'customize' dialog: regular network details disables editing, since
that should be a rare and potentially dangerous operation.
2015-04-07 18:52:35 -04:00
Cole Robinson
ebfb0cd726 mediadev: Kill the abstraction, just use nodedevs
It's really a useless hold over from the days when we manually talked
to HAL.

One semi useful bit lost in the shuffle is the option to repoll cdroms
for media. But since virt-manager allows attaching a device to the
VM regardless of whether it notices media change, this plumbing is
really overkill. If libvirt ever grows nodedev events we will get this
much easier.
2015-04-07 13:59:43 -04:00
Cole Robinson
070dd60732 create: If we can't detect URL, still only show 'supported' list 2015-04-04 16:32:41 -04:00
Cole Robinson
ce73272c7e create: Drop hardcoded STABLE_OS_SUPPORT list
It's out of date, and doesn't even seem to work with current RHEL versions
and no one is complaining.

If we want to add it back, it should be an explicit setup.py configure
option.
2015-04-04 13:48:15 -04:00
Cole Robinson
595b5b4bdf osdict: Drop explicit 'type' class
create.py is the only thing that cares about this nowadays, so we can
work with things to make it all simpler.
2015-04-04 12:48:50 -04:00
Cole Robinson
647420ca90 create: Log results of recommended resources 2015-04-04 12:10:20 -04:00
Cole Robinson
bd9ab2d5b5 osdict: Add toplevel OSDB as API entry point
Makes code more readable, and lazy loading simpler.
2015-04-04 12:06:41 -04:00
Cole Robinson
b654db1d17 create: Add aarch64 to the arch priority list
Since it's reasonably well supported now
2015-04-03 17:37:34 -04:00
Cole Robinson
97259c4d9b capabilities: Store results of guest_lookup together
Simplifies API users lives to not have to remember whether caps guest
or caps domain contains a particular value.
2015-04-03 17:37:08 -04:00
Cole Robinson
81a1910d90 capabilities: Rename no_install_options -> has_install_options
It's easier to visually parse the wording
2015-04-03 17:25:29 -04:00
Cole Robinson
fe9ffe86f6 capabilities: Drop xen-only bios virt checks
These only work for xen x86, and are less relevant nowadays since HW
virt has been around for a very long time. Also it's tough to be sure
that we aren't giving a bogus warning.
2015-04-03 17:25:29 -04:00
Charles Arnold
20fe287341 virt-manager: Don't allow an empty string for a network name
When starting the 'Create virtual network' wizard, you are allowed to proceed
without specifying a Network Name.  An error only occurs after all else is
completed with the wizard. This patch stops the user from proceeding if a
network name has not been specified.

The check for an empty string is done in util.py which also effects storage
pool names and guest names neither of which should have empty strings.

Signed-off-by: Charles Arnold <carnold@suse.com>

Message-Id: <551D664702000091000F42E8@prv-mh.provo.novell.com>
2015-04-03 10:49:42 -04:00
Cole Robinson
b4a7c5e67d virt-manager: Refresh pools after VM/storage is created (bz 1146282)
After the caching changes over the past year, virt-manager's internal state
isn't accurate when virtinst creates new disk storage.

Manually update the pools at the two virtinst entry points: create.py and
addhardware.py
2015-03-26 19:08:04 -04:00
Cole Robinson
a5b3e2adab create: Try to default to UEFI for aarch64
If we detect AAVMF, set it up, and allow all install options.
If we don't find AAVMF, disable all options except import install (the
current behavior) and show a warning.
2015-02-22 10:25:51 -05:00
Giuseppe Scrivano
a063a74831 storage: change default storage size to 20G
If libosinfo fails to detect the operating system or the user doesn't
select any, use 20G by default.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-01-27 20:08:04 +01:00
Cole Robinson
01d6541f69 create: Don't show default disk path on summary page
Since it's dependent on the VM name, which the user might change
2014-12-03 13:14:36 -05:00
Cole Robinson
4a678f0543 create: Fix default storage path when VM name is changed (bz 1169141)
Regressed with 2e7ebd4 . Use skip_disk_page() to determine when we
shouldn't assume default storage
2014-12-03 13:08:18 -05:00
Cole Robinson
d178923609 create: Clarify function name
It's no longer the 'name' page
2014-12-03 10:13:39 -05:00
Guido Günther
1726505fd6 s/gconf/gsettings/
GConf got replaced by GSettings but some methods kept the old name
2014-09-29 08:56:37 -04:00
Cole Robinson
310f65273f osdict: Restrict n-cpus to 1 for machvirt
It fails to boot otherwise
2014-09-23 17:09:36 -04:00
Cole Robinson
c4162f6708 Use -M virt as default machine for arm/aarch64
Centralize the default machine logic in caps and use it consistently
2014-09-23 16:05:48 -04:00
Cole Robinson
226c4562d5 virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
Giuseppe Scrivano
9af18bf4e6 virtManager, create: re-enable distro detection with URLs
It was broken by commit 4ee97133e7

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-05 11:28:57 +02:00
Giuseppe Scrivano
4ee97133e7 virtManager, create: disable ISO detection with remote connections
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-08-04 12:14:32 +02:00
Giuseppe Scrivano
312b349fce virt-manager, create: honor untoggled "Set a fixed MAC address"
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1083461

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-22 09:25:05 +02:00
Cole Robinson
9986074ab0 connection: Revive option to show QEMU/KVM in pretty desc
I thought it was unused, but it was just grep fail
2014-07-07 18:00:10 -04:00
Tal Kain
02e2fd9cd4 vmmCreate: Fixed an AttributeError created by 7fcdd61
When trying to create a new virtual machine an exception has been thrown:
Error launching manager: 'vmmConnection' object has no attribute
'get_pretty_desc_active'

Signed-off-by: Tal Kain <tal@kain.net>
2014-07-07 17:54:19 -04:00
Giuseppe Scrivano
0deff29ee7 virtManager, create: set the model for autocompletion earlier
it fixes this error:

(virt-manager:11676): Gtk-CRITICAL **: gtk_tree_model_get_iter_first: assertion 'GTK_IS_TREE_MODEL (tree_model)' failed

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-05 12:00:49 +02:00
Giuseppe Scrivano
6e7c406b6a virtManager, create: prevent focus on widget when not visible
it fixes this error:

(virt-manager:11184): Gtk-WARNING **: GtkEntry - did not receive focus-out-event. If you connect a handler to this signal, it must return FALSE so the entry gets the event as well.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-05 12:00:49 +02:00
Chen Hanxiao
240111f091 create: fix a comment typo
s/detction/detection

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-27 10:06:24 +08:00
Chen Hanxiao
2f4a424521 use binary prefixes for units where appropriate
https://bugzilla.redhat.com/show_bug.cgi?id=1103893

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:56:53 +08:00
Giuseppe Scrivano
be63db61ad create: allow users to select a type without variant
The check made in get_config_os_info fails anytime a variant is not
found, making impossible to choose Generic.  Change it to not fail if
the OS was found.

commit 33a2d1a1c8 broke this.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-04 21:20:24 +02:00
Cole Robinson
aefd4c4824 connection: Use name instead of uuid for object keys
And clean up the API mess while we are at it. Treat the key as an opaque
value that users shouldn't depend on.

Besides the improved code clarity and API layout, this will help diagnose
'key error' issues, since we'll see an object name instead of UUID which
is hard to trace back.
2014-06-02 17:48:32 -04:00
Cole Robinson
3654d56aa6 create: Raise error if populating summary page fails 2014-05-31 13:31:08 -04:00
Cole Robinson
3d49bbe649 create: Fix error when detecting OS in 'show all' list
The will be free'd when the widget is repopulated, so don't access
stale data.
2014-04-30 15:46:06 -04:00
Cole Robinson
3ae2b0959d create: Simplify set_os_val 2014-04-30 15:45:56 -04:00
Giuseppe Scrivano
33a2d1a1c8 virt-manager: use autocomplete for OS variant selection
After the migration to libosinfo, choosing an OS variant from "New VM"
wizard became a mess for the very long list of options.
Using an autocomplete entry text will facilitate this task, as an user
can start typing the variant as soon as the OS type is selected.
The combo-box is left untouched, so undecided users can still use it.

UI-suggested-by: Máirín Duffy <duffy@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-04-26 10:32:30 +02:00
Giuseppe Scrivano
b20462d861 virt-manager: display error on an empty installation URL
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1086529

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-04-18 09:52:44 +02:00
Cole Robinson
932e6e00bb details: Fix changing graphics type (bz 1083903)
And clean up the API usage to avoid these types of issues in the future.
2014-04-03 10:53:54 -04:00
Cole Robinson
a398d245cb Clean up pylint integration
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
2014-04-02 19:00:24 -04:00
Giuseppe Scrivano
6b5171031e virt-manager: enable media detection for CD/ISO images
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-26 16:12:13 +01:00