2845 Commits

Author SHA1 Message Date
Cole Robinson
c3d54cbd20 manager: Only log 'Closing manager' if it's not already closed
Same with 'Showing manager'
2013-06-13 14:12:19 -04:00
Cole Robinson
b8d3bde4a2 autodrawer: Fix a gtk assertion at app shutdown 2013-06-13 14:10:59 -04:00
Cole Robinson
eeba8b6d0b autodrawer: Fix fullscreen toolbar centering on F19
child_get_property appears to be busted.
2013-06-13 13:55:43 -04:00
Cole Robinson
3da7f55462 create-interface: Fix VLAN tag upper limit
https://bugzilla.redhat.com/show_bug.cgi?id=863322
2013-06-12 21:27:47 -04:00
Cole Robinson
436a5bfc8b serialcon: Fix tracebacks when we get EOF on stream 2013-06-12 21:10:52 -04:00
Cole Robinson
4201ef9e68 details: Multiple screenshot improvements and fixes
- Fix screenshot after gtk3 conversion
- Report errors to the user if something goes wrong
- Drop the 'screenshot saved' success dialog
- Capture the screenshot data before asking for the file path, so things
  aren't out of date.
- Give a default recommended screenshot path to save.

First bit fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=969410
2013-06-12 21:00:11 -04:00
Martin Kletzander
77fb38e602 serialcon: Close the console at the end of the stream
When LXC guest was shut down while its console was open, virt-manager
got stuck in a loop due to the fact that the readable event was not
properly removed from the callback.  Mimicking the behavior from
libvirt's tolls/console.c file, this patch properly closes the console
in case stream.recv() returns empty string.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=968896

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-06-12 11:10:30 +02:00
Martin Kletzander
1ca9d6ebd2 Update supported models (bz 959888) 2013-06-12 10:49:30 +02:00
Cole Robinson
ff297777cc details: Don't traceback if VM deleted with open details window
When a VM is undefined, whether explicitly through virt-manager or behind
our back, we close and cleanup any associated vmmDetails windows. However
there's a race here: if the details window is the last remaining top
level window, cleanup() is called twice which tracebacks.

Fix this by dispatching the exit_app routine in an idle callback, to
avoid racing with any window delete routines.

Reported-by: Leonardo Garcia <lagarcia@br.ibm.com>
2013-06-11 11:02:56 -04:00
Leonardo Garcia
665375db1b Fix progres bar output bug in virt-clone.
The loop in StorageVolume._progress_thread that updates the cloning progress
bar has a call to sleep in the beginning of the loop which causes issues with
the progress bar. An example output (shorten to use less columns) with the
problem:

[laggarcia@fedora18 virt-manager]$ ./virt-clone --connect
qemu+ssh://root@192.168.122.1/system --original=Fedora18-test --auto-clone
root@192.168.122.1's password:
Allocating 'Fedora18-test-clone.img'                                  |  20 GB  00:00:56

Clone 'Fedora18-test-clone' created successfully.
[laggarcia@fedora18 virt-manager]$ '    4% [===-     ] -300039887.4 B/s | 881 MB  --:--:-- ETA

As the StorageVolume._progress_thread sleeps for one second when the loop
starts, it might occur that, when the cloning procedure finishes, the loop is
still awaiting to update the progress bar, which will cause a bad progress bar
update.

This simple fix solves this issue.
2013-06-10 10:20:35 -04:00
Leonardo Garcia
576721d8b2 Remove unnecessary nested try block.
This nested block has been added by python-virtinst's commit
4a9664634dd5ae65ed92b59b1f1543633c7d8112, aparently without need.
2013-06-10 09:55:17 -04:00
Cole Robinson
0f8ea6eaa6 baseclass: Clean up non-standard __init__
Only used by console.py, make it more explicit.
2013-06-08 19:25:36 -04:00
Martin Kletzander
e407c2eac9 Make pylint a bit happier
Various fixes for some pylint and pep8 warnings/errors which are
fixable and cleanup few lines with that.
2013-06-05 10:19:54 +02:00
Martin Kletzander
74aa8c8a58 Generate valid UUIDs according to RFC4122
Similar change to that made in libvrt's upstream commit 396c4d34.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=963161
2013-06-05 10:19:53 +02:00
Leonardo Garcia
6a1ad46978 Do not show manager window at startup if user requested to show any other window from command line. 2013-05-30 11:25:44 -04:00
Leonardo Garcia
efd5401378 connect_to_uri is not a public method.
connect_to_uri is only called from engine.py.
2013-05-30 11:25:44 -04:00
Cole Robinson
2274e233e0 Fix PCI commit, add CCID controller as well 2013-05-28 10:55:40 -04:00
Cole Robinson
a5a9f8e3bd Fix a couple more typos pointed out by translator 2013-05-27 20:04:55 -04:00
Cole Robinson
448730306e virtinst: Add pretty name for PCI controller 2013-05-27 19:45:14 -04:00
Cole Robinson
de1695b2a9 setup.py: Change default-graphics from spice->vnc
It's still changeable with 'configure', but this makes the unconfigured
default in line with what modern distros should use.
2013-05-27 18:51:12 -04:00
Cole Robinson
14578fc2c3 details: Fix changing cirrus->QXL for active VM (bz 928882) 2013-05-27 18:50:25 -04:00
Cole Robinson
799bca76f3 spec: Make sure libvirt-daemon-config-network is installed (bz 950329) 2013-05-27 18:41:40 -04:00
Cole Robinson
a0961e35b7 spec: Unconditionally add default-graphics=spice (bz 965864) 2013-05-27 18:40:11 -04:00
Cole Robinson
7f621db08f Fix a few wordings recommended by a translator 2013-05-27 13:41:45 -04:00
Cole Robinson
4b8d28df1d Update translations 2013-05-27 13:41:38 -04:00
Marc Deslauriers
fb76c4e550 virt-manager: Update list of Ubuntu releases
Hi,

Here's a patch to update the list of Ubuntu releases.

Thanks,

Marc.

commit 1ada943da0ec01f444b3df452e6f371d07021330
Author: Marc Deslauriers <marc.deslauriers@ubuntu.com>
Date:   Tue May 21 15:59:17 2013 -0400

    Update list of Ubuntu releases
2013-05-21 16:02:30 -04:00
Gene Czarcinski
41c782a37e static route support
The syntax for static route support is defined by the
new <route> subelement which has the form:
  <route family='xx' address='xx' prefix='n' gateway='gg' metric='m'/>
This patch builds on the previous patches for adding IPv6 support and
extending the virtual network support.

The static route support code has been recently added to libvirt and will
be included in libvirt 1.0.6.
.
Signed-off-by: Gene Czarcinski <gene@czarc.net>
2013-05-21 15:45:34 -04:00
Cole Robinson
070e19eab9 Drop 'avahi-tools' package list used during dev (bz 963472) 2013-05-15 17:35:14 -04:00
Cole Robinson
bde9943221 gsettings: Fix default for perms-fix-ignore (bz 962569) 2013-05-15 15:35:55 -04:00
Cole Robinson
0877f9a3d9 Fix some pylint 2013-05-13 16:45:51 -04:00
Guannan Ren
a4e736a7cb domain: add 'pre-startup' signal and do nodedevs checking
This patch introduces 'pre-start' signal and registers
nodedev checking handler to check duplicate USB devices.
If virt-manager can not identify unique usb device any more
before domain startup, it will throw a tip error to tell it
is time to reattach host USB devices to get updated bus/addr info.
2013-05-13 16:43:33 -04:00
Cole Robinson
f625cf66d4 testdriver: Add guest using a duplicate host USB device 2013-05-11 11:44:25 -04:00
Cole Robinson
b68faac8e8 Fix crash when creating guest from ISO media (bz 958641)
Accessing another unknown gsettings key. Should be the last one
though...
2013-05-09 20:07:29 -04:00
Cole Robinson
d8deda4264 spec: Make sure virt-manager pulls in -common (bz 958730) 2013-05-09 18:32:30 -04:00
Cole Robinson
cce9d6fb2a virt-manager: Fix error reporting with invalid cli arg (bz 959795) 2013-05-09 18:29:07 -04:00
Cole Robinson
a3da77dab6 spec: Fix dep on vte (bz 958945) 2013-05-09 18:24:09 -04:00
Guannan Ren
32f0781531 addhardware: differentiate duplicate usb devices by bus/addr
When there are multiple usb devices with same vendor/product
in the host device list, the bus/addr is going to be used when
attaching one of usb devices.

Currently is_dup flag is only useful to VirtualHostDeviceUSB.

I put get_nodedevs_number() in connection.py, so the startup
hooks can use it.
2013-05-09 13:48:18 -04:00
Guannan Ren
4c1039252a virtinst: set is_dup to true when --host-device come with bus.addr
When there are multile USB devices, --host-device with bus.addr
can identify unique device, so we need to add bus/addr info to
XML rather than only vendor/product

If there is only one USB device with --host-device bus.addr,
adding bus/addr is no harm under the request of user.
2013-05-09 13:48:18 -04:00
Michal Novotny
3f58dc5423 INSTALL: Fix typo in RPM generation command
Signed-off-by: Michal Novotny <minovotn@redhat.com>
2013-05-08 14:22:26 -04:00
Cole Robinson
d3f9bc8e7a details: Remove unused bit in the UI 2013-04-29 12:24:46 -04:00
Tadej Janež
e8e6278c65 manager: show guest machine stats under Details -> Performance.
This fixes rhbz #878425.
2013-04-29 12:20:44 -04:00
Cole Robinson
44f788bb99 setup.py: Fix sdist 2013-04-27 09:28:15 -04:00
Cole Robinson
40cbc39a98 Revert "add a checkbox for cpu host-model mode, remove 'copy' button"
host-model is a bit more scary then previous behavior, since the
model of an existing VM can transparently change across libvirt
upgrade or HW upgrade. This will probably be improved at the libvirt
level, but for now revert.

This reverts commit 17f43e47fb4022093a047b27d2ec60458e5dfcef.
2013-04-27 09:28:15 -04:00
Guannan Ren
5a316b9a51 details: the bus, device values of USB device is decimal rather than hex
Although the code in lookup_nodedev() is general to deal with
hostdev, it has to seperate USB device from PCI device there.
For PCI device, the domain/bus/slot/function is hex.
For USB device, the bus/device is decimal.

This fix makes the label use hostdev pretty_name:

 +------------------------------------------------------+
 | Physical USB Device                                  |
 |   Device: 006:032 RSA RSA SecureID (R) Authenticator |

(crobinso: fix some pylint)
2013-04-27 09:28:15 -04:00
Martin Kletzander
54c6bb6bd1 Add controller example into virt-install manual page
There was an example for USB controller, but to show all the
sub-options, there was the master= option used without extra
information about the fact that it is used for companion controllers
only.  So this patch adds second example in front of the previous one
and re-words the description a little bit.
2013-04-26 12:53:11 +02:00
Martin Kletzander
13c5ffc6cd Describe controller models in virt-install man page
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=952086
2013-04-26 08:53:42 +02:00
Guannan Ren
0802cb1add virtinst: throw error when --host-device can't specify unique device
When there are mutiple USB devices with identical vendorId and
productId, with --host-device <vendorId:productId>, virt-install
fails to specify one.
Currently the virt-install add the first node device with
these vendorId and productId.
This fix will throw out an error when argument to --host-device
can't specify unique node device.

For example:
virt-install ${other args} \
             --host-device <vendorId:productId>
ERROR    15e1:2007 corresponds to multiple node devices
2013-04-25 13:40:23 -04:00
Cole Robinson
b15e51e73b baseclass: Privatize refcount debug helper 2013-04-25 12:07:57 -04:00
Cole Robinson
6f4167a66f clone: Fix --preserve-data --file /existing/storage/vol
We were validating storage creation in a bunch of cases where we
shouldn't, since it was all skipped anyways.
2013-04-24 10:50:20 -04:00
Cole Robinson
978140b065 engine: Remove unneeded helper function 2013-04-23 20:00:12 -04:00