691 Commits

Author SHA1 Message Date
Giuseppe Scrivano
92de2db42b virtManager: always save "do not show again" setting
Any other message box performs different than "Unapplied changes",
which stores this information regardless of the user choice of
Yes/No.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1047874

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-28 19:19:17 +02:00
Giuseppe Scrivano
4ba378d1b0 virtManager, host: warn user for unapplied changes
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1047875

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-28 19:19:16 +02:00
Giuseppe Scrivano
312b349fce virt-manager, create: honor untoggled "Set a fixed MAC address"
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1083461

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-22 09:25:05 +02:00
Giuseppe Scrivano
cbb18b0e96 network: refresh the XML definition on state update
The XML definition returned by libvirt can change on a state
transition. vmmNetwork.force_update_status invalidates the old
definition.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-08 00:05:09 +02:00
Giuseppe Scrivano
e44ee980ae virtManager: add QoS information for a network
Add UI elements to display and modify QoS settings in the network
details.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1089117

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-08 00:05:09 +02:00
Cole Robinson
9986074ab0 connection: Revive option to show QEMU/KVM in pretty desc
I thought it was unused, but it was just grep fail
2014-07-07 18:00:10 -04:00
Tal Kain
02e2fd9cd4 vmmCreate: Fixed an AttributeError created by 7fcdd61
When trying to create a new virtual machine an exception has been thrown:
Error launching manager: 'vmmConnection' object has no attribute
'get_pretty_desc_active'

Signed-off-by: Tal Kain <tal@kain.net>
2014-07-07 17:54:19 -04:00
Giuseppe Scrivano
0deff29ee7 virtManager, create: set the model for autocompletion earlier
it fixes this error:

(virt-manager:11676): Gtk-CRITICAL **: gtk_tree_model_get_iter_first: assertion 'GTK_IS_TREE_MODEL (tree_model)' failed

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-05 12:00:49 +02:00
Giuseppe Scrivano
6e7c406b6a virtManager, create: prevent focus on widget when not visible
it fixes this error:

(virt-manager:11184): Gtk-WARNING **: GtkEntry - did not receive focus-out-event. If you connect a handler to this signal, it must return FALSE so the entry gets the event as well.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-05 12:00:49 +02:00
Cole Robinson
7fcdd61920 manager: Expand logic to avoid colliding connection descriptions
And drop some unused code
2014-07-04 18:20:54 -04:00
Cole Robinson
aa823b5b58 connection: Handle unsupport KeepAlive (like test URIs) 2014-07-04 18:20:54 -04:00
Cole Robinson
e12d7a6a8c connection: Report error if things fall over during connection bring up 2014-07-04 18:20:54 -04:00
Cole Robinson
f66c4ef3e4 connection: Fix error reporting if TCP creds dialog fails 2014-07-04 18:20:54 -04:00
Giuseppe Scrivano
32b9653f5b virt-manager: select the initial connection
Automatically select the connection in this order:

- URI specified via command line --connect
- First active connection
- First connection

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-02 15:31:41 +02:00
Giuseppe Scrivano
f4365b669a console: prevent access to deleted objects
last commits revealed that some objects can still be accessed by
registered callbacks after the console is closed.  Unregister these
callbacks.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-02 15:31:41 +02:00
Giuseppe Scrivano
538c68a41d virt-manager: check if still connected every 20 seconds
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-02 15:31:40 +02:00
Cole Robinson
3c2dc15af7 serialcon: Remove some redundant VTE API calls
Latest VTE doesn't seem to provide set_emulation anymore, and the other
two seem to be the default anyways. This also avoids some VTE bindings
breakage on current rawhide:

https://bugzilla.redhat.com/show_bug.cgi?id=1114379
2014-07-02 09:20:17 -04:00
Chen Hanxiao
658c9500a9 createnet: fix a small pylint
commit f109b1ed6fc93c1c74675d047affc0fe57ae7243
used a undefined variable 'PAGE_MAX'.
It looks like it should be in a developing series,
but should be fixed in upstream.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-27 09:06:14 +02:00
Chen Hanxiao
240111f091 create: fix a comment typo
s/detction/detection

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-27 10:06:24 +08:00
Giuseppe Scrivano
f109b1ed6f createnet: validate last page before creating the network
On the last page in the createnet wizard the Next button is changed to
Finish.  Ensure the user input is validated also on this page.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-26 15:26:37 +02:00
Giuseppe Scrivano
81bd6bbffb createnet: fix "show_err" typo
s|show_erro|show_err|

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-26 15:26:37 +02:00
Cole Robinson
72d0d5d8ea manager: Make it clear which functions are called from engine.py 2014-06-26 09:05:34 -04:00
Giuseppe Scrivano
eb5b261311 details.py: fix typo
s|removeable|removable|

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1112629

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-24 17:14:19 +02:00
Giuseppe Scrivano
48be09a997 createnet: use vmmInterface.get_name() instead of vmmInterface.name
It fixes this exception:

Traceback (most recent call last):
  File "virt-manager/virtManager/host.py", line 467, in add_network
    self.addnet.show(self.topwin)
  File "virt-manager/virtManager/createnet.py", line 102, in show
    self.reset_state()
  File "virt-manager/virtManager/createnet.py", line 180, in reset_state
    devnames.append(iface.name)
AttributeError: 'vmmInterface' object has no attribute 'name'

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-24 17:14:19 +02:00
Cole Robinson
c78974c0d9 connection: Drop netdev abstraction
Just open code it in the one place it's needed. Try to simplify some of
the netlist logic while we are at it. Should fix:

https://bugzilla.redhat.com/show_bug.cgi?id=1109574
2014-06-18 12:41:36 -04:00
Giuseppe Scrivano
4ac49a1d66 virt-manager: split EDIT_VCPUS and EDIT_MAXVCPUS
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1098040

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-17 17:27:47 +02:00
Giuseppe Scrivano
5c2459e6e4 createpool.py: fix creation of gluster pools
It fixes this exception:

Traceback (most recent call last):
  File "virt-manager/virtManager/createpool.py", line 454, in page_changed
    self.set_page(page_number)
  File "virt-manager/virtManager/createpool.py", line 451, in set_page
    self.show_options_by_pool()
  File "virt-manager/virtManager/createpool.py", line 292, in show_options_by_pool
    self.widget("pool-source-name").get_child().set_text(
AttributeError: 'Entry' object has no attribute 'get_child'

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-16 08:20:58 +02:00
Chen Hanxiao
2f4a424521 use binary prefixes for units where appropriate
https://bugzilla.redhat.com/show_bug.cgi?id=1103893

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:56:53 +08:00
Chen Hanxiao
ba96af8df8 addhardware: add a tool tip when USB controller already existed
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:50:04 +08:00
Chen Hanxiao
e124f3e401 addhardware: enable setting model when adding controller
This patch will enable setting controller model
when adding controller.

If no USB controller or usb model = none,
we could add a new one;
if had, disable 'create-finish' button.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:48:22 +08:00
Chen Hanxiao
7beb7db31d addhardware: move _change_config_helper from details
rename it as change_config_helper.
It will be used in the later patch.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:47:19 +08:00
Giuseppe Scrivano
3118ec5f51 createpool.py: fix comment typo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-12 10:03:32 +02:00
Chen Hanxiao
17a11672b1 createnet: enable specify /29 subnet
https://bugzilla.redhat.com/show_bug.cgi?id=1106913

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-11 09:52:07 +08:00
Giuseppe Scrivano
be63db61ad create: allow users to select a type without variant
The check made in get_config_os_info fails anytime a variant is not
found, making impossible to choose Generic.  Change it to not fail if
the OS was found.

commit 33a2d1a1c8eece3c55dd69aed1e7d4018b3d15aa broke this.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-04 21:20:24 +02:00
Cole Robinson
f686e36e42 details: Expose chipset=i440fx/q35 in customize dialog
So enterprising users can choose q35 for x86 qemu/kvm VMs. Some
discussion over here:

http://www.redhat.com/archives/virt-tools-list/2014-May/msg00001.html
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00019.html

We show a warning if q35 is selected, saying it's not well tested.
Hopefully that dissuades people who are just clicking about.
2014-06-03 15:58:04 -04:00
Cole Robinson
03670c38dc details: xen keyboard can't be removed either 2014-06-02 18:54:28 -04:00
Cole Robinson
aefd4c4824 connection: Use name instead of uuid for object keys
And clean up the API mess while we are at it. Treat the key as an opaque
value that users shouldn't depend on.

Besides the improved code clarity and API layout, this will help diagnose
'key error' issues, since we'll see an object name instead of UUID which
is hard to trace back.
2014-06-02 17:48:32 -04:00
Cole Robinson
42204c9379 connection: Add debug helper to disable libvirt events 2014-06-02 12:02:09 -04:00
Cole Robinson
d17cf4a223 console: vnc: Don't force keyboard grab before widget is realized
Causes gtk warnings on the console, and the code was mistaken anyways
2014-05-31 19:40:18 -04:00
Cole Robinson
091eb9fe26 details: Expose LXC <initarg> 2014-05-31 17:34:23 -04:00
Cole Robinson
9369ad3ac0 virt-manager: Allow setting interface portgroup element
We only show the option if the selected virtual network actually has
portgroups listed in its XML
2014-05-31 15:51:24 -04:00
Cole Robinson
519e3b5768 connection: Log when objects are added/removed 2014-05-31 13:52:13 -04:00
Cole Robinson
3654d56aa6 create: Raise error if populating summary page fails 2014-05-31 13:31:08 -04:00
Cédric Bosdonnat
2e7ebd4b76 Don't create a qemu disk image when creating containers
Make sure we don't create a default disk image if the option is checked
but not visible as this is the case for containers
2014-05-28 08:26:42 -04:00
Cole Robinson
768ff1ff84 createvol: remove redundant logging 2014-05-21 10:45:51 -04:00
Chen Hanxiao
0b21c96d34 host: fix a typo
s/Starmode/Startmode

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-05-21 16:41:30 +08:00
Cole Robinson
139392c093 createnet: Catch too small network prefix (bz 1095347) 2014-05-19 19:23:46 -04:00
Cole Robinson
51976bba2d storagevol: Log on XMLDesc errors 2014-05-19 17:32:22 -04:00
Cole Robinson
9fd0ef5c88 details: Better handling for <input type=keyboard> 2014-05-04 13:23:54 -04:00
Cole Robinson
196ff823b3 Fix warnings with latest pep8 2014-05-02 10:20:59 -04:00