shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-26 10:03:54 +03:00
Code Issues Projects Releases Wiki Activity
6,025 Commits 2 Branches 64 Tags
Commit Graph

1433 Commits

Author SHA1 Message Date
Cole Robinson
1c05db691d guest: Cache capsinfo 
Don't repeatedly look it up, was slowing down the test suite by about 5%
 2018-09-06 20:38:59 -04:00
Cole Robinson
a2fa799478 capabilities: Drop lookup_virtinst_guest 
Users should just init Guest() directly, and call
set_capabilities_defaults if they need default arch data
 2018-09-06 20:28:05 -04:00
Cole Robinson
e61f2b991b guest: Re-organize function locations 2018-09-06 20:12:49 -04:00
Cole Robinson
5f22f41da4 guest: Absorb capabilities defaults setup 
Rather than forcing API users to go through the capabilities APIs.
This lets us simplify things in virt-install quite a bit, and is
needed for smarter machine type defaults
 2018-09-06 20:12:49 -04:00
Cole Robinson
12a7a18be0 cli: Fix traceback detection 2018-09-06 18:39:14 -04:00
Cole Robinson
a754718889 devices: disk: Use uppercase naming for mode lists 2018-09-06 16:51:14 -04:00
Cole Robinson
63287c83fb addhardware: Move disk bus listing to virtinst 
Drop the stable_default stuff as domcaps usage should make
it obsolete for any cases we care about
 2018-09-06 16:40:49 -04:00
Cole Robinson
a09a46289a addhardware: Move controller list logic to virtinst 
And tweak the UI defaults a bit, preferring virtio-scsi and
usb3
 2018-09-06 16:05:12 -04:00
Cole Robinson
7994dc90c8 addhardware: Move video model list to virtinst 
And make it smart about the hypervisor
 2018-09-06 14:45:05 -04:00
Cole Robinson
b3865d7b0d addhardware: Drop tcp/udp/dev char support 
I know openstack uses tcp consoles but for end users I've never
really heard about it. RHEL compiles out udp as well. I'm fine telling
users to go to the cli and use virt-xml for this use case.

Use this opportunity to drop a lot of code that only simplified the
case when there are tons of char options we need to consider
 2018-09-06 13:28:21 -04:00
Cole Robinson
cd07d6af34 sound: Track recommended models in virtinst 
Change addhardware to show an editable model entry, like the
details wizard
 2018-09-06 13:28:21 -04:00
Cole Robinson
be1f5a6e25 devices: Remove a bunch of unused static lists 2018-09-06 13:28:21 -04:00
Cole Robinson
2b7043cd85 createpool: Fix showing formats 
But shrink the format list to 'auto' only, but also add a text entry
so users can type their own
 2018-09-06 13:28:21 -04:00
Cole Robinson
c5033c02d5 fsdetails: Use combo entry for format list 
And stop listing all the crazy qemu formats
 2018-09-06 13:28:21 -04:00
Cole Robinson
242844fefa osdict: Make the broken uefi+hyperv bit more explicit 
And add links to the relevant bug reports
 2018-09-04 14:55:40 -04:00
Cole Robinson
4394eff9fa xmlbuilder: Drop last usages of set_converter 
Unfold most of them into manual property() wrappers. It's a bit
noisier but the logic is easier to follow.
 2018-09-04 14:55:04 -04:00
Cole Robinson
bd35f4711c devices: disk: Rename setup() to build_storage() 
It's more explicit. Plus drop the supposedly generic setup()
entry point, storage is handled specially everywhere so it's
not a generic interface
 2018-09-04 14:55:04 -04:00
Cole Robinson
ebd6091cc8 devices: interface: Simplify is_conflict_net calls 
We don't return a non-fatal error these days, so adjust all callers
to only handle failure
 2018-09-04 14:55:04 -04:00
Cole Robinson
c27cdc67de devices: interface: Convert setup() to validate() 
That's all it's doing. Fold in mac validation while we are here
 2018-09-04 14:55:04 -04:00
Cole Robinson
43f40950eb devices: Remove some redundant char/rng xml callbacks 
I think these aren't needed after the default fixing stuff, or maybe
past xmlbuilder fixes
 2018-09-04 14:55:04 -04:00
Cole Robinson
2e9a11b220 xmlbuilder: Drop last remaining validate_cb usage 
Fold the interface bits into the existing validate() function
 2018-09-04 14:55:04 -04:00
Cole Robinson
6711b538ef sysinfo: Remove validate date 
Libvirt does this for us, no need to duplicate it
 2018-09-04 14:55:04 -04:00
Cole Robinson
852d7b564d virtinst: Remove name field validate_cb usage 
Either openly do this at callers, or wrap it in a validate() call.
Doing this at set time has always had issues, like the self.replace hack
 2018-09-04 14:55:04 -04:00
Cole Robinson
2ac54ac001 guest: Drop self.installer and start_install wrapper 
This changes all the callers to invoke start_install directly on the
Installer object. We still stash the installer instance inside the
guest object in create.py, just for simplicity
 2018-09-04 14:55:04 -04:00
Cole Robinson
c154bbacd4 guest: Fold add_default_devices into set_defaults 
It doesn't have any need anymore to be separate
 2018-09-04 14:55:04 -04:00
Cole Robinson
f1bbc5f67a guest: move set_install_defaults to installer class 
It's only called explicitly in one place, so update the caller
 2018-09-04 14:55:04 -04:00
Cole Robinson
8a6a491306 guest: Drop self.autostart and self.replace 
Require callers to pass autostart as an argument to start_install
self.replace isn't even used for guest installs
 2018-09-04 14:55:04 -04:00
Cole Robinson
9e05c56397 guest: Drop self.domain 
The only user is virt-install, make its usage explicit
 2018-09-04 14:55:04 -04:00
Cole Robinson
fdbb1f9e5a installer: Absorb all guest start_install handling 
Really it makes more conceptual sense that the Installer class
should handle start_install and friends, but that's difficult
because the layering is all mixed up.

Start to untangle it by moving all those routines to the Installer
class and adding wrapper APIs to Guest to maintain compat for now.
 2018-09-04 14:55:04 -04:00
Cole Robinson
1abbdfc551 installer: Drop isinstall parameter 
Separate the install from postinstall config case more clearly,
so the installer is only ever altering bits for the install-time
case, and Guest handles actually writing postinstall bits
 2018-09-04 14:55:04 -04:00
Cole Robinson
068c8aedd2 installer: Remove ContainerInstaller and ImportInstaller 
Fold their non-logic into the base Installer class
 2018-09-04 14:55:04 -04:00
Cole Robinson
0ed8946a5a xmlbuilder: Remove the default_cb and default_name logic 
It was always very hard to follow the logic chain with default_*
settings, having it explicit in set_defaults() function calls is
much easier to follow and more flexible for the future
 2018-09-04 14:55:04 -04:00
Cole Robinson
1e76496fa8 storage: remove default_cb usage 2018-09-04 14:55:04 -04:00
Cole Robinson
221dd00cb9 devices: disk: remove default_cb usage 2018-09-04 14:55:04 -04:00
Cole Robinson
fff3c88f9c devices: disk: Absorb Guest bus/target default setting 
Simplifies cli stuff as a nice side effect
 2018-09-04 14:55:04 -04:00
Cole Robinson
4e7652b548 domain: cpu: Add set_defaults 2018-09-04 14:55:04 -04:00
Cole Robinson
cf65bef6f5 domain: clock: add set_defaults 2018-09-04 14:55:04 -04:00
Cole Robinson
d5bff2c987 guest: Remove default_cb usage 
This lets us simplify things in create.py a bit, since we don't
need to manually encode a UUID
 2018-09-04 14:55:04 -04:00
Cole Robinson
e6219504ce domain: os: Add set_defaults 2018-09-04 14:55:04 -04:00
Cole Robinson
c1443f8a80 guest: Remove fallback xen loader/emulator handling 
This has been provided by libvirt caps for a long time, and we
don't even test it
 2018-09-04 14:55:04 -04:00
Cole Robinson
468f5e67fa domain: pm: Add set_defaults 2018-09-04 14:55:04 -04:00
Cole Robinson
5517033c79 domain: seclabel: Add set_defaults 2018-09-04 14:55:04 -04:00
Cole Robinson
9a5b903086 domain: features: Add set_defaults 
And move all the Guest logic there.

We need to add an xmlbuilder helper _prop_is_unset to be able to
determine if a bool property is unset, in our quest to remove
default_* xmlbuilder bits
 2018-09-04 14:55:04 -04:00
Cole Robinson
640a068650 devices: controller: Add set_defaults 2018-09-04 14:55:04 -04:00
Cole Robinson
6215f790f5 devices: filesystem: Add set_defaults 
Requires a bit of rework in virt-manager handling, which had lots
of explicit "default" handling
 2018-09-04 14:55:04 -04:00
Cole Robinson
ef83565e48 devices: hostdev: Add set_defaults 2018-09-04 14:55:04 -04:00
Cole Robinson
0f918a4bd5 addhw: Move interface model list to virtinst 
So we are keeping the default and model list logic closer together,
as its similar
 2018-09-04 14:55:04 -04:00
Cole Robinson
64dc334538 devices: interface: Add set_default function 
Move all the Guest network default logic to it, and drop a now
redundant test
 2018-09-04 14:55:04 -04:00
Cole Robinson
7b5f1a304d guest: Publicize _os_object as osinfo 2018-09-04 14:55:04 -04:00
Cole Robinson
347143982a devices: Add set_defaults for memballon, redirdev, rng, smartcard 2018-09-04 14:55:04 -04:00