Fabiano Fidêncio
473f5c14d6
installer*.py: Remove temporary dirs
...
Together with the temporary files removal, let's also remove the
directories created to store those files.
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
2019-06-07 13:41:57 -04:00
Fabiano Fidêncio
2dd006d6f2
installer: Log when cleaning up the unattended files
...
Similarly to what's already done in installertreeinfo.py, let's log when
removing the files used during the unattended installation.
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
2019-06-07 13:41:57 -04:00
Fabiano Fidêncio
98bd275969
unattended: Do not create a "unattended" dir
...
Let's just use mktemp() as done in several other places and avoid the
risk of having the content of the folder overwritten in case of parallel
installations.
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
2019-06-07 13:41:57 -04:00
Cole Robinson
e58d765ae5
tests: xmlconfig: Add tests for real uuid and mac generation
2019-06-06 18:35:36 -04:00
Cole Robinson
2bd08bee64
util: Move generate_uuid to a Guest staticmethod
2019-06-06 18:24:23 -04:00
Cole Robinson
f4f8cfb33b
util: Remove validate_macaddr
...
Libvirt does this for us
2019-06-06 18:11:01 -04:00
Cole Robinson
f47f6f3c7c
util: Replace xml_indent with textwrap.indent
2019-06-06 18:11:01 -04:00
Cole Robinson
50addfebca
nodedev: Drop the non-standard .parse() handling
2019-06-05 16:35:34 -04:00
Cole Robinson
ab0c99057b
nodedev: Fold DRMDevice into NodeDevice
2019-06-05 16:35:34 -04:00
Cole Robinson
87b2ea4672
nodedev: Fold SCSIBus into NodeDevice
2019-06-05 16:35:34 -04:00
Cole Robinson
8d13125564
nodedev: Fold StorageDevice into NodeDevice
2019-06-05 16:35:34 -04:00
Cole Robinson
eeb7babef7
nodedev: Fold SCSIDevice into NodeDevice
2019-06-05 16:35:34 -04:00
Cole Robinson
cf3bc3eb3b
nodedev: Remove unused USBBus parsing
2019-06-05 16:35:34 -04:00
Cole Robinson
b7ac99473d
nodedev: Fold USBDevice into NodeDevice
2019-06-05 16:35:34 -04:00
Cole Robinson
a0881bc6f2
nodedev: Fold PCIDevice into NodeDevice
2019-06-05 16:35:34 -04:00
Cole Robinson
ca804c5b5e
nodedev: Fold NetDevice into NodeDevice
2019-06-05 16:35:34 -04:00
Cole Robinson
966b0b5a6b
nodedev: Drop cap 'system' parsing
...
We don't use it for anything internally
2019-06-05 16:35:34 -04:00
Cole Robinson
9e56169813
connection: Drop unused filter_nodedevs devcap value
2019-06-05 16:35:34 -04:00
Cole Robinson
8221061ec5
domain: Absorb conn.get_nodedev_count
...
It's the only user
2019-06-05 16:35:34 -04:00
Cole Robinson
d167021b0f
osdict: Drop the solaris10 x2apic hack
...
The upstream kvm bug has never been resolved. I think this is
obscure enough nowadays that we don't need to track and test it
2019-06-05 16:35:34 -04:00
Cole Robinson
2510c299f5
Use shutil.which instead of distutils find_executable
...
The former is the more standard library method for this
with python3
2019-06-05 16:35:34 -04:00
Cole Robinson
d2462367ee
virt-manager: Add --test-options
...
Will take a string of comma separated options which we can use to
tweak app behavior, for testing. Convert the existing --test-* options
to use the same abstraction internally. This will make it easier to
add new test options in the future
2019-06-05 16:28:05 -04:00
Cole Robinson
d65f54dc9d
uitests: Enable accessibility if it's turned off
2019-06-05 16:28:05 -04:00
Cole Robinson
09b0caec42
uitests: More work to fix newvm.py flakiness
2019-06-05 16:22:41 -04:00
Cole Robinson
3734148b8c
uitests: Improve click() onscreen handling
2019-06-05 12:27:03 -04:00
Cole Robinson
85f5b18a08
uitests: Improve mediachange assertion check
2019-06-05 12:26:35 -04:00
Cole Robinson
72dd4c8f83
config: Disable libguestfs inspection with --test-first-run
...
Adds some non-determinism to the active tests and pollutes the logs
2019-06-05 11:15:28 -04:00
Cole Robinson
f2304664d6
snapshots: Split out vmmSnapshotNew class
...
Simplifies code org
2019-06-05 11:15:28 -04:00
Cole Robinson
318e0c0a39
vmwindow: Clean up vmmDetails on window cleanup
2019-06-05 11:13:33 -04:00
Cole Robinson
87a73b07e2
installer: Remove cdrom by path, not device handle
...
The latter doesn't play well with Customize wizard XML editing, which
recreates objects
2019-06-05 11:13:33 -04:00
Cole Robinson
d6e241897f
createpool: Fix a couple gtk stderr warnings
2019-06-05 11:13:33 -04:00
Cole Robinson
bc232eb8de
devices: disk: Drop DIR+floppy validation
...
Libvirt already gives us a similar warning at parse time, this is
obscure enough that we don't need to catch it upfront
2019-06-05 11:13:33 -04:00
Cole Robinson
08b26e9b1c
devices: disk: Add tests for missing _storage_backend
2019-06-05 11:13:33 -04:00
Cole Robinson
f22a0ec2e4
xmlbuilder: Add replace_child
...
This will be used for UI XML editing of devices
2019-06-05 11:13:33 -04:00
Cole Robinson
5e7322edca
libvirtobject: Make _redefine overrides more clear
2019-06-05 11:13:33 -04:00
Cole Robinson
78526aea74
man: virt-install: mention <iothreadids> too
2019-06-04 14:17:45 -04:00
Athina Plaskasoviti
27a51b2210
cli: Add --iothreads iothreadids.iothread[0-9]*.id
...
XML Mapping:
<domain>
...
<iothreadids>
<iothread id="X"/>
...
</iothreadids>
...
</domain>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-06-04 14:17:01 -04:00
Cole Robinson
fe20c4c96e
man: virt-install: Document --iothreads
2019-06-04 10:58:31 -04:00
Athina Plaskasoviti
8c708210db
cli: Add --iothreads
...
XML Mapping:
<domain>
...
<iothreads>X</iothreads>
...
</domain>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-06-04 10:58:31 -04:00
Athina Plaskasoviti
304b323f5d
cli: Fix add --memballoon stats.period
...
XML Mapping
<memballoon model=...>
<stats period="10"/>
</memballoon>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-05-29 14:03:14 -04:00
Athina Plaskasoviti
5b443fd383
cli: Fix --memballoon autodeflate
...
Fixing commit ebf2199875
XML Mapping:
<memballoon model="virtio" autodeflate="on"/>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-05-28 17:32:58 +02:00
Athina Plaskasoviti
ebf2199875
cli: Add --memballoon autodeflate
...
XML Mapping:
<memballoon model=...>
<autodeflate>on</autodeflate>
</memballoon>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-05-23 10:03:27 -04:00
Pavel Hrdina
06c2f87397
cli: fix cpu secure option to actually work
...
The 'secure' option is processed after the model is already set.
CPU security options are resolved while setting CPU model so we need
to know the 'secure' option value before we set the CPU model.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2019-05-22 16:40:54 +02:00
Pavel Hrdina
abda575e48
tests: include CPU security features in kvm q35 domcapabilities
...
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2019-05-22 14:09:59 +02:00
Athina Plaskasoviti
35c53fc02c
cli: Add --disk rawio
...
XML mapping:
<disk type=... rawio="yes">
...
</disk>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
2019-05-20 15:32:04 +02:00
Cole Robinson
0b4c6dd066
addhardware: tpm: select version 2.0 by default
...
The full default selection of CRB + version 1.2 is explicitly
rejected by libvirt. Select version 2.0 by default so it has
a chance of working
2019-05-17 15:57:53 -04:00
Cole Robinson
2b49fae921
details: Align cpu model combo left
2019-05-17 15:35:41 -04:00
Athina Plaskasoviti
d171489f7d
cli: Add --disk wwn
...
XML mapping:
<disk>
<wwn>...</wwn>
</disk>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Athina Plaskasoviti <athina.plaskasoviti@gmail.com>
2019-05-17 15:29:18 -04:00
Cole Robinson
0366eb15e2
docs: Multiple updates
...
* Renaming HACKING.md to CONTRIBUTING.md, special github naming
* Point to modern virt-manager.org bug link
* Mention option to use github issue tracker
* Point to the github wiki for more contribution docs
* Many minor updates
2019-05-16 16:31:27 -04:00
Cole Robinson
d50187e65c
setup: Make codespell an optional part of the 'pylint' target
2019-05-16 14:43:31 -04:00