shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2024-10-27 01:55:20 +03:00
Code Issues Projects Releases Wiki Activity
6,742 Commits 2 Branches 63 Tags 97 MiB
df80852952
Commit Graph

1671 Commits

Author SHA1 Message Date
Cole Robinson
df80852952 addhardware: add xmleditor UI 2019-06-13 07:15:46 -04:00
Cole Robinson
0937c1e54b createvol: add xmleditor UI 2019-06-13 07:15:46 -04:00
Cole Robinson
68b3cb16e5 createpool: add xmleditor UI 2019-06-13 07:15:46 -04:00
Cole Robinson
50d13d8c12 storagelist: add xmleditor UI 2019-06-13 07:15:46 -04:00
Cole Robinson
7d9d8d9237 createnet: add xmleditor UI 2019-06-13 07:15:46 -04:00
Cole Robinson
5f4510b4df hostnets: add xmleditor UI 2019-06-13 07:13:43 -04:00
Cole Robinson
18af72212b xmleditor: Add the shared code 
The XML editor ui is a two tabbed notebook, one 'Details' tab
and one 'XML' tab. The latter has a gtksourceview and allows editing
the raw libvirt XML for whatever the selected object is.

API users will programmatically insert the xmleditor notebook into
their UI, with the existing UI under the details tab.
 2019-06-13 07:13:43 -04:00
Cole Robinson
ecb60c3062 Drop use of logging.info 
Just use logging.debug in these random places
 2019-06-11 17:55:09 -04:00
Cole Robinson
078348fbbf create: move generate_name to Guest 
This will be used by virt-install.
Tweak the logic a bit to not have 'generic' in the name
 2019-06-11 17:54:45 -04:00
Cole Robinson
387614c641 generatename: Move libvirt collision handling to callers 
Make every caller pass an explicit cb that handles libvirt
collision processing. Makes it easier to see exactly what is going
on at the call impls
 2019-06-11 17:54:45 -04:00
Cole Robinson
47a6f3a6d5 storage: Handle guest collision checking 
This pattern is already used in two places. Formalize and centralize
it
 2019-06-11 17:54:45 -04:00
Cole Robinson
58dfe05344 virtManager: Remove some unnecessary generatename collidelist usage 
The libvirt callbacks will handle this for us already
 2019-06-11 17:54:45 -04:00
Cole Robinson
6e6a0b8a6a connection: Use shared default pool lookup logic 
It wasn't abiding a different pool name pointing to our default
path
 2019-06-11 17:54:45 -04:00
Cole Robinson
e27202d178 createpool: Use StoragePool.default_target_path 
Indirectly, rather than the less useful get_default_dir
 2019-06-11 17:54:45 -04:00
Cole Robinson
abb4719cee addstorage: Drop non-storagepool fallback code 
This isn't tested, and the usecase will error later anyways when
we attempt to create storage.
 2019-06-11 17:54:45 -04:00
Cole Robinson
b5a664bd1b virtinst: move UI only functions into virtManager 
These throw off code coverage testing. They are mostly:

* pretty* device helpers
* network + snapshot validation + creation routines
 2019-06-09 18:33:45 -04:00
Cole Robinson
388850f04e virtinst: Rename util to xmlutil 
The only functions left in there are largely for xml handling, so
make it explicit
 2019-06-07 18:21:24 -04:00
Cole Robinson
6677f677da util: move generate_name to generatename.py 2019-06-07 18:16:53 -04:00
Cole Robinson
c2de4d7c36 util: Move get_cache_dir to VirtinstConnection 
Renaming it get_app_cache_dir so it doesn't conflict with get_cache_dir
usage in virtManager
 2019-06-07 17:53:15 -04:00
Cole Robinson
6f5cd58ead util: Move pretty_* into virtManager code 2019-06-07 17:21:25 -04:00
Cole Robinson
ca10e4094b util: move is_error_nosupport to SupportCache 2019-06-07 16:49:19 -04:00
Cole Robinson
ecc3e3d34e support: add is_libvirt_error_no_domain 
Repurpose the generic util.exception_is_libvirt_error for the one
purpose that it's actually used, add it as a SupportCache staticmethod,
and test it
 2019-06-07 16:44:14 -04:00
Cole Robinson
f85e6def55 support: Convert callers to the new format 2019-06-07 16:26:03 -04:00
Cole Robinson
566a4681a8 support: Rework support check invocations 
SupportCache.check_support(SUPPORT_FOOBAR, args) becomes
SupportCache.foobar(args)

And SupportCache absorbs the caching infrastructure from
VirtinstConnection.

For now we add some hackery to hide the API change from callers, but
this will be undone in the next patch
 2019-06-07 16:25:39 -04:00
Cole Robinson
3d2f678c0f support: Add a SupportCache class 
For now it just contains all the SUPPORT ID numbers and public
functions.
 2019-06-07 15:56:23 -04:00
Cole Robinson
50addfebca nodedev: Drop the non-standard .parse() handling 2019-06-05 16:35:34 -04:00
Cole Robinson
ab0c99057b nodedev: Fold DRMDevice into NodeDevice 2019-06-05 16:35:34 -04:00
Cole Robinson
b7ac99473d nodedev: Fold USBDevice into NodeDevice 2019-06-05 16:35:34 -04:00
Cole Robinson
a0881bc6f2 nodedev: Fold PCIDevice into NodeDevice 2019-06-05 16:35:34 -04:00
Cole Robinson
9e56169813 connection: Drop unused filter_nodedevs devcap value 2019-06-05 16:35:34 -04:00
Cole Robinson
8221061ec5 domain: Absorb conn.get_nodedev_count 
It's the only user
 2019-06-05 16:35:34 -04:00
Cole Robinson
d2462367ee virt-manager: Add --test-options 
Will take a string of comma separated options which we can use to
tweak app behavior, for testing. Convert the existing --test-* options
to use the same abstraction internally. This will make it easier to
add new test options in the future
 2019-06-05 16:28:05 -04:00
Cole Robinson
72dd4c8f83 config: Disable libguestfs inspection with --test-first-run 
Adds some non-determinism to the active tests and pollutes the logs
 2019-06-05 11:15:28 -04:00
Cole Robinson
f2304664d6 snapshots: Split out vmmSnapshotNew class 
Simplifies code org
 2019-06-05 11:15:28 -04:00
Cole Robinson
318e0c0a39 vmwindow: Clean up vmmDetails on window cleanup 2019-06-05 11:13:33 -04:00
Cole Robinson
d6e241897f createpool: Fix a couple gtk stderr warnings 2019-06-05 11:13:33 -04:00
Cole Robinson
5e7322edca libvirtobject: Make _redefine overrides more clear 2019-06-05 11:13:33 -04:00
Cole Robinson
0b4c6dd066 addhardware: tpm: select version 2.0 by default 
The full default selection of CRB + version 1.2 is explicitly
rejected by libvirt. Select version 2.0 by default so it has
a chance of working
 2019-05-17 15:57:53 -04:00
Cole Robinson
9d78759ac5 devices: redirdev: Use CharSource 
redirdev does the same internally for libvirt, so let's follow that
pattern, and fix the fallout
 2019-05-14 11:57:50 -04:00
Cole Robinson
6d46e37e09 devices: rng: Use CharSource 
Re-use CharSource, just like libvirt does internally. Adjust all
callers to match. Rename type -> backend_model while we are here,
because type is ambiguous
 2019-05-14 11:57:50 -04:00
Cole Robinson
b2b9d7d366 devices: char: Add CharSource 
Move all ./source handling into CharSource, which will be reused by
other device classes as well. This requires us to add ../ handling
into our xmlapi xpath engine
 2019-05-14 11:57:50 -04:00
Cole Robinson
1b3e8e1a32 addhardware: Remove supports_property usage 
It's not a pattern I think is worth extending in the future, and
make internal refactorings more difficult. Drop it, and drop it
from tpm and char devices since it is now unused
 2019-05-13 14:06:32 -04:00
Cole Robinson
bd6f751657 details: Drop char supports_property usage 
Whether we show something in the UI should be more dependent on
whether it's actually set in the XML, not some internal hardcoded
list which can go out of date.
 2019-05-13 13:38:46 -04:00
Cole Robinson
e6eb1d447b devices: char: Rename some properties to better match XML 
* bind_port -> bind_service
* source_host -> connect_host
* source_port -> connect_service
 2019-05-13 12:35:55 -04:00
Cole Robinson
a6495bb38f domain: virtinst: custom implement _redefine_xmlobj 2019-05-13 12:09:39 -04:00
Cole Robinson
cfa1a0569b create: Use self._guest less in install path 
Pass it around to all the callbacks as needed. Makes the flow easier
to follow
 2019-05-13 12:09:39 -04:00
Cole Robinson
a54b83072a addhardware: Remove unused is_customize_dialog 2019-05-13 12:09:39 -04:00
Cole Robinson
201dfdb23e netlist: Don't spam logs with errors on app shutdown 2019-05-13 12:08:55 -04:00
Cole Robinson
583dae7af5 details: Clarify config_apply variable names 2019-05-13 12:08:55 -04:00
Cole Robinson
a506e3c108 details: Have a separate hw column for unique key 
Right now we overload the DEVICE column for non-device pages
like overview or memory. Add a separate column for KEY, and have
DEVICE==None for non-device pages
 2019-05-13 12:08:55 -04:00