Cole Robinson
e0190f7b5e
XMLBuilder: Drop some is_parse checking
2013-07-24 10:40:35 -04:00
Cole Robinson
2ba3ec2684
Guest: Convert to new style XML prop, drop a bunch of XML infrastructure
...
Now every XML property is new style, without explicit local get/set
handlers. Drop a bunch of XML infrastructure that was helping with the
transition.
2013-07-24 07:54:04 -04:00
Cole Robinson
326731cfc5
xmlbuilder: Remove order_elements hack
2013-07-23 17:34:32 -04:00
Cole Robinson
e802eae07b
VirtualCharDevice: Convert to new style XML props, rework API
2013-07-23 17:34:31 -04:00
Cole Robinson
e5230e90e9
VirtualAddress: Convert to new style XML properties
...
This adds a bunch of extra XML parsing infrastructure to make everything
work the same.
2013-07-15 10:40:12 -04:00
Cole Robinson
7cfe4ddb4d
VirtualDisk: Move xml cleanup to a global xmlbuilder hook
2013-07-14 18:31:33 -04:00
Cole Robinson
c7ca9c88e3
VirtualDisk: Convert path to new style XML property
...
Due to the complexity here, we hide the XML bits under _xmlpath, and use
path to cover the internal state integration.
2013-07-14 18:16:17 -04:00
Cole Robinson
13d8a4dae5
VirtualDisk: convert driver_type and driver_name to new style property
2013-07-14 18:16:01 -04:00
Cole Robinson
1a74a8fda6
VirtualDisk: Convert 'type' to new style XML property
2013-07-14 18:15:47 -04:00
Cole Robinson
ae74bd662f
VirtualDisk: Convert device property to new implicit style
2013-07-14 17:15:12 -04:00
Cole Robinson
2cea517823
xmlbuilder: Allow classes to specify order of certain xml elements
...
This will save us some test case churn. As an example, we now
do auto building of disk <target> XML and it doesn't alter things.
Without this bus and target are often swapped.
2013-07-14 16:45:28 -04:00
Cole Robinson
ed8d785eef
VirtualDisk: Drop driver_name = "qemu" from set_defaults
...
Our property functions should already handle that.
2013-07-14 16:35:25 -04:00
Cole Robinson
70d34e928e
VirtualDisk: Drop set_vol_object, it is barely used
...
And it complicates syncing state. Make points where we sync values
more explicit.
2013-07-14 16:35:09 -04:00
Cole Robinson
6506fb2995
VirtualDisk: Drop is_parse conditional if changing device
...
We can easily push this up to the caller, nothing really changes the
device of an existing device in practice.
2013-07-14 16:35:09 -04:00
Cole Robinson
d3dbbe9f54
xmlbuilder: Add explicit support for refreshing an XML prop
2013-07-14 16:34:54 -04:00
Cole Robinson
69e1d66b53
xmlbuilder: Few misc cleanups and streamlinings
2013-07-13 22:51:54 -04:00
Cole Robinson
7d75a43e33
XMLProperty: Add convenience param is_int
2013-07-13 21:49:32 -04:00
Cole Robinson
5f58d05051
VirtualDisk: Convert more XMLProperties to the new world order
2013-07-13 21:40:54 -04:00
Cole Robinson
02f35628fb
VirtualDisk: Make get_xml_config not have side effects
...
Move all the defaults setting to a set_defaults function, wire it
up to Guest.get_xml_config.
2013-07-13 20:22:19 -04:00
Cole Robinson
e04dfdd4ff
virtinst: Test rhel defaults, and make sure it doesn't break test suite
2013-07-13 20:01:07 -04:00
Cole Robinson
b152e83fef
virtinst: Rename XMLBuilderDomain.py -> xmlbuilder.py
...
And XMLBuilderDomain -> XMLBuilder
And _xml_property -> XMLProperty
2013-07-13 18:57:24 -04:00
Cole Robinson
4ce1774d53
VirtualDisk: Rework provisioning and validation behavior
...
We separate all the provisioning bits to diskbackend.py. VirtualDisk
users now need to explicitly opt in to storage creation by using
set_create_storage().
validation is no longer done automatically, users must call the
validation() command.
__init__ drops all extra parameters.
This will eventually get us to a point where we can unify the manual
XML building and XML parsing machinery, and get consistent validation
behavior between devices.
2013-07-13 16:37:33 -04:00
Cole Robinson
fbf2d9ee40
VirtualDisk: Convert simple props to unified parse/get/set
2013-07-12 15:26:51 -04:00
Cole Robinson
dcd632da80
XMLBuilder: Provide default fget and fset impls
...
This is the first step towards unifying the XML handling split between
parsing and creating from scratch. Demonstrate it with VirtualDisk.iotune
bits.
2013-07-12 14:41:29 -04:00
Cole Robinson
0d5fe93048
Centralize XML helpers in virtinst/util.py
2013-07-12 13:10:23 -04:00
Cole Robinson
f1b55090d2
VirtualDisk: Drop cache and io from __init__
...
They are barely used and can be specified separately.
2013-07-12 13:10:23 -04:00
Cole Robinson
57d4fcab33
VirtualDisk: Drop the volName parameter, it's not needed
2013-07-12 13:10:22 -04:00
Cole Robinson
c151b75896
XMLBuilder: Remove largely unused validation helpers
...
They aren't adding much value
2013-07-12 13:10:22 -04:00
Cole Robinson
318ba7e474
VirtualConnection: Deal with Guest objects, not raw XML
...
We already do XML parsing, no need to open code it elsewhere
2013-07-10 20:09:51 -04:00
Cole Robinson
3d1b1735ee
XMLBuilder: Simplify XML deference
...
As long as we carry around a reference for every time we lookup
a sub node and use a wrapper class to do the free'ing, we should
be fine.
2013-07-10 20:09:51 -04:00
Cole Robinson
7a2caee6e1
VirtualConnection: Allow using virt-manager object caches
...
So when we call into virtinst it doesn't do a whole round of object
lookup and XML fetching.
2013-07-07 18:54:08 -04:00
Cole Robinson
9d560f7d9a
VirtualDisk: Always return VM names from is_conflict_disk
2013-07-07 16:34:46 -04:00
Cole Robinson
d5dc06148d
virtinst: Move fetch_all_guests to connection object
...
And fetch_all_pools. And have it use pollhelpers
2013-07-07 15:14:59 -04:00
Cole Robinson
94f8d4cfa9
VirtualConnection: cache capabilities XML
...
This means we can drop passing around the pre-parsed caps info everywhere.
2013-07-06 14:12:13 -04:00
Cole Robinson
492a039f7d
VirtualConnection: proxy virtinst.support API
...
Simplifies the lives of callers, and will allow us to do caching later
2013-07-06 12:40:24 -04:00
Cole Robinson
ec734191fc
virtinst: connection: Absorb all scattered URI helpers
2013-07-06 12:40:24 -04:00
Cole Robinson
57e86259d8
Make conn required for all virtinst objects
...
This was the way the API had been heading, this just formalizes it.
2013-07-05 20:28:21 -04:00
Cole Robinson
4c967118d4
VirtualDisk: Remove vdisk provisioning
...
Since we haven't had any patches from Sun/Oracle for 4 years, and this
stuff should really go through libvirt storage APIs anyways.
2013-07-03 11:53:17 -04:00
Cole Robinson
80e6389b75
Fix a spelling error
2013-06-30 14:33:01 -04:00
Martin Kletzander
af9762313e
Fix VirtualDisk formatting
...
Add EOLs after iotune elements and add address generation when the
address is set.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-06-19 18:18:32 -04:00
Cole Robinson
a55bb900fc
VirtualDisk: Fix iotune code indentation
2013-04-17 13:15:24 -04:00
Cole Robinson
9f3b21c9a1
Shorten iotune names for simplicity
...
And refactor some of the virt-manager code for the same goal.
2013-04-16 18:37:42 -04:00
Cole Robinson
0d243983d0
Revive pep8 and clean up the code
...
autopep8 is pretty cool :)
2013-04-13 15:22:43 -04:00
Cole Robinson
3f79fa3919
Fix the last of the pylint messages
...
If using an older pylint, there are still some complaints about hashlib
and Popen, but those aren't our problems.
2013-04-13 13:45:08 -04:00
Cole Robinson
c5e45ae448
Remove all relative imports
...
We also drop VirtualDevice from the 'public' virtinst API, since there
are better ways to get its info.
2013-04-12 08:27:44 -04:00
Cole Robinson
927bcc11cd
virtinst: util: Move URI helpers to their own file
...
Helps us avoid some relative imports, and makes things cleaner.
2013-04-11 12:15:38 -04:00
Cole Robinson
e0e3c212e4
virtinst: Remove manual selinux bits
...
Wasn't very useful to begin with, and modern day svirt correctly
handles things.
2013-04-11 12:15:37 -04:00
Cole Robinson
b3779eec7d
Remove old 'Xen' class name back compat
2013-04-11 12:15:37 -04:00
Cole Robinson
3bce20d974
virtinst: Combine util.py and _util.py
...
Was originally split to not pollute the public API, but we aren't public
anymore
2013-04-11 12:15:37 -04:00
Cole Robinson
d6c8ad0297
Wire up python unit tests, unify gettext setup
2013-04-03 18:22:05 -04:00