Commit Graph

169 Commits

Author SHA1 Message Date
Cole Robinson
cbf38cbe9f pylint: Ignore new warnings 2014-10-27 19:53:25 -04:00
Wei Huang
2d6422e10b virt-manager/details: add checking code for CPU threads
This patches adds the support to check the thread # against the
selected CPU model. If the selected # of CPU threads > 1 and CPU
model does not support hyper-threading, a warning message will be shown.

Signed-off-by: Wei Huang <wei@redhat.com>
2014-10-27 18:05:21 -04:00
Giuseppe Scrivano
750eeaad98 virt-manager, details: properly check for pool presence
commit 5e8f35f5e6 introduced this
problem.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-10-14 12:23:08 +02:00
Lubomir Rintel
835d40b151 addhardware, details: STOCK_DIRECTORY is gone
It's no longer present in Gtk+ 3.14 and deprecated since at least 3.10 in favor
of named "folder" icon. That seems a good fit, a quick check on my system finds
it present in all themes that are available.
2014-10-06 12:14:14 -04:00
Giuseppe Scrivano
5e8f35f5e6 virt-manager, details: fix path and size for disk type='volume'
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146869

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-09-26 16:24:59 +02:00
Cole Robinson
e1b646594c console: Hide display widget from consumers
There were several layering violations, make it explicit by making
display private, and providing APIs for everything the consumers
need.
2014-09-21 13:25:43 -04:00
Cole Robinson
b0d5198b7a virt-manager: Switch 'Copy host' to use host-model (bz 1133155)
Similar to the previous change for virt-install
2014-09-20 20:44:14 -04:00
Cole Robinson
f2ff378a9d details: Avoid some misleading logging on rename 2014-09-20 16:18:10 -04:00
Cole Robinson
56c091600a details: Move hostdev prettyifier to virtinst 2014-09-20 14:56:57 -04:00
Cole Robinson
439e5ad0fe details: Reorg a bunch of the global helpers
Some were redundant, some should be in virtinst
2014-09-20 10:23:19 -04:00
Cole Robinson
ae26313ed4 details: Add UI for enabling UEFI via 'customize before install'
We expose a simple combobox with two entries: BIOS, and UEFI. The
UEFI option is only selectable if 1) libvirt supports the necessary
domcapabilities bits, 2) it detects that qemu supports the necessary
command line options, and 3) libvirt detects a UEFI binary on the
host that maps to a known template via qemu.conf

If those conditions aren't met, we disable the UEFI option, and show
a small warning icon with an explanatory tooltip.

The option can only be changed via New VM->Customize Before Install.
For existing x86 VMs, it's a readonly label.
2014-09-17 18:43:41 -04:00
Lin Ma
2f62ba964c Add comparison function for NodeDevice
PCIDevice and USBDevice include respective comparison logic.

Signed-off-by: Lin Ma <lma@suse.com>
2014-09-16 11:41:13 -04:00
Cole Robinson
226c4562d5 virtManager: Switch to relative imports 2014-09-12 16:28:38 -04:00
Cole Robinson
b398a46e9b domain: Cache has_managed_save value
Otherwise we call it every time a domain row is selected, which makes
things choppy on remote connections.
2014-09-12 16:28:37 -04:00
Giuseppe Scrivano
92de2db42b virtManager: always save "do not show again" setting
Any other message box performs different than "Unapplied changes",
which stores this information regardless of the user choice of
Yes/No.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1047874

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-28 19:19:17 +02:00
Giuseppe Scrivano
eb5b261311 details.py: fix typo
s|removeable|removable|

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1112629

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-24 17:14:19 +02:00
Giuseppe Scrivano
4ac49a1d66 virt-manager: split EDIT_VCPUS and EDIT_MAXVCPUS
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1098040

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-17 17:27:47 +02:00
Chen Hanxiao
2f4a424521 use binary prefixes for units where appropriate
https://bugzilla.redhat.com/show_bug.cgi?id=1103893

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:56:53 +08:00
Chen Hanxiao
7beb7db31d addhardware: move _change_config_helper from details
rename it as change_config_helper.
It will be used in the later patch.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:47:19 +08:00
Cole Robinson
f686e36e42 details: Expose chipset=i440fx/q35 in customize dialog
So enterprising users can choose q35 for x86 qemu/kvm VMs. Some
discussion over here:

http://www.redhat.com/archives/virt-tools-list/2014-May/msg00001.html
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00019.html

We show a warning if q35 is selected, saying it's not well tested.
Hopefully that dissuades people who are just clicking about.
2014-06-03 15:58:04 -04:00
Cole Robinson
03670c38dc details: xen keyboard can't be removed either 2014-06-02 18:54:28 -04:00
Cole Robinson
aefd4c4824 connection: Use name instead of uuid for object keys
And clean up the API mess while we are at it. Treat the key as an opaque
value that users shouldn't depend on.

Besides the improved code clarity and API layout, this will help diagnose
'key error' issues, since we'll see an object name instead of UUID which
is hard to trace back.
2014-06-02 17:48:32 -04:00
Cole Robinson
091eb9fe26 details: Expose LXC <initarg> 2014-05-31 17:34:23 -04:00
Cole Robinson
9369ad3ac0 virt-manager: Allow setting interface portgroup element
We only show the option if the selected virtual network actually has
portgroups listed in its XML
2014-05-31 15:51:24 -04:00
Cole Robinson
9fd0ef5c88 details: Better handling for <input type=keyboard> 2014-05-04 13:23:54 -04:00
Cole Robinson
196ff823b3 Fix warnings with latest pep8 2014-05-02 10:20:59 -04:00
Chen Hanxiao
8d3dbfb90c details: force select list entry before showing popup menu
We show/hide remove device menu by the attribute
of config-remove button.
But on some desktop, it showing popup menu before
selection.
This patch will force select list entry before
showing popup menu.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-26 22:45:50 +08:00
Chen Hanxiao
2dd2e440d1 addhardware: introduce populate_controller_model_combo
Introduce populate_controller_model_combo for details
and addhardware.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-26 22:41:31 +08:00
Chen Hanxiao
cb682c09eb details: show/hide remove popup menu by remove button
Use the senesitive attribute of remove button to
determine whether remove popup menu should be shown.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-22 07:31:18 +08:00
Cole Robinson
70da20682c details: Explicit warn that 'format' doesn't change image format (bz 1089457) 2014-04-21 17:04:33 -04:00
Chen Hanxiao
86fc54be8e details: hiding removebutton for USB controller
commit 4c53debd8a
break hiding "config-remove" for USB controller.
This patch will fix this issue.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-15 22:44:43 +08:00
Chen Hanxiao
4ccb1d862b details: use uniformed expression of "Default"
We use both "Default" and "default" for controllers
if no controller model needed.
They should be the same expression and "Default"
is a better choice.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-04-14 20:08:00 +08:00
Cole Robinson
932e6e00bb details: Fix changing graphics type (bz 1083903)
And clean up the API usage to avoid these types of issues in the future.
2014-04-03 10:53:54 -04:00
Cole Robinson
ee6a541167 details: Fix showing vcpus values in 'customize' dialog (bz 1083903) 2014-04-03 10:30:37 -04:00
Cole Robinson
a398d245cb Clean up pylint integration
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
2014-04-02 19:00:24 -04:00
Giuseppe Scrivano
37eecb215d virtManager: hide "Remove Hardware" for non-devices
The menu item "Remove Hardware" in the Overview window is valid only
when a hardware device is selected, hide it in any other case.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1081373

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-27 13:50:06 +01:00
Cole Robinson
eee5061af8 details: Rework all define and hotplug operations
Rather than register a bunch of functions to call, lump it all into
one function per page. This allows us to easily call UpdateDevice
unconditionally, to pick up any addition hotplug operations that
become available via libvirt and qemu.
2014-03-22 16:48:00 -04:00
Cole Robinson
bc393b5f1f details: Don't try to show machine type for management domain 2014-03-20 14:04:29 -04:00
Giuseppe Scrivano
f8e1a68889 virtManager: show the state reason in the VM overview
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1073766

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-20 08:48:47 +01:00
Giuseppe Scrivano
81696a5144 virtinst: use libvirt getCPUModelNames when available
Read the list of CPU models trough getCPUModelNames instead of
accessing directly the file cpu_map.xml.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1060316

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-13 19:00:54 +01:00
Cole Robinson
b078ba8c3d details: Fix fallback if fetching CPU models fails (bz 1072704) 2014-03-06 11:31:09 -05:00
Chen Hanxiao
7dfdbb3f35 Fix some pylint
Two bad-indentation fixed.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-01 11:23:42 +08:00
Cole Robinson
3fcc2c2fed details: Fix setting default window size 2014-02-28 14:36:13 -05:00
Maros Zatko
74e6d43903 vmmDetails: toggle visibilities on page change 2014-02-28 14:29:48 -05:00
Chen Hanxiao
77553c7e49 ui: disable setting uid/gid_start for user namespace
Libvirt not allowed uid/gid_start
configured as none 0 or not specified.
This patch will disable config uid/gid_start in UI.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-27 10:01:29 +08:00
Cole Robinson
99eaf059ae Fix deprecation warnings on F21/rawhide 2014-02-25 15:57:38 -05:00
Chen Hanxiao
08daebe1aa details: add UI interface for LXC user namespace
We could config user namespace for LXC container
in details->overview page.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 21:37:13 -05:00
Martin Kletzander
55e85b1612 Unify prettification of VirtIO serial
Use the same case for occurrences of 'VirtIO' which start with
uppercase V.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Cole Robinson
d220cc5d52 preferences: Allow disabling VM CPU poll
With this, the only libvirt API call we hit on each tick is the
connection nodeinfo.
2014-02-11 15:45:05 -05:00
Cole Robinson
e42835b0ff details: Don't poll XML if using domain events 2014-02-11 15:45:04 -05:00