Commit Graph

4618 Commits

Author SHA1 Message Date
Cole Robinson
bbb048cbd0 clitest: Add KVM tests for aarch64, armv7, ppc64le 2015-04-22 20:28:47 -04:00
Cole Robinson
6fd3983f6d tests: Clean up capabilities test data
Make it clear which ones are used for the caps unit tests, and which
are for cli/UI testing and can be updated at will. And drop a bunch
of outdated stuff.
2015-04-22 19:05:06 -04:00
Cole Robinson
8a3e3391c8 clitest: Drop explicit fake.iso filename
Just use one of the other files we stub out
2015-04-22 18:00:00 -04:00
Cole Robinson
d4bf3b58a0 clitest: Drop prompttest infrastructure
Just fake it for the one remaining test
2015-04-22 18:00:00 -04:00
Cole Robinson
070664b9e7 tests: Enable property checking for all objects
And loosen restrictions a bit so any read/write will trigger the
tracking.
2015-04-22 16:26:03 -04:00
Giuseppe Scrivano
1c22118179 aarch64: support virt-rhelsa7.1 machine type
Just check for the prefix of the machine type, as it is done for ARM
vexpress.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1212021

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-04-22 19:08:02 +02:00
Cole Robinson
4c361933ea tests: Have the property checker work on whole test suite
Not just xmlparse.py. So we can test a new property via clitest and
not always via xmlparse
2015-04-21 20:15:37 -04:00
Cole Robinson
ccc0da3e51 tests: Add specific VM for virtxml tests
Decouple it from test-many-devices which is really about manual testing
of virt-manager UI. It's annoying that every time test-many-devices is
extended we need to regenerate all the virtxml tests.
2015-04-21 19:50:41 -04:00
Cole Robinson
18a6d8b444 migrate: Add 'temporary' option
This doesn't undefine the VM source, and leaves it temporary on the
destination. Basically the default migration action
2015-04-21 17:39:44 -04:00
Cole Robinson
fb26349546 domain: Make the tick() logic easier to follow 2015-04-21 17:15:58 -04:00
Cole Robinson
62ad0e91ee migrate: Big reworking of the dialog
It's largely the same, but now

- The code is better organized
- The UI is much more streamlined, only showing relevant fields when
  required.
- We warn about the hostname/URI cases that we know libvirt will error on
- Drop some of the attempts at being smart, and just mimic what libvirt
  will do.
2015-04-21 17:15:58 -04:00
Cole Robinson
bfcfdbf785 host: Remove some redundant connection fields 2015-04-21 16:33:41 -04:00
Cole Robinson
996c8b76b8 clone: Use conn desc if showing destination conn 2015-04-21 16:33:41 -04:00
Cole Robinson
692604e0a3 domain: migrate: Use UNDEFINE_SOURCE
Leaving a VM defined on the source is dangerous: if they are sharing
storage, and aren't using virtlockd, then they might be inadvertently
started in two places at once and trash a disk image.

Some people might still need the option to turn this off, so maybe we
will revive it. Not sure though
2015-04-21 16:33:41 -04:00
Cole Robinson
26c729887d domain: migrate: use PERSIST_DEST flag
Don't do it manually, it's been supported by libvirt for 5 years
2015-04-21 16:33:41 -04:00
Cole Robinson
be86785fdd migrate: Drop unused 'live' parameter. We always pass LIVE 2015-04-21 16:33:41 -04:00
Cole Robinson
2b877cf337 migrate: Remove 'max downtime' support
This is only needed when people have very specific downtime constraints
on public facing services. I don't think that covers many virt-manager
users. So suggest they just use the command line for this.
2015-04-21 16:33:41 -04:00
Cole Robinson
39dc0c7b94 migrate: Drop 'bandwidth' UI
A bit too enterprisy for my tastes. If people need this they should use
the command line.
2015-04-21 16:33:41 -04:00
Cole Robinson
8aefc012c5 connect: Fix handling of missing avahi (bz 1213299)
gdbus seems to behave differently here now. Perform an API check at
initial lookup time to ensure avahi is available
2015-04-20 12:32:33 -04:00
Cole Robinson
7b1a4634a8 clone: Refresh cached pools after storage creation 2015-04-14 18:42:56 -04:00
Cole Robinson
6dbe19bd83 libvirtobject: Fix deleting a running VM
The recent XML rework wasn't catching when a domain disappears while
trying to refresh it's state from the event loop.
2015-04-13 18:24:46 -04:00
Cole Robinson
1a8c6ba645 console: Use VM title as window title 2015-04-13 17:30:12 -04:00
Cole Robinson
e4e4c8c6f7 domain: Some 'customize before install' fixes after XML rework 2015-04-13 17:25:40 -04:00
Cole Robinson
dcfce5585a osdict: If detecting fedora-unknown, convert to latest fedora
That's basically what it is internally for libosinfo, and it helps
us generate better names in virt-manager
2015-04-13 17:07:16 -04:00
Cole Robinson
10ad151d4b connection: Clarify tick functions and who should use them 2015-04-13 16:56:46 -04:00
Cole Robinson
4553912c64 diskbackend: Fix busted volume lookup API name 2015-04-13 16:41:59 -04:00
Cole Robinson
c82507fc41 mediacombo: Just log error if populating fails
This is a non-essential feature. I just hit a backtrace when trying
to refresh XML. It's fixed by the previous patch, but we should avoid
these errors from killing the create.py wizard at least.
2015-04-13 16:41:58 -04:00
Cole Robinson
83f1c5f4bb nodedev: Populate XML at init time 2015-04-13 15:43:48 -04:00
Cole Robinson
6ecf01a3bd console: Catch and handle password auth errors (bz 1151801) 2015-04-12 14:10:45 -04:00
Cole Robinson
4e47cc9061 console: Fix password entry grab_focus 2015-04-12 12:43:29 -04:00
Cole Robinson
f013453999 sshtunnels: Don't log the SSH command over and over
Just log it once at init time
2015-04-12 12:21:38 -04:00
Cole Robinson
2ca72d1117 viewers: Don't try to use SSH tunnels in spice local case
Regressed with the recent tunnel cleanups
2015-04-12 11:06:15 -04:00
Cole Robinson
acebd1248c viewers: Add explicit API for removing display from parent
Previously we were hacking it in
2015-04-12 10:33:41 -04:00
Cole Robinson
c3fc4ee5a2 console: Drop timeout retry logic
This was needed in the days of old xen + libvirt, but I don't think
it's required nowadays, and if it is it's busted with our XML caching
I think.
2015-04-12 10:24:35 -04:00
Cole Robinson
792774450f console: Properly cleanup viewer when closing
Otherwise signals aren't properly removed, can cause some backtraces on
shutdown.
2015-04-12 09:53:23 -04:00
Cole Robinson
80c2dde350 virt-manager: Fix connection to domain from cli
Need to tweak our signal handling here with the recent connection changes.
2015-04-12 09:34:55 -04:00
Cole Robinson
aec851f73a viewers: Always clean up tunnel FDs when closing viewer
We were basically leaking a lot of FDs. They were still being tracked
but they were stranded and never dealt with.
2015-04-11 22:44:03 -04:00
Cole Robinson
e2cdfd651c sshtunnels: Don't use python socket for FD we pass to spice
Since socket objects close their FD when they are garbage collected,
this seems to lead to crashes like reported here:

https://bugzilla.redhat.com/show_bug.cgi?id=1135808
2015-04-11 22:36:04 -04:00
Cole Robinson
21b80226a8 config: Remove debug print statement 2015-04-11 22:36:04 -04:00
Cole Robinson
285e345f17 viewer: Simplify tunnel handling
- Cache ginfo, since it is tied to a single viewer instance
- Always create the sshtunnels object
- Track lock state so we can make it idempotent
2015-04-11 21:39:24 -04:00
Cole Robinson
93f826a8b2 cli: Replace add --check option (bz 1063471)
For fine grained enabling/disabling validation checks. Use this to
replace the heavy handed --force option.
2015-04-11 19:48:35 -04:00
Cole Robinson
0f3d86ac9e guest: Disable PM for virt-install as well
We are just mirroring the behavior that virt-manager (and boxes) have
used for a while now.

In my experience the average user is confused by their VMs suspending,
so for our sake I'd rather make people opt into this feature.
2015-04-11 18:02:45 -04:00
Cole Robinson
a2c7d62ec4 guest: Disable spice image compression for local VMs
The image compression setting has a noticably detrimental effect on
spice graphics quality. It's meant to be used for spice VDI but the
vast majority of people don't use spice in a way that makes bandwidth
usage matter.

Boxes has already done this for a while as well:

https://mail.gnome.org/archives/commits-list/2013-March/msg14904.html

Turn it off by default if creating the VM on a local connection.
2015-04-11 17:53:17 -04:00
Cole Robinson
e9495110ca connection: Refresh XML for every libvirt object event
We tried to split up status vs XML refreshing, but they are tied together
in various ways (like the runtime XML changes when a VM starts). This
was breaking console connecting when starting a VM
2015-04-11 17:24:30 -04:00
Cole Robinson
20d37422fe virt-install: Fill in a bunch of --graphics spice options (bz 1110017) 2015-04-11 16:56:27 -04:00
Cole Robinson
9a789c19e2 virt-install: Support --hostdev scsi passthrough (bz 1054912)
Pass it a type=scsi nodedev name, and we will set things up correctly.
2015-04-11 15:55:09 -04:00
Cole Robinson
630a80de62 storagelist: Fix sorting by size 2015-04-11 15:08:07 -04:00
Cole Robinson
9d99b8caab createvol: Don't cap capacity to host space (bz 1118706)
Only cap allocation, since we can overcommit with sparse images.
2015-04-11 14:56:23 -04:00
Cole Robinson
d7a7d00e9e engine: Don't raise conn poll errors if only systray visible (bz 1082685) 2015-04-11 14:41:02 -04:00
Cole Robinson
f7b05912f0 engine: Before launching any error, try to find a parent dialog 2015-04-11 14:39:52 -04:00