4 Commits

Author	SHA1	Message	Date
Toshiki Sonoda	6ec00474a6	virtinstall: Hide total_size in the progress bar if it doesn't need ... virt-install prints the total_size value to the progress bar even if it is meaningless. This value can be confusing to user, so for execute prosess that doesn't copy files (total_size = 0B), we hide the total_size value. For example, 'Creating domain...' doesn't need to print the total_size value. Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com> Signed-off-by: Haruka Ohata <ohata.haruka@fujitsu.com>	2022-12-14 13:18:36 -05:00
Cole Robinson	4114fa1aa8	progress: Fix showing correct final total ... Reproducer: Reproducer: ./virt-install --connect test:///default \ --location tests/data/fakemedia/fake-f26-netinst.iso Before: Starting install... Retrieving 'vmlinuz' | 0 B 00:00:00 ... Retrieving 'initrd.img' | 0 B 00:00:00 ... After: Starting install... Retrieving 'vmlinuz' | 9 B 00:00:00 ... Retrieving 'initrd.img' | 9 B 00:00:00 ... progress.end() currently only reports the total amount of bytes that were last written to the UI. It should report the total amount that's been passed to update(). Reported-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com> Signed-off-by: Cole Robinson <crobinso@redhat.com>	2022-12-14 13:01:48 -05:00
Cole Robinson	58837a7641	tests: Add full test coverage for progress text output ... Signed-off-by: Cole Robinson <crobinso@redhat.com>	2021-06-09 16:52:12 -04:00
Cole Robinson	078178f476	progress: Drop tqdm and revert back to local urlgrabber copy ... I thought tqdm was available everywhere, but it does not seem like it will be in RHEL9. Revert back to the old urlgrabber copy, now stored in virtinst/_progresspriv.py. If we ever want to try tqdm again, we can just revert this commit Signed-off-by: Cole Robinson <crobinso@redhat.com>	2021-06-09 16:52:11 -04:00