Commit Graph

136 Commits

Author SHA1 Message Date
Cole Robinson
ee6a541167 details: Fix showing vcpus values in 'customize' dialog (bz 1083903) 2014-04-03 10:30:37 -04:00
Cole Robinson
a398d245cb Clean up pylint integration
- Drop no longer needed disable= bits
- Use string names for all skipped pylint messages
2014-04-02 19:00:24 -04:00
Giuseppe Scrivano
37eecb215d virtManager: hide "Remove Hardware" for non-devices
The menu item "Remove Hardware" in the Overview window is valid only
when a hardware device is selected, hide it in any other case.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1081373

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-27 13:50:06 +01:00
Cole Robinson
eee5061af8 details: Rework all define and hotplug operations
Rather than register a bunch of functions to call, lump it all into
one function per page. This allows us to easily call UpdateDevice
unconditionally, to pick up any addition hotplug operations that
become available via libvirt and qemu.
2014-03-22 16:48:00 -04:00
Cole Robinson
bc393b5f1f details: Don't try to show machine type for management domain 2014-03-20 14:04:29 -04:00
Giuseppe Scrivano
f8e1a68889 virtManager: show the state reason in the VM overview
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1073766

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-20 08:48:47 +01:00
Giuseppe Scrivano
81696a5144 virtinst: use libvirt getCPUModelNames when available
Read the list of CPU models trough getCPUModelNames instead of
accessing directly the file cpu_map.xml.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1060316

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-03-13 19:00:54 +01:00
Cole Robinson
b078ba8c3d details: Fix fallback if fetching CPU models fails (bz 1072704) 2014-03-06 11:31:09 -05:00
Chen Hanxiao
7dfdbb3f35 Fix some pylint
Two bad-indentation fixed.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-03-01 11:23:42 +08:00
Cole Robinson
3fcc2c2fed details: Fix setting default window size 2014-02-28 14:36:13 -05:00
Maros Zatko
74e6d43903 vmmDetails: toggle visibilities on page change 2014-02-28 14:29:48 -05:00
Chen Hanxiao
77553c7e49 ui: disable setting uid/gid_start for user namespace
Libvirt not allowed uid/gid_start
configured as none 0 or not specified.
This patch will disable config uid/gid_start in UI.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-27 10:01:29 +08:00
Cole Robinson
99eaf059ae Fix deprecation warnings on F21/rawhide 2014-02-25 15:57:38 -05:00
Chen Hanxiao
08daebe1aa details: add UI interface for LXC user namespace
We could config user namespace for LXC container
in details->overview page.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-24 21:37:13 -05:00
Martin Kletzander
55e85b1612 Unify prettification of VirtIO serial
Use the same case for occurrences of 'VirtIO' which start with
uppercase V.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-02-12 21:55:32 +01:00
Cole Robinson
d220cc5d52 preferences: Allow disabling VM CPU poll
With this, the only libvirt API call we hit on each tick is the
connection nodeinfo.
2014-02-11 15:45:05 -05:00
Cole Robinson
e42835b0ff details: Don't poll XML if using domain events 2014-02-11 15:45:04 -05:00
Cole Robinson
94b7c124f6 details: stats: Report if memory polling is disabled 2014-02-10 15:13:31 -05:00
Cole Robinson
82754ddc84 Expose hostdev rombar in UI and cli (bz 768857) 2014-02-10 14:25:23 -05:00
Cole Robinson
4a006b5ff8 details: Expose fine grained boot config
Basically put an explicit device list in the boot UI, if the hypervisor
supports it. For unsupported hv, use the same old disk/cd/floppy/net UI.
2014-02-10 13:34:17 -05:00
Cole Robinson
8577bdf386 details: Break out icon and label helpers for each device 2014-02-09 15:20:41 -05:00
Cole Robinson
6fdc2f6d16 details: Tweak label of usb redirdev 2014-02-05 14:27:46 -05:00
Cole Robinson
f5c32063e4 wip 2014-02-05 14:09:05 -05:00
Cole Robinson
b2b0ac0cc2 details: Fix regression in 'customize before install'
char target_port isn't available before we've installed the guest
2014-02-04 17:32:46 -05:00
Chen Hanxiao
d0001cff89 details: fix a small typo
s/editted/edited

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-04 20:03:52 +08:00
Chen Hanxiao
f0fb4ca204 details: show port number for console device in hwlist
We could see more than one console devices
in hwlist because of multi console support.
This patch will show port number of console device
in hwlist.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-02-04 10:30:12 +08:00
Cole Robinson
99d80ccdb2 details: Fix cpu model sorting 2014-02-01 16:36:40 -05:00
Cole Robinson
f4bc4a35a2 details: enforce relationship between cpu topology and maxvcpus (bz 708892) 2014-02-01 09:14:55 -05:00
Cole Robinson
90c9b3ca2e details: Reword the CPU model UI a bit more
- Add options in the model drop down for clear, hvdefault, and app default
- Make 'copy host' a check box, when enabled it hides the model dropdown
- Detect if the VM CPU is a copy of the host CPU
- Undocumented bit that allows passing in host-model/host-passthrough
    to the model field for people that really want those settings.
2014-01-31 13:40:09 -05:00
Cole Robinson
c85e8d84d0 details: Remove explicit CPU feature UI
Not too useful, and makes things difficult for us.
2014-01-31 10:43:56 -05:00
Cole Robinson
bff94f2365 console: Support spice 'resize-guest' (bz 754559)
This will auto change the guest resolution to match the window size.
Off by default, can be enabled like scaling preferences.
2014-01-31 10:08:18 -05:00
Cole Robinson
382543e15f console: Clean up scaling function names 2014-01-30 19:15:02 -05:00
Cole Robinson
64b2d0c6b7 Move shared graphics editing UI to gfxdetails.py
Fixes a couple UI bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=696217
https://bugzilla.redhat.com/show_bug.cgi?id=875403
2014-01-29 09:22:28 -05:00
Cole Robinson
c5581c01d2 Move sharedui.py to vmmenu.py
Since that's all it contains now
2014-01-29 09:22:28 -05:00
Chen Hanxiao
45ec7baf92 details: show port number of console device in typelabel
We could set multi console for VM and containers.
But our UI did not show the number of it.
It would bring troubles when we want to delete one.
This patch will show port number of console device
in typelabel.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-29 10:44:55 +08:00
Cole Robinson
169ae1203d Break out shared network list UI to netlist.py
Use this to show vport stuff in addhw, give a warning about macvtap
networking, and allow macvtap from the create wizard.
2014-01-28 10:00:06 -05:00
Cole Robinson
37e1242bf4 details: Fix virtualport UI when IDs are empty 2014-01-27 15:06:27 -05:00
Cole Robinson
9d922f56df fsdetails: Fix error reporting
The UI file layout meant we were trying to use a gtk.Grid object
as the error dialog parent. Rework things to behave like snapshots.py
2014-01-27 11:03:59 -05:00
Cole Robinson
889ec18031 uiutil: Use list selection helpers everywhere 2014-01-27 10:46:14 -05:00
Cole Robinson
2771511946 uiutil: Make more use of set_combo_text_column 2014-01-26 21:35:42 -05:00
Cole Robinson
708a2737cf Split uihelpers into sharedui and uiutil
Reserve uiutil for the little gtk helper functions, rest goes into shared
UI (which all should probably be factored into their own files but thats
a task for another day)
2014-01-26 18:15:50 -05:00
Cole Robinson
2a34b353da uihelpers: Move browse_local to error.py
It doesn't fit any better, but now it's accessible to all UI classes
more easily.
2014-01-26 18:01:10 -05:00
Cole Robinson
58d5e0b799 uihelpers: Move a few more functions closer to their callers 2014-01-26 17:51:15 -05:00
Cole Robinson
20088ab8fb Move many shared UI functions to addhw static functions
Much of uihelpers is just simple stuff that's shared between addhw
and details UI, so just make it staticmethods in addhw, which details
already has a reference to.
2014-01-26 17:09:07 -05:00
Cole Robinson
ad363f9774 details: Remove runtime vcpu pinning list
I don't think anyone depended on this, and it's overkill for virt-manager.
2014-01-26 14:21:24 -05:00
Cole Robinson
e771af0112 details: If refresing page errors, still disable apply
and switch to the busted page, rather than strangely stay on the
previous page.
2014-01-26 14:15:46 -05:00
Cole Robinson
11ebe5d84e details: Move inspection info to its own page 2014-01-26 14:15:46 -05:00
Cole Robinson
46ad7e8bdb details: Remove UI for security, apic, acpi, clock
99% of users never need to tweak them, and now that we have virt-xml,
most of what they could want to do is a simple CLI oneliner.
2014-01-26 14:15:46 -05:00
Chen Hanxiao
4c53debd8a add support for showing and modifying scsi controller model
We could specify 'model' for scsi controllers,
that means we could see more than one controllers
with same icon and blank details.
That will confuse users.

This patch will show details of scsi controller device.
And also we could modify scsi controller model
between 'default' and 'virtio-scsi'.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-01-22 09:07:40 -05:00
Martin Kletzander
dc0b9bbaaf Rename hide_unsupported_rhel_options to stable_defaults and clean-up its usage
There were multiple problems with the setting and usage of
hide_unsupported_rhel_options.  Due to the fact that the option has
several diferent namings throughout the code, this patch is renaming
it to stable_defaults, which basically says what the option does and
makes it possible to use it without need for more than one negation
(where the old code had up to 4 of them in some places), which also
helps understanding it.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2014-01-21 17:13:18 +01:00