shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-11 05:17:59 +03:00
Code Issues Projects Releases Wiki Activity
5,651 Commits 2 Branches 64 Tags 99 MiB
f69b823fad
Commit Graph

88 Commits

Author SHA1 Message Date
Cole Robinson
b6dcee8eb7 Use consistent and minimal license header for every file 2018-03-21 07:29:40 -04:00
Cole Robinson
93c22eff79 xmlbuilder: Move xml_indent to util 2018-03-20 10:35:22 -04:00
Cole Robinson
3d34f6a231 storage: Fix validating empty hosts value (bz #1557942) 
https://bugzilla.redhat.com/show_bug.cgi?id=1557942
 2018-03-19 10:29:00 -04:00
Radostin Stoyanov
1ae5c4ff75 pylint: Resolve logging-not-lazy 
A new Python checker was added to warn about using a + operator inside
call of logging methods when one of the operands is a literal string.

https://pylint.readthedocs.io/en/latest/whatsnew/1.8.html

Signed-off-by: Radostin Stoyanov <rstoyanov1@gmail.com>
 2018-03-03 16:04:12 -05:00
Cole Robinson
3079426c82 virtinst: Drop doc= for properties 
This data never gets to the user and largely is just duplicating
libvirt docs. It's redundant
 2018-02-22 20:49:07 -05:00
Cole Robinson
6cad350649 storage: Use a threading event to signal progress thread 
Much more reactive and saves us time in the test suite
 2018-02-22 19:12:23 -05:00
Cole Robinson
d108bbe143 Convert docstrings to standard reStructuredText param format 2018-02-14 11:08:09 -05:00
Cole Robinson
dae8642bb1 xmlbuilder: centralize adding child new child prop instances 
Currently the domain CPU class has a child property like:

  siblings = XMLChildProperty(_CPUCellSibling)

If a user wants to add a new sibling, we add a convenience function:

    def add_sibling(self):
        obj = _CPUCellSibling(self.conn)
        self.add_child(obj)
        return obj

Rather than require every child property to define a similar matching
helper function, this adds infrastructure in xmlbuilder to do this
generically for every child property. Now callers can do

    obj = guest.cpu.siblings.add_new()
 2018-02-08 14:03:47 -05:00
Radostin Stoyanov
978fb25ac7 Wrap keys(), values() in a list 
In Python 3 dict.values() [1] , dict.keys() [2] and dict.items() [3]
return a view [4] of the dictionary’s values, keys and items.

In Python 2 these functions return a list. [5] [6] [7]

To resolve this we can convert the result of these function to a list.

[1] https://docs.python.org/3/library/stdtypes.html#dict.values
[2] https://docs.python.org/3/library/stdtypes.html#dict.keys
[3] https://docs.python.org/3/library/stdtypes.html#dict.items
[4] https://docs.python.org/3/library/stdtypes.html#dict-views
[5] https://docs.python.org/2/library/stdtypes.html#dict.items
[6] https://docs.python.org/2/library/stdtypes.html#dict.keys
[7] https://docs.python.org/2/library/stdtypes.html#dict.values
 2018-02-06 18:49:17 -05:00
Rauno Väli
582c1d3ded devicedisk: copy all rbd pool host and auth for volume 
(crobinso: add test suite coverage, fix some pylint)
 2018-01-30 11:30:22 -05:00
Radostin Stoyanov
6712261510 Python 2/3 division compatability 
In Python 2 the classic devision of integers returns an integer
but in Python 3 it might return float.

Example:
- Python 2:          - Python 3:
    >>> 9 / 4            >>> 9 / 4
    2                    2.25
    >>> 9 // 4           >>> 9 // 4
    2                    2
    >>> 9 / 4.0          >>> 9 / 4.0
    2.25                 2.25
    >>> 9 // 4.0         >>> 9 // 4.0
    2.0                  2.0

For more info see: https://www.python.org/dev/peps/pep-0238/
 2018-01-27 15:30:17 -05:00
Cole Robinson
fe59c33772 virtinst: storage: Don't generate UUID by default 
Just let libvirt do it for us, it doesn't really add anything
 2017-12-14 12:45:01 -05:00
Cole Robinson
8b4befae60 virtinst: Drop UUID validation 
It's redundant as libvirt will give us these checks already, and we
aren't even testing it
 2017-12-14 12:45:01 -05:00
Chen Hanxiao
7f1b4cee82 pycodestyle: fix all E125 warnings 
Fix all E125:
     Continuation line with same indent as next logical line

   Also remove ignore options of E125

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-10-21 23:26:16 +08:00
Chen Hanxiao
c92aade081 pycodestyle: fix all E203 warnings 
Fix all E203 whitespace before ':'
   Also remove E203 ignore option of pycodestyle

Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
 2017-08-11 00:01:38 +08:00
Cole Robinson
c4826444e9 storage: Fix 'srcname' referenced before assignment (bz #1474766) 
https://bugzilla.redhat.com/show_bug.cgi?id=1474766
 2017-08-03 12:38:37 -04:00
Radostin Stoyanov
b93cc3bbc9 pycodestyle: Do not use bare 'except:' 
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].

[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
 2017-08-02 13:57:43 -04:00
Cole Robinson
a9903ae0e0 connection: Remove clear_cache callback 
It doesn't actually accomplish what we want for the virt-manager case,
and cache_new_pool should cover our needs now
 2017-07-20 17:30:37 -04:00
Cole Robinson
4792c7cb8e connection: Add a default impl of cache_new_pool 
Inserts it into the cache, and adds its associated volumes too
 2017-07-20 17:30:36 -04:00
Cole Robinson
a9d9c0d035 connection: rename s/add_new_pool/cache_new_pool/g 
Better describes exactly what's going on
 2017-07-20 17:29:55 -04:00
Cole Robinson
5b51c98ae5 storage: Check for pool name collisions against the pool cache 
Rather than using storagePoolLookupByName. This will save some API
calls, but the main benefit is that it can help shake out cache
issues.
 2017-07-20 17:28:38 -04:00
Cole Robinson
4e7a6ad728 tests: pylint: Silence/fix a bunch of new warnings 2017-06-16 12:54:56 -04:00
Pavel Hrdina
1686511886 virtManager.connection: introduce cb_add_new_pool 
The cb_add_new_pool callback will add a newly created storage pool
into virt-manager's cache so we don't have to wait for the libvirt
event to be handled.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1435064

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-05-22 19:43:49 +02:00
Cole Robinson
a90d675394 Switch deprecating log.warn to log.warning 
Same semantics, but the alias is deprecated
 2017-05-05 14:53:28 -04:00
Cole Robinson
62feeb02a8 Switch to python3 style 'except X as Y' notation 
Which also works with python2.7
 2017-05-05 14:52:11 -04:00
Cole Robinson
9c8ffe51da storage: Move alloc/cap validation to validate() 
Doing this at property set time is overly noisy. Follow the same
pattern of VirtualDisk and only do this in the validate() function.

https://bugzilla.redhat.com/show_bug.cgi?id=1433239
 2017-03-17 12:14:05 -04:00
Pavel Hrdina
82eaf4742e virtinst.storage: improve detection of disk type 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2017-03-06 14:31:42 -05:00
Cole Robinson
eb2a56f700 util: Move xml_indent to XMLBuilder 2016-08-24 15:56:13 -04:00
Tristan Helmich
27703ca379 storage: Enable creation of zfs storave volumes 2016-08-09 11:48:34 -04:00
Pavel Hrdina
9cdf78e94c translation: fix usage of translate function 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2016-07-26 09:34:20 +02:00
Cole Robinson
5398282e12 storage: Detect backing_store format automatically 
By attempting to manage/import the passed path. This makes it
work via both virt-install and virt-manager

https://bugzilla.redhat.com/show_bug.cgi?id=1235406
 2016-06-16 20:36:30 -04:00
Cole Robinson
8d4e58c501 cli: Add --disk backing_format= option 2016-06-16 20:09:37 -04:00
Cole Robinson
f4dfb6de9d Fix recent pylint/pep8 output 2016-04-18 16:42:12 -04:00
Cole Robinson
95fd32dffd storage: Avoid some test suite noise on thread cleanup 2015-12-24 11:30:15 -05:00
Pavel Hrdina
0ccbcd8883 storage: remove attempt counter from disk allocation thread 
Remove the lookup counter from _progress_thread, it's not necessary, the
loop is terminated by _install_finished boolean.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1270277

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2015-11-19 15:09:59 +01:00
Charles Arnold
f30975c3f8 storage: remove cow as supported format 
Support for this format was removed about a year ago from
qemu with this commit,

commit 550830f9351291c585c963204ad9127998b1c1ce
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date:   Tue Sep 16 15:24:24 2014 +0100

    block: delete cow block driver

Signed-off-by: Charles Arnold <carnold@suse.com>
 2015-09-29 16:33:16 -04:00
Cole Robinson
697164f2e5 virtinst: Centralize urlgrabber meter lookup 
We will eventually want to drop this dep since it's basically dead
upstream, this is a small step in that direction
 2015-09-06 15:09:44 -04:00
Cole Robinson
acfb988945 xmlbuilder: Make _add_child and _remove_child public 
We have a lot of functions that are just wrappers around these, so
make it public for future use.
 2015-09-04 15:47:43 -04:00
Charles Arnold
eb92178e0c storage: fix default storage pool lookup 
virt-convert fails when the storage pool is already present but
is not called 'default'.

If the 'default' pool has been removed but another pool uses the
default location of /var/lib/libvirt/images virt-convert will fail
to find the pool and attempt to create another one with the same
path. This causes the conversion to fail.

Signed-off-by: Charles Arnold <carnold@suse.com>

(crobinso: Remove now-redundant 'pass')
 2015-08-31 18:25:37 -04:00
Cole Robinson
e22aeac5ae storage: session path should be ~/.local/share/libvirt/images 
Not .local/libvirt/images :/ App dirs aren't supposed to be in ~/.local
 2015-08-10 12:35:13 -04:00
Pavel Hrdina
0fbe8e7a1f translation: fix wrong usage of _() function 
All the strings have to be at first translated and then we can fill the
formated and translated string.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
 2015-06-05 16:33:51 -04:00
Cole Robinson
2d54949719 virtinst: Drop a bunch of uses of xmlbuilder make_xpath_cb 
I'd like to drop that functionality from xmlbuilder, and just open
code it at the callers... this is most of the way there
 2015-05-06 16:26:51 -04:00
Cole Robinson
252c216fb9 createpool: Don't unconditionally use /var/lib/libvirt 
Doesn't make sense for session URIs
 2015-05-02 19:54:14 -04:00
Cole Robinson
45e6cd4cac Remove redundant 'default dir' functions 2015-05-02 19:48:04 -04:00
Cole Robinson
015da05973 storage: Use .local/libvirt/images for session URIs 
.config isn't really appropriate
 2015-05-02 19:09:14 -04:00
Cole Robinson
8369c65966 storage: Use ~/.config/libvirt/images for qemu:///session 
It doesn't create the annoying ~/VirtualMachines directory, and already
has proper labelling.
 2015-04-24 21:01:55 -04:00
Giuseppe Scrivano
616df760be storage: copy allocation and capacity also on cross-pool clones 
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1210265

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-04-10 16:40:49 +02:00
Cole Robinson
45ae269950 storage: Use XMLBuilder for pool enumerate parsing 
And kill the parse_node_helper function, since that paradigm is dead.
 2015-04-03 16:45:43 -04:00
Giuseppe Scrivano
bbb96bcaa8 clone: keep the same image format on a cross-pool clone 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
 2015-04-01 11:56:34 +02:00
Cole Robinson
6e2e43b178 storage: Fix some pylint on libvirt without REFLINK flag 2015-02-22 10:25:47 -05:00