Cole Robinson
c7ca9c88e3
VirtualDisk: Convert path to new style XML property
...
Due to the complexity here, we hide the XML bits under _xmlpath, and use
path to cover the internal state integration.
2013-07-14 18:16:17 -04:00
Cole Robinson
13d8a4dae5
VirtualDisk: convert driver_type and driver_name to new style property
2013-07-14 18:16:01 -04:00
Cole Robinson
1a74a8fda6
VirtualDisk: Convert 'type' to new style XML property
2013-07-14 18:15:47 -04:00
Cole Robinson
ae74bd662f
VirtualDisk: Convert device property to new implicit style
2013-07-14 17:15:12 -04:00
Cole Robinson
8ad9084e5f
default rejiggering setup, no regression
2013-07-14 17:12:39 -04:00
Cole Robinson
2cea517823
xmlbuilder: Allow classes to specify order of certain xml elements
...
This will save us some test case churn. As an example, we now
do auto building of disk <target> XML and it doesn't alter things.
Without this bus and target are often swapped.
2013-07-14 16:45:28 -04:00
Cole Robinson
154bad0184
xmlbuilder: Simplify default getter/setter some more
2013-07-14 16:35:25 -04:00
Cole Robinson
2d460a98e5
xmlbuilder: Don't treat 0 as None in setter impl
2013-07-14 16:35:25 -04:00
Cole Robinson
9c5a1b60ee
CloneManager: Make sure to sync driver_name
2013-07-14 16:35:25 -04:00
Cole Robinson
ed8d785eef
VirtualDisk: Drop driver_name = "qemu" from set_defaults
...
Our property functions should already handle that.
2013-07-14 16:35:25 -04:00
Cole Robinson
70d34e928e
VirtualDisk: Drop set_vol_object, it is barely used
...
And it complicates syncing state. Make points where we sync values
more explicit.
2013-07-14 16:35:09 -04:00
Cole Robinson
328f98272c
xmlbuilder: Add plumbing to track if a property is unset
2013-07-14 16:35:09 -04:00
Cole Robinson
6506fb2995
VirtualDisk: Drop is_parse conditional if changing device
...
We can easily push this up to the caller, nothing really changes the
device of an existing device in practice.
2013-07-14 16:35:09 -04:00
Cole Robinson
d3dbbe9f54
xmlbuilder: Add explicit support for refreshing an XML prop
2013-07-14 16:34:54 -04:00
Cole Robinson
c12327cbd1
Guest: Switch memory units to KB to match default XML
2013-07-13 23:07:01 -04:00
Cole Robinson
69e1d66b53
xmlbuilder: Few misc cleanups and streamlinings
2013-07-13 22:51:54 -04:00
Cole Robinson
7d75a43e33
XMLProperty: Add convenience param is_int
2013-07-13 21:49:32 -04:00
Cole Robinson
5f58d05051
VirtualDisk: Convert more XMLProperties to the new world order
2013-07-13 21:40:54 -04:00
Cole Robinson
41afdfd9aa
hostkeymap: Globally cache the host lookup
...
Rather than make the callers worry about it
2013-07-13 20:58:09 -04:00
Cole Robinson
ed826315a5
xmlbuilder: Simplify free'ing xpath contexts
2013-07-13 20:47:19 -04:00
Cole Robinson
02f35628fb
VirtualDisk: Make get_xml_config not have side effects
...
Move all the defaults setting to a set_defaults function, wire it
up to Guest.get_xml_config.
2013-07-13 20:22:19 -04:00
Cole Robinson
e7b518cbff
Guest: Drop validate_parms, it's not useful
2013-07-13 20:01:07 -04:00
Cole Robinson
e04dfdd4ff
virtinst: Test rhel defaults, and make sure it doesn't break test suite
2013-07-13 20:01:07 -04:00
Cole Robinson
b152e83fef
virtinst: Rename XMLBuilderDomain.py -> xmlbuilder.py
...
And XMLBuilderDomain -> XMLBuilder
And _xml_property -> XMLProperty
2013-07-13 18:57:24 -04:00
Cole Robinson
4d5ca0ae5a
XMLBuilder: Simplify is_multi handling
2013-07-13 18:57:20 -04:00
Cole Robinson
d8c68e3495
XMLBuilder: Split up massive get/set helpers
...
This should be a no-op, just a big cleanup
2013-07-13 17:54:46 -04:00
Cole Robinson
4ce1774d53
VirtualDisk: Rework provisioning and validation behavior
...
We separate all the provisioning bits to diskbackend.py. VirtualDisk
users now need to explicitly opt in to storage creation by using
set_create_storage().
validation is no longer done automatically, users must call the
validation() command.
__init__ drops all extra parameters.
This will eventually get us to a point where we can unify the manual
XML building and XML parsing machinery, and get consistent validation
behavior between devices.
2013-07-13 16:37:33 -04:00
Cole Robinson
5962fde3e6
VirtualConnection: Fix uri helpers when we use the default empty URI
2013-07-13 16:32:21 -04:00
Cole Robinson
fbf2d9ee40
VirtualDisk: Convert simple props to unified parse/get/set
2013-07-12 15:26:51 -04:00
Cole Robinson
ce243314c0
tests: Verify that every new style XML prop is exercised
...
coverage isn't going to help us much here, so add some hacky infrastructure
to ensure that xmlparse.py is touching every new style xmlprop.
2013-07-12 15:19:37 -04:00
Cole Robinson
dcd632da80
XMLBuilder: Provide default fget and fset impls
...
This is the first step towards unifying the XML handling split between
parsing and creating from scratch. Demonstrate it with VirtualDisk.iotune
bits.
2013-07-12 14:41:29 -04:00
Cole Robinson
f620b317b9
tests: Make sure all XML use " for quoting
...
This is what libxml outputs with, and it's going to mess up
test output with upcoming tests.
2013-07-12 14:19:54 -04:00
Cole Robinson
0d5fe93048
Centralize XML helpers in virtinst/util.py
2013-07-12 13:10:23 -04:00
Cole Robinson
534e613d40
VirtualNetworkInterface: Absord MAC generating routines
2013-07-12 13:10:23 -04:00
Cole Robinson
f1b55090d2
VirtualDisk: Drop cache and io from __init__
...
They are barely used and can be specified separately.
2013-07-12 13:10:23 -04:00
Cole Robinson
57d4fcab33
VirtualDisk: Drop the volName parameter, it's not needed
2013-07-12 13:10:22 -04:00
Cole Robinson
c151b75896
XMLBuilder: Remove largely unused validation helpers
...
They aren't adding much value
2013-07-12 13:10:22 -04:00
Cole Robinson
318ba7e474
VirtualConnection: Deal with Guest objects, not raw XML
...
We already do XML parsing, no need to open code it elsewhere
2013-07-10 20:09:51 -04:00
Cole Robinson
97264a3dfe
VirtualConnection: Some reorganizing to avoid circular references
2013-07-10 20:09:51 -04:00
Cole Robinson
3d1b1735ee
XMLBuilder: Simplify XML deference
...
As long as we carry around a reference for every time we lookup
a sub node and use a wrapper class to do the free'ing, we should
be fine.
2013-07-10 20:09:51 -04:00
Martin Kletzander
f08313513b
Use proper disk targets.
...
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=968878
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
2013-07-09 09:12:53 -04:00
Cole Robinson
7a2caee6e1
VirtualConnection: Allow using virt-manager object caches
...
So when we call into virtinst it doesn't do a whole round of object
lookup and XML fetching.
2013-07-07 18:54:08 -04:00
Cole Robinson
d386ba5d62
VirtualConnection: Add option to cache fetch_* results
...
We use this in the CLI tools since there's no point in repeatedly updating
the VM list if the whole process only takes a few seconds.
2013-07-07 16:38:11 -04:00
Cole Robinson
9d560f7d9a
VirtualDisk: Always return VM names from is_conflict_disk
2013-07-07 16:34:46 -04:00
Cole Robinson
d5dc06148d
virtinst: Move fetch_all_guests to connection object
...
And fetch_all_pools. And have it use pollhelpers
2013-07-07 15:14:59 -04:00
Cole Robinson
ee7d0b620d
connection: Support listAll* object lookups
...
These calls save us a few API lookups, but are not supported by all
libvirt versions.
Since these bits were getting quite large, move them all to a separate
pollhelpers file.
However listAllInterfaces is returning an empty list for now, so we
disable the check: https://bugzilla.redhat.com/show_bug.cgi?id=982014
2013-07-07 15:06:09 -04:00
Cole Robinson
b7ee86541d
virtManager: connection: Switch to tick() paradigm for all objects
...
This is going to be much slower than what we currently do, but we
will be trying to fix that shortly.
2013-07-07 08:44:46 -04:00
Cole Robinson
d427800f11
Share default_uri function
2013-07-06 20:09:18 -04:00
Cole Robinson
3692e98ba0
VirtualConnection: Cache conn support checks
2013-07-06 15:53:35 -04:00
Cole Robinson
c406a6433c
VirtualConnection: cache version lookups
2013-07-06 15:39:00 -04:00