mirror of
https://github.com/virt-manager/virt-manager.git
synced 2025-02-04 17:47:19 +03:00
63fce081ed
This is E721 in pycodestyle [1]:
"do not compare types, use ‘isinstance()’"
The main differece between "type() is" and "isinstance()" is that
isinstance() supports inheritance. [1]
This can be seen in the example below:
>>> type(True) is int
False
>>> isinstance(True, int)
True
As we can see in python 'bool' a subclass of 'int'.
[1] https://pycodestyle.readthedocs.io/en/latest/intro.html#error-codes
[2] https://docs.python.org/2/library/functions.html#isinstance
99 lines
3.3 KiB
Python
99 lines
3.3 KiB
Python
#
|
|
# Copyright (C) 2011, 2013 Red Hat, Inc.
|
|
# Copyright (C) 2011 Cole Robinson <crobinso@redhat.com>
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
|
|
# MA 02110-1301 USA.
|
|
#
|
|
|
|
# This module provides a simple way to trace any activity on a specific
|
|
# python class or module. The trace output is logged using the regular
|
|
# logging infrastructure. Invoke this with virt-manager --trace-libvirt
|
|
|
|
import logging
|
|
import re
|
|
import threading
|
|
import time
|
|
import traceback
|
|
|
|
from types import FunctionType
|
|
from types import ClassType
|
|
from types import MethodType
|
|
|
|
|
|
def generate_wrapper(origfunc, name):
|
|
# This could be used as generic infrastructure, but it has hacks for
|
|
# identifying places where libvirt hits the network from the main thread,
|
|
# which causes UI blocking on slow network connections.
|
|
|
|
def newfunc(*args, **kwargs):
|
|
threadname = threading.current_thread().name
|
|
is_main_thread = (threading.current_thread().name == "MainThread")
|
|
|
|
# These APIs don't hit the network, so we might not want to see them.
|
|
is_non_network_libvirt_call = (name.endswith(".name") or
|
|
name.endswith(".UUIDString") or
|
|
name.endswith(".__init__") or
|
|
name.endswith(".__del__") or
|
|
name.endswith(".connect") or
|
|
name.startswith("libvirtError"))
|
|
|
|
if not is_non_network_libvirt_call and is_main_thread:
|
|
tb = ""
|
|
if is_main_thread:
|
|
tb = "\n%s" % "".join(traceback.format_stack())
|
|
logging.debug("TRACE %s: thread=%s: %s %s %s%s",
|
|
time.time(), threadname, name, args, kwargs, tb)
|
|
return origfunc(*args, **kwargs)
|
|
|
|
return newfunc
|
|
|
|
|
|
def wrap_func(module, funcobj):
|
|
name = funcobj.__name__
|
|
logging.debug("wrapfunc %s %s", funcobj, name)
|
|
|
|
newfunc = generate_wrapper(funcobj, name)
|
|
setattr(module, name, newfunc)
|
|
|
|
|
|
def wrap_method(classobj, methodobj):
|
|
name = methodobj.__name__
|
|
fullname = classobj.__name__ + "." + name
|
|
logging.debug("wrapmeth %s", fullname)
|
|
|
|
newfunc = generate_wrapper(methodobj, fullname)
|
|
setattr(classobj, name, newfunc)
|
|
|
|
|
|
def wrap_class(classobj):
|
|
logging.debug("wrapclas %s %s", classobj, classobj.__name__)
|
|
|
|
for name in dir(classobj):
|
|
obj = getattr(classobj, name)
|
|
if isinstance(obj, MethodType):
|
|
wrap_method(classobj, obj)
|
|
|
|
|
|
def wrap_module(module, regex=None):
|
|
for name in dir(module):
|
|
if regex and not re.match(regex, name):
|
|
continue
|
|
obj = getattr(module, name)
|
|
if isinstance(obj, FunctionType):
|
|
wrap_func(module, obj)
|
|
if isinstance(obj, (ClassType, type)):
|
|
wrap_class(obj)
|