virt-manager/virtinst
Jonathon Jongsma 40b73fec1b Fix filesystem socket.source
When specifying the socket.source option for filesystem devices, like
this:
  --filesystem type=mount,driver.type=virtiofs,source.socket=/xyz.sock,target.dir=tag1

virt-install is writing the xml as:

    <filesystem type="mount">
      <source>
        <socket>/xyz.sock</socket>
      </source>
      <target dir="tag1"/>
      <driver type="virtiofs"/>
    </filesystem>

This produces an error such as:

  ERROR missing source information for device mount_tag1

But the socket should be an attribute of source rather than a child
element. After this patch, the same command results in the following XML
and no error is produced:

    <filesystem type="mount">
      <source socket="/xyz.sock"/>
      <target dir="tag1"/>
      <driver type="virtiofs"/>
    </filesystem>

Resolves: RHEL-1126

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
2023-10-24 10:30:37 +02:00
..
devices Fix filesystem socket.source 2023-10-24 10:30:37 +02:00
domain cli: support --boot loader.stateless= 2022-10-17 11:54:37 -04:00
install installer: drop default TPM for --cloud-init install phase 2023-09-12 12:04:49 -04:00
__init__.py i18n: globally install also the ngettext function 2020-07-14 11:24:14 -04:00
_progresspriv.py virtinstall: Hide total_size in the progress bar if it doesn't need 2022-12-14 13:18:36 -05:00
buildconfig.py Prep for release 4.1.0 2022-08-04 15:53:33 -04:00
capabilities.py capabilities: Remove noisy alias debugging 2022-08-01 06:04:48 -04:00
cli.py Fix some pylint 2023-09-12 11:54:04 -04:00
cloner.py cloner: clone serial files 2023-03-22 17:44:06 -04:00
connection.py connection: De-duplicate ui and cli version logging 2022-08-01 06:04:48 -04:00
diskbackend.py diskbackend: Set relative path for media change 2022-02-27 13:44:26 -05:00
domcapabilities.py guest: Query availability of spicevmc channels in domcaps 2022-12-14 12:44:54 -05:00
generatename.py generatename: Move libvirt collision handling to callers 2019-06-11 17:54:45 -04:00
guest.py installer: drop default TPM for --cloud-init install phase 2023-09-12 12:04:49 -04:00
logger.py tests: abide logging options for clitests 2019-12-11 17:57:28 -05:00
network.py hostnets: Remove SR-IOV info listing 2019-06-16 23:48:51 -04:00
nodedev.py nodedev: Move the CLI string format lookup to cli.py 2022-01-21 13:20:46 -05:00
osdict.py tests: test win11 XML generation 2023-01-19 11:54:03 -05:00
pollhelpers.py Fix pylint/pycodestyle warnings with latest versions 2022-12-13 11:23:45 -05:00
progress.py progress: Drop tqdm and revert back to local urlgrabber copy 2021-06-09 16:52:11 -04:00
snapshot.py virtinst: move UI only functions into virtManager 2019-06-09 18:33:45 -04:00
storage.py virt-clone: Copy disk permissions as well 2023-09-10 11:19:31 -04:00
support.py object: nodedev: support isActive state 2022-01-17 14:37:06 -05:00
uri.py xmlutil: add a diff() helper 2020-09-05 15:49:55 -04:00
virtclone.py Remove shebangs from library paths 2021-06-22 19:54:37 -04:00
virtinstall.py Fix pylint/pycodestyle warnings with latest versions 2022-12-13 11:23:45 -05:00
virtxml.py cli: Break up parse_option_strings 2022-08-03 12:34:47 -04:00
xmlapi.py cli: Add --xml xpath option for virt-install and virt-xml 2020-09-11 15:04:37 -04:00
xmlbuilder.py Fix some pylint 2023-09-12 11:54:04 -04:00
xmlutil.py xmlutil: Take unindent_device_xml from details.py 2022-08-03 12:34:47 -04:00