mirror of
https://github.com/virt-manager/virt-manager.git
synced 2025-01-20 14:03:52 +03:00
301423b83a
The commit 6baa327d added active_pcr_banks support, but put it under the child
element <tpm>, which is wrong, It should be under sub child element <backend>.
Before:
--tpm model=tpm-tis,backend.type=emulator,backend.version=2.0,\
active_pcr_banks.sha1=on,\
active_pcr_banks.sha256=yes,\
active_pcr_banks.sha384=yes,\
active_pcr_banks.sha512=yes
It results in the following domain xml:
<tpm model='tpm-tis'>
<backend type='emulator' version='2.0'/>
<alias name='tpm0'/>
</tpm>
After:
--tpm model=tpm-tis,backend.type=emulator,backend.version=2.0,\
backend.active_pcr_banks.sha1=on,\
backend.active_pcr_banks.sha256=yes,\
backend.active_pcr_banks.sha384=yes,\
backend.active_pcr_banks.sha512=yes
It results in the following domain xml:
<tpm model='tpm-tis'>
<backend type='emulator' version='2.0'>
<active_pcr_banks>
<sha1/>
<sha256/>
<sha384/>
<sha512/>
</active_pcr_banks>
</backend>
<alias name='tpm0'/>
</tpm>
Signed-off-by: Lin Ma <lma@suse.de>
85 lines
2.9 KiB
Python
85 lines
2.9 KiB
Python
#
|
|
# Copyright 2011, 2013 Red Hat, Inc.
|
|
# Copyright 2013 IBM Corporation
|
|
#
|
|
# This work is licensed under the GNU GPLv2 or later.
|
|
# See the COPYING file in the top-level directory.
|
|
|
|
from .device import Device
|
|
from ..xmlbuilder import XMLBuilder, XMLChildProperty, XMLProperty
|
|
|
|
|
|
class _ActivePCRBanks(XMLBuilder):
|
|
XML_NAME = "active_pcr_banks"
|
|
|
|
sha1 = XMLProperty("./sha1", is_bool=True)
|
|
sha256 = XMLProperty("./sha256", is_bool=True)
|
|
sha384 = XMLProperty("./sha384", is_bool=True)
|
|
sha512 = XMLProperty("./sha512", is_bool=True)
|
|
|
|
|
|
class DeviceTpm(Device):
|
|
XML_NAME = "tpm"
|
|
|
|
VERSION_1_2 = "1.2"
|
|
VERSION_2_0 = "2.0"
|
|
VERSIONS = [VERSION_1_2, VERSION_2_0]
|
|
|
|
TYPE_PASSTHROUGH = "passthrough"
|
|
TYPE_EMULATOR = "emulator"
|
|
TYPES = [TYPE_PASSTHROUGH, TYPE_EMULATOR]
|
|
|
|
MODEL_TIS = "tpm-tis"
|
|
MODEL_CRB = "tpm-crb"
|
|
MODEL_SPAPR = "tpm-spapr"
|
|
MODELS = [MODEL_TIS, MODEL_CRB, MODEL_SPAPR]
|
|
|
|
type = XMLProperty("./backend/@type")
|
|
version = XMLProperty("./backend/@version")
|
|
model = XMLProperty("./@model")
|
|
device_path = XMLProperty("./backend/device/@path")
|
|
encryption_secret = XMLProperty("./backend/encryption/@secret")
|
|
persistent_state = XMLProperty(
|
|
"./backend/@persistent_state", is_yesno=True)
|
|
debug = XMLProperty("./backend/@debug")
|
|
source_type = XMLProperty("./backend/source/@type")
|
|
source_path = XMLProperty("./backend/source/@path")
|
|
|
|
active_pcr_banks = XMLChildProperty(_ActivePCRBanks, is_single=True,
|
|
relative_xpath="./backend")
|
|
|
|
|
|
##################
|
|
# Default config #
|
|
##################
|
|
|
|
@staticmethod
|
|
def default_model(guest):
|
|
domcaps = guest.lookup_domcaps()
|
|
|
|
if not domcaps.devices.tpm.present and not guest.os.is_pseries():
|
|
# Preserve the old default when domcaps is old
|
|
return DeviceTpm.MODEL_CRB
|
|
if domcaps.devices.tpm.get_enum("model").has_value(DeviceTpm.MODEL_CRB):
|
|
# CRB is the modern version, and it implies version 2.0
|
|
return DeviceTpm.MODEL_CRB
|
|
|
|
# Let libvirt decide so we don't need to duplicate its arch logic
|
|
return None
|
|
|
|
def set_defaults(self, guest):
|
|
if self.device_path and not self.type:
|
|
self.type = self.TYPE_PASSTHROUGH
|
|
if not self.type:
|
|
# Libvirt requires a backend type to be specified. 'emulator'
|
|
# may not be available if swtpm is not installed, but trying to
|
|
# fallback to 'passthrough' in that case isn't really workable.
|
|
# Instead we specify it unconditionally and let libvirt error.
|
|
self.type = self.TYPE_EMULATOR
|
|
|
|
# passthrough and model and version are all interconnected, so
|
|
# don't try to set a default model if other bits are set
|
|
if (self.type == self.TYPE_EMULATOR and
|
|
not self.model and not self.version):
|
|
self.model = self.default_model(guest)
|