virt-manager/virtManager/packageutils.py
Radostin Stoyanov b93cc3bbc9 pycodestyle: Do not use bare 'except:'
A bare 'except:' catches all exceptions [1], including SystemExit,
KeyboardInterrupt, and GeneratorExit (which is not an error and should
not normally be caught by user code). In situations where you need to
catch all “normal” errors, you can catch the base class for all normal
exceptions, Exception [2].

[1] https://docs.python.org/2/howto/doanddont.html#except
[2] https://docs.python.org/2/library/exceptions.html#Exception
2017-08-02 13:57:43 -04:00

155 lines
5.3 KiB
Python

#
# Copyright (C) 2012-2013 Red Hat, Inc.
# Copyright (C) 2012 Cole Robinson <crobinso@redhat.com>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
# MA 02110-1301 USA.
#
import logging
import time
from gi.repository import Gio
#############################
# PackageKit lookup helpers #
#############################
def check_packagekit(parent, errbox, packages):
"""
Returns None when we determine nothing useful.
Returns (success, did we just install libvirt) otherwise.
"""
ignore = errbox
if not packages:
logging.debug("No PackageKit packages to search for.")
return
logging.debug("PackageKit check/install for packages=%s", packages)
try:
bus = Gio.bus_get_sync(Gio.BusType.SYSTEM, None)
Gio.DBusProxy.new_sync(bus, 0, None,
"org.freedesktop.PackageKit",
"/org/freedesktop/PackageKit",
"org.freedesktop.PackageKit", None)
except Exception:
logging.exception("Couldn't connect to packagekit")
return
try:
for package in packages[:]:
if packagekit_isinstalled(package):
logging.debug("package=%s already installed, skipping it",
package)
packages.remove(package)
if packages:
packagekit_install(parent, packages)
else:
logging.debug("Nothing to install")
except Exception as e:
# PackageKit frontend should report an error for us, so just log
# the actual error
logging.debug("Error talking to PackageKit: %s", str(e), exc_info=True)
return
return True
def packagekit_isinstalled(package):
bus = Gio.bus_get_sync(Gio.BusType.SESSION, None)
pk_control = Gio.DBusProxy.new_sync(bus, 0, None,
"org.freedesktop.PackageKit",
"/org/freedesktop/PackageKit",
"org.freedesktop.PackageKit.Query", None)
return pk_control.IsInstalled("(ss)", package, "")
def packagekit_install(parent, package_list):
ignore = parent
bus = Gio.bus_get_sync(Gio.BusType.SESSION, None)
pk_control = Gio.DBusProxy.new_sync(bus, 0, None,
"org.freedesktop.PackageKit",
"/org/freedesktop/PackageKit",
"org.freedesktop.PackageKit.Modify", None)
# Set 2 hour timeout
timeout = 1000 * 60 * 60 * 2
logging.debug("Installing packages: %s", package_list)
pk_control.InstallPackageNames("(uass)", 0, package_list, "",
timeout=timeout)
logging.debug("Install completed")
###################
# Service helpers #
###################
def start_libvirtd():
"""
Connect to systemd and start libvirtd if required
"""
logging.debug("Trying to start libvirtd through systemd")
unitname = "libvirtd.service"
try:
bus = Gio.bus_get_sync(Gio.BusType.SYSTEM, None)
except Exception:
logging.exception("Error getting system bus handle")
return
try:
systemd = Gio.DBusProxy.new_sync(bus, 0, None,
"org.freedesktop.systemd1",
"/org/freedesktop/systemd1",
"org.freedesktop.systemd1.Manager", None)
except Exception:
logging.exception("Couldn't connect to systemd")
return
try:
unitpath = systemd.GetUnit("(s)", unitname)
unit = Gio.DBusProxy.new_sync(bus, 0, None,
"org.freedesktop.systemd1", unitpath,
"org.freedesktop.systemd1.Unit", None)
state = unit.get_cached_property("ActiveState")
logging.debug("libvirtd state=%s", state)
if str(state).lower().strip("'") == "active":
logging.debug("libvirtd already active, not starting")
return True
except Exception:
logging.exception("Failed to lookup libvirtd status")
return
# Connect to system-config-services and offer to start
try:
logging.debug("libvirtd not running, asking system-config-services "
"to start it")
scs = Gio.DBusProxy.new_sync(bus, 0, None,
"org.fedoraproject.Config.Services",
"/org/fedoraproject/Config/Services/systemd1",
"org.freedesktop.systemd1.Manager", None)
scs.StartUnit("(ss)", unitname, "replace")
time.sleep(2)
logging.debug("Starting libvirtd appeared to succeed")
return True
except Exception:
logging.exception("Failed to talk to system-config-services")