virt-manager/virtinst
Cole Robinson f27e203732 cli: Skip MAC collision error with --check mac_in_use=
There's valid cases where a VM can be defined with a conflicting MAC
address. Prior to  ebd6091cc8 and related refactorings we were more
lax here if the conflicting VM wasn't running, but now we are blocking
some valid usage.

Hoist the validation check up to cli.py and add --check mac_in_use=off
to skip the validation. Advertise it like we do for other checks, so
now a collision error will look something like:

The MAC address '22:11:11:11:11:11' is in use by another virtual
machine. (Use --check mac_in_use=off or --check all=off to override)

Reported-by: Pino Toscano <ptoscano@redhat.com>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-07-06 10:17:10 -04:00
..
devices cli: Skip MAC collision error with --check mac_in_use= 2020-07-06 10:17:10 -04:00
domain domain: cpu: Finish test coverage 2020-01-27 13:08:12 -05:00
install urldetect: Fix SafeConfigParser deprecation warning 2020-07-05 08:12:47 -04:00
__init__.py virtManager: Remove virInterface polling 2020-01-26 11:39:34 -05:00
buildconfig.py tests: Rename all test files to have test_ prefix 2020-01-27 06:57:37 -05:00
capabilities.py tests: More work to make dir search test host independent 2020-01-30 16:18:20 -05:00
cli.py cli: Skip MAC collision error with --check mac_in_use= 2020-07-06 10:17:10 -04:00
cloner.py cli: Skip MAC collision error with --check mac_in_use= 2020-07-06 10:17:10 -04:00
connection.py Fix pylint with latest pylint version 2020-03-30 16:04:12 -04:00
diskbackend.py tests: Don't report UID/GID in fake caps data 2020-02-05 19:39:45 -05:00
domcapabilities.py virtinst: trivial codespell fixes 2020-07-04 17:56:57 -04:00
generatename.py generatename: Move libvirt collision handling to callers 2019-06-11 17:54:45 -04:00
guest.py addhardware: Remove dead virtio-scsi collision code 2020-01-29 06:52:29 -05:00
logger.py tests: abide logging options for clitests 2019-12-11 17:57:28 -05:00
network.py hostnets: Remove SR-IOV info listing 2019-06-16 23:48:51 -04:00
nodedev.py Switch to more traditional logging structure 2019-06-17 00:12:31 -04:00
osdict.py virtinst: install: Fill out more test coverage 2020-01-27 13:08:12 -05:00
pollhelpers.py tests: Add full coverage for pollhelpers and VirtinstConnection 2020-01-27 06:57:37 -05:00
progress.py virtinst/progress.py: change 'fo' to make codespell happy 2020-07-04 17:56:57 -04:00
snapshot.py virtinst: move UI only functions into virtManager 2019-06-09 18:33:45 -04:00
storage.py Fix pylint with latest pylint version 2020-03-30 16:04:12 -04:00
support.py virtManager: Remove virInterface polling 2020-01-26 11:39:34 -05:00
uri.py virtinst: uri: Rework MagicURI to work with passed in fakeuri 2020-02-03 07:05:11 -05:00
virtclone.py cli: Skip MAC collision error with --check mac_in_use= 2020-07-06 10:17:10 -04:00
virtinstall.py cli: Skip MAC collision error with --check mac_in_use= 2020-07-06 10:17:10 -04:00
virtxml.py cli: Move some domain helpers from virt-xml to cli 2020-02-03 08:41:46 -05:00
xmlapi.py Fix codespell errors 2019-07-12 16:10:39 -04:00
xmlbuilder.py virtinst: trivial codespell fixes 2020-07-04 17:56:57 -04:00
xmlutil.py virtinst: Add full test coverage for xml*.py files 2019-06-09 19:00:03 -04:00