mirror of
https://github.com/virt-manager/virt-manager.git
synced 2025-01-20 14:03:52 +03:00
fae3fecc1e
The current implementation of Secret Service keyring client assumes that the last component of an item path is integer, which is not true for some Secret Service server implementations (e.g. KeePassXC). Besides, the Secret Service API documents advises against recording object path (not to mentioning parsing it in any way), recommending using lookup attributes instead[1]. This commit fixes the code to behave in more interoperable way. - The item path (called "keyid" in code) is no longer parsed and stored anywhere. - The secret item is looked up in the Secret Service using hvuri and machine uuid attributes. - /console-password with (username, keyid) is removed from GSettings storage. Instead, only username is stored in /console-username. [1] https://specifications.freedesktop.org/secret-service/latest/ch03.html Resolves: #237