mirror of
https://gitlab.com/virt-viewer/virt-viewer.git
synced 2025-01-05 09:17:45 +03:00
wixl: use a versionized installation directory
It turned out that not only the current MSI broke the "component rule", but also that our files are not versionized correctly. Windows Installer applies some file versioning rules before replacing a file http://msdn.microsoft.com/en-us/library/aa368599%28v=vs.85%29.aspx Since msitools doesn't extract version from files and populate the Version field of the File table, it "usually" keep the current file installed. It's practically impossible to rely on version information from files (from a quick look, only 5% of the files are versionized and even less correctly, libgcrypt seems to do non-monotonic buildid for example) So the rule that applies when files are not versionized is to check the file hash, and the modified date. File hash was added recently in msitools, but doesn't apply when the installed file itself has a version. In order to solve the above problems, it's simpler to just have a different installation prefix. Windows Installer will see files with different component guid, and won't be checking any file update rule. I have verified the upgrade is working, not leaving any file behind and updating registry correctly with this solution. Until the files are correctly versionized, it looks like the only sensible thing to do. Furthermore, this make it simpler to have several versions installed in parallel later on (when we change productid)
This commit is contained in:
parent
29f2d8a8e8
commit
668c52775f
@ -84,7 +84,7 @@
|
||||
|
||||
<Directory Id="TARGETDIR" Name="SourceDir">
|
||||
<Directory Id="$(var.ArchProgramFilesFolder)">
|
||||
<Directory Id="INSTALLDIR" Name="VirtViewer">
|
||||
<Directory Id="INSTALLDIR" Name="VirtViewer v@VERSION@@BUILDID@">
|
||||
<Component Id="CDepsFile" Guid="*">
|
||||
<File Id="filA1E799D196006E6DF67DACE15B8C6193" KeyPath="yes" Source="deps.txt"/>
|
||||
</Component>
|
||||
|
Loading…
Reference in New Issue
Block a user