ovirt: Allow to remove CD images

It turns out this is supposed to be done through update requests with a
CD image with an empty name, which is what the current code tries to do.
The only reason it's not working is because of server-side bugs with
oVirt < 3.5
The requirement on libgovirt is raised to 0.3.2 as
a small change is needed as well in libgovirt to allow empty filenames:
https://git.gnome.org/browse/libgovirt/commit/?id=bdb788fcc

Without this change, nothing too bad will happen, but the CD won't be
removed and warnings will be logged in the console.
This commit is contained in:
Christophe Fergeau 2014-09-22 14:15:00 +02:00
parent bb44ce0a1f
commit 9803f9cb42
2 changed files with 1 additions and 5 deletions

View File

@ -21,7 +21,7 @@ GTK_VNC1_REQUIRED="0.3.8"
GTK_VNC2_REQUIRED="0.4.0"
SPICE_GTK_REQUIRED="0.22"
SPICE_PROTOCOL_REQUIRED="0.10.1"
GOVIRT_REQUIRED="0.3.1"
GOVIRT_REQUIRED="0.3.2"
AC_SUBST([GLIB2_REQUIRED])
AC_SUBST([LIBXML2_REQUIRED])

View File

@ -450,10 +450,6 @@ ovirt_foreign_menu_activate_item_cb(GtkMenuItem *menuitem, gpointer user_data)
g_debug("Removing current cdrom image");
iso_name = NULL;
foreign_menu->priv->next_iso_name = NULL;
/* FIXME: No idea how to remove a CDRom from a VM through ovirt REST
* API for now, so return early.
*/
return;
}
g_object_set(foreign_menu->priv->cdrom,
"file", iso_name,