2007-09-13 03:50:21 +04:00
/*
2002-01-30 09:08:46 +03:00
Unix SMB / CIFS implementation .
1998-08-17 17:11:34 +04:00
file closing
Copyright ( C ) Andrew Tridgell 1992 - 1998
2007-02-07 00:05:34 +03:00
Copyright ( C ) Jeremy Allison 1992 - 2007.
2005-07-08 08:51:27 +04:00
Copyright ( C ) Volker Lendecke 2005
2007-09-13 03:50:21 +04:00
1998-08-17 17:11:34 +04:00
This program is free software ; you can redistribute it and / or modify
it under the terms of the GNU General Public License as published by
2007-07-09 23:25:36 +04:00
the Free Software Foundation ; either version 3 of the License , or
1998-08-17 17:11:34 +04:00
( at your option ) any later version .
2007-09-13 03:50:21 +04:00
1998-08-17 17:11:34 +04:00
This program is distributed in the hope that it will be useful ,
but WITHOUT ANY WARRANTY ; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the
GNU General Public License for more details .
2007-09-13 03:50:21 +04:00
1998-08-17 17:11:34 +04:00
You should have received a copy of the GNU General Public License
2007-07-10 04:52:41 +04:00
along with this program . If not , see < http : //www.gnu.org/licenses/>.
1998-08-17 17:11:34 +04:00
*/
# include "includes.h"
2007-01-19 00:51:52 +03:00
extern struct current_user current_user ;
1998-08-17 17:11:34 +04:00
/****************************************************************************
2003-01-03 21:50:13 +03:00
Run a file if it is a magic script .
1998-08-17 17:11:34 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2003-01-03 21:50:13 +03:00
2007-12-22 04:13:02 +03:00
static void check_magic ( struct files_struct * fsp )
1998-08-17 17:11:34 +04:00
{
2007-09-13 03:50:21 +04:00
int ret ;
const char * magic_output = NULL ;
SMB_STRUCT_STAT st ;
int tmp_fd , outfd ;
TALLOC_CTX * ctx = NULL ;
const char * p ;
2007-12-22 04:13:02 +03:00
struct connection_struct * conn = fsp - > conn ;
2007-09-13 03:50:21 +04:00
if ( ! * lp_magicscript ( SNUM ( conn ) ) ) {
2001-04-13 04:37:00 +04:00
return ;
2007-09-13 03:50:21 +04:00
}
2003-01-03 21:50:13 +03:00
DEBUG ( 5 , ( " checking magic for %s \n " , fsp - > fsp_name ) ) ;
2007-09-13 03:50:21 +04:00
if ( ! ( p = strrchr_m ( fsp - > fsp_name , ' / ' ) ) ) {
p = fsp - > fsp_name ;
} else {
p + + ;
}
2003-01-03 21:50:13 +03:00
2007-09-13 03:50:21 +04:00
if ( ! strequal ( lp_magicscript ( SNUM ( conn ) ) , p ) ) {
return ;
2001-04-13 04:37:00 +04:00
}
2007-09-13 03:50:21 +04:00
ctx = talloc_stackframe ( ) ;
if ( * lp_magicoutput ( SNUM ( conn ) ) ) {
magic_output = lp_magicoutput ( SNUM ( conn ) ) ;
} else {
magic_output = talloc_asprintf ( ctx ,
" %s.out " ,
fsp - > fsp_name ) ;
}
if ( ! magic_output ) {
TALLOC_FREE ( ctx ) ;
return ;
}
chmod ( fsp - > fsp_name , 0755 ) ;
ret = smbrun ( fsp - > fsp_name , & tmp_fd ) ;
DEBUG ( 3 , ( " Invoking magic command %s gave %d \n " ,
fsp - > fsp_name , ret ) ) ;
2003-01-03 21:50:13 +03:00
2007-09-13 03:50:21 +04:00
unlink ( fsp - > fsp_name ) ;
if ( ret ! = 0 | | tmp_fd = = - 1 ) {
if ( tmp_fd ! = - 1 ) {
2003-01-03 21:50:13 +03:00
close ( tmp_fd ) ;
}
2007-09-13 03:50:21 +04:00
TALLOC_FREE ( ctx ) ;
return ;
}
outfd = open ( magic_output , O_CREAT | O_EXCL | O_RDWR , 0600 ) ;
if ( outfd = = - 1 ) {
close ( tmp_fd ) ;
TALLOC_FREE ( ctx ) ;
return ;
}
2003-01-03 21:50:13 +03:00
2007-09-13 03:50:21 +04:00
if ( sys_fstat ( tmp_fd , & st ) = = - 1 ) {
2001-04-13 04:37:00 +04:00
close ( tmp_fd ) ;
close ( outfd ) ;
2007-09-13 03:50:21 +04:00
return ;
2001-04-13 04:37:00 +04:00
}
2007-09-13 03:50:21 +04:00
transfer_file ( tmp_fd , outfd , ( SMB_OFF_T ) st . st_size ) ;
close ( tmp_fd ) ;
close ( outfd ) ;
TALLOC_FREE ( ctx ) ;
1998-08-17 17:11:34 +04:00
}
/****************************************************************************
Common code to close a file or a directory .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2000-04-22 04:33:16 +04:00
2007-02-07 00:05:34 +03:00
static NTSTATUS close_filestruct ( files_struct * fsp )
2007-09-13 03:50:21 +04:00
{
2007-02-07 00:05:34 +03:00
NTSTATUS status = NT_STATUS_OK ;
1998-08-17 17:11:34 +04:00
connection_struct * conn = fsp - > conn ;
2005-07-08 08:51:27 +04:00
if ( fsp - > fh - > fd ! = - 1 ) {
2007-02-07 00:05:34 +03:00
if ( flush_write_cache ( fsp , CLOSE_FLUSH ) = = - 1 ) {
status = map_nt_error_from_unix ( errno ) ;
}
2002-03-20 03:46:53 +03:00
delete_write_cache ( fsp ) ;
}
1999-12-13 16:27:58 +03:00
1998-08-17 17:11:34 +04:00
conn - > num_files_open - - ;
2007-02-07 00:05:34 +03:00
return status ;
1998-08-17 17:11:34 +04:00
}
2004-06-08 20:14:31 +04:00
/****************************************************************************
If any deferred opens are waiting on this close , notify them .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2005-09-30 21:13:37 +04:00
static void notify_deferred_opens ( struct share_mode_lock * lck )
2004-06-08 20:14:31 +04:00
{
2005-09-30 21:13:37 +04:00
int i ;
for ( i = 0 ; i < lck - > num_share_modes ; i + + ) {
struct share_mode_entry * e = & lck - > share_modes [ i ] ;
if ( ! is_deferred_open_entry ( e ) ) {
continue ;
}
if ( procid_is_me ( & e - > pid ) ) {
/*
* We need to notify ourself to retry the open . Do
* this by finding the queued SMB record , moving it to
* the head of the queue and changing the wait time to
* zero .
*/
schedule_deferred_open_smb_message ( e - > op_mid ) ;
} else {
2006-01-13 01:17:54 +03:00
char msg [ MSG_SMB_SHARE_MODE_ENTRY_SIZE ] ;
share_mode_entry_to_message ( msg , e ) ;
2007-05-15 00:31:28 +04:00
messaging_send_buf ( smbd_messaging_context ( ) ,
e - > pid , MSG_SMB_OPEN_RETRY ,
( uint8 * ) msg ,
MSG_SMB_SHARE_MODE_ENTRY_SIZE ) ;
2005-09-30 21:13:37 +04:00
}
}
2004-06-08 20:14:31 +04:00
}
1998-08-17 17:11:34 +04:00
/****************************************************************************
2006-05-18 03:15:53 +04:00
Deal with removing a share mode on last close .
1998-08-17 17:11:34 +04:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
1999-12-13 16:27:58 +03:00
2007-01-05 14:31:28 +03:00
static NTSTATUS close_remove_share_mode ( files_struct * fsp ,
enum file_close_type close_type )
1998-08-17 17:11:34 +04:00
{
connection_struct * conn = fsp - > conn ;
2008-01-11 03:35:54 +03:00
bool delete_file = false ;
bool changed_user = false ;
2005-09-30 21:13:37 +04:00
struct share_mode_lock * lck ;
2007-01-04 18:12:22 +03:00
SMB_STRUCT_STAT sbuf ;
2007-01-05 14:31:28 +03:00
NTSTATUS status = NT_STATUS_OK ;
2007-07-17 04:09:56 +04:00
int ret ;
2007-05-29 13:30:34 +04:00
struct file_id id ;
1998-08-17 17:11:34 +04:00
This is a big, rather ugly patch. Whilst investigating the files not truncated
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
2001-03-30 12:57:24 +04:00
/*
* Lock the share entries , and determine if we should delete
* on close . If so delete whilst the lock is still in effect .
* This prevents race conditions with the file being created . JRA .
*/
1998-08-17 17:11:34 +04:00
2008-01-06 16:21:25 +03:00
lck = get_share_mode_lock ( talloc_tos ( ) , fsp - > file_id , NULL , NULL ) ;
1999-12-13 16:27:58 +03:00
2005-09-30 21:13:37 +04:00
if ( lck = = NULL ) {
2007-01-04 18:12:22 +03:00
DEBUG ( 0 , ( " close_remove_share_mode: Could not get share mode "
" lock for file %s \n " , fsp - > fsp_name ) ) ;
2007-01-05 14:31:28 +03:00
return NT_STATUS_INVALID_PARAMETER ;
2005-09-30 21:13:37 +04:00
}
2001-08-22 04:29:40 +04:00
2005-09-30 21:13:37 +04:00
if ( ! del_share_mode ( lck , fsp ) ) {
2007-01-04 18:12:22 +03:00
DEBUG ( 0 , ( " close_remove_share_mode: Could not delete share "
" entry for file %s \n " , fsp - > fsp_name ) ) ;
2005-07-08 08:51:27 +04:00
}
1998-08-17 17:11:34 +04:00
2007-01-19 00:51:52 +03:00
if ( fsp - > initial_delete_on_close & & ( lck - > delete_token = = NULL ) ) {
2007-10-19 04:40:25 +04:00
bool became_user = False ;
2007-01-19 00:51:52 +03:00
/* Initial delete on close was set and no one else
* wrote a real delete on close . */
if ( current_user . vuid ! = fsp - > vuid ) {
become_user ( conn , fsp - > vuid ) ;
became_user = True ;
}
set_delete_on_close_lck ( lck , True , & current_user . ut ) ;
if ( became_user ) {
unbecome_user ( ) ;
}
}
delete_file = lck - > delete_on_close ;
2005-09-30 21:13:37 +04:00
if ( delete_file ) {
int i ;
/* See if others still have the file open. If this is the
2007-02-07 00:05:34 +03:00
* case , then don ' t delete . If all opens are POSIX delete now . */
2005-09-30 21:13:37 +04:00
for ( i = 0 ; i < lck - > num_share_modes ; i + + ) {
2007-02-07 00:05:34 +03:00
struct share_mode_entry * e = & lck - > share_modes [ i ] ;
if ( is_valid_share_mode_entry ( e ) ) {
if ( fsp - > posix_open & & ( e - > flags & SHARE_MODE_FLAG_POSIX_OPEN ) ) {
continue ;
}
2005-09-30 21:13:37 +04:00
delete_file = False ;
break ;
}
}
}
1998-08-17 17:11:34 +04:00
2004-06-08 20:14:31 +04:00
/* Notify any deferred opens waiting on this close. */
2005-09-30 21:13:37 +04:00
notify_deferred_opens ( lck ) ;
reply_to_oplock_break_requests ( fsp ) ;
2004-06-08 20:14:31 +04:00
1998-09-11 23:14:27 +04:00
/*
* NT can set delete_on_close of the last open
* reference to a file .
*/
2007-01-04 18:12:22 +03:00
if ( ! ( close_type = = NORMAL_CLOSE | | close_type = = SHUTDOWN_CLOSE )
| | ! delete_file
| | ( lck - > delete_token = = NULL ) ) {
TALLOC_FREE ( lck ) ;
2007-01-05 14:31:28 +03:00
return NT_STATUS_OK ;
2007-01-04 18:12:22 +03:00
}
2005-12-13 21:11:50 +03:00
2007-01-04 18:12:22 +03:00
/*
* Ok , we have to delete the file
*/
2005-12-13 21:11:50 +03:00
2007-01-04 18:12:22 +03:00
DEBUG ( 5 , ( " close_remove_share_mode: file %s. Delete on close was set "
" - deleting file. \n " , fsp - > fsp_name ) ) ;
2006-02-02 23:44:50 +03:00
2008-01-11 03:35:54 +03:00
if ( ! unix_token_equal ( lck - > delete_token , & current_user . ut ) ) {
/* Become the user who requested the delete. */
2006-02-02 23:44:50 +03:00
2008-01-11 03:35:54 +03:00
DEBUG ( 5 , ( " close_remove_share_mode: file %s. "
" Change user to uid %u \n " ,
2008-01-11 20:46:41 +03:00
fsp - > fsp_name ,
2008-01-11 03:35:54 +03:00
( unsigned int ) lck - > delete_token - > uid ) ) ;
if ( ! push_sec_ctx ( ) ) {
smb_panic ( " close_remove_share_mode: file %s. failed to push "
" sec_ctx. \n " ) ;
}
2006-02-02 23:44:50 +03:00
2008-01-11 03:35:54 +03:00
set_sec_ctx ( lck - > delete_token - > uid ,
lck - > delete_token - > gid ,
lck - > delete_token - > ngroups ,
lck - > delete_token - > groups ,
NULL ) ;
changed_user = true ;
}
2007-01-04 18:12:22 +03:00
/* We can only delete the file if the name we have is still valid and
hasn ' t been renamed . */
2007-07-17 04:09:56 +04:00
if ( fsp - > posix_open ) {
ret = SMB_VFS_LSTAT ( conn , fsp - > fsp_name , & sbuf ) ;
} else {
ret = SMB_VFS_STAT ( conn , fsp - > fsp_name , & sbuf ) ;
}
if ( ret ! = 0 ) {
2007-01-04 18:12:22 +03:00
DEBUG ( 5 , ( " close_remove_share_mode: file %s. Delete on close "
" was set and stat failed with error %s \n " ,
fsp - > fsp_name , strerror ( errno ) ) ) ;
2007-01-05 14:31:28 +03:00
/*
* Don ' t save the errno here , we ignore this error
*/
2007-01-04 18:12:22 +03:00
goto done ;
}
2007-08-02 12:53:24 +04:00
id = vfs_file_id_from_sbuf ( conn , & sbuf ) ;
2007-05-29 13:30:34 +04:00
if ( ! file_id_equal ( & fsp - > file_id , & id ) ) {
2007-01-04 18:12:22 +03:00
DEBUG ( 5 , ( " close_remove_share_mode: file %s. Delete on close "
" was set and dev and/or inode does not match \n " ,
fsp - > fsp_name ) ) ;
2007-05-29 13:30:34 +04:00
DEBUG ( 5 , ( " close_remove_share_mode: file %s. stored file_id %s, "
" stat file_id %s \n " ,
2007-01-04 18:12:22 +03:00
fsp - > fsp_name ,
2007-09-10 14:56:07 +04:00
file_id_string_tos ( & fsp - > file_id ) ,
file_id_string_tos ( & id ) ) ) ;
2007-01-05 14:31:28 +03:00
/*
* Don ' t save the errno here , we ignore this error
*/
2007-01-04 18:12:22 +03:00
goto done ;
2001-11-13 04:35:20 +03:00
}
1998-09-11 23:14:27 +04:00
2007-01-04 18:12:22 +03:00
if ( SMB_VFS_UNLINK ( conn , fsp - > fsp_name ) ! = 0 ) {
/*
* This call can potentially fail as another smbd may
* have had the file open with delete on close set and
* deleted it when its last reference to this file
* went away . Hence we log this but not at debug level
* zero .
*/
DEBUG ( 5 , ( " close_remove_share_mode: file %s. Delete on close "
" was set and unlink failed with error %s \n " ,
fsp - > fsp_name , strerror ( errno ) ) ) ;
2007-01-05 14:31:28 +03:00
status = map_nt_error_from_unix ( errno ) ;
2007-01-04 18:12:22 +03:00
}
2007-05-11 11:22:10 +04:00
notify_fname ( conn , NOTIFY_ACTION_REMOVED ,
FILE_NOTIFY_CHANGE_FILE_NAME ,
fsp - > fsp_name ) ;
2007-02-11 07:37:56 +03:00
/* As we now have POSIX opens which can unlink
* with other open files we may have taken
* this code path with more than one share mode
* entry - ensure we only delete once by resetting
* the delete on close flag . JRA .
*/
set_delete_on_close_lck ( lck , False , NULL ) ;
2007-01-04 18:12:22 +03:00
done :
2007-02-07 00:05:34 +03:00
2008-01-11 03:35:54 +03:00
if ( changed_user ) {
/* unbecome user. */
pop_sec_ctx ( ) ;
}
2006-02-20 20:59:58 +03:00
TALLOC_FREE ( lck ) ;
2007-01-05 14:31:28 +03:00
return status ;
2006-05-18 03:15:53 +04:00
}
/****************************************************************************
Close a file .
close_type can be NORMAL_CLOSE = 0 , SHUTDOWN_CLOSE , ERROR_CLOSE .
printing and magic scripts are only run on normal close .
delete on close is done on normal and shutdown close .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2007-02-07 00:05:34 +03:00
static NTSTATUS close_normal_file ( files_struct * fsp , enum file_close_type close_type )
2006-05-18 03:15:53 +04:00
{
2007-02-07 00:05:34 +03:00
NTSTATUS status = NT_STATUS_OK ;
NTSTATUS saved_status1 = NT_STATUS_OK ;
NTSTATUS saved_status2 = NT_STATUS_OK ;
2007-10-11 00:34:30 +04:00
NTSTATUS saved_status3 = NT_STATUS_OK ;
2006-05-18 03:15:53 +04:00
connection_struct * conn = fsp - > conn ;
This is a big, rather ugly patch. Whilst investigating the files not truncated
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
2001-03-30 12:57:24 +04:00
2007-10-11 00:34:30 +04:00
if ( fsp - > aio_write_behind ) {
/*
* If we ' re finishing write behind on a close we can get a write
* error here , we must remember this .
*/
int ret = wait_for_aio_completion ( fsp ) ;
if ( ret ) {
saved_status1 = map_nt_error_from_unix ( ret ) ;
}
} else {
cancel_aio_by_fsp ( fsp ) ;
}
2006-05-18 03:15:53 +04:00
/*
* If we ' re flushing on a close we can get a write
* error here , we must remember this .
*/
2007-10-11 00:34:30 +04:00
saved_status2 = close_filestruct ( fsp ) ;
2006-05-18 03:15:53 +04:00
if ( fsp - > print_file ) {
print_fsp_end ( fsp , close_type ) ;
file_free ( fsp ) ;
2007-02-07 00:05:34 +03:00
return NT_STATUS_OK ;
2006-05-18 03:15:53 +04:00
}
/* If this is an old DOS or FCB open and we have multiple opens on
the same handle we only have one share mode . Ensure we only remove
the share mode on the last close . */
if ( fsp - > fh - > ref_count = = 1 ) {
/* Should we return on error here... ? */
2007-10-11 00:34:30 +04:00
saved_status3 = close_remove_share_mode ( fsp , close_type ) ;
2006-05-18 03:15:53 +04:00
}
if ( fsp - > oplock_type ) {
This is a big, rather ugly patch. Whilst investigating the files not truncated
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
2001-03-30 12:57:24 +04:00
release_file_oplock ( fsp ) ;
2006-05-18 03:15:53 +04:00
}
This is a big, rather ugly patch. Whilst investigating the files not truncated
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
2001-03-30 12:57:24 +04:00
2007-05-14 17:01:28 +04:00
locking_close_file ( smbd_messaging_context ( ) , fsp ) ;
This is a big, rather ugly patch. Whilst investigating the files not truncated
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
2001-03-30 12:57:24 +04:00
2007-12-22 04:01:26 +03:00
status = fd_close ( fsp ) ;
2004-10-21 23:51:33 +04:00
This is a big, rather ugly patch. Whilst investigating the files not truncated
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
2001-03-30 12:57:24 +04:00
/* check for magic scripts */
2006-02-02 23:44:50 +03:00
if ( close_type = = NORMAL_CLOSE ) {
2007-12-22 04:13:02 +03:00
check_magic ( fsp ) ;
This is a big, rather ugly patch. Whilst investigating the files not truncated
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
2001-03-30 12:57:24 +04:00
}
2001-12-17 00:04:19 +03:00
/*
* Ensure pending modtime is set after close .
*/
2007-03-06 02:40:03 +03:00
if ( fsp - > pending_modtime_owner & & ! null_timespec ( fsp - > pending_modtime ) ) {
2001-12-17 00:04:19 +03:00
set_filetime ( conn , fsp - > fsp_name , fsp - > pending_modtime ) ;
2007-03-06 02:40:03 +03:00
} else if ( ! null_timespec ( fsp - > last_write_time ) ) {
2005-03-11 00:43:58 +03:00
set_filetime ( conn , fsp - > fsp_name , fsp - > last_write_time ) ;
2001-12-17 00:04:19 +03:00
}
This is a big, rather ugly patch. Whilst investigating the files not truncated
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
2001-03-30 12:57:24 +04:00
2007-02-07 00:05:34 +03:00
if ( NT_STATUS_IS_OK ( status ) ) {
if ( ! NT_STATUS_IS_OK ( saved_status1 ) ) {
status = saved_status1 ;
} else if ( ! NT_STATUS_IS_OK ( saved_status2 ) ) {
status = saved_status2 ;
2007-10-11 00:34:30 +04:00
} else if ( ! NT_STATUS_IS_OK ( saved_status3 ) ) {
status = saved_status3 ;
2007-02-07 00:05:34 +03:00
}
}
1999-12-13 16:27:58 +03:00
DEBUG ( 2 , ( " %s closed file %s (numopen=%d) %s \n " ,
2004-10-21 23:51:33 +04:00
conn - > user , fsp - > fsp_name ,
conn - > num_files_open ,
2007-02-07 00:05:34 +03:00
nt_errstr ( status ) ) ) ;
1998-08-17 17:11:34 +04:00
file_free ( fsp ) ;
2007-02-07 00:05:34 +03:00
return status ;
1998-08-17 17:11:34 +04:00
}
/****************************************************************************
Close a directory opened by an NT SMB call .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2007-02-07 00:05:34 +03:00
static NTSTATUS close_directory ( files_struct * fsp , enum file_close_type close_type )
1998-08-17 17:11:34 +04:00
{
2005-10-28 02:35:08 +04:00
struct share_mode_lock * lck = 0 ;
2007-10-19 04:40:25 +04:00
bool delete_dir = False ;
2007-02-07 00:05:34 +03:00
NTSTATUS status = NT_STATUS_OK ;
2005-10-28 02:35:08 +04:00
1999-12-13 16:27:58 +03:00
/*
* NT can set delete_on_close of the last open
* reference to a directory also .
*/
2008-01-06 16:21:25 +03:00
lck = get_share_mode_lock ( talloc_tos ( ) , fsp - > file_id , NULL , NULL ) ;
2005-10-28 02:35:08 +04:00
if ( lck = = NULL ) {
DEBUG ( 0 , ( " close_directory: Could not get share mode lock for %s \n " , fsp - > fsp_name ) ) ;
2007-02-07 00:05:34 +03:00
return NT_STATUS_INVALID_PARAMETER ;
2005-10-28 02:35:08 +04:00
}
if ( ! del_share_mode ( lck , fsp ) ) {
DEBUG ( 0 , ( " close_directory: Could not delete share entry for %s \n " , fsp - > fsp_name ) ) ;
}
2007-01-19 00:51:52 +03:00
if ( fsp - > initial_delete_on_close ) {
2007-10-19 04:40:25 +04:00
bool became_user = False ;
2007-01-19 00:51:52 +03:00
/* Initial delete on close was set - for
* directories we don ' t care if anyone else
* wrote a real delete on close . */
if ( current_user . vuid ! = fsp - > vuid ) {
become_user ( fsp - > conn , fsp - > vuid ) ;
became_user = True ;
}
2007-01-20 00:46:12 +03:00
send_stat_cache_delete_message ( fsp - > fsp_name ) ;
2007-01-19 00:51:52 +03:00
set_delete_on_close_lck ( lck , True , & current_user . ut ) ;
if ( became_user ) {
unbecome_user ( ) ;
}
}
delete_dir = lck - > delete_on_close ;
2005-10-28 02:35:08 +04:00
2007-01-04 19:26:15 +03:00
if ( delete_dir ) {
int i ;
/* See if others still have the dir open. If this is the
2007-02-07 00:05:34 +03:00
* case , then don ' t delete . If all opens are POSIX delete now . */
2007-01-04 19:26:15 +03:00
for ( i = 0 ; i < lck - > num_share_modes ; i + + ) {
2007-02-07 00:05:34 +03:00
struct share_mode_entry * e = & lck - > share_modes [ i ] ;
if ( is_valid_share_mode_entry ( e ) ) {
if ( fsp - > posix_open & & ( e - > flags & SHARE_MODE_FLAG_POSIX_OPEN ) ) {
continue ;
}
2007-01-04 19:26:15 +03:00
delete_dir = False ;
break ;
}
}
}
2006-02-02 23:44:50 +03:00
if ( ( close_type = = NORMAL_CLOSE | | close_type = = SHUTDOWN_CLOSE ) & &
delete_dir & &
lck - > delete_token ) {
/* Become the user who requested the delete. */
if ( ! push_sec_ctx ( ) ) {
smb_panic ( " close_directory: failed to push sec_ctx. \n " ) ;
}
set_sec_ctx ( lck - > delete_token - > uid ,
lck - > delete_token - > gid ,
lck - > delete_token - > ngroups ,
lck - > delete_token - > groups ,
NULL ) ;
2006-02-28 09:41:07 +03:00
TALLOC_FREE ( lck ) ;
2007-09-13 01:48:20 +04:00
status = rmdir_internals ( talloc_tos ( ) ,
fsp - > conn , fsp - > fsp_name ) ;
2006-02-02 23:44:50 +03:00
2007-02-11 17:55:21 +03:00
DEBUG ( 5 , ( " close_directory: %s. Delete on close was set - "
" deleting directory returned %s. \n " ,
fsp - > fsp_name , nt_errstr ( status ) ) ) ;
1999-12-13 16:27:58 +03:00
2006-02-02 23:44:50 +03:00
/* unbecome user. */
pop_sec_ctx ( ) ;
1999-12-13 16:27:58 +03:00
/*
* Ensure we remove any change notify requests that would
* now fail as the directory has been deleted .
*/
2007-02-07 00:05:34 +03:00
if ( NT_STATUS_IS_OK ( status ) ) {
2005-10-28 03:30:25 +04:00
remove_pending_change_notify_requests_by_fid ( fsp , NT_STATUS_DELETE_PENDING ) ;
2005-07-08 08:51:27 +04:00
}
2005-10-28 03:30:25 +04:00
} else {
2006-02-28 09:41:07 +03:00
TALLOC_FREE ( lck ) ;
2006-12-31 20:52:24 +03:00
remove_pending_change_notify_requests_by_fid (
fsp , NT_STATUS_OK ) ;
2001-11-13 04:35:20 +03:00
}
1999-12-13 16:27:58 +03:00
1998-08-17 17:11:34 +04:00
/*
* Do the code common to files and directories .
*/
close_filestruct ( fsp ) ;
file_free ( fsp ) ;
2007-02-07 00:05:34 +03:00
return status ;
2003-01-03 21:50:13 +03:00
}
1999-12-13 16:27:58 +03:00
2003-01-03 21:50:13 +03:00
/****************************************************************************
Close a ' stat file ' opened internally .
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2007-11-21 18:41:12 +03:00
static NTSTATUS close_stat ( files_struct * fsp )
2003-01-03 21:50:13 +03:00
{
/*
* Do the code common to files and directories .
*/
close_filestruct ( fsp ) ;
file_free ( fsp ) ;
2007-02-07 00:05:34 +03:00
return NT_STATUS_OK ;
1999-12-13 16:27:58 +03:00
}
/****************************************************************************
2003-01-03 21:50:13 +03:00
Close a files_struct .
1999-12-13 16:27:58 +03:00
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
2007-02-07 00:05:34 +03:00
NTSTATUS close_file ( files_struct * fsp , enum file_close_type close_type )
1999-12-13 16:27:58 +03:00
{
2007-02-07 00:05:34 +03:00
if ( fsp - > is_directory ) {
2006-02-02 23:44:50 +03:00
return close_directory ( fsp , close_type ) ;
2007-02-07 00:05:34 +03:00
} else if ( fsp - > is_stat ) {
2003-01-03 21:50:13 +03:00
return close_stat ( fsp ) ;
2007-02-07 00:05:34 +03:00
} else if ( fsp - > fake_file_handle ! = NULL ) {
2006-05-17 19:01:57 +04:00
return close_fake_file ( fsp ) ;
2007-02-07 00:05:34 +03:00
}
return close_normal_file ( fsp , close_type ) ;
1999-12-13 16:27:58 +03:00
}